- 11 Feb, 2020 2 commits
-
-
Michał Mirosław authored
Current code races in init/exit with interrupt handlers. This is noticed by the warning below. Fix it by using devres for ordering allocations and IRQ de/registration. WARNING: CPU: 0 PID: 827 at drivers/staging/wfx/bus_spi.c:142 wfx_spi_irq_handler+0x5c/0x64 [wfx] race condition in driver init/deinit Cc: stable@vger.kernel.org Fixes: 0096214a ("staging: wfx: add support for I/O access") Signed-off-by:
Michał Mirosław <mirq-linux@rere.qmqm.pl> Reviewed-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/f0c66cbb3110c2736cd4357c753fba8c14ee3aee.1581416843.git.mirq-linux@rere.qmqm.plSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
YueHaibing authored
drivers/staging/wfx/queue.c: In function wfx_tx_queues_get: drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not used [-Wunused-but-set-variable] commit 2e57865e ("staging: wfx: pspoll_mask make no sense") left behind this unused variable. Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Reviewed-by:
-
- 10 Feb, 2020 38 commits
-
-
Michael Straube authored
Rename the local variable pnetdev in rtw_alloc_etherdev_with_old_priv to avoid hungarian notation and clear the last checkpatch warning in the file osdep_service.c. rtl8188eu/os_dep/osdep_service.c:32: WARNING: line over 80 characters Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200210200830.22868-1-straube.linux@gmail.comSigned-off-by:
-
JieunKim authored
pr_info is preferred to use than printk. pr_info calls printk with KERN_INFO macros by itself. Signed-off-by:
JieunKim <jieun.kim4758@gmail.com> Link: https://lore.kernel.org/r/20200210091421.12335-1-jieun.kim4758@gmail.comSigned-off-by:
-
Ian Abbott authored
We do not currently provide routing information for NI PCIe-6251 and PCI-6259 boards, but they are functionally identical to the PCI-6251 and PCI-6259 boards and can share their routing information. (This has been confirmed for the PCIe-6251 by Éric Piel, using the "NI MAX" software for Windows. It is hoped that it applies to PCIe-6259, but has not yet been checked due to lack of hardware.) Initialize the `alt_route_name` member of the board information for PCIe-6251 and PCIe-6259 to allow them to make use of the routing information provided for PCI-6251 and PCI-6259 respectively. Cc: Éric Piel <piel@delmic.com> Cc: Spencer E. Olson <olsonse@umich.edu> Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/20200207151400.272678-5-abbotti@mev.co.ukSigned-off-by:
-
Ian Abbott authored
We do not have or do not provide routing information for all supported boards. Some of the boards for which we do not provide routing information actually have routes that are identical to a similar board for which we already provide routing information. To allow boards to share identical routing information, add an `alt_route_name` member to `struct ni_board_struct`. This will be initialized to `NULL` for all boards except those that will use make use of the identical routing information that has been provided for a similar board, in which case it will name that board. Pass the `alt_route_name` member value to `ni_assign_device_routes()` as the `alt_board_name` parameter, which it will use if no routing information could be found for the actual board name. Cc: Éric Piel <piel@delmic.com> Cc: Spencer E. Olson <olsonse@umich.edu> Signed-off-by:
-
Ian Abbott authored
We do not have or provide routing information available for all supported boards. Some of the boards for which we do not currently provide routing information actually have identical routes to a similar board for which we do provide routing information. To avoid having to provide duplicate routing information, add an "alternate board name" parameter (possibly `NULl`) to `ni_assign_device_routes()` and `ni_find_device_routes()`. If the routing information cannot be found for the actual board name, try finding it using the alternate board name. Cc: Éric Piel <piel@delmic.com> Cc: Spencer E. Olson <olsonse@umich.edu> Signed-off-by:
-
Ian Abbott authored
Split out the loops in `ni_find_valid_routes()` into separate functions: * ni_find_route_values(device_family) to find the list of route values for a device family (e.g "ni-mseries"); and * ni_find_valid_routes(board_name) to find the set of valid routes for a board name. The functions above return `NULL` if the information is not found (as we do not currently have the routing information available for all supported boards). Cc: Éric Piel <piel@delmic.com> Cc: Spencer E. Olson <olsonse@umich.edu> Signed-off-by:
-
Mohana Datta Yelugoti authored
This patch fixes "WARNING: please, no spaces at the start of a line" by checkpatch.pl by replacing spaces with the tab. Signed-off-by:
Mohana Datta Yelugoti <ymdatta.work@gmail.com> Link: https://lore.kernel.org/r/20200209173628.21221-1-ymdatta.work@gmail.comSigned-off-by:
-
Sumera Priyadarsini authored
This patch fixes the file r8190_rtl8256.c to avoid the following checkpatch.pl warnings: CHECK: spaces preferred around that '>>' (ctx:VxV) Signed-off-by:
Sumera Priyadarsini <sylphrenadin@gmail.com> Link: https://lore.kernel.org/r/20200209073020.13423-1-sylphrenadin@gmail.comSigned-off-by:
-
Nishad Kamdar authored
This patch corrects the SPDX License Identifier style in header files related to pi433 radio module drivers. It assigns explicit block comment to the SPDX License Identifier. Changes made by using a script provided by Joe Perches here: https://lkml.org/lkml/2019/2/7/46. Suggested-by:
Joe Perches <joe@perches.com> Signed-off-by:
Nishad Kamdar <nishadkamdar@gmail.com> Link: https://lore.kernel.org/r/20200208083621.GA3797@nishadSigned-off-by:
-
Michael Straube authored
Remove unnecessary RETURN label and use return directly instead. Since the return type of rtw_free_netdev() is void, remove the return at the end of the function. Signed-off-by:
-
Nicolas Saenz Julienne authored
They aren't used anywhere. Get rid of them. Signed-off-by:
Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Link: https://lore.kernel.org/r/20200131103836.14312-22-nsaenzjulienne@suse.deSigned-off-by:
-
Nicolas Saenz Julienne authored
The function implementation does not exist. Signed-off-by:
-
Nicolas Saenz Julienne authored
The function does nothing. Signed-off-by:
-
Nicolas Saenz Julienne authored
It's not used anywhere. Signed-off-by:
-
Nicolas Saenz Julienne authored
The only remaining state doesn't provide any information anymore nor the completion that depends on it, which is set to complete_all() before any user may wait on it. Signed-off-by:
-
Nicolas Saenz Julienne authored
After the first states cleanup pass some set_suspend/resume_state() calls disappeared which opened up even more opportunities for deletions. Signed-off-by:
-
Nicolas Saenz Julienne authored
It's impossible to get into them, so simply delete them. Signed-off-by:
-
Nicolas Saenz Julienne authored
Nobody is waiting on it. Signed-off-by:
-
Nicolas Saenz Julienne authored
Nobody calls this function. Signed-off-by:
-
Nicolas Saenz Julienne authored
It's not used. Signed-off-by:
-
Nicolas Saenz Julienne authored
Function does nothing. Signed-off-by:
-
Nicolas Saenz Julienne authored
The function does nothing. Signed-off-by:
-
Nicolas Saenz Julienne authored
The function always returns true, which makes a whole bunch of code useless. Signed-off-by:
-
Nicolas Saenz Julienne authored
vchiq_platform_suspend() and vchiq_platform_resume() do nothing, get rid of them. Signed-off-by:
-
Nicolas Saenz Julienne authored
vchiq_platform_paused() and vchiq_platform_resumed() do nothing. Signed-off-by:
-
Nicolas Saenz Julienne authored
The function always returns 0, delete the function and all code conditional to it, namely the suspend timer. Signed-off-by:
-
Nicolas Saenz Julienne authored
The variable is always 0. So delete it an all the code conditional to it. Signed-off-by:
-
Nicolas Saenz Julienne authored
Nobody is waiting on it, so delete it. Signed-off-by:
-
Nicolas Saenz Julienne authored
Nobody is waiting on it, so delete all relevant code. Signed-off-by:
-
Nicolas Saenz Julienne authored
The boolean value is never set to true, hence remove it and all the code that depends on it. Signed-off-by:
-
Nicolas Saenz Julienne authored
There are not being used, so we're better off without them. Signed-off-by:
-
Derek Robson authored
Fixed checkpatch warnings, Prefer using '"%s...", __func__' Signed-off-by:
Derek Robson <robsonde@gmail.com> Link: https://lore.kernel.org/r/20200202070243.112059-1-robsonde@gmail.comSigned-off-by:
-
Nishad Kamdar authored
This patch corrects the SPDX License Identifier style in header files related to Netlogic network devices. It assigns explicit block comment to the SPDX License Identifier. Changes made by using a script provided by Joe Perches here: https://lkml.org/lkml/2019/2/7/46. Suggested-by:
-
Pragat Pandya authored
Remove global declaration of unused struct "dev_info_t". Structure "dev_info_t" is defined in exfat.h and not referenced in any other file. Signed-off-by:
Pragat Pandya <pragat.pandya@gmail.com> Link: https://lore.kernel.org/r/20200130101118.15936-3-pragat.pandya@gmail.comSigned-off-by:
-
Pragat Pandya authored
Remove global declaration of unused struct "part_info_t". Structure "part_info_t" is defined in exfat.h and not referenced in any other file. Signed-off-by:
-
Tetsuhiro Kohada authored
remove 'vol_type' variable. The following issues are described in exfat's TODO. > clean up the remaining vol_type checks, which are of two types: > some are ?: operators with magic numbers, and the rest are places > where we're doing stuff with '.' and '..'. The vol_type variable is always set to 'EXFAT'. The variable checks are unnessesary, so remove unused code. Signed-off-by:
Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> Reviewed-by:
Mori Takahiro <Mori.Takahiro@ab.MitsubishiElectric.co.jp> Suggested-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
-
Ajay Singh authored
Refactor SPI commands handling by making use of 'struct' for data exchange and extraction of information flow between host and firmware. The SPI read/write commands are now handled in separate function instead of using a single function to process all types of command. The use of 'struct' helped to make the code self explanatory. These points were discussed and suggested during code review [1]. 1. https://www.spinics.net/lists/linux-wireless/msg191489.htmlSigned-off-by:
Ajay Singh <ajay.kathat@microchip.com> Link: https://lore.kernel.org/r/20200203160848.4052-1-ajay.kathat@microchip.comSigned-off-by:
-
Malcolm Priestley authored
Fall back is no longer used in driver so remove all functions and headers. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/33732aad-5905-c173-ea81-431265e4f7e7@gmail.comSigned-off-by:
-
