Unsigned cannot be negative.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

STAGING_RDMA was failing to build when INFINIBAND was set to 'm' and
STAGING_RDMA was set to 'y'.

Making this a tristate properly inherits the 'm' from the INFINIBAND setting.
Reviewed-by: Dalessandro, Dennis <dennis.dalessandro@intel.com>
Reviewed-by: John, Jubin <jubin.john@intel.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed warnings found by checkpatch.pl:

Please use a blank line after function/struct/union/enum declarations
  FILE: drivers/staging/rdma/amso1100/c2_mq.c:158:
  FILE: drivers/staging/rdma/hfi1/file_ops.c:2069:
  FILE: drivers/staging/rdma/hfi1/sdma.c:744:
  FILE: drivers/staging/rdma/hfi1/verbs.c:1202:
Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes the following sparse warning:
  drivers/staging/rdma/hfi1/device.c:127:12:
  warning: symbol 'class_name_user' was not declared. Should it be static?
Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use kvfree() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangtang@163.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

hfi1_rc_hdrerr() stores the result of be32_to_cpu() into opcode, which
is a local variable declared as u8.  Later this variable is used in a
24-bit logical right shift, which makes clang complains (when building
an allmodconfig kernel with LLVMLinux patches):

    drivers/staging/rdma/hfi1/rc.c:2399:9: warning: shift count >= width
    of type [-Wshift-count-overflow]
        opcode >>= 24;
               ^   ~~

All of this lead to the point that opcode may have been designed to be
a 32-bit integer instead of an 8-bit one.  Therefore make this variable
u32.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_ctrl_initgain_byrssi to _rtl92e_dm_ctrl_initgain_byrssi.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename firmware_check_ready to _rtl92e_fw_check_ready.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename r8192_wx_set_enc to _rtl92e_wx_set_enc.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_tx_update_tssi_weak_signal to
_rtl92e_dm_tx_update_tssi_weak_signal.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_tx_update_tssi_strong_signal to
_rtl92e_dm_tx_update_tssi_strong_signal.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_TXPowerTrackingCallback_TSSI to
_rtl92e_dm_tx_power_tracking_callback_tssi.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_TXPowerTrackingCallback_ThermalMeter to
_rtl92e_dm_tx_power_tracking_cb_thermal.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_txpower_reset_recovery to _rtl92e_dm_tx_power_reset_recovery.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_StartSWFsync to _rtl92e_dm_start_sw_fsync.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_StartHWFsync to _rtl92e_dm_start_hw_fsync.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_send_rssi_tofw to _rtl92e_dm_send_rssi_to_fw.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_rxpath_sel_byrssi to _rtl92e_dm_rx_path_sel_byrssi.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_pd_th to _rtl92e_dm_pd_th.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_Init_WA_Broadcom_IOT to _rtl92e_dm_init_wa_broadcom_iot.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_InitializeTXPowerTracking_TSSI to
_rtl92e_dm_initialize_tx_power_tracking_tssi.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_init_rxpath_selectio to _rtl92e_dm_init_rx_path_selection.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_InitializeTXPowerTracking_ThermalMeter to
_rtl92e_dm_init_tx_power_tracking_thermal.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_initial_gain to _rtl92e_dm_initial_gain.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_init_fsync to _rtl92e_dm_init_fsync.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_init_dynamic_txpower to _rtl92e_dm_init_dynamic_tx_power.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_init_ctstoself to _rtl92e_dm_init_cts_to_self.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_init_bandwidth_autoswitch to
_rtl92e_dm_init_bandwidth_autoswitch.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_fsync_timer_callback to _rtl92e_dm_fsync_timer_callback.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_EndSWFsync to _rtl92e_dm_end_sw_fsync.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_EndHWFsync to _rtl92e_dm_end_hw_fsync.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_dynamic_txpower to _rtl92e_dm_dynamic_tx_power.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_dig_init to _rtl92e_dm_dig_init.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_deInit_fsync to _rtl92e_dm_deinit_fsync.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_ctstoself to _rtl92e_dm_cts_to_self.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_ctrl_initgain_byrssi_highpwr to
_rtl92e_dm_ctrl_initgain_byrssi_highpwr.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_ctrl_initgain_byrssi_by_fwfalse_alarm to
_rtl92e_dm_ctrl_initgain_byrssi_false_alarm.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_ctrl_initgain_byrssi_by_driverrssi to
_rtl92e_dm_ctrl_initgain_byrssi_driver.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_cs_ratio to _rtl92e_dm_cs_ratio.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Use naming schema found in other rtlwifi devices.
Rename dm_check_txrateandretrycount to
_rtl92e_dm_check_txrateandretrycount.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>