- 16 Nov, 2015 40 commits
-
-
Ivan Safonov authored
goto is not needed here. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ivan Safonov authored
IS_* and GET_CVID_* macros have not been used. Signed-off-by:
-
Ivan Safonov authored
IS_* macros (except one) occur only once. Signed-off-by:
-
Ivan Safonov authored
The range of elements to fill with zeros is determined by using a roundup macro Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Ivan Safonov authored
This name is better suited for this variable. Signed-off-by:
-
Ivan Safonov authored
This name is better suited for this variable. Signed-off-by:
-
Ivan Safonov authored
This name is better suited for this variable. Signed-off-by:
-
Ivan Safonov authored
checkpatch fix: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Ivan Safonov authored
It is superfluous. Signed-off-by:
-
Ivan Safonov authored
The array should not change in any case. Signed-off-by:
-
Ivan Safonov authored
It is simpler. Signed-off-by:
-
Ivan Safonov authored
It makes the code little easier. Signed-off-by:
-
Ivan Safonov authored
If the 'remain' is zero, the loop is not executed at all. Signed-off-by:
-
Ivan Safonov authored
Variable value calculated in the previous loop. Signed-off-by:
-
Ivan Safonov authored
It is now possible to get rid of re-initializing the offset variable. Signed-off-by:
-
Ivan Safonov authored
Line become shorter. After the loop offset variable points to the location following insertion. Signed-off-by:
-
Ivan Safonov authored
It is made to the initial value could be placed in the offset variable. Signed-off-by:
-
Ivan Safonov authored
It is better to read. Signed-off-by:
-
Abdul Hussain authored
This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by:
Abdul Hussain <hussain.abdul@outlook.com> Signed-off-by:
-
Ivan Safonov authored
The body of this loop is executed only once, so it can be removed. In this loop no keyword 'continue', only 'break' at the end. Signed-off-by:
-
Ivan Safonov authored
Here is more suitable for loop. Signed-off-by:
-
Ivan Safonov authored
It is a simple and clear representation of this loop. Signed-off-by:
-
Rémy Oudompheng authored
Previously the code could exit with failure too early. Signed-off-by:
Rémy Oudompheng <remyoudompheng@gmail.com> Signed-off-by:
-
Rémy Oudompheng authored
Remove rtw_get_passing_time_ms function and adjust type of relevant variables. Signed-off-by:
-
Shivani Bhardwaj authored
Remove the function ldlm_pool_set_limit() and replace its calls with the function it wrapped. Signed-off-by:
Shivani Bhardwaj <shivanib134@gmail.com> Acked-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
Shivani Bhardwaj authored
Remove the function ldlm_pool_get_limit() and replace its calls with the function it wrapped. Signed-off-by:
-
Shivani Bhardwaj authored
Remove the function ldlm_pl2ns() and replace its calls with the function it wrapped. Signed-off-by:
-
Shivani Bhardwaj authored
Remove the prototype of function cfs_trace_free_string_buffer() as it is no longer needed. Signed-off-by:
-
Shivani Bhardwaj authored
Remove the function cfs_trace_free_string_buffer() as it can be replaced with the standard function kfree(). Signed-off-by:
-
Shivani Bhardwaj authored
Replace the calls of function cfs_trace_free_string_buffer() with kfree() as the former function is not required. Signed-off-by:
-
Shivani Bhardwaj authored
Remove the function ll_check_page() and replace all its calls with the function it wrapped. Signed-off-by:
-
Amitoj Kaur Chawla authored
This patch moves extern declarations in socklnd_lib.c to the respective header file, 'socklnd.h'. This patch also removes extern keyword from function declarations since functions have the extern specifier by default. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Acked-by:
-
Markus Elfring authored
The variable "rc" will be eventually set to an error return code in the class_register_type() function. Thus let us omit the explicit initialisation at the beginning. Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
-
Sebastien Buisson authored
Fix 'error handling' issues found by Coverity version 6.5.1: Unchecked return value (CHECKED_RETURN) Calling function without checking return value. Signed-off-by:
Sebastien Buisson <sebastien.buisson@bull.net> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3427 Reviewed-on: http://review.whamcloud.com/7103Reviewed-by:
Bobbie Lind <bobbie.j.lind@intel.com> Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Liang Zhen authored
page_collection::pc_lock is supposed to protect race between functions called by smp_call_function(), however we don't have this use-case for ages and page_collection only lives in stack of thread, so it is safe to remove it. Signed-off-by:
Liang Zhen <liang.zhen@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3055 Reviewed-on: http://review.whamcloud.com/7660Reviewed-by:
Bobi Jam <bobijam@gmail.com> Reviewed-by:
-
Fan Yong authored
There are some race conditions when check/use cfs_fail_val. For example: when inject failure stub for LFSCK test as following: 764 if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_DELAY2) && 765 cfs_fail_val > 0) { 766 struct l_wait_info lwi; 767 768 lwi = LWI_TIMEOUT(cfs_time_seconds(cfs_fail_val), 769 NULL, NULL); 770 l_wait_event(thread->t_ctl_waitq, 771 !thread_is_running(thread), 772 &lwi); 773 774 if (unlikely(!thread_is_running(thread))) { 775 CDEBUG(D_LFSCK, "%s: scan dir exit for engine " 776 "stop, parent "DFID", cookie "LPX64"n", 777 lfsck_lfsck2name(lfsck), 778 PFID(lfsck_dto2fid(dir)), 779 lfsck->li_cookie_dir); 780 RETURN(0); 781 } 782 } The "cfs_fail_val" may be changed as zero by others after the check at the line 765 but before using it at the line 768. Then the LFSCK engine will fall into "wait" until someone run "lfsck_stop". Signed-off-by:Fan Yong <fan.yong@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6146 Reviewed-on: http://review.whamcloud.com/13481Reviewed-by:
Lai Siyao <lai.siyao@intel.com> Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Signed-off-by:
-
James Simmons authored
The modinfo data has gone stale for the author information. This patch changes all the MODULE_AUTHOR to OpenSFS. Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/16132Reviewed-by:
Frank Zago <fzago@cray.com> Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
-
Dmitry Eremin authored
The imp->imp_connection really could be NULL, we better check for it before dereferencing it in taht call to libcfs_nid2str_r. Signed-off-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
-
Dmitry Eremin authored
Buffer overflow of string buffer due to non null terminated string. Use strlcpy() when it's justifiable. Use sizeof(var) instead of constants. Signed-off-by:
-
frank zago authored
The function libcfs_debug_set_level is used only internally so no reason to expose it in libcfs_private.h. This is broken out from LU-5829 patch http://review.whamcloud.com/13319. Signed-off-by:
-
