- 20 Sep, 2014 8 commits
-
-
Benedict Boerger authored
Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it be static? The function CAM_read_entry is not used and therefore deleted. Signed-off-by:
Benedict Boerger <benedict.boerger@cs.tu-dortmund.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ragnar B. Johannsson authored
Move ieee80211_crypto*_init and _exit prototype declarations from r8192U_core.c to ieee80211/ieee80211.h. This fixes the following sparse warnings: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:12: warning: symbol 'ieee80211_crypto_init' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:223:13: warning: symbol 'ieee80211_crypto_deinit' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:764:12: warning: symbol 'ieee80211_crypto_tkip_init' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:769:13: warning: symbol 'ieee80211_crypto_tkip_exit' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:467:12: warning: symbol 'ieee80211_crypto_ccmp_init' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:472:13: warning: symbol 'ieee80211_crypto_ccmp_exit' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c:281:12: warning: symbol 'ieee80211_crypto_wep_init' was not declared. Should it be static? drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c:286:13: warning: symbol 'ieee80211_crypto_wep_exit' was not declared. Should it be static? Signed-off-by:
Ragnar B. Johannsson <ragnar@igo.is> Signed-off-by:
-
Mahati Chamarthy authored
This fixes the following checkpatch.pl warnings: WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... Signed-off-by:
Mahati Chamarthy <mahati.chamarthy@gmail.com> Signed-off-by:
-
Vaishali Thakkar authored
This patch removes following checkpatch.pl warnings in rtl_core.c file: WARNING: Braces {} are not necessary for single statement blocks WARNING: Space prohibited before semicolon Signed-off-by:Vaishali Thakkar <vthakkar1994@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Vaishali Thakkar authored
This patch removes unnecessory variable in file ret_core.c using coccinelle script.Semantic patch for this is as follows: @@ identifier ret; @@ -int ret = 0; ... when != ret when strict -return ret; +return 0; Signed-off-by: -
Rajbinder Brar authored
This removes checkpatch.pl warning WARNING: line over 80 characters Signed-off-by:
Rajbinder Brar <brar.rajbinder@gmail.com> Signed-off-by:
-
Rajbinder Brar authored
This patch fixes the checkpatch.pl warning in baseband.c file WARNING: else is not useful after a break or return Signed-off-by:
-
Aybuke Ozdemir authored
This patch fixes these error messages found by checkpatch.pl: ERROR: do not use C99 // comments Signed-off-by:
Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by:
-
- 19 Sep, 2014 32 commits
-
-
Abel Moyo authored
Added error checking for alloc_tx_struct in do_tx() Signed-off-by:
Abel Moyo <abelmoyo.ab@gmail.com> Signed-off-by:
-
Gulsah Kose authored
Fixes "Missing a blank line after declarations" checkpatch.pl warning in gdm_mux.c Signed-off-by:
Gulsah Kose <gulsah.1004@gmail.com> Reviewed-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Daeseok Youn authored
Using schedule_timeout_interruptible() is exactly same as setting a status of current process and calling schedule_timeout(). Removes dgap_ms_sleep(), because this function is used only when closing tty channel on dgap_tty_close(). And also removes ch_close_delay that is always set to 250 on dgap_tty_init(). Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Ankita Patil authored
This patch removes unnecessary variable in file dgap.c using Coccinelle. Semantic patch for this is as follows: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; Also removed the unneeded variable manually. Signed-off-by:Ankita Patil <patil.ankita.r@gmail.com> Signed-off-by:
-
Purnendu Kapadia authored
- no space after cast - allignment should match open parenthesis - remove unnecessary new line Signed-off-by:
Purnendu Kapadia <pro8linux@gmail.com> Signed-off-by:
-
Aybuke Ozdemir authored
This patch fixes these warning messages found by checkpatch.pl: WARNING: Space prohibited before semicolon. Signed-off-by:
-
Aybuke Ozdemir authored
This patch fixes these warning messages found by checkpatch.pl: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Aybuke Ozdemir authored
This patch fixes these error messages found by checkpatch.pl: ERROR: "foo* bar" should be "foo *bar" Signed-off-by:
-
Greg Donald authored
Fix checkpatch.pl "space required after that ','" errors Signed-off-by:
Greg Donald <gdonald@gmail.com> Signed-off-by:
-
Kieron Browne authored
Use cpu_to_le16 to cast int for assignment to __le16 members Signed-off-by:
Kieron Browne <kieron.browne@gmail.com> Signed-off-by:
-
MihaelaGaman authored
Fix checkpatch.pl "spaces required around": >, =, =, =, =, +=, >, >, <, <, :, < errors. Signed-off-by:
MihaelaGaman <mp.gaman@gmail.com> Signed-off-by:
-
Vaishali Thakkar authored
This patch compresses two lines in to a single line in file rtw_android.c if immediate return statement is found. It also removes variable bytes_written as it is no longer needed. It is done using script Coccinelle. And coccinelle uses following semantic patch for this compression function: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; Signed-off-by: Vaishali Thakkar<vthakkar1994@gmail.com> Acked-by: -
Gulsah Kose authored
This patch fixes "foo * bar" should be "foo *bar" checkpatch.pl error in rtw_cmd.c Signed-off-by:
-
Catalina Mocanu authored
This fixes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations. Signed-off-by:
Catalina Mocanu <catalina.mocanu@gmail.com> Signed-off-by:
-
Catalina Mocanu authored
This fixes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations. Signed-off-by:
-
Aybuke Ozdemir authored
This patch fixes these warning messages found by checkpatch.pl: WARNING : Missing a blank line after declarations Signed-off-by:
-
Catalina Mocanu authored
This fixes the following checkpatch.pl warning: WARNING: Missing a blank line after declarations. Signed-off-by:
-
Tina Johnson authored
Clean-up patch to fix the following checkpatch.pl warnings: ade7753.c:325: WARNING: Missing a blank line after declarations ade7753.c:383: WARNING: Missing a blank line after declarations Signed-off-by: Tina Johnson<tinajohnson.1234@gmail.com> Signed-off-by: -
Tina Johnson authored
Saved one line of code by merging the assigning and return statements of variable ret. And thus removed variable len which was no longer useful. This patch was done using Coccinelle script and the following semantic patch was used: @@ expression ret; identifier f; @@ -ret = +return f(...); -return ret; Signed-off-by:Tina Johnson <tinajohnson.1234@gmail.com> Acked-by:
-
Julia Lawall authored
This patch removes some kzalloc-related macros and rewrites the associated null tests to use !x rather than x == NULL. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ptr; statement S,S1; @@ \(OBD_ALLOC\|OBD_ALLOC_WAIT\|OBD_ALLOC_PTR\|OBD_ALLOC_PTR_WAIT\)(ptr,...); if ( + ! ptr - == NULL ) S else S1 @@ expression ptr,size; @@ - OBD_ALLOC(ptr,size) + ptr = kzalloc(size, GFP_NOFS) @@ expression ptr,size; @@ - OBD_ALLOC_WAIT(ptr,size) + ptr = kzalloc(size, GFP_KERNEL) @@ expression ptr,size; @@ - OBD_ALLOC_PTR(ptr) + ptr = kzalloc(sizeof(*ptr), GFP_NOFS) @@ expression ptr,size; @@ - OBD_ALLOC_PTR_WAIT(ptr,size) + ptr = kzalloc(sizeof(*ptr), GFP_KERNEL) // </smpl> Signed-off-by:
-
Martin Kelly authored
Cleanup whitespace and comments in Ioctl.h in a few ways: - > 80 character cleanup - Comment clarification - More consistent vertical alignment Signed-off-by:
Martin Kelly <martkell@amazon.com> Reviewed-by:
Matthias Beyer <mail@beyermatthias.de> Signed-off-by:
-
Fabien Malfoy authored
Several pointer declaration syntax have been fixed to match the coding style. Signed-off-by:
Fabien Malfoy <fabien.malfoy@laposte.net> Signed-off-by:
-
Merlin Chlosta authored
Declare ieee80211_TURBO_Info static to fix a sparse "symbol was not declared" warning. Signed-off-by:
Merlin Chlosta <eudyptula@merlin.geekmail.org> Signed-off-by:
-
Vincenzo Scotti authored
Signed-off-by:
Vincenzo Scotti <vinc94@gmail.com> Reported-by:
kbuild test robot <fengguang.wu@intel.com> Signed-off-by:
-
Masanari Iida authored
This patch Convert pr_warning to pr_warn. Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Sudip Mukherjee authored
fixed sparse warning : context imbalance in 'destroy_device' unexpected unlock this patch will generate warning from checkpatch for lines over 80 character , but since those are user-visible strings so it was not modified. Signed-off-by:Sudip Mukherjee <sudip@vectorindia.org> Tested-by:
Benjamin Romer <benjamin.romer@unisys.com> Acked-by:
-
Luke Hart authored
Copy the channel type into a temporary buffer so that code will work for architectures that don't support MMIO. This now works in same way as other tests in same function. Signed-off-by:
Luke Hart <luke.hart@birchleys.eu> Signed-off-by:
-
Mark Einon authored
Fix two occurrences of the checkpatch check: CHECK: Logical continuations should be on the previous line Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Mark Einon authored
Fix this checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by:
-
Mark Einon authored
A few calls to sizeof() in et131x.c give the type as a parameter - use the equivalent variable name instead. Signed-off-by:
-
Mark Einon authored
In some places in et131x.c, one arm of am if/else statement has braces and the other not - put braces on both arms where this happens. Signed-off-by:
-
Mark Einon authored
In three places in et131x.c, spaces exist after a cast. Remove them. Signed-off-by:
-
