1. 26 Apr, 2014 40 commits
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Larry Finger's avatar
      staging: r8723au: Fix sparse warnings in core/rtw_ap.c · a96ae6f4
      Larry Finger authored
      The following warnings are fixed:
      
      drivers/staging/rtl8723au/core/rtw_ap.c:79:23: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/core/rtw_ap.c:79:23:    expected unsigned short [unsigned] [usertype] tim_bitmap_le
      drivers/staging/rtl8723au/core/rtw_ap.c:79:23:    got restricted __le16 [usertype] <noident>
      drivers/staging/rtl8723au/core/rtw_ap.c:1441:37: warning: restricted __le16 degrades to integer
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      a96ae6f4
    • Larry Finger's avatar
      staging: r8723au: Set undeclared routines to static · c0b99bed
      Larry Finger authored
      The following sparse warnings are fixed:
      
      drivers/staging/rtl8723au/core/rtw_cmd.c:1211:6: warning: symbol 'dynamic_chk_wk_hdl' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_cmd.c:1238:6: warning: symbol 'lps_ctrl_wk_hdl' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_cmd.c:1812:6: warning: symbol 'rtw_getrttbl_cmd_cmdrsp_callback' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_mlme.c:364:6: warning: symbol 'rtw_free_network' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_mlme.c:373:6: warning: symbol 'rtw_free_network_nolock' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_mlme.c:631:6: warning: symbol 'rtw_add_network' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_mlme.c:644:5: warning: symbol 'rtw_is_desired_network' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2246:5: warning: symbol 'DoReserved23a' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:5549:6: warning: symbol 'linked23a_rx_sig_stren_disp' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_pwrctrl.c:272:4: warning: symbol 'PS_RDY_CHECK' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_recv.c:1937:5: warning: symbol 'enqueue_reorder_recvframe23a' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_sta_mgt.c:24:6: warning: symbol '_rtw_init_stainfo' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_sta_mgt.c:112:6: warning: symbol 'rtw_mfree_all_stainfo' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_sta_mgt.c:127:6: warning: symbol 'rtw_mfree_sta_priv_lock' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_wlan_util.c:143:15: warning: symbol 'ratetbl_val_2wifirate' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_wlan_util.c:188:5: warning: symbol 'is_basicrate' was not declared. Should it be static?
      drivers/staging/rtl8723au/core/rtw_wlan_util.c:206:14: warning: symbol 'ratetbl2rateset' was not declared. Should it be static?
      
      Three of the above routines were not used and were deleted.
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c0b99bed
    • Larry Finger's avatar
      staging: r8723au: Fix endian errors in descriptor get and set macros · 69d9ff1a
      Larry Finger authored
      There are several macros used to get and set portions of the RX and TX descriptor
      information that need to be converted to be endian correct. The following sparse
      warnings are fixed:
      
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2477:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2477:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2479:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2479:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2479:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2479:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2479:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2479:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2649:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2649:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2651:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2651:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2651:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2651:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2651:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2651:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2863:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2863:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2865:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2865:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2865:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2865:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2865:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2865:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2996:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2996:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2998:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2998:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2998:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2998:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2998:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:2998:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3105:25: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3105:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3105:25:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3164:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3164:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3167:17: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3167:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3167:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3167:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3167:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3167:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3313:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3313:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3315:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3315:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3315:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3315:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3315:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3315:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3581:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3581:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3581:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3583:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3583:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3583:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3586:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3586:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3586:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3592:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3592:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3594:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3594:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3594:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3594:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3594:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3594:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3702:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3702:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3702:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3704:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3704:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3704:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3707:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3707:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3707:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3711:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3711:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3711:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3713:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3713:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3713:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3715:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3715:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3715:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3721:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3721:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3723:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3723:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3723:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3723:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3723:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3723:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3827:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3827:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3829:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3829:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3829:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3829:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3829:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3829:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3938:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3938:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3940:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3940:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3940:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3940:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3940:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3940:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4010:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4010:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4012:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4012:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4012:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4012:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4012:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4012:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4199:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4199:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4201:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4201:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4201:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4201:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4201:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4201:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4509:28: warning: too many warnings
      drivers/staging/rtl8723au/core/rtw_xmit.c:940:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_xmit.c:940:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:940:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:940:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:940:9:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:940:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:946:25: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:946:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:946:25:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:957:25: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:957:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:957:25:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:980:25: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:980:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:980:25:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:982:25: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:982:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:982:25:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:986:33: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:986:33:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:986:33:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:987:25: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:987:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:987:25:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:988:25: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:988:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:988:25:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:997:25: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:997:25: warning: cast to restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:1176:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/core/rtw_xmit.c:1176:17:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:1176:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/core/rtw_xmit.c:1260:25: warning: invalid assignment: &=
      drivers/staging/rtl8723au/core/rtw_xmit.c:1260:25:    left side has type unsigned short
      drivers/staging/rtl8723au/core/rtw_xmit.c:1260:25:    right side has type fouled restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:224:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:224:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:226:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:226:9:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:226:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:226:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:226:9:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:226:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:316:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:316:9:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:316:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:317:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:317:9:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:317:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:317:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:317:9:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:317:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:320:9: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:320:9:    expected unsigned short [unsigned] [short] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:320:9:    got restricted __le16 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:354:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:354:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:354:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:358:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:358:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:358:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:366:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:366:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:366:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:382:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:382:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:387:17: warning: invalid assignment: &=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:387:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:387:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:387:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:387:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:387:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:390:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:390:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:390:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:391:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:391:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:391:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:395:17: warning: invalid assignment: &=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:395:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:395:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:395:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:395:17:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:395:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:426:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:426:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:427:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:427:9:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:427:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:427:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:427:9:    left side has type unsigned short
      drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:427:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:319:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:319:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:323:17: warning: invalid assignment: &=
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:323:17:    left side has type unsigned short
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:323:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:323:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:323:17:    left side has type unsigned short
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:323:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:326:17: warning: invalid assignment: &=
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:326:17:    left side has type unsigned short
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:326:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:326:17: warning: invalid assignment: |=
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:326:17:    left side has type unsigned short
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:326:17:    right side has type restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2368:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2368:9: warning: cast to restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2370:9: warning: invalid assignment: &=
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2370:9:    left side has type unsigned short
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2370:9:    right side has type restricted __le16
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2370:9: warning: invalid assignment: |=
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2370:9:    left side has type unsigned short
      drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c:2370:9:    right side has type restricted __le16
      
      The following new warnings were temporarily added:
      
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4509:28: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4509:28:    expected unsigned short [unsigned] [assigned] [usertype] capab_info
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4509:28:    got restricted __le16 [usertype] capab_info
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:4612:17: warning: cast to restricted __le32
      drivers/staging/rtl8723au/core/rtw_mlme_ext.c:5549:6: warning: symbol 'linked23a_rx_sig_stren_disp' was not declared. Should it be static?
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      69d9ff1a
    • Larry Finger's avatar
      staging: r8723au: Fix endian issues in hal/rtl8723au_recv.c · 74714a59
      Larry Finger authored
      The following sparse warnings are fixed:
      
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:145:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:145:22:    expected restricted __le32 [usertype] rxdw0
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:145:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:146:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:146:22:    expected restricted __le32 [usertype] rxdw1
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:146:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:147:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:147:22:    expected restricted __le32 [usertype] rxdw2
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:147:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:148:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:148:22:    expected restricted __le32 [usertype] rxdw3
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:148:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:149:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:149:22:    expected restricted __le32 [usertype] rxdw4
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:149:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:150:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:150:22:    expected restricted __le32 [usertype] rxdw5
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:150:22:    got unsigned int [unsigned] [usertype] <noident>
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      74714a59
    • Larry Finger's avatar
      staging: r8723au: Fix endian issues with TX and RX descriptors · caa90ab1
      Larry Finger authored
      All descriptors are __le32, not unsigned int. The following sparse warnings are fixed:
      
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2626:24: warning: invalid assignment: &=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2626:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2626:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2632:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2632:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2632:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2873:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2873:22:    expected unsigned int [unsigned] txdw0
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2873:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2874:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2874:22:    expected unsigned int [unsigned] txdw1
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2874:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2875:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2875:22:    expected unsigned int [unsigned] txdw2
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2875:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2876:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2876:22:    expected unsigned int [unsigned] txdw3
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2876:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2877:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2877:22:    expected unsigned int [unsigned] txdw4
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2877:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2878:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2878:22:    expected unsigned int [unsigned] txdw5
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2878:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2879:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2879:22:    expected unsigned int [unsigned] txdw6
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2879:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2880:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2880:22:    expected unsigned int [unsigned] txdw7
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2880:22:    got restricted __le32 [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2903:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2903:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2903:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2906:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2906:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2906:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2910:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2910:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2910:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2914:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2914:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2914:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2919:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2919:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2919:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2922:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2922:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2922:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2924:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2924:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2924:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2928:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2928:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2928:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2932:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2932:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2932:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:145:24: warning: cast to restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:146:24: warning: cast to restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:147:24: warning: cast to restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:148:24: warning: cast to restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:149:24: warning: cast to restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:150:24: warning: cast to restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:77:32: warning: invalid assignment: &=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:77:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:77:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:82:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:82:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:82:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:92:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:92:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:92:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:97:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:97:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:97:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:100:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:100:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:100:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:183:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:183:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:183:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:186:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:186:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:186:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:188:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:188:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:188:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:193:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:193:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:193:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:195:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:195:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:195:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:200:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:200:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:200:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:204:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:204:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:204:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:214:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:214:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:214:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:215:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:215:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:215:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:218:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:218:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:218:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:224:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:224:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:224:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:226:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:226:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:226:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:229:48: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:229:48:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:229:48:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:231:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:231:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:231:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:235:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:235:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:235:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:238:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:238:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:238:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:240:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:240:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:240:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:245:40: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:245:40:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:245:40:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:248:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:248:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:248:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:251:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:251:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:251:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:254:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:254:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:254:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:255:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:255:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:255:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:257:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:257:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:257:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:264:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:264:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:264:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:266:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:266:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:266:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:271:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:271:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:271:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:274:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:274:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:274:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:277:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:277:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:277:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:288:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:288:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:288:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:290:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:290:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:290:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:294:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:294:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:294:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:295:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:295:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:295:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:296:24: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:296:24:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:296:24:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:299:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:299:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:299:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:306:32: warning: invalid assignment: |=
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:306:32:    left side has type unsigned int
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:306:32:    right side has type restricted __le32
      drivers/staging/rtl8723au/hal/usb_ops_linux.c:473:20: warning: cast to restricted __le32
      drivers/staging/rtl8723au/hal/usb_ops_linux.c:590:36: warning: cast to restricted __le32
      
      The following new warnings are temporarily added:
      
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2873:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2874:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2875:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2876:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2877:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2878:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2879:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2880:24: warning: cast from restricted __le32
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:145:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:145:22:    expected restricted __le32 [usertype] rxdw0
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:145:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:146:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:146:22:    expected restricted __le32 [usertype] rxdw1
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:146:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:147:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:147:22:    expected restricted __le32 [usertype] rxdw2
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:147:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:148:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:148:22:    expected restricted __le32 [usertype] rxdw3
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:148:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:149:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:149:22:    expected restricted __le32 [usertype] rxdw4
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:149:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:150:22: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:150:22:    expected restricted __le32 [usertype] rxdw5
      drivers/staging/rtl8723au/hal/rtl8723au_recv.c:150:22:    got unsigned int [unsigned] [usertype] <noident>
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:211:51: warning: incorrect type in argument 2 (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:211:51:    expected unsigned int [usertype] *pdw
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:211:51:    got restricted __le32 *<noident>
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:212:51: warning: incorrect type in argument 2 (different base types)
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:212:51:    expected unsigned int [usertype] *pdw
      drivers/staging/rtl8723au/hal/rtl8723au_xmit.c:212:51:    got restricted __le32 *<noident>
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      caa90ab1
    • Larry Finger's avatar
      staging: r8723au: Fix sparse warning in os_dep/os_intfs.c · 73302d7f
      Larry Finger authored
      Sparse reports the following:
      
      drivers/staging/rtl8723au/os_dep/os_intfs.c:321:14: warning: restricted __be16 degrades to integer
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      73302d7f
    • Larry Finger's avatar
      staging: r8723au: Fix sparse errors in os_dep/osdep_service.c · fecb32d4
      Larry Finger authored
      Sparse reports
      
      drivers/staging/rtl8723au/os_dep/osdep_service.c:24:20: error: Bad character constant
      drivers/staging/rtl8723au/os_dep/osdep_service.c:25:0: error: Bad character constant
      
      The constant in question is never used.
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      fecb32d4
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
      staging: rtl8723au: rtw_joinbss_cmd23a(): Remove unnecessary typecast · ea4190b1
      Jes Sorensen authored
      and remove use-once variable t_len.
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      ea4190b1
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
      staging: rtl8723au: Use a workqueue for command handling · d97e2d2b
      Jes Sorensen authored
      Rewrite the old thread based code to use a workqueue instead. This
      removes a pile of complexity, locks and queues and eliminates problem
      that cmd handling could have been killed from userspace.
      
      This was suggested by Tejun Heo - thanks!
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d97e2d2b
    • Jes Sorensen's avatar
    • Jes Sorensen's avatar
      staging: rtl8723au: rtw_cfg80211_inform_bss() fix Smatch warning · f844717c
      Jes Sorensen authored
      Check the size of pnetwork->network.IELenght correctly to avoid Smatch
      warning.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f844717c
    • Jes Sorensen's avatar
      staging: rtl8723au: c2h_wk_callback(): Use GFP_KERNEL, and check return value · fbde4129
      Jes Sorensen authored
      It is safe to use GFP_KERNEL in a workqueue handler, and check the
      return value. If the malloc fails, skip and try again.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      fbde4129
    • Jes Sorensen's avatar
      staging: rtl8723au: rtw_check_beacon_data23a(): Make len unsigned int · 8282aeb6
      Jes Sorensen authored
      Making len unsigned int fixes a warning caused by smatch getting
      confused that len could be negative.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      8282aeb6
    • Jes Sorensen's avatar
      staging: rtl8723au: process_80211d(): Fix order of advancing array pos · 17979959
      Jes Sorensen authored
      Fix smatch warning from advancing array index before reading out the
      value of the array.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      17979959
    • Jes Sorensen's avatar
      staging: rtl8723au: collect_bss_info23a(): Eliminate smatch warning · 79a76349
      Jes Sorensen authored
      Make length an unsigned int. This should avoid Smatch warning that
      'length' can go negative.
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      79a76349
    • Jes Sorensen's avatar
      staging: rtl8723au: Fix incorrect pointer test introduced in previous commit · 0b682c9b
      Jes Sorensen authored
      Commit da290c54 inverted the check of
      the return value when converting to use cfg80211_find_ie().
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0b682c9b
    • Jes Sorensen's avatar
      staging: rtl8723au: Check kmalloc return value and fix size of memcpy() · 5bd28bc2
      Jes Sorensen authored
      Check kmalloc() return before dereferencing bssid in
      rtw_check_bcn_info23a() and use the correct size to copy
      rtw_basic_rate_ofdm in update_bmc_sta_support_rate23a()
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5bd28bc2
    • Jes Sorensen's avatar