- 10 Oct, 2013 23 commits
-
-
Marcel Holtmann authored
The return value of hci_send_frame() is never checked. So just make this function void and print an error when the hdev->send driver callback returns a negative value. Having the error printed is actually an improvement over the current situation where any driver error just gets ignored. Signed-off-by:
Marcel Holtmann <marcel@holtmann.org> Signed-off-by:
Johan Hedberg <johan.hedberg@intel.com>
-
Marcel Holtmann authored
The hdev parameter of hci_send_frame must be always valid. If the hdev is not valid, it would not even make it to this stage. The callers will have already accessed hdev at that point many times. Signed-off-by:
-
Marcel Holtmann authored
The assignement of skb->dev is done all over the place. So it makes it hard to eventually get rid of it. Move it all in one central place so it gets assigned right before calling hdev->send driver callback. Signed-off-by:
-
Marcel Holtmann authored
The smp.h header file is only used internally by the bluetooth.ko module and is not a public API. So make it local to the core Bluetooth module. Signed-off-by:
-
Marcel Holtmann authored
The a2mp.h header file is only used internally by the bluetooth.ko module and is not a public API. So make it local to the core Bluetooth module. Signed-off-by:
-
Marcel Holtmann authored
The amp.h header file is only used internally by the bluetooth.ko module and is not a public API. So make it local to the core Bluetooth module. Signed-off-by:
-
Marcel Holtmann authored
Since there is no use of hdev->ioctl by any Bluetooth driver since ever, so just lets remove it. Signed-off-by:
-
Marcel Holtmann authored
The btmrvl_ioctl() function is not used and thus remove it. Signed-off-by:
-
Marcel Holtmann authored
The dtl1_hci_ioctl() function is not used and thus remove it. Signed-off-by:
-
Marcel Holtmann authored
The btuart_hci_ioctl() function is not used and thus remove it. Signed-off-by:
-
Marcel Holtmann authored
The bt3c_hci_ioctl() function is not used and thus remove it. Signed-off-by:
-
Marcel Holtmann authored
The bluecard_hci_ioctl() function is not used and thus remove it. Signed-off-by:
-
Marcel Holtmann authored
The bfusb_ioctl() function is not used and thus remove it. Signed-off-by:
-
Marcel Holtmann authored
The legacy ioctls for device specific commands including inquiry are not support by AMP controllers. So just reject them right away instead of trying to send the HCI command and wait for failure from the actual hardware. Signed-off-by:
-
Marcel Holtmann authored
When changing the alternate setting for the ISOC endpoints, use the hci_conn_num() helper function to count currently established SCO and eSCO connections and store the the value. This avoids direct access to the connection hash. In addition use the stored value instead accessing the connection hash over and over again. Signed-off-by:
-
Marcel Holtmann authored
When checking for the current number of LE connections, use hci_conn_num() function instead of a full blown lookup within the connection hash or direct access of the counters. In the case of re-enabling advertising, it is more useful to check for any connection attempt or existing connection. Signed-off-by:
-
Marcel Holtmann authored
The function declaration goes over 80 characters, so break it down. Signed-off-by:
-
Johan Hedberg authored
When the HCI_SETUP flag is set the controller has not yet been announced over mgmt and therefore doesn't exist from that perspective. If we nevertheless get a mgmt command for it we should respond with the appropriate INVALID_INDEX error. Signed-off-by:
-
Johan Hedberg authored
The l2cap_recv_frame function is expected to take ownership and eventually free the skb passed to it. We need to ensure that the conn->rx_skb pointer is no longer reachable when calling l2cap_recv_frame so that no other function, such as l2cap_conn_del, may think that it can free conn->rx_skb. An actual situation when this can happen is when smp_sig_channel (called from l2cap_recv_frame) fails and l2cap_conn_del gets called as a consequence. The l2cap_conn_del function would then try to free conn->rx_skb, but as the same skb was just passed to smp_sig_channel and freed we get a double-free. Signed-off-by:
-
Marcel Holtmann authored
The support for Bluetooth High Speed can only be enabled on controllers where also Secure Simple Pairing has been enabled. Trying to enable high speed when SSP is disabled will result into an error. Disabling SSP will at the same time disable high speed as well. It is required to enforce this dependency on SSP since high speed support is only defined for authenticated, unauthenticated and debug link keys. These link key types require SSP. Signed-off-by:
-
Marcel Holtmann authored
The variable val in the set_ssp() function of the management interface is not needed. Just use cp->val directly since its input values have already been validated. Signed-off-by:
-
Andre Guedes authored
This patch does some code refactoring in hci_connect_le() by moving the exception code into if statements and letting the main flow in first level of function scope. It also adds extra comments to improve the code readability. Signed-off-by:
Andre Guedes <andre.guedes@openbossa.org> Signed-off-by:
-
Andre Guedes authored
This patch introduces a new helper, which uses the HCI request framework, for creating LE connectons. All the handling is now done by this function so we can remove the hci_cs_le_create_conn() event handler. This patch also removes the old hci_le_create_connection() since it is not used anymore. Signed-off-by:
-
- 08 Oct, 2013 1 commit
-
-
Johan Hedberg authored
We only (re)enable advertising when LE is disconnected. Trying to enable advertising using mgmt_set_advertising while connected should simply change the flag but not do anything else (until the connection gets dropped). This patch fixes this by making an LE connection lookup to determine whether there are any connected devices or not. Signed-off-by:
-
- 07 Oct, 2013 16 commits
-
-
Johannes Berg authored
Sparse points out three places where variables are shadowed, rename two of the variables and remove the duplicate third. Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
-
Marcel Holtmann authored
When initializing an AMP controller, read its current flow control mode so that the correct value is used. The AMP controller defaults to block based flow control and this extra command is just to double check. Signed-off-by:
-
Marcel Holtmann authored
When initializing an AMP controller, read its current known location data so that it can be analyzed later on. Signed-off-by:
-
Marcel Holtmann authored
The commands for reading supported features and commands are both supported by AMP controllers. Issue them during controller init phase so their values are known. Signed-off-by:
-
Marcel Holtmann authored
Within the AMP discover response, list powered down AMP controllers as powered down. No point in trying to make them look any different. Signed-off-by:
-
Marcel Holtmann authored
The management interface only operates on BR/EDR controllers. The check for the power down notification is a bit intermixed with the check if controller auto power off is active. Since there are more than just BR/EDR controllers supported, make this check explicit since the auto power off check also applies to AMP controllers and it has to happen in this exact order. Otherwise the bit will not be cleared. Signed-off-by:
-
Marcel Holtmann authored
Even AMP controllers should be powered off after the setup phase. It is not a good idea to keep AMP controllers powered on all the time if they are not in use. Power on of the AMP controller can either be done manually via command line commands or directly via A2MP. Especially since there is an indication in A2MP for powered down controllers that can be activated. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_discovering() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_remote_name() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_device_found() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_device_disconnected() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_device_connected() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_connect_failed() function is not used so change it to just return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_disconnect_failed() function is not used so change it to just return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_set_powered_failed() function is never used and so make the function just return void. Signed-off-by:
-
Marcel Holtmann authored
The return value from mgmt_index_added() and mgmt_index_removed() functions is never used. So do not pretend that returning an error would actually be handled and just make both functions return void. Signed-off-by:
-
