- 24 Aug, 2004 40 commits
-
-
Kurt Garloff authored
When using bounce buffers for SG_IO commands with unaligned buffers in blk_rq_map_user(), we should free the pages from blk_rq_unmap_user() which calls bio_uncopy_user() for the non-BIO_USER_MAPPED case. That function failed to free the pages for write requests. So we leaked pages and you machine would go OOM. Rebooting helped ;-) This bug was triggered by writing audio CDs (but not on data CDs), as the audio frames are not aligned well (2352 bytes), so the user pages don't just get mapped. Bug was reported by Mathias Homan and debugged by Chris Mason + me. (Jens is away.) From: Chris Mason <mason@suse.com> Fix the leak for real Signed-off-by:
Kurt Garloff <garloff@suse.de> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Martin Schwidefsky authored
From: Heiko Carstens <heiko.carstens@de.ibm.com> From: Andreas Herrmann <aherrman@de.ibm.com> From: Maxim Shchetynin <maxim@de.ibm.com> zfcp host adapter changes: - Use predefined macro to create in_recovery sysfs attributes. - Add function to check CT_IU response. - Fix handling of rejected ELS commands. - Change return value of zfcp_fsf_req_sbal_get to -ERESTARTSYS in some cases. - Return proper error code if control file upload/download failed. - Remove dead code. - Avoid sparse warnings. Signed-off-by:
Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by:
-
Martin Schwidefsky authored
From: Jan Glauber <jan.glauber@de.ibm.com> From: Martin Schwidefsky <schwidefsky@de.ibm.com> s390 core changes: - Use copy_siginfo_from_user32 instead of copy_from_user to get the siginfo structure in sys32_rt_sigqueueinfo. - Remove prototype for non-existant stop_timers function. - Regenerate default configuration. Signed-off-by:
-
Rusty Russell authored
From: Arjan van de Ven <arjanv@redhat.com> The patch below sets the tainted sysctl file to read only, otherwise userspace can just overwrite/reset it. Signed-off-by:
-
Pavel Machek authored
This patch is thanks to pavouk. Signed-off-by:
-
Pavel Machek authored
Coding style document is not consistent with itself on whether there should be space after ","... This makes it standardize on ", " option. Signed-off-by:
-
Eric W. Biederman authored
The ramdisk_blocksize option has been broken for quite a while in 2.6. Making an initrd with a 4K ext2 filesystem impossible to use. After digging into this, the problem turned out to that rd.c was not setting the hard sector size. There were a few secondary problems like i_blkbits was not being set, and the number KiB in uncompressed ext2 images was not taking into account the block size. I have also corrected the surrounding comments as they were not just incorrect but misleading. Signed-off-by:
-
Olaf Hering authored
For some reasons ls -l /proc/$$/exe doesnt work all time for me, with 2.6.8.1 on ppc64. Sometimes it does, sometimes not. No pattern. A few printks show that this check in proc_pid_readlink() triggers an -EACCES: current->fsuid != inode->i_uid proc_pid_readlink(755) error -13 ntptrace(11408) fsuid 100 i_uid 0 0 sys_readlink(281) ntptrace(11408) error -13 readlink Signed-off-by:
-
Cornelia Huck authored
The drivers under drivers/media/dvb/ttpci depend on pci (especially since they select VIDEO_SAA7146, which depends on pci). Signed-off-by:
Cornelia Huck <kernel@cornelia-huck.de> Signed-off-by:
-
Maximilian Attems authored
Signed-off-by:
Maximilian Attems <janitor@sternwelten.at> Signed-off-by:
-
James Morris authored
The patch below reduces kernel memory used by SELinux policy rules by about 37% on 64-bit systems. This is because the size of struct avtab_node is 40 bytes on 64-bit, and defaults to a size-64 slab. Creating a slab cache specifically for these structs saves considerable amounts of kernel memory on 64-bit systems with large rulesets. 'Strict' policy has over 300k rules, while 'targeted' policy has around 3k rules. Here's the slabtop output with 64 and 40 byte sized slabs to show the memory savings, for strict policy: 303475 303447 99% 0.06K 4975 61 19900K avtab_node 303456 303447 99% 0.04K 3161 96 12644K avtab_node Also, there are 57% more objects per slab. Signed-off-by:
James Morris <jmorris@redhat.com> Signed-off-by:
-
Stephen D. Smalley authored
This patch restores the proper auditing behavior for the name_bind check. Author: James Morris <jmorris@redhat.com> Signed-off-by:
Stephen Smalley <sds@epoch.ncsc.mil> Signed-off-by:
-
Stephen D. Smalley authored
This patch defers setting the inode security state for newly created inodes until after policy has been loaded. Signed-off-by:
-
Stephen D. Smalley authored
This patch changes the SELinux flush_unauthorized_files function to also recheck access to the controlling tty and reset it if it is no longer accessible under the new security context. This patch is relative to the selinuxfs devnull patch. Signed-off-by:
-
Stephen D. Smalley authored
This patch adds a null device node to selinuxfs and replaces the SELinux open_devnull() code by simply acquiring a reference to this node each time, based on a comment by Al Viro on lkml (see http://marc.theaimsgroup.com/?l=linux-kernel&m=108664922032035&w=2). Signed-off-by:
-
Jeff Mahoney authored
Since the filesystem doesn't explicitly set s->s_maxbytes, seeks will fail beyond 2^32-1, due to s->s_maxbytes being set to the default of MAX_NON_LFS. Attached is the quick one liner fix. Signed-off-by:
-
Jeff Mahoney authored
Here are a few fixes for bugs noticed on reiserfs-list or our own bugzilla. Attached is a patch that fixes several problems with xattrs/acls: [SECURITY] Fixes the inode not getting dirtied when mode is set via setxattr() [CORRECTNESS] Fixes the inode not getting ctime updated when an xattr is removed [DATA] Fixes an issue with dcache hash colliding names in the filesystem root caused by the d_compare to hide .reiserfs_priv. The bug can only occur in the filesystem root, which is why we haven't seen many (any, outside of the suse bugzilla, afaik) reports on this. The results are that dcache operations on colliding entries in the fs root will choose the first match rather than the correct entry. Signed-off-by: -
Paul Fulghum authored
Replace syncppp interface with generic HDLC interface. Generic HDLC provides superset of syncppp function. Signed-off-by:
Paul Fulghum <paulkf@microgate.com> Signed-off-by:
-
Paul Fulghum authored
Replace syncppp interface with generic HDLC interface. Generic HDLC provides superset of syncppp function. Signed-off-by:
-
Paul Fulghum authored
Replace syncppp interface with generic HDLC interface. Generic HDLC provides superset of syncppp function. Signed-off-by:
-
Rusty Russell authored
When exporting the module parameters of built-in modules, we need to access the respective struct kernel_parameters. Currently, they're freed at init time, and obviously this can't continue to be done. So, move them out of __init_begin and __init_end and into RODATA in asm-generic/vmlinux.lds.h. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (modified) Signed-off-by:
Dominik Brodowski <linux@brodo.de> Signed-off-by:
-
Rusty Russell authored
module_param() and family take a "perms" argument; several people have incorrectly used "644" instead of "0644". (I have a patch which checks for sane perms at compile time, but it bloats modules, so I haven't included it.) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (authored) Signed-off-by:
-
Rusty Russell authored
__FIXADDR_TOP and PAGE_OFFSET are hardcoded in various places. I had to change it to run the kernel under qemu-fast, so I wanted to centralize them. To do this, we rename vsyscall.lds to vsyscall.lds.s, and generate it from vsyscall.lds.S. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (created) Signed-off-by:
-
Rusty Russell authored
Paul Jackson points out that the sysfs code saves a node's cpumask in the sysfs node, although it can change with CPU hotplug. Don't do this. Signed-off-by:
Rusty Russell <rusty@rustcorp.com.au> Signed-off-by:
-
Anton Blanchard authored
Most of the inode slabs are cacheline aligned. This can waste a fair amount of memory, especially on architectures with large cacheline sizes (eg 128 bytes). Alignment has a few advantages. It prevents 2 cpus from accessing 2 data structures in the same cacheline. Since struct inodes are well over a cacheline and there are so many of them, there is little chance we will hit this problem if we remove the alignment. Alignment also ensures the maximum amount of the data structure is in the same cacheline (instead of straddling 2 for example). The large size of struct inode reduces this advantage. With this patch the inode_cache slab goes from 640 bytes to 544 bytes, and the number that fits in a 4kB slab goes from 6 to 7 on ppc64. A number of other inode slabs also see improvements. Signed-off-by:
Anton Blanchard <anton@samba.org> Signed-off-by:
-
Anton Blanchard authored
Reduce size of struct dentry from 248 to 232 bytes on 64bit. - Reduce size of qstr by 8 bytes, placing int hash and int len together. We gain a further 4 byte saving when qstr is used in struct dentry since qstr goes from 24 to 16 bytes and the next member (d_lru) requires 8 byte alignment (which means 4 bytes of padding). - Move d_mounted to the end, since char d_iname[] only requires 1 byte alignment. This reduces struct dentry by another 4 bytes. With these changes the number of objects we can fit into a 4kB slab goes from 16 to 17 on ppc64. Note the above assumes the architecture naturally aligns types. Signed-off-by:
-
Anton Blanchard authored
Reduce size of buffer_head from 96 to 88 bytes on 64bit architectures by putting b_count and b_size together. b_count will still be in the first 16 bytes on 32bit architectures, so 16 byte cacheline machines shouldnt be affected. With this change the number of objects per 4kB slab goes up from 40 to 44 on ppc64. Signed-off-by:
-
Pavel Machek authored
According to devices.txt, serial ports are reffered as ttyS0 (and not ttyS00). It would be nice to use that convention in printks, too. Signed-off-by:
-
Chris Wright authored
Use simple_read_from_buffer in proc_info_read and proc_pid_attr_read. Viro had ack'd this earlier. Signed-off-by:
Chris Wright <chrisw@osdl.org> Signed-off-by:
-
Chris Wright authored
Use simple_read_from_buffer. This also eliminates page allocation for the sprintf buffer. Switch to get_zeroed_page instead of open-coding it. Viro had ack'd this earlier. Still applies w/ the transaction update. Signed-off-by:
-
Chris Wright authored
Fix typos in security/security.c. From: Nicolas Kaiser <nikai@nikai.net> Signed-off-by: -
Chris Wright authored
Add configure option for setting default SELinux bootparam value. Ack'd by James Morris. Signed-off-by:
-
Chris Wright authored
I'd suggest the patch below to let the SECURITY_CAPABILITIES and SECURITY_ROOTPLUG dependencies look a bit more simple. Signed-off-by:
Adrian Bunk <bunk@fs.tum.de> Signed-off-by:
-
Christoph Hellwig authored
(from the Debian kernel package) Signed-off-by:
-
Christoph Hellwig authored
We don't allow non-ELF kernels since 2.0 days, and surprisingly this is not actually checked anywhere. Signed-off-by:
-
Christoph Hellwig authored
This can't happen with a sane filesystem (but is triggered by the buggy clearcase bin only kernel module), so let's better BUG_ON early. Adopted from Al's patch in the RH tree. Signed-off-by:
-
Christoph Hellwig authored
- build only if either CONFIG_LEGACY_PTYS or CONFIG_UNIX98_PTYS are set instead of testing in the file - try to keep big CONFIG_LEGACY_PTYS and CONFIG_UNIX98_PTYS ifdef blocks at the end of the file instead of cluttering all over Signed-off-by:
-
Jesse Barnes authored
I found that sn_console was missing an include and a fix if CONFIG_SMP=n. This patch fixes up the two small problems I found. Signed-off-by:
Jesse Barnes <jbarnes@sgi.com> Signed-off-by:
-
Jesse Barnes authored
People are mainly concerned with showing off their total bogomips, not per-cpu bogomips, so turn it into a KERN_DEBUG message for the benefit of systems with lots of CPUs. Signed-off-by:
-
James Morris authored
Below is an updated version of the patch which moves duplicated transaction-based file operation code into libfs. Since the last post, the patch has been through a couple of iterations with Al, who suggested a number of cleanups including locking and interface simplification. For filesystem writers, the interface is now much simpler. The simple_transaction_get() helper should be part of the file op write method. This safely obtains the transaction request data during write(), allocates a page for it and stores it there. The data is returned to the caller for potential further processing, which then makes it available for the next read() call via simple_transaction_set(). See the selinuxfs and nfsctl code for examples of use. Signed-off-by:
-
