- 26 Jun, 2004 5 commits
-
-
James Bottomley authored
-
Randy Dunlap authored
| From: Andrew Morton | To: linux-scsi@vger.kernel.org | Subject: fdomain screwup | | - fdomain_setup() is marked __init, but is called from non-__init | fdomain_16x0_detect() | | - fdomain_setup() is declared in drivers/scsi/pcmcia/fdomain_stub.c as | taking two arguments, but is implemented in fdomain_setup() taking a | single argument. | | Please, never ever ever put extern function declarations in .c files. | Put it in a header file which is visible to the definition and to all | callsites. | | - fdomain_setup() is declared static, hence the linkage fails. | | - fdomain_16x0_bus_reset() is implemented in drivers/scsi/fdomain.c but | has static scope, so the call from drivers/scsi/pcmcia/fdomain_stub.c | doesn't work. [I didn't find this to be the case, so I didn't fix it.] | - fdomain_16x0_bus_reset() has an extern declaration in | drivers/scsi/pcmcia/fdomain_stub.c. This should be moved to a header | file which is visible to etc... Builds and loads. No hardware to test. Signed-off-by:
Randy Dunlap <rddunlap@osdl.org> Signed-off-by:
James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
On Mon, Jun 21, 2004 at 12:16:08PM -0400, Moore, Eric Dean wrote: > We are pleased to announce the MPT Fusion release candidate for lk 2.6 I've worked with Eric offline to resolve the issue we had and get some more changes in, but he has left for his vacation today. He send me a patch though and left it to me whether we'd merged it despite only moderate testing. Given 2.6.7 was just done and he'll certainly be back before 2.6.8 I'd go for it. Below is the patch rediffed against scsi-misc-2.6: Signed-off-by: -
James Bottomley authored
The DMA conversion of the advansys driver is still broken. Add a #warning to the driver and a comment above it explaining what needs to be done. Mark the driver as BROKEN because of the warning Also remove the #include "scsi.h" Signed-off-by: -
Douglas Gilbert authored
- fix PCI wide "use_sg > 0" problem introduced in lk 2.6.7-bk2 - fix ISA oops (present in all versions of the lk 2.6 series to date) - bump version to "3.3K" and add comments - fix compilation error when ADVANSYS_DEBUG defined Signed-off-by:
-
- 24 Jun, 2004 1 commit
-
-
James Bottomley authored
From: Andrew Vasquez <praka@users.sourceforge.net> Instead make all files do the proper includes. Signed-off-by:
-
- 22 Jun, 2004 23 commits
-
-
James Bottomley authored
Signed-off-by: -
Maximilian Attems authored
Cleaned up code for error handing. Added checks to unmap memory, release IRQ's, and freeing up dev->queue. Signed-off-by:
MJK <mkemp@cs.nmsu.edu> Signed-off-by:
Maximilian Attems <janitor@sternwelten.at> Signed-off-by:
-
James Bottomley authored
From: maximilian attems <janitor@sternwelten.at> Cleaned up code for error handing. Added checks to unmap memory, release IRQ's, and freeing up dev->queue. Signed-off-by:
-
James Bottomley authored
-
Andrew Vasquez authored
Update version number to 8.00.00b14-k. Signed-off-by:
Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by:
-
Andrew Vasquez authored
Fix incorrect return-code check in bus-reset error handler. Signed-off-by:
-
James Bottomley authored
From: Andrew Vasquez <andrew.vasquez@qlogic.com> Resync with latest released firmware -- 3.02.30. Signed-off-by:
-
Andrew Vasquez authored
Cleanup qla2x00_eh_wait_on_command() srb_t handling. Signed-off-by:
-
James Bottomley authored
From: Andrew Vasquez <andrew.vasquez@qlogic.com> Use the standard include/scsi/* headers rather than those in drivers/scsi/. Slightly modified variant from initial patch sent by Christoph Hellwig <hch () lst !de>. Signed-off-by:
-
Andrew Vasquez authored
Christoph Hellwig <hch () lst !de>: o Remove TRUE/FALSE #define usage within the driver. Signed-off-by:
-
Andrew Vasquez authored
Add firmware dump support for ISPs with memory chips larger than 128KB (512/1024KB). Signed-off-by:
-
Andrew Vasquez authored
Small fixes: o Remove incorrect and unused ISP2100 #define SS_RESIDUAL_LEN_VALID. o Fix problem where an incorrect status would be returned for qla2x00_configure_fabric() if the driver was unable to log into a fabric's SNS. o Check for the additional WAIT_FOR_AL_PA state in qla2x00_fw_ready() since switch vendors may push NOS/OLS primitives during a 'port disabled' state. Signed-off-by: -
Andrew Vasquez authored
Issue a big-hammer after link-down-timeout expires in order properly return tape commands to the mid-layer. Signed-off-by:
-
Andrew Vasquez authored
Address several outstanding problem within the various eh_*() functions: o Fixup nested spinlock usage in error-hanlding functions. o Set the Loop down timer during abort isp if loop was already down for the driver to detect cable is unplugged at min time. Signed-off-by:
-
Andrew Vasquez authored
Remove several unused failover variables and functions from the embedded driver. Signed-off-by:
-
Andrew Vasquez authored
Fix several tape handling issue: 1) When the firmware receives the LOGO from the device, any active exchanges will be returned with a completion status of 0x29 -- this will cause the port to be marked as lost and request made to the DPC routine to begin a relogin attempt. The problem is, since we've never actually logged out of the device and cannot do so in interrupt context, we must be sure to perform the logout before the qla2x00_fabric_login() in the RELOGIN_NEEDED code. 2) Sets the Get Port Database options to ZERO when issuing the call to qla2x00_get_port_database(). This consolidates actuall login handling in the place it should be, in the previous qla2x00_fabric_login() call rather than depending on any 'hidden' behaviour of the firmware. If a device did a LOGO after the login, then any subsequent exachanges will be returned with an 0x29 completion status and the RELOGIN_NEEDED code will handle the login. 3) Finally, if the master and slave state do not indicate a logged-in state from the Get Port Database call, then one cannot depend on the information returned from the firmware -- the firmware typically wipes out the PCB information for a given loopID when logged out. So, return immediately with a failed status. Signed-off-by:
-
Andrew Vasquez authored
Small initialization fixes: o 'point-to-point preferred, else loop' is not a safe connection mode setting for ISP2200 boards. Use 'loop preferred, else point-to-point.' o Add modules parameter to enable ZIO -- Support mode 5 only. o No point in doing a PRLI (process login) to the SNS port. o Fix problem where the driver would incorrectly skip ports with the same domain and area of the HBA. Signed-off-by:
-
Andrew Vasquez authored
Add permissions to the driver's module_params. Signed-off-by:
-
Andrew Vasquez authored
Problem reported/corrected by Michael Reed [mdr@sgi.com]: We have a 2312 that puts the 8.00.00b12-k qla2xxx driver into an infinite loop with a solid interrupt, 0x8008, hcsr = 0x7430, risc status register 0x40008110, immediately after enabling parity on the board. It looks as though the early out test in qla_isr.c:qla2x00_intr_handler() against stat is broken. HSR_RISC_PAUSED is set. Also, there's a stale mailbox completion flagged (stat&0xff) which will short circuit the default case in the switch if it got that far. Signed-off-by:
-
Andrew Vasquez authored
Restructure qla2x00_start_scsi() so that PCI mappings are done after we've verified command list and request queue resource availability. Signed-off-by:
-
Andrew Vasquez authored
On Tuesday, June 22, 2004 12:07 AM, Arjan van de Ven wrote: > On Tue, 2004-06-22 at 07:49, Andrew Vasquez wrote: > > > diff -Nru a/drivers/scsi/qla2xxx/qla_iocb.c > b/drivers/scsi/qla2xxx/qla_iocb.c > > --- a/drivers/scsi/qla2xxx/qla_iocb.c 2004-06-21 15:36:37 -07:00 > > +++ b/drivers/scsi/qla2xxx/qla_iocb.c 2004-06-21 15:36:37 -07:00 @@ > > -43,7 +43,7 @@ else if (cmd->sc_data_direction == > > DMA_FROM_DEVICE) cflags = CF_READ; else { > > - switch (cmd->data_cmnd[0]) { > > + switch (cmd->cmnd[0]) { > > case WRITE_6: > > case WRITE_10: > > case WRITE_12: > > this sounds wrong. > Yes, it is _wrong_! This code is baggage left behind from earlier drivers when we were 'asked' to work around certain applications' inability to properly construct commands. > Is there any reason qlogic drivers can't use/trust the midlayer > instead of doing qla2x00_get_cmd_direction() to reverse engineer to > direction ?? Sure. Especially considering an earlier thread: http://marc.theaimsgroup.com/?t=108727983000002&r=1&w=2Signed-off-by: -
Andrew Vasquez authored
Problem reported/corrected by Tony Battersby [tonyb@cybernetics.com]: o The qla2xxx driver calculates data transfer residuals for some but not all circumstances. The patch below adds data transfer residual calculations for the remaining cases. o Interrogate the proper cmnd[] array when determining the transfer direction. Signed-off-by: -
Andrew Vasquez authored
Add memory barriers to ensure that all load operations have completed before the (MMIO) write to the ISP's registers. Signed-off-by:
-
- 21 Jun, 2004 9 commits
-
-
Guennadi Liakhovetski authored
While reviewing tmscsim, I noticed something, I didn't quite like / understand. The driver takes the host_lock (with irqsave) at the entry to the ISR, and releases it at the exit. And inside the ISR there are potentially long busy-waits... Like int ctr = 6000000; /* only try for about a second */ while( --ctr && !((dstate = DC390_read8 (DMA_Status)) & DMA_XFER_DONE) && pSRB->SGToBeXferLen ); The attached patch is attempting to fix those places. Not sure if this is a proper fix though. In my understanding, after looking through the code, the host_lock is used to protect host-specific data and host-registers. The ->queuecommand is already called with it help, so, one just, basically, have to protect other contexts - interrupt, timer,... So, looks mostly right. Signed-off-by: -
Guennadi Liakhovetski authored
On Sun, 23 May 2004, Christoph Hellwig wrote: > these leaks. Maybe also merge dc390_init and dc390_init_one? > > Similarly I think DC390_release should be merged into dc390_remove_one. Attached. Also fixed some __init / __devinit and __exit / __devexit attributes. Although, would be good to have something like #ifdef CONFIG_HOTPLUG_PCI #define __pcidevinit #define __pcidevinitdata #define __pcidevexit #define __pcidevexitdata #else #define __pcidevinit __init #define __pcidevinitdata __initdata #define __pcidevexit __exit #define __pcidevexitdata __exitdata #endif Signed-off-by: -
Mark Haverkamp authored
Allows 32 bit apps to use ioctls in a 64 bit kernel. Signed-off-by Mark Haverkamp <markh@osdl.org> Signed-off-by: -
Christoph Hellwig authored
+ minor cleanups Signed-off-by: -
Christoph Hellwig authored
Signed-off-by: -
Christoph Hellwig authored
Signed-off-by: -
Christoph Hellwig authored
avoid obsolete APIs Signed-off-by: -
Christoph Hellwig authored
Avoid old APIs and fix a bad bug were the irq handler argument was derefenced as struct Scsi_Host * instead of Adpater * which made the driver instantly crash on SMP. Signed-off-by: -
Christoph Hellwig authored
replace obsolete typedefs and scsi_to_pci_dma_dir, use proper includes and re-order includes correctly. Signed-off-by:
-
- 20 Jun, 2004 2 commits
-
-
James Bottomley authored
From: Joel Soete <soete.joel@tiscali.be> This patch makes the ncr driver capable of accepting segments which are larger than the block size. It has been tested against IOMMU merging on parisc. Signed-off-by: -
James Bottomley authored
From: Matthew Wilcox <willy@debian.org> - remove all of the PCI chips (8xx series) leaving only 720 - pull out stand alone initialisation code (driver becomes a chip only driver for NCR Q720 and Zalon) - remove most vestiges of PCI support (chip driver should be bus neutral) - tidy up typedefs - remove simulated intfly (may need putting back for 770) Signed-off-by:
-
