- 04 Mar, 2010 40 commits
-
-
Jeff Mahoney authored
rt2860 uses skb->tail directly. This patch uses the tail pointer macros instead. Signed-off-by:
Jeff Mahoney <jeffm@suse.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Minchan Kim authored
If create_device is failed, it can't free gendisk and request_queue of preceding devices. It cause memory leak. This patch fixes it. Signed-off-by:
Minchan Kim <minchan.kim@gmail.com> Acked-by:
Nitin Gupta <ngupta@vflare.org> Signed-off-by:
-
Németh Márton authored
The id_table field of the struct i2c_driver is constant in <linux/i2c.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by:
Németh Márton <nm127@freemail.hu> Cc: Julia Lawall <julia@diku.dk> Cc: cocci@diku.dk Signed-off-by:
-
Németh Márton authored
The id_table field of the struct usb_device_id is constant in <linux/usb.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by:
-
Németh Márton authored
The id_table field of the struct pci_driver is constant in <linux/pci.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by:
-
Jonathan Cameron authored
A second smatch detected error. First part fixes in a typo in the comment directly above that I noticed whilst trying to remember what this code actually does. Second part is the actual fix. I'm fairly amazed this one never caused trouble in testing as it is in one of the most common paths. Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Jonathan Cameron authored
This error was picked up by running the smatch static checker over all the IIO subsytem. Signed-off-by:
-
Simon Horman authored
Increment the pointer rather than its value. These appear to be logic errors. Thanks to Dan Carpenter for the first hunk of this change. Cc: Dan Carpenter <error27@gmail.com> Signed-off-by:
Simon Horman <horms@verge.net.au> Signed-off-by:
-
horms@vergenet.net authored
tcp_seq is only initialised in case where ZM_ENABLE_PERFORMANCE_EVALUATION is defined. So move the call to ZM_SEQ_DEBUG() and the decleration of tcp_seq in there too. This allows ZM_SEQ_DEBUG() to be removed from the non-ZM_ENABLE_PERFORMANCE_EVALUATION case in the header file. This resolves several compile warnings for the non-ZM_ENABLE_PERFORMANCE_EVALUATION case. However, the ZM_ENABLE_PERFORMANCE_EVALUATION case seems to be completely broken. $ gcc (Debian 4.4.2-8) 4.4.2 Copyright (C) 2009 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ make ... drivers/staging/otus/80211core/cagg.c: In function 'zfAggRxEnabled': drivers/staging/otus/80211core/cagg.c:1872: warning: left-hand operand of comma expression has no effect drivers/staging/otus/80211core/cagg.c:1872: warning: left-hand operand of comma expression has no effect drivers/staging/otus/80211core/cagg.c:1872: warning: statement with no effect ... Signed-off-by:
-
horms@vergenet.net authored
Signed-off-by:
-
horms@vergenet.net authored
Signed-off-by:
-
horms@vergenet.net authored
$ gcc (Debian 4.4.2-8) 4.4.2 Copyright (C) 2009 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ make ... drivers/staging/otus/ioctl.c: In function 'usbdrv_wpa_ioctl': drivers/staging/otus/ioctl.c:2253: warning: ISO C90 forbids mixed declarations and code ... Signed-off-by:
-
Jarod Wilson authored
We don't actually need most of the register defines to build, and most of the ones we don't need aren't currently interesting. We'll leave a full copy of all of them in libcrystalhd's source, and only include what we need and/or think might be interesting in the driver. Signed-off-by:
Jarod Wilson <jarod@redhat.com> Signed-off-by:
-
Jarod Wilson authored
I somehow managed to not actually include these two fixes in the submission that was committed to the staging tree. libcrystalhd should eventually be built against the kernel-provided header, and needs the stdint.h include. The VOID bit is to keep things in sync with the Mac OS X driver and library that Scott Davilla is also working on. Signed-off-by:
Scott Davilla <davilla@4pi.com> Signed-off-by:
-
Peter Huewe authored
Without WEXT_PRIV set the p80211wext.c fails to build due to unknown fields in the iw_handler_def struct. Those fields are enclosed in WEXT_PRIV conditionals in the prototype of iw_handler_def in include/net/iw_handler.h Signed-off-by:
Peter Huewe <peterhuewe@gmx.de> Acked-by:
-
Peter Huewe authored
Without WEXT_PRIV set the driver fails to build due to unknown fields in the iw_handler_def struct. Those fields are enclosed in WEXT_PRIV conditionals in the prototype of iw_handler_def in include/net/iw_handler.h Signed-off-by:
-
Peter Huewe authored
Without WEXT_PRIV set the driver fails to build due to unknown fields in the iw_handler_def struct. Those fields are enclosed in WEXT_PRIV conditionals in the prototype of iw_handler_def in include/net/iw_handler.h Signed-off-by:
-
Peter Huewe authored
This patch adds a NULL test to check wether kmalloc was successful or not. Signed-off-by:
-
Alexander Beregalov authored
Assign dev only if fh is not NULL. Signed-off-by:
Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by:
-
Roel Kluin authored
`!' has a higher precedence than `&' so parentheses are required. Signed-off-by:
Roel Kluin <roel.kluin@gmail.com> Signed-off-by:
-
Andrew Lunn authored
The module now only compiles inside mainline, so remove the comments about different versions of the kernel it can be used with. Also update comments about building with debug enabled and how to use the VIS data now that it no longer natively outputs dot or JSON. Signed-off-by:
Andrew Lunn <andrew@lunn.ch> Signed-off-by:
-
Evgeniy Polyakov authored
Since pohmelfs isn't tied to a single block device, it needs to setup a backing dev like nfs/btrfs/etc do. Signed-off-by:
Jens Axboe <axboe@kernel.dk> Signed-off-by:
Evgeniy Polyakov <zbr@ioremap.net> Cc: stable <stable@kernel.org> Signed-off-by:
-
Dan Carpenter authored
err_out_put is for when the netfs_trans_alloc() succeeded. Signed-off-by:
Dan Carpenter <error27@gmail.com> Acked-by:
-
Joe Perches authored
Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Alan Cox authored
SEP doesn't need lock_kernel. Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Roel Kluin authored
This always evaluates to true. Signed-off-by:
-
Benjamin Adolphi authored
This fixes all coding style issues and some spelling mistakes. Signed-off-by:
Benjamin Adolphi <b.adolphi@gmail.com> Signed-off-by:
-
Dan Carpenter authored
There was a buffer overflow in the original code. rf_path was 2 and it should have been only 0 or 1. I don't have the hardware for this, so I can't test it. Looking at the code, there are two almost identical sections for updating the hal variables. The first one was clearly wrong and had the array overflow as well. The second one looked correct. I decided to use the second section as is except for whitespace changes. The differences between the two original sections: 1) The second one had more debug output. 2) The second one looped over rf_path instead of corrupting data. 3) The second one had these additional assigments. if (rf_path == 0) { priv->TxPowerLevelOFDM24G[i] = priv->RfTxPwrLevelOfdm1T[rf_path][i] ; priv->TxPowerLevelCCK[i] = priv->RfTxPwrLevelCck[rf_path][i]; } Signed-off-by: -
H Hartley Sweeten authored
Trivial, use the %pM kernel extension to display the MAC address. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by:
-
H Hartley Sweeten authored
Trivial, use the %pM kernel extension to display the MAC address. Signed-off-by:
-
H Hartley Sweeten authored
Trivial, use the %pM kernel extension to display the MAC address. Signed-off-by:
-
H Hartley Sweeten authored
Trivial, use the %pM kernel extension to display the MAC address. Signed-off-by:
-
Dan Carpenter authored
A 33 char ESSID is too long and it could cause a buffer overflow a couple lines below when we put a NULL terminator on the end. Signed-off-by:
-
Dan Carpenter authored
The INPUT(n) macro indexes an array of size 2. Signed-off-by:
-
Dan Carpenter authored
medusa_set_videostandard() takes the lock but it always drops it before returning. This was found with a static checker and compile tested only. :/ Signed-off-by:
-
Dan Carpenter authored
The check for dio_num_asics is used to determine if there is more than 1 irq. If it is false then irq[1] is past the end of the array. Signed-off-by:
-
Dan Carpenter authored
Changed > to >= to avoid array overflow. Signed-off-by:
-
C yp authored
Also removed an extra semicolon. Signed-off-by:
Cyp <cyp561@gmail.com> Cc: Nitin Gupta <ngupta@vflare.org> Signed-off-by:
-
Simon Horman authored
Remove compatibility code as this is not an older version of the kernel. Signed-off-by:
-
