- 10 Sep, 2009 40 commits
-
-
Avi Kivity authored
We're in arch/x86, what could we possibly be emulating? Signed-off-by:Avi Kivity <avi@redhat.com>
-
Anthony Liguori authored
According to 16.2.5 in the SDM, eflags.vm in the tss is consulted before loading and new segments. If eflags.vm == 1, then the segments are treated as 16-bit segments. The LDTR and TR are not normally available in vm86 mode so if they happen to somehow get loaded, they need to be treated as 32-bit segments. This fixes an invalid vmentry failure in a custom OS that was happening after a task switch into vm8086 mode. Since the segments were being mistakenly treated as 32-bit, we loaded garbage state. Signed-off-by:
Anthony Liguori <aliguori@us.ibm.com> Signed-off-by:
-
Avi Kivity authored
We set rflags.vm86 when virtualizing real mode to do through vm8086 mode; so we need to take it out again when reading rflags. Signed-off-by: -
Avi Kivity authored
The symbol only controls irq routing, not MSI-X. Signed-off-by: -
Avi Kivity authored
It is no longer possible to reproduce the problem any more, so presumably it has been fixed. Signed-off-by: -
Gleb Natapov authored
Since on vcpu entry we do it only if apic is enabled we should do it when TPR is changed while apic is disabled. This happens when windows resets HW without setting TPR to zero. Signed-off-by:
Gleb Natapov <gleb@redhat.com> Signed-off-by:
-
Joerg Roedel authored
Nested SVM is (in my experience) stable enough to be enabled by default. So omit the requirement to pass a module parameter. Signed-off-by:
Joerg Roedel <joerg.roedel@amd.com> Signed-off-by:
-
Joerg Roedel authored
Not checking for this flag breaks any nested hypervisor that does not set VINTR. So fix it with this patch. Signed-off-by:
-
Joerg Roedel authored
This patch removes one indentation level from nested_svm_intr and makes the logic more readable. Signed-off-by:
-
Joerg Roedel authored
This check is not necessary. We have to sync the vcpu->arch.cr2 always back to the VMCB. This patch remove the is_nested check. Signed-off-by:
-
Joerg Roedel authored
This patch moves the handling for special nested vmexits like #pf to a separate function. This makes the kvm_override parameter obsolete and makes the code more readable. Signed-off-by:
-
Joerg Roedel authored
If nested svm fails to load the msrpm the vmrun succeeds with the old msrpm which is not correct. This patch changes the logic to roll back to host mode in case the msrpm cannot be loaded. Signed-off-by:
-
Joerg Roedel authored
This function is not longer required. So remove it. Signed-off-by:
-
Joerg Roedel authored
This patch removes the usage of nested_svm_do from the vmrun emulation path. Signed-off-by:
-
Joerg Roedel authored
This patch removes the usage of nested_svm_do from the vmload and vmsave emulation code paths. Signed-off-by:
-
Joerg Roedel authored
This patch changes nested svm to call nested_svm_exit_handled_msr directly and not through nested_svm_do. [alex: fix oops due to nested kmap_atomics] Signed-off-by:
Alexander Graf <agraf@suse.de> Signed-off-by:
-
Joerg Roedel authored
This patch is the starting point of removing nested_svm_do from the nested svm code. The nested_svm_do function basically maps two guest physical pages to host virtual addresses and calls a passed function on it. This function pointer code flow is hard to read and not the best technical solution here. As a side effect this patch indroduces the nested_svm_[un]map helper functions. Signed-off-by:
-
Joerg Roedel authored
Makes the code of this function more readable by removing on indentation level for the core logic. Signed-off-by:
-
Joerg Roedel authored
If this function returns true a nested vmexit is required. Move that vmexit into the nested_svm_exit_handled function. This also simplifies the handling of nested #pf intercepts in this function. Signed-off-by:
-
Joerg Roedel authored
When caching guest intercepts there is no need anymore for the nested_svm_exit_handled_real function. So move its code into nested_svm_exit_handled. Signed-off-by:
-
Joerg Roedel authored
When the nested intercepts are cached we don't need to call get_user_pages and/or map the nested vmcb on every nested #vmexit to check who will handle the intercept. Further this patch aligns the emulated svm behavior better to real hardware. Signed-off-by:
-
Joerg Roedel authored
This makes it more clear for which purpose these members in the vcpu_svm exist. Signed-off-by:
-
Joerg Roedel authored
The interrupt completion code must run after nested exits are handled because not injected interrupts or exceptions may be handled by the l1 guest first. Signed-off-by:
-
Joerg Roedel authored
The vmcb control area contains more then 800 bytes of reserved fields which are unnecessarily copied. Fix this by introducing a copy function which only copies the relevant part and saves time. Signed-off-by:
-
Joerg Roedel authored
Only copy the necessary parts of the vmcb save area on vmrun and save precious time. Signed-off-by:
-
Joerg Roedel authored
It is more efficient to copy only the relevant parts of the vmcb back to the nested vmcb when we emulate an vmexit. Signed-off-by:
-
Joerg Roedel authored
This patch makes the code easier to read when it comes to setting, clearing and checking the status of the virtualized global interrupt flag for the VCPU. Signed-off-by:
-
Avi Kivity authored
Needed by KVM. Signed-off-by: -
Gleb Natapov authored
They are not doing anything else now. Signed-off-by:
-
Gleb Natapov authored
Currently they are called when irq vector is been delivered. Calling ack notifiers at this point is wrong. Device assignment ack notifier enables host interrupts, but guest not yet had a chance to clear interrupt condition in a device. Signed-off-by:
-
Gleb Natapov authored
d5ecfdd25 moved it out because back than it was impossible to call it inside spinlock. This restriction no longer exists. Signed-off-by:
-
Roel Kluin authored
Check whether index is within bounds before grabbing the element. Signed-off-by:
Roel Kluin <roel.kluin@gmail.com> Cc: Avi Kivity <avi@redhat.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
Amit Shah authored
We ignore writes to the perfctr msrs. Ignore reads as well. Kaspersky antivirus crashes Windows guests if it can't read these MSRs. Signed-off-by:
Amit Shah <amit.shah@redhat.com> Signed-off-by:
-
Avi Kivity authored
Instead of calling vmx_get_segment() (which reads a whole bunch of vmcs fields), read only the cs selector which contains the cpl. Signed-off-by: -
Jan Kiszka authored
So far unprivileged guest callers running in ring 3 can issue, e.g., MMU hypercalls. Normally, such callers cannot provide any hand-crafted MMU command structure as it has to be passed by its physical address, but they can still crash the guest kernel by passing random addresses. To close the hole, this patch considers hypercalls valid only if issued from guest ring 0. This may still be relaxed on a per-hypercall base in the future once required. Cc: stable@kernel.org Signed-off-by:
Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by:
-
Marcelo Tosatti authored
Remove the bogus n_free_mmu_pages assignment from alloc_mmu_pages. It breaks accounting of mmu pages, since n_free_mmu_pages is modified but the real number of pages remains the same. Cc: stable@kernel.org Signed-off-by:
Marcelo Tosatti <mtosatti@redhat.com> Signed-off-by:
-
Izik Eidus authored
First check if the list is empty before attempting to look at list entries. Cc: stable@kernel.org Signed-off-by:
Izik Eidus <ieidus@redhat.com> Signed-off-by:
-
Bartlomiej Zolnierkiewicz authored
This takes care of the following entries from Dan's list: arch/x86/kvm/i8254.c +714 kvm_inject_pit_timer_irqs(6) warning: variable derefenced in initializer 'vcpu' arch/x86/kvm/i8254.c +714 kvm_inject_pit_timer_irqs(6) warning: variable derefenced before check 'vcpu' Reported-by:
Dan Carpenter <error27@gmail.com> Cc: corbet@lwn.net Cc: eteo@redhat.com Cc: Julia Lawall <julia@diku.dk> Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Acked-by:
Sheng Yang <sheng@linux.intel.com> Signed-off-by:
-
Joerg Roedel authored
If userspace knows that the kernel part supports 1GB pages it can enable the corresponding cpuid bit so that guests actually use GB pages. Signed-off-by:
-
Joerg Roedel authored
Signed-off-by:
-
