- 23 Feb, 2020 4 commits
-
-
Gustavo A. R. Silva authored
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by:Gustavo A. R. Silva <gustavo@embeddedor.com> Link: https://lore.kernel.org/r/20200220132908.GA30501@embeddedorSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Kaaira Gupta authored
fix all checkpatch.pl warnings of 'braces {} should be used on all arms of this statement' in the file qlge_ethtool.c by adding the braces. Acked-by:Kaaira Gupta <kgupta@es.iitr.ac.in> Link: https://lore.kernel.org/r/20200221202904.GA19627@kaaira-HP-Pavilion-NotebookSigned-off-by:
-
Kaaira Gupta authored
exfat_fat_sync() is not called anywhere, hence remove it from exfat_cache.c and exfat.h Acked-by:
Valdis Kletnieks <valdis.kletnieks@vt.edu> Signed-off-by:
-
Tetsuhiro Kohada authored
Remove symlink feature completely. Becouse -Uses reserved areas(defined in the Microsoft exfat specification), causing future incompatibilities. -Not described in Microsoft exfat specifications or SD standards. -For REMOVABLE media, causes incompatibility with other implementations. -Not supported by other major exfat drivers. -Not implemented symlink feature in linux FAT/VFAT. Remove this feature completely because of serious media compatibility issues. (Can't enable even with CONFIG) If you have any questions about this patch, please let me know. Reviewed-by:
Takahiro Mori <Mori.Takahiro@ab.MitsubishiElectric.co.jp> Acked-by:
Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> Link: https://lore.kernel.org/r/20200219055727.12867-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jpSigned-off-by:
-
- 17 Feb, 2020 3 commits
-
-
Sandesh Kenjana Ashok authored
Issue found by checkpatch. Signed-off-by:
Sandesh Kenjana Ashok <sandeshkenjanaashok@gmail.com> Link: https://lore.kernel.org/r/20200214232143.GA20675@SandeshPCSigned-off-by:
-
Tetsuhiro Kohada authored
count_entries() function is only used to count sub-dirs. Clarify the role and rename to count_dir_entries(). Signed-off-by:
-
Tetsuhiro Kohada authored
remove 'dos_name','short_name' and related definitions. 'dos_name' and 'short_name' are definitions before VFAT. These are never used in exFAT. Signed-off-by:
-
- 14 Feb, 2020 9 commits
-
-
Ajay Singh authored
Define macros for global as well as SPI/SDIO specific register to avoid use of magic numbers. Signed-off-by:
Ajay Singh <ajay.kathat@microchip.com> Link: https://lore.kernel.org/r/20200214172250.13026-9-ajay.kathat@microchip.comSigned-off-by:
-
Ajay Singh authored
Make use of a shorter name for 'hif' variable to avoid possible 80 character checkpatch warning while the replacing hardcoded value with macros in chip_wakeup(). Signed-off-by:
-
Ajay Singh authored
Instead of using hardcoded value for SDIO register address added the macro for them. Signed-off-by:
-
Ajay Singh authored
Use common function wilc_sdio_set_block_size() to set the block size for SDIO. Signed-off-by:
-
Ajay Singh authored
Make use of 'ALIGN' macro to align the size data value. Signed-off-by:
-
Ajay Singh authored
Make use of FIELD_PREP/FIELD_GET macro to refactor the interrupt handling for SDIO. Signed-off-by:
-
Ajay Singh authored
Make use of MAX_NUM_INT existing macro to handle the maximum supported interrupts count and removed MAX_NUN_INT_THRPT_ENH2 macro. Signed-off-by:
-
Ajay Singh authored
Simplified the code by making use of FIELD_GET/_PREP bitfield macro. Signed-off-by:
-
Lukasz Szczesny authored
This patch fixes spacing issues reported by checkpatch. Signed-off-by:
Lukasz Szczesny <luk@wybcz.pl> Link: https://lore.kernel.org/r/20200212230834.GA294323@localhostSigned-off-by:
-
- 13 Feb, 2020 1 commit
-
-
Marcelo Diop-Gonzalez authored
If kref_get_unless_zero() fails, we should keep looking for the next service, since the callers of this function expect that a NULL return value means there are no more. Signed-off-by:
Marcelo Diop-Gonzalez <marcgonzalez@google.com> Link: https://lore.kernel.org/r/20200213194001.130110-1-marcgonzalez@google.comSigned-off-by:
-
- 12 Feb, 2020 14 commits
-
-
Chris Packham authored
This reverts commit 075a1e87. Now that the build issues have been fixed we can resume build testing. Signed-off-by:
Chris Packham <chris.packham@alliedtelesis.co.nz> Link: https://lore.kernel.org/r/20200205001116.14096-7-chris.packham@alliedtelesis.co.nzSigned-off-by:
-
Chris Packham authored
Remove the typedef and update usage to use the union. Signed-off-by:
-
Chris Packham authored
Remove declaration of union cvmx_helper_link_info as typedef and update uses to use the union. Signed-off-by:
-
Chris Packham authored
Remove typedef declaration from struct cvmx_wqe and replace its previous uses with new struct declaration. Signed-off-by:
-
Chris Packham authored
This reverts commit 710d7fbe. Re-instate the code so subsequent commits can clean it up and get it building properly. Signed-off-by:
-
Chris Packham authored
This reverts commit 95ace52e. Re-instate the code so subsequent commits can clean it up and get it building properly. Signed-off-by:
-
Greg Kroah-Hartman authored
It's been over 6 months, and no one has noticed that these drivers are deleted, probably because no one actually has this hardware. As no one has volunteered to maintain the code, let's drop it for good. Link: https://lore.kernel.org/r/20200210231417.GA1736729@kroah.comSigned-off-by:
-
Ajay Singh authored
Refactor handling of P2P specific action frames. Make use of 'struct' to handle the P2P frames instead of manipulating using 'buf' pointer. Signed-off-by:
-
Marcelo Diop-Gonzalez authored
There are a few places where a service's reference count is incremented, something quick is done, and the refcount is dropped. This can be made a little simpler/faster by not grabbing a reference in these cases. Signed-off-by:
-
Marcelo Diop-Gonzalez authored
Currently reference counts are implemented by locking service_spinlock and then incrementing the service's ->ref_count field, calling kfree() when the last reference has been dropped. But at the same time, there's code in multiple places that dereferences pointers to services without having a reference, so there could be a race there. It should be possible to avoid taking any lock in unlock_service() or service_release() because we are setting a single array element to NULL, and on service creation, a mutex is locked before looking for a NULL spot to put the new service in. Using a struct kref and RCU-delaying the freeing of services fixes this race condition while still making it possible to skip grabbing a reference in many places. Also it avoids the need to acquire a single spinlock when e.g. taking a reference on state->services[i] when somebody else is in the middle of taking a reference on state->services[j]. Signed-off-by:
-
Kaaira Gupta authored
Fix three checkpatch.pl warnings of 'quoted string split across lines' in gasket_core.c by merging the strings in one line. Though some strings are over 80 characters long, fixing this warning is necessary to ease grep-ing the source for printk. Signed-off-by:
-
Marcelo Diop-Gonzalez authored
This fixes some checkpatch warnings about incorrect indentation levels Signed-off-by:
-
Marcelo Diop-Gonzalez authored
there are extra parentheses around many conditional statements that make things a little harder to read Signed-off-by:
-
Marcelo Diop-Gonzalez authored
vchiq_get_service_fourcc() doesn't seem to be used anywhere Signed-off-by:
-
- 11 Feb, 2020 9 commits
-
-
Gustavo A. R. Silva authored
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertenly introduced[3] to the codebase from now on. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: -
Gustavo A. R. Silva authored
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertenly introduced[3] to the codebase from now on. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: -
Pragat Pandya authored
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "AccessTimestamp" to "access_timestamp" Signed-off-by:
Pragat Pandya <pragat.pandya@gmail.com> Link: https://lore.kernel.org/r/20200210183558.11836-20-pragat.pandya@gmail.comSigned-off-by:
-
Pragat Pandya authored
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "ModifyTimestamp" to "modify_timestamp" Signed-off-by:
-
Pragat Pandya authored
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "CreateTimestamp" to "create_timestamp" Signed-off-by:
-
Pragat Pandya authored
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "NumSubdirs" to "num_subdirs" Signed-off-by:
-
Pragat Pandya authored
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Attr" to "attr" Signed-off-by:
-
Pragat Pandya authored
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "ShortName" to "short_name" Signed-off-by:
-
Pragat Pandya authored
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Name" to "name" Signed-off-by:
-
