- 02 Mar, 2005 7 commits
-
-
Jean Delvare authored
> (4/5) Deprecate i2c_client.id. Now that i2c_client.id has no more users in the kernel (none that I could find at least) we could remove that struct member. I however think that it's better to only deprecate it at the moment, in case I missed users or any of the other patches are delayed for some reason. We could then delete the id member definitely in a month or so. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Jean Delvare authored
(3/5) Stop using i2c_client.id in misc drivers. Affected drivers: * acorn/char/pcf8583 * acorn/char/i2c * i2c/i2c-dev * macintosh/therm_windtunnel * sound/oss/dmasound/dac3550a * sound/ppc/keywest The Acorn pcf8583 driver would give the i2c_client id the same value as the i2c_driver id, and later test that client id (in i2c). I changed it to test the client's driver id instead. The result is the same and the client id is then useless and can be removed. All other drivers here would allocate the client id to some value and then never use it. They are unaffected by the change. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Jean Delvare authored
(2/5) Stop using i2c_client.id in media/video drivers. Affected drivers: * adv7170 * adv7175 * bt819 * bt856 * bttv * cx88 * ovcamchip * saa5246a * saa5249 * saa7110 * saa7111 * saa7114 * saa7134 * saa7185 * tda7432 * tda9840 * tda9875 * tea6415c * tea6420 * tuner-3036 * vpx3220 Most drivers here would include the id as part of their i2c client name (e.g. adv7170[0]). This looks more like an habit than something really needed, so I replaced the various printf by strlcpy, which should be slightly faster. As said earlier, clients can be differenciated thanks to their bus id and address if needed, so I don't think that including this information in the client name is wise anyway. Other drivers would either set the id to -1 or to a unique value but then never use it. These drivers are unaffected by the changes. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Jean Delvare authored
(1/5) Stop using i2c_client.id in i2c/chips drivers (mostly hardware monitoring drivers). Drivers affected: * adm1021 * adm1025 * adm1026 * adm1031 * ds1621 * fscher * gl518sm * isp1301_omap * lm75 * lm77 * lm80 * lm83 * lm85 * lm87 * lm90 * max1619 * pcf8574 * pcf8591 * rtc8564 * smsc47m1 * w83l785ts The vast majority of these drivers simply defined the i2c_client id struct member but never used it, so they are not affected at all by the change. Exceptions are: * lm85 and rtc8564, which would at least display the id in a debug message when assigning it. Not really useful though, as the id was then never used. * adm1026, which used the assigned id in all driver messages. However, since dev_* calls will append the bus number and client address to these messages, the id information is redundant and can go away. Also, the driver would allow some GPIO reprogramming on the first client only (id=0) and removing the id doesn't allow that anymore. I would restore a similar functionality if needed, but the ADM1026 chip is found on very few motherboards and none of these has more than one ADM1026 chip AFAIK, so it doesn't seem to be worth the effort. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Greg Kroah-Hartman authored
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Jean Delvare authored
Quoting myself: > As soon as you will have confirmed that everything worked as expected, > Jonas and I will provide a patch adding a pwm polarity reconfiguration > module parameter for you to test. This should give you access to the > PWM features of your it87 chip again, but in a safe way for a change > ;) Here comes this patch. The new "fix_pwm_polarity" module parameter allows one to force the it87 chip reconfiguration. This is only supported in the case the original PWM configuration is suspected to be bogus, and only if we think that reconfiguring the chip is safe. I wish to thank Rudolf Marek and Jonas Munsin again for their testing and review of my code. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
Stefan Ott authored
This patch against 2.6.11-rc1 contains a driver for fscpos sensors. Signed-off-by: Stefan Ott <stefan@desire.ch> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
-
- 01 Mar, 2005 14 commits
-
-
Linus Torvalds authored
-
Greg Kroah-Hartman authored
You really don't want -2 (which was just a cut-and-paste of the initial value for the parameter) for the file mode in sysfs. Signed-off-by: Greg Kroah-Hartman <greg@kroah.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Chris Wright authored
Send audit repsonse to socket which request came from, rather than pid that request came from. Signed-off-by: Chris Wright <chrisw@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
bk://bk.arm.linux.org.uk/linux-2.6-serialLinus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
bk://bk.arm.linux.org.uk/linux-2.6-rmkLinus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
Greg Kroah-Hartman authored
count is size_t, fill_write_buffer() may return a negative number which would evade the 'count > 0' checks and do bad things. found by the Coverity tool Signed-off-by: Alexander Nyberg <alexn@dsv.su.se> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Dmitry Torokhov authored
Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
takis@lumumba.luc.ac.be authored
Remember to release the PCI regions on an error path. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Chris Wright authored
Audit inode filter drops high bits on inode number by cut 'n paste mistake. Signed-off-by: Chris Wright <chrisw@osdl.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Andrew Morton authored
Avoid a possible null-pointer deref. Found by the Coverity tool Signed-off-by: Alexander Nyberg <alexn@dsv.su.se> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Alexander Nyberg authored
The 'bad' label will call function that unconditionally dereferences the NULL pointer. Found by the Coverity tool Signed-off-by: Alexander Nyberg <alexn@dsv.su.se> Acked-by: James Morris <jmorris@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Alexander Nyberg authored
There's a leak here in the first error path. Found by the Coverity tool. Signed-off-by: Alexander Nyberg <alexn@dsv.su.se> Acked-by: James Morris <jmorris@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Kenji Kaneshige authored
This patch fix the error check in acpi_pci_irq_disable(). Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> Signed-off-by: Tony Luck <tony.luck@intel.com>
-
Andrew Morton authored
With CONFIG_AUDITSYSCALL=n: arch/ia64/kernel/ptrace.c: In function `syscall_trace_enter': arch/ia64/kernel/ptrace.c:1615: warning: implicit declaration of function `audit_syscall_entry' arch/ia64/kernel/ptrace.c: In function `syscall_trace_leave': arch/ia64/kernel/ptrace.c:1631: warning: implicit declaration of function `audit_syscall_exit' And the link fails, due to audit_syscall_entry() not being present. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Tony Luck <tony.luck@intel.com>
-
- 28 Feb, 2005 15 commits
-
-
Ben Dooks authored
Patch from Ben Dooks Remove the currently #if'ed out FTVPCI debug code from arch/arm/kernel/debug.S as FTVPCI has no current build candidate. Signed-off-by: Ben Dooks Signed-off-by: Russell King
-
Ben Dooks authored
Patch from Ben Dooks Add Ben Dooks to the credits file Signed-off-by: Ben Dooks Signed-off-by: Russell King
-
Sascha Hauer authored
Patch from Sascha Hauer This patch provided by Pavel Pisa fixes a wrong bitmask in imx_decode_pll. Sascha Hauer Signed-off-by: Pavel Pisa Signed-off-by: Sascha Hauer Signed-off-by: Russell King
-
Sascha Hauer authored
Patch from Sascha Hauer This patch fixes the handling of the dma interrupt acknowledge register (DISR). A DMA interrupt is acknowledged by setting the corresponding bit in DISR. So we are not allowed to use |= on this register because we could lose interrupts. Sascha Hauer Signed-off-by: Sascha Hauer Signed-off-by: Russell King
-
Alex Williamson authored
Patch from Alex Williamson This patch adds support for detecting and working around a bug in the A2 rev of the Exar ST16C2550 UART. The chip incorrectly advertises an EFR and mis-detects as having the wrong size FIFO. Much of the patch below is Russell's proposed solution to the problem. The only changes I've made are to check the FIFO size on the part (because there is a real part with the same divisor ID and larger FIFO) and save and restore the LCR register around the size_fifo() routine (it doesn't work correctly with a LCR value of 0xBF). Signed-off-by: Alex Williamson Signed-off-by: Russell King
-
Randy Dunlap authored
rrunner: references __initdata in a __devinit function; data should be __devinitdata; Error: ./drivers/net/rrunner.o .text refers to 00000000000002b2 R_X86_64_32S .init.data Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Jes Sorensen <jes@wildopensource.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
hp100: references __init code that should be marked as __devinit; Error: ./drivers/net/hp100.o .text refers to 0000000000000f7f R_X86_64_PC32 .init.text+0x00000000000000b8 Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
dc395x scsi driver makes many references to __init functions & __initdata that should be __devinit & __devinitdata. Error: ./drivers/scsi/dc395x.o .text refers to 00000000000021ef R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 000000000000220e R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000222e R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000022f4 R_X86_64_PC32 .init.text+0x0000000000000177 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002301 R_X86_64_32S .init.data Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002307 R_X86_64_32S .init.data+0x0000000000000004 Error: ./drivers/scsi/dc395x.o .text refers to 000000000000230f R_X86_64_32S .init.data+0x0000000000000008 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002317 R_X86_64_32S .init.data+0x000000000000000c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000231d R_X86_64_32S .init.data Error: ./drivers/scsi/dc395x.o .text refers to 000000000000232d R_X86_64_PC32 .init.text+0xfffffffffffffffc Error: ./drivers/scsi/dc395x.o .text refers to 000000000000237a R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 000000000000238c R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023ac R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023d6 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023e6 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 00000000000023fe R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000240b R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002418 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000242f R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 000000000000243f R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002469 R_X86_64_PC32 .init.text+0x00000000000000b4 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002476 R_X86_64_PC32 .init.text+0x000000000000009c Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002489 R_X86_64_PC32 .init.data+0x0000000000000060 Error: ./drivers/scsi/dc395x.o .text refers to 0000000000002494 R_X86_64_PC32 .init.text+0x0000000000000177 Error: ./drivers/scsi/dc395x.o .text refers to 00000000000024a3 R_X86_64_32S .init.data+0x0000000000000078 Error: ./drivers/scsi/dc395x.o .text refers to 00000000000024ac R_X86_64_PC32 .init.text+0xfffffffffffffffc Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
ICCVersion() is only used by init code & can be marked __init; Error: ./drivers/isdn/hisax/icc.o .text refers to 000000000000014a R_X86_64_32S .init.data Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
sound/oss/opl3sa2: calls __init function during probe, which may be after init for PNP devices; Error: ./sound/oss/opl3sa2.o .text refers to 0000000000000204 R_X86_64_PC32 .init.text+0xfffffffffffffffc Error: ./sound/oss/opl3sa2.o .text refers to 0000000000000210 R_X86_64_PC32 .init.text+0xfffffffffffffffc Error: ./sound/oss/opl3sa2.o .text refers to 000000000000021c R_X86_64_PC32 .init.text+0xfffffffffffffffc Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
sonicvibes: _devinit function was referencing __initdata (2x), which should be __devinitdata; Error: ./sound/oss/sonicvibes.o .text refers to 0000000000003ca7 R_X86_64_32S .init.data+0x0000000000000080 Error: ./sound/oss/sonicvibes.o .text refers to 00000000000043eb R_X86_64_32S .init.data+0x0000000000000024 Error: ./sound/oss/sonicvibes.o .text refers to 00000000000043f2 R_X86_64_32S .init.data+0x0000000000000020 Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Randy Dunlap authored
Exit-only function uninit_aedsp16() was marked __init instead of __exit; ae_config data was marked __initdata but used during exit; several cleanup functions were marked _init but used for init or exit cleanups; Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000004 R_X86_64_PC32 .init.data+0x000000000000003b Error: ./sound/oss/aedsp16.o .exit.text refers to 000000000000000c R_X86_64_PC32 .init.text+0x00000000000001e4 Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000013 R_X86_64_PC32 .init.text+0x0000000000000034 Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000019 R_X86_64_PC32 .init.data+0x000000000000003f Error: ./sound/oss/aedsp16.o .exit.text refers to 0000000000000023 R_X86_64_PC32 .init.text+0x00000000000001b4 Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Jens Axboe authored
Make sure that a bio doesn't contain NULL pages in the front of its vec, if a device bounces a bio that doesn't start from 0. Problem noted by Mark Haverkamp. Signed-off-by: Jens Axboe <axboe@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Andrea Arcangeli authored
The new pipe buffer merging doesn't check for the "no readers" case, so with small writes that coalesce, we may not get a timely SIGPIPE/EPIPE notification to the writer. Signed-off-by: Andrea Arcangeli <andrea@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
Linus Torvalds authored
The pipe code has traditionally not cared about which end-point of the pipe you are polling, meaning that if you poll the write-only end of a pipe, it will still set the "this pipe is readable" bits if there is data to be read on the read side. That makes no sense, and together with the new bigger buffers breaks python-twisted. Based on debugging/patch by Andrea Arcangeli and testcase from Thomas Crhak
-
- 27 Feb, 2005 4 commits
-
-
Randy Dunlap authored
srat's node_to_pxm() references pxm2node[] after init. so pxm2node[] should not be __initdata. Error: ./arch/x86_64/mm/srat.o .text refers to 0000000000000008 R_X86_64_32S .init.data Error: ./arch/x86_64/mm/srat.o .text refers to 0000000000000015 R_X86_64_32S .init.data Signed-off-by: Randy Dunlap <rddunlap@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-
bk://kernel.bkbits.net/davem/net-2.6Linus Torvalds authored
into ppc970.osdl.org:/home/torvalds/v2.6/linux
-
David S. Miller authored
We should report the total bytes in the whole receive queue, not just the first packet, in these cases. Reported by Uwe Bonnes. Signed-off-by: David S. Miller <davem@davemloft.net>
-
David S. Miller authored
Spotted by itkes@fat.imed.msu.ru, the fn_hash_dump_bucket() main loop does not increment 'i' properly, and thus routes will not be listed, when the test 'i < s_i' passes. The bug was added when the code was converted over to hlist_for_each_entry() by your's truly. Signed-off-by: David S. Miller <davem@davemloft.net>
-