1. 26 Sep, 2018 5 commits
  2. 21 Sep, 2018 2 commits
    • Nathan Chancellor's avatar
      scsi: advansys: Remove unnecessary parentheses · 874deb1c
      Nathan Chancellor authored
      Clang warns when multiple pairs of parentheses are used for a single
      conditional statement.
      
      drivers/scsi/advansys.c:6451:20: warning: equality comparison with
      extraneous parentheses [-Wparentheses-equality]
                                      if ((sdtr_data == 0xFF)) {
                                           ~~~~~~~~~~^~~~~~~
      drivers/scsi/advansys.c:6451:20: note: remove extraneous parentheses
      around the comparison to silence this warning
                                      if ((sdtr_data == 0xFF)) {
                                          ~          ^      ~
      drivers/scsi/advansys.c:6451:20: note: use '=' to turn this equality
      comparison into an assignment
                                      if ((sdtr_data == 0xFF)) {
                                                     ^~
                                                     =
      1 warning generated.
      
      Link: https://github.com/ClangBuiltLinux/linux/issues/155Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
      Acked-by: default avatarMatthew Wilcox <willy@infradead.org>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      874deb1c
    • Greg Edwards's avatar
      scsi: target: iblock: split T10 PI SGL across command bios · fed564f6
      Greg Edwards authored
      When T10 PI is enabled on a backing device for the iblock backstore, the PI
      SGL for the entire command is attached to the first bio only.  This works fine
      if the command is covered by a single bio, but can result in ref tag errors in
      the client for the other bios in a multi-bio command, e.g.
      
      [   47.631236] sda: ref tag error at location 2048 (rcvd 0)
      [   47.637658] sda: ref tag error at location 4096 (rcvd 0)
      [   47.644228] sda: ref tag error at location 6144 (rcvd 0)
      
      The command will be split into multiple bios if the number of data SG elements
      exceeds BIO_MAX_PAGES (see iblock_get_bio()).
      
      The bios may later be split again in the block layer on the host after
      iblock_submit_bios(), depending on the queue limits of the backing device.
      The block and SCSI layers will pass through the whole PI SGL down to the LLDD
      however that first bio is split up, but the LLDD may only use the portion that
      corresponds to the data length (depends on the LLDD, tested with scsi_debug).
      
      Split the PI SGL across the bios in the command, so each bio's
      bio_integrity_payload contains the protection information for the data in the
      bio.  Use an sg_mapping_iter to keep track of where we are in PI SGL, so we
      know where to start with the next bio.
      Signed-off-by: default avatarGreg Edwards <gedwards@ddn.com>
      Reviewed-by: default avatarMike Christie <mchristi@redhat.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      fed564f6
  3. 17 Sep, 2018 9 commits
  4. 12 Sep, 2018 24 commits