- 26 Oct, 2019 16 commits
-
-
Jules Irenge authored
Fix check warnings of logical continuations should be on the previous line. Issue detected by checkpatch tool. Signed-off-by:
Jules Irenge <jbi.octave@gmail.com> Link: https://lore.kernel.org/r/20191019140719.2542-4-jbi.octave@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jules Irenge authored
Fix warning of lines over 80 characters. Issue detected by checkpatch tool. Signed-off-by:
-
Jules Irenge authored
Fix warnings of no space is necessary after a cast. Issue detected by checkpatch tool. Signed-off-by:
-
Jérôme Pouiller authored
Original API declares 16 tx_policies. But in fact, the 16th is used internally by the firmware. So, only 15 tx_policies are available for driver. Reported-by:
Alban Jeantheau <alban.jeantheau@silabs.com> Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20191017093954.657-6-Jerome.Pouiller@silabs.comSigned-off-by:
-
Jérôme Pouiller authored
MAC address read from chip is unconditionally used even if a MAC address is configured in device tree. Reported-by:
Marc Dorval <marc.dorval@silabs.com> Signed-off-by:
-
Jérôme Pouiller authored
In most case, of_get_mac_address() return NULL in case of error. However, if CONFIG_OF_NET is not set, it return -ENODEV. Signed-off-by:
-
Jérôme Pouiller authored
If CONFIG_MMC=m and CONFIG_WFX=y, compilation complains with undefined references: drivers/staging/wfx/main.o: In function `wfx_core_init': /linux/drivers/staging/wfx/main.c:488: undefined reference to `sdio_register_driver' drivers/staging/wfx/main.o: In function `wfx_core_exit': /linux/drivers/staging/wfx/main.c:496: undefined reference to `sdio_unregister_driver' drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to `sdio_register_driver' drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to `sdio_unregister_driver' Indeed, symbols sdio_* are not present in kernel image. This patch disallows CONFIG_WFX=y if CONFIG_MMC=m. This solution impacts users who want to use SPI bus with configuration: CONFIG_WFX=y + CONFIG_SPI=y + CONFIG_MMC=m. However, I think this is a twisted case. So, I think it won't be missed. Reported-by:zhong jiang <zhongjiang@huawei.com> Signed-off-by:
-
Jérôme Pouiller authored
"Secure link" feature is not available in in-tree driver (because it depends on mbedtls). Thus, secure_link.h only empty functions. Module parameter "slk_key" and associated function wfx_fill_sl_key() had an unjustifiable place in main.c. This patch relocate them to secure_link.h. BTW, content of wfx_fill_sl_key() is now useless. Just keep a warning if user try to use "slk_key" attribute (unsupported by this driver). Signed-off-by:
-
Jérôme Pouiller authored
wfx_version.h says that this code is same same than driver 2.3.1 hosted on github: https://github.com/siliconlabs/wfx-linux-driver/tree/2.3.1-public However, it is inaccurate, driver in-tree contains multiple small patches ahead 2.3.1. I prefer to drop this confusing information. Signed-off-by: -
Javier F. Arias authored
Change tabs for spaces when they are incorrectly used as separators. Fix suggested by Julia Lawall. Signed-off-by:
Javier F. Arias <jarias.linux@gmail.com> Link: https://lore.kernel.org/r/7b06c103665ab7250dded8c5dadc093228eee7b4.1571284318.git.jarias.linux@gmail.comSigned-off-by:
-
Javier F. Arias authored
Fix function call format by following the coding style guidelines for argument wrapping in function calls. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix indentation warnings to improve the code formatting. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Remove commented code for a cleaner file. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Add spaces between operators for a better readability. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix lines over 80 characters by wrapping arguments in function calls, improving the format for a better code readability. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Replace the hardcoded function names with the corresponding predefined identifiers. Issue found by checkpatch. Signed-off-by:
-
- 25 Oct, 2019 24 commits
-
-
Valdis Kletnieks authored
Add a L: tag so get_maintainers.pl output includes the linux-fsdevel list Signed-off-by:
Valdis Kletnieks <Valdis.Kletnieks@vt.edu> Link: https://lore.kernel.org/r/20191023055353.695275-1-Valdis.Kletnieks@vt.eduSigned-off-by:
-
Ajay Singh authored
During concurrent mode(AP/STA + P2P), pass the mgmt frames received from firmware to appropriate interface. Iterate the complete interface list to pass frames on the interface which has registered to receive mgmt frame. Added extra time for 'remain_on_ch' timer to ensure that timeout for uncanceled remain_on_channel is not triggered & 'p2p_listen_state' is not cleared before passing the mgmt frames to p2p interface. Signed-off-by:
Ajay Singh <ajay.kathat@microchip.com> Link: https://lore.kernel.org/r/20191018124511.22751-1-ajay.kathat@microchip.comSigned-off-by:
-
Dan Carpenter authored
The "rates_len" value needs to be capped so that the memcpy() doesn't copy beyond the end of the array. Fixes: c5c77ba1 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Adham Abozaeid <adham.abozaeid@microchip.com> Link: https://lore.kernel.org/r/20191017091832.GB31278@mwandaSigned-off-by:
-
Adham Abozaeid authored
In a fast disconnect/connect sequence, cfg80211_connect_result() can fail to find the bss object which the driver is connecting to. Detailed sequence of events: * Driver is connected in STA mode * Disconnect request arrives from user space. Driver disconnects and calls cfg80211_disconnected() which adds new event to the cfg80211_wq worker thread * Connect request arrives from user space. cfg80211_connect() stores ssid/ssid_len and calls rdev_connect() * __cfg80211_disconnected() runs in worker thread and zero wdev->ssid_len * Connect succeeds. Driver calls cfg80211_connect_result() which fails to find the bss because wdev->ssid_len is zero To overcome this, upon connect request, store the bss object in the driver and upon connect completion pass it to kernel using cfg80211_connect_bss(). Ref: bcdd49b0 ("store bss object and use cfg80211_connect_bss()") Signed-off-by:
-
Michael Straube authored
Remove code valid only for 5 GHz, according to the TODO. - find and remove remaining code valid only for 5 GHz. Most of the obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20191024155918.13399-1-straube.linux@gmail.comSigned-off-by:
-
Jamal Shareef authored
Fix duplicated arguments to bitwise & operator. Issue detected by coccinelle. Signed-off-by:
Jamal Shareef <jamal.k.shareef@gmail.com> Link: https://lore.kernel.org/r/20191023215105.18049-1-jamal.k.shareef@gmail.comSigned-off-by:
-
CristianeNaves authored
Fix lines ending with a '('. Issue found by checkpatch. Signed-off-by:CristianeNaves <cristianenavescardoso09@gmail.com> Link: https://lore.kernel.org/r/20191024134623.GA4506@cristiane-Inspiron-5420Signed-off-by:
-
Gabriela Bittencourt authored
Cleans up checks of "Alignment should match open parenthesis" in file sm750_cursor.h Signed-off-by:
Gabriela Bittencourt <gabrielabittencourt00@gmail.com> Link: https://lore.kernel.org/r/20191024163822.7157-4-gabrielabittencourt00@gmail.comSigned-off-by:
-
Gabriela Bittencourt authored
Cleans up checks of "Alignment should match open parenthesis" in file sm750_accel.h Signed-off-by:
-
Gabriela Bittencourt authored
Cleans up checks of "Alignment should match open parenthesis" in file ddk750_sii164.c Signed-off-by:
-
Gabriela Bittencourt authored
Formatting comments in file drivers/staging/sm750fb/sm750_accel.h. Signed-off-by:
-
Gabriela Bittencourt authored
Formatting comments in file drivers/staging/sm750fb/sm750_accel.c. Signed-off-by:
-
Jules Irenge authored
Fix warnings of Block comments use * on subsequent lines. Issue detected by checkpatch tool. Signed-off-by:
-
Jules Irenge authored
Fix warnings of space required between operator and variables. Issue detected by checkpatch tool Signed-off-by:
-
Jules Irenge authored
Fix warnings of line over 80 characters. Issue detected by checkepatch tool. Signed-off-by:
-
Evan Chime authored
Change "standred" on line 3 to "standard" Signed-off-by:
Evan Chime <chime.evan.dri.devel@gmail.com> Link: https://lore.kernel.org/r/20191018175759.GA8294@ik-ubuntuSigned-off-by:
-
Evan Chime authored
Change "in to" in "Changing comments in to linux standred format" on line 3 to "into" Signed-off-by:
-
Jules Irenge authored
Fix warnings of comparision to bool. Issue detected by coccinelle tool. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Link: https://lore.kernel.org/r/20191022185328.9387-1-jbi.octave@gmail.comSigned-off-by:
-
Jamal Shareef authored
Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan. The semantic patch that makes this report is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/Signed-off-by:
-
YueHaibing authored
drivers/staging/comedi/drivers/ni_routes.c:52:21: warning: route_table_size defined but not used [-Wunused-const-variable=] It is never used since introduction. Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/20191023075206.33088-1-yuehaibing@huawei.comSigned-off-by:
-
Valdis Kletnieks authored
Convert FFS_MEMORYERR to -ENOMEM Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_INVALIDPATH to -EINVAL Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_FILEEXIST to -EEXIST Signed-off-by:
-
Valdis Kletnieks authored
Convert FFS_NOTNAMETOOLONG to -ENAMETOOLONG Signed-off-by:
-
