- 30 Apr, 2004 31 commits
-
-
Rolf Eike Beer authored
This is a bunch of coding style fixes (wrap long lines, whitspacing etc.) for pciehp_pci.c
-
Rolf Eike Beer authored
This patch does two things: -remove casts of pointers which are void* or already the correct type for the target -if we dereferenced a struct member and copied this to it's own variable use this and don't dereference the member again
-
Rolf Eike Beer authored
Don't know why, but it looks like a good idea to mark this global variables static.
-
Rolf Eike Beer authored
Some coding style fixes and small cleanups for pciehp_core.c: -wrap long lines -kill spaces before opening braces of functions -remove code duplication where both parts of an if statement do exactly the same -kill some useless comments -kill an unneeded initialisation
-
Rolf Eike Beer authored
The result of kmalloc does not need to be casted to any other pointer type. Also use kmalloc(*foo) instead of kmalloc(type_of_foo) and wrap some long lines.
-
Rolf Eike Beer authored
Some small coding style fixes and a typo fix for pciehp.h
-
Rolf Eike Beer authored
This changes pciehp_core.c::init_slots to use goto for error hanling. Also a missing magic missed by previous patches is killed.
-
Rolf Eike Beer authored
Remove useless NULL checks from cpqphp_ctrl.c. Under normal circumstances there is no chance for any of this functions to get called with a NULL argument. If we are in such trouble that we get a NULL pointer don't hide it, just oops.
-
Rolf Eike Beer authored
The hardware_test function of the PCI Express Hotplug driver is empty. It's better to completely kill this to tell the user hardware tests are not supported by this driver.
-
Rolf Eike Beer authored
This patch removes the cast of kmalloc's results to the target pointer type. Also it fixes kmalloc to use sizeof(*foo) instead of sizeof(type_of_foo) as suggested by Matthew Wilcox. Also removes a few useless checks if a pointer is NULL before calling kfree: kfree checks this itself.
-
Rolf Eike Beer authored
Remove useless NULL checks and magic numbers from rpaphp. If one of these ever becomes invalid we are in serious trouble anyway.
-
Rolf Eike Beer authored
Remove useless NULL checks and magic numbers from PCI Express Hotplug, also some minimal coding style fixes.
-
Greg Kroah-Hartman authored
Doesn't anyone build their patches anymore before sending them out...
-
Rolf Eike Beer authored
Fix missing braces. It does not change the code but makes it easier to read.
-
Rolf Eike Beer authored
This converts PCI Express Hotplug to the new style of module parameter handling.
-
Rolf Eike Beer authored
Walking through a pci_resource list and freeing all members is done a lot of times in unload functions. This patch moves this to an inline function in pciehp_core.c, pciehp_pci.c, shpchp_core.c and shpchp_pci.c. This shrinks the code a lot (some 200 lines) and makes it much easier to read. Also adds some __exit.
-
Rolf Eike Beer authored
Convert PCI Hotplug Core to new style of module parameter handling.
-
Rolf Eike Beer authored
Add missing braces around if statement, if not we will try to add devices for an empty slot.
-
Rolf Eike Beer authored
This patch removes the cast of kmalloc's results to the target pointer type. Also it fixes kmalloc to use sizeof(*foo) instead of sizeof(type_of_foo) as suggested by Matthew Wilcox. Also removes a few useless checks if a pointer is NULL before calling kfree: kfree checks this itself.
-
Rolf Eike Beer authored
Final small fixes for cpqphp_core.c: -use better error handling in one_time_init -small coding style fixes -the name of the driver is not "pci_hotplug" -add an __exit for unload_cpqphp -changes enough to increment version, isn't it?
-
Rolf Eike Beer authored
Some coding style fixes I missed last time.
-
Rolf Eike Beer authored
Change cpqphp_ctrl.c to use goto for error handling.
-
Rolf Eike Beer authored
This is not C++! Fix comments from C++ style to C style, removing some useless ones (e.g. no need to tell up and down protect a critical section).
-
Rolf Eike Beer authored
Remove some useless NULL checks in cpqphp_core.c
-
Rolf Eike Beer authored
Convert ctrl_slot_setup to use goto for error handling and fix some minor coding style things.
-
Rolf Eike Beer authored
This puts the LED shifting used as "hardware test" in a function to make cpqhp_hardware_test much smaller and easier to read. Also changes some comments from C++ to C style.
-
Rolf Eike Beer authored
Fix a lot of coding style issues in Compaq PCI hotplug: -spaces before opening brace of functions -much too much C++ style comments -wrap long lines -remove some comments where the code does not really need to be explained Eike
-
Rolf Eike Beer authored
Convert Compaq PCI Hotplug driver to use the new style of module parameters.
-
Rolf Eike Beer authored
set_controller_speed is implemented in cpqphp.h but only used in cpqphp_ctrl.c and it's much too big to be defined in a header file. This patch moves it to cpqphp_ctrl.c. Also the inline attribute is removed, this function is called from 2 places and to big to be an inline.
-
Rolf Eike Beer authored
Remove some useless NULL and magic checks from Compaq PCI Hotplug driver. If one of this pointers is invalid we are in bad trouble anyway.
-
Rolf Eike Beer authored
The usual coding style fixes, this time for cpqphp_ctrl.c and cpqphp.c.
-
- 29 Apr, 2004 9 commits
-
-
Rolf Eike Beer authored
configure_new_function is way too big (>600 lines). Split it in 2 functions, one for the new functions and one for bridges. And split out a small piece from the bridge function which is used twice to it's own function. Patch is huge because of the identation changes but does nothing than the split and some minor coding style changes.
-
Rolf Eike Beer authored
The result of kmalloc does not need to be casted, it is a void * which can be assigned to any pointer variable. Also avoid code duplication in one if statement.
-
Rolf Eike Beer authored
-
Rolf Eike Beer authored
Some final fixes for the skeleton driver: -spaces before opening brace -add a better example for hardware_test function -remove a "int retval" in a void function -some more coding style changes -changed enough stuff: increase version number -fix a typo in a comment
-
Rolf Eike Beer authored
Convert PCI hotplug skeleton driver to use goto for error handling in init_slots to avoid code duplication.
-
Rolf Eike Beer authored
Add __init and __exit to some functions only called from __init/__exit context.
-
Rolf Eike Beer authored
Coding style fixes for pcihp_skeleton.c: remove spaces before opening braces and change a comment in function hardware_test to make clearer that the functions purpose is not to tell the user there are no tests.
-
Rolf Eike Beer authored
This one removes all the useless NULL checks including slot_paranoia_check, get_slot and the magic number from the PCI hotplug skeleton driver. Also some lines containing only a single tab are fixed.
-
Rolf Eike Beer authored
Convert the PCI hotplug skeleton driver to use new style of module parameter handling.
-