An error occurred fetching the project authors.
  1. 15 Aug, 2012 1 commit
  2. 04 Sep, 2011 1 commit
    • Joe Perches's avatar
      [media] bt8xx: Use current logging styles · 8af443e5
      Joe Perches authored
      This converts some messages that were emitted at
      KERN_INFO to KERN_DEBUG.  All of these messages
      were guarded by bttv_debug tests.
      
      Add pr_fmt.
      Convert printks to pr_<level>
      Convert printks without KERN_<level> to appropriate pr_<level>.
      Removed embedded prefixes when pr_fmt was added.
      Whitespace cleanups when around other conversions.
      Macros coded with if statements should be do { if... } while (0)
      so the macros can be used in other if tests.
      Use ##__VA_ARGS__ for variadic macro as well.
      Coalesce format strings.
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      8af443e5
  3. 22 Mar, 2011 1 commit
    • Mauro Carvalho Chehab's avatar
      [media] several drivers: Fix a few gcc 4.6 warnings · 972d724c
      Mauro Carvalho Chehab authored
      au0828-dvb.c:99:6: warning: variable 'ptr' set but not used [-Wunused-but-set-variable]
      au0828-video.c:1180:25: warning: variable 'maxheight' set but not used [-Wunused-but-set-variable]
      au0828-video.c:1180:15: warning: variable 'maxwidth' set but not used [-Wunused-but-set-variable]
      bttv-input.c:196:16: warning: variable 'current_jiffies' set but not used [-Wunused-but-set-variable]
      
      Those variables are not used at all, so just remove them.
      
      Cc: Steven Toth <stoth@hauppauge.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      972d724c
  4. 30 Dec, 2010 1 commit
  5. 29 Dec, 2010 8 commits
  6. 24 Dec, 2010 1 commit
    • Tejun Heo's avatar
      media/video: don't use flush_scheduled_work() · 8c71778c
      Tejun Heo authored
      This patch converts the remaining users of flush_scheduled_work() in
      media/video.
      
      * bttv-input.c and cx23885-input.c don't use workqueue at all.  No
        need to flush.
      
      * Make omap24xxcam.c and saa7134-empress.c flush the used work
        directly.
      
      * In fd_defio.c, replace cancel_delayed_work() +
        flush_scheduled_work() with cancel_delayed_work_sync().  While at
        it, replace the deprecated cancel_rearming_delayed_work() with
        cancel_delayed_work_sync().
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
      8c71778c
  7. 21 Oct, 2010 1 commit
  8. 19 May, 2010 3 commits
  9. 18 May, 2010 1 commit
  10. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  11. 26 Feb, 2010 2 commits
  12. 16 Dec, 2009 2 commits
  13. 05 Dec, 2009 2 commits
  14. 12 Sep, 2009 2 commits
    • Mauro Carvalho Chehab's avatar
      V4L/DVB (12595): common/ir: use a struct for keycode tables · 715a2233
      Mauro Carvalho Chehab authored
      Currently, V4L uses a scancode table whose index is the scancode and
      the value is the keycode. While this works, it has some drawbacks:
      
      1) It requires that the scancode to be at the range 00-7f;
      
      2) keycodes should be masked on 7 bits in order for it to work;
      
      3) due to the 7 bits approach, sometimes it is not possible to replace
      the default keyboard to another one with a different encoding rule;
      
      4) it is different than what is done with dvb-usb approach;
      
      5) it requires a typedef for it to work. This is not a recommended
      Linux CodingStyle.
      
      This patch is part of a larger series of IR changes. It basically
      replaces the IR_KEYTAB_TYPE tables by a structured table:
      struct ir_scancode {
             u16     scancode;
             u32     keycode;
      };
      
      This is very close to what dvb does. So, a further integration with DVB
      code will be easy.
      
      While we've changed the tables, for now, the IR keycode handling is still
      based on the old approach.
      
      The only notable effect is the redution of about 35% of the ir-common
      module size:
      
         text    data     bss     dec     hex filename
         6721   29208       4   35933    8c5d old/ir-common.ko
         5756   18040       4   23800    5cf8 new/ir-common.ko
      
      In thesis, we could be using above u8 for scancode, reducing even more the size
      of the module, but defining it as u16 is more convenient, since, on dvb, each
      scancode has up to 16 bits, and we currently have a few troubles with rc5, as their
      scancodes are defined with more than 8 bits.
      
      This patch itself shouldn't be doing any functional changes.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      715a2233
    • Mauro Carvalho Chehab's avatar
      V4L/DVB (12585): Add remote support to cph03x bttv card · ed44f66e
      Mauro Carvalho Chehab authored
      Hello kernel developers.
      I found a bug report from an user in launchpad. I just copy it here. It
      includes patch.
      
      I don't own the necessary hardware to test it but the patch looks
      trivial.
      
      I'm not subscribed to this list, so please CC me. Thanks!
      
      Here is the text:
      
      """
      remote control for my tv card doesnt work
      
      I have Askey CPH03x TV Capturer.
      When I load bttv module with "card=59" option which is proper for this
      tv card,
      I can watch tv with sound but my remote control doesnt work. There is no
      ir
      event in /proc/bus/input/device .
      When bttv module is loaded with "card=137" option remote control works
      very
      well.
      
      $ cat /proc/bus/input/devices
      .......
      ........
      : Bus=0001 Vendor=109e Product=0350 Version=0001
      N: Name="bttv IR (card=137)"
      P: Phys=pci-0000:00:0d.0/ir0
      S: Sysfs=/devices/pci0000:00/0000:00:0d.0/input/input144
      U: Uniq=
      H: Handlers=kbd event6
      B: EV=100003
      B: KEY=2c0814 100004 0 0 0 4 2008000 2090 2001 1e0000 4400 0 ffc
      
      Unfortunately there is no sound.
      """
      
      https://bugs.launchpad.net/ubuntu/+bug/239733
      http://bugzilla.kernel.org/show_bug.cgi?id=11995
      
      --
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ed44f66e
  15. 12 Oct, 2008 1 commit
  16. 24 Apr, 2008 1 commit
  17. 25 Jan, 2008 1 commit
  18. 10 Oct, 2007 1 commit
  19. 20 Jul, 2007 1 commit
  20. 18 Jul, 2007 1 commit
  21. 21 Feb, 2007 3 commits
  22. 10 Dec, 2006 1 commit
  23. 10 Sep, 2006 1 commit
  24. 25 Jun, 2006 1 commit
  25. 24 Mar, 2006 1 commit