1. 12 Dec, 2003 1 commit
    • Matthew Dharm's avatar
      [PATCH] USB: don't send any MODE SENSE commands to usb mass storage devices · 6a9f4367
      Matthew Dharm authored
      This patch basically eliminates the use of MODE_SENSE or MODE_SENSE_10 for
      direct-access USB storage devices.  That $&%*! command has caused us more
      trouble than all the others combined, and after more than a year we still
      don't have a good way of handling/using them.
      
      I constantly get complaints about devices which don't work because of the
      way 2.5/6 uses MODE_SENSE and MODE_SENSE_10 -- this patch will greatly
      increase compatiblity with devices.  As with the patch to limit transfer
      sizes, I'd like to see this applied as soon as possible.
      
      Matt
      
      > ----- Forwarded message from Patrick Mansfield <patmans@us.ibm.com> -----
      >
      > Date: Thu, 20 Nov 2003 08:28:27 -0800
      > From: Patrick Mansfield <patmans@us.ibm.com>
      > Subject: [PATCH] don't send any MODE SENSE commands to usb mass storage devices
      > To: mdharm-scsi@one-eyed-alien.net
      
      Matthew -
      
      Is this patch in your queue? I don't see it in Linus' tree yet.
      
      Don't send any MODE SENSE commands to usb mass storage devices.
      6a9f4367
  2. 11 Dec, 2003 11 commits
    • Alan Stern's avatar
      [PATCH] USB storage: Unusual_devs.h addition · ee7895f3
      Alan Stern authored
      This patch adds to unusual_devs.h an entry reported by Andries Brouwer and
      it moves another entry to the correct position in the numerical ordering.
      ee7895f3
    • Davide Andrian's avatar
      [PATCH] USB storage: Medion 6047 Digital Camera · e0747c61
      Davide Andrian authored
      ...a patch for the "Medion 6047 Digital Camera"
      
      
      
      *** a/drivers/usb/storage/unusual_devs.h	Sun Nov 23 22:31:51 2003
      e0747c61
    • Martin Berentsen's avatar
      [PATCH] USB storage: Minolta Dimage S414 usb patch · 76f63a39
      Martin Berentsen authored
      here I submitt you the vendor/id patch for the
      Minolta Dimage S414 Camera,
      which runs fine with the usb under linux.
      
      cat /proc/bus/usb/device ->
      76f63a39
    • Alan Stern's avatar
      [PATCH] USB storage: Another unusual_devs.h update · 409f256e
      Alan Stern authored
      On Thu, 20 Nov 2003, Stefan J. Betz wrote:
      
      > Hello People,
      >
      > i have some Mitsumi USB Floppy Drive with the following Data:
      > Manufactur: Mitsumi
      > Typ       : D353FUE
      >
      > When i plug this Device into my Linux Box (Kernel 2.6.0-test9), i get
      > the following messages in my Syslog:
      >
      > Nov 20 22:17:57 mobileone kernel: hub 1-0:1.0: new USB device on port 1, assigned address 2
      > Nov 20 22:17:57 mobileone kernel: usb-storage: This device (03ee,6901,0100 S 04 P 00) has unneeded SubClass and Protocol entries in unusual_devs.h
      > Nov 20 22:17:57 mobileone kernel:    Please send a copy of this message to <linux-usb-devel@lists.sourceforge.net>
      > Nov 20 22:17:57 mobileone kernel: scsi2 : SCSI emulation for USB Mass Storage devices
      > Nov 20 22:17:57 mobileone kernel:   Vendor: MITSUMI   Model: USB FDD           Rev: 1039
      > Nov 20 22:17:57 mobileone kernel:   Type:   Direct-Access                      ANSI SCSI revision: 02
      > Nov 20 22:17:57 mobileone kernel: Attached scsi generic sg2 at scsi2, channel 0, id 0, lun 0,  type 0
      
      > I that is enough information to Support that drive (or how can i use ist
      > today?)
      >
      > Greeting Betz Stefan
      
      Thank you for sending this in.  The usb-storage driver will be updated
      sometime after 2.6.0-final is released.
      
      Alan Stern
      409f256e
    • Alexander Oltu's avatar
      [PATCH] USB storage: patch for unusual_devs.h · 2f937bad
      Alexander Oltu authored
      I send a patch and copy of /proc/bus/usb/devices for my 5`25 external
      USB enclosure. I don't know exactly manufacturer of this device, but
      model is CD-509.
      It will be nice if it helps somebody else.
      
      
      T:  Bus=01 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#=  1 Spd=12  MxCh= 2
      B:  Alloc= 93/900 us (10%), #Int=  1, #Iso=  0
      D:  Ver= 1.00 Cls=09(hub  ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
      P:  Vendor=0000 ProdID=0000 Rev= 0.00
      S:  Product=USB UHCI Root Hub
      S:  SerialNumber=14a0
      C:* #Ifs= 1 Cfg#= 1 Atr=40 MxPwr=  0mA
      I:  If#= 0 Alt= 0 #EPs= 1 Cls=09(hub  ) Sub=00 Prot=00 Driver=hub
      E:  Ad=81(I) Atr=03(Int.) MxPS=   8 Ivl=255ms
      T:  Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  2 Spd=1.5 MxCh= 0
      D:  Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
      P:  Vendor=045e ProdID=0040 Rev= 3.00
      S:  Manufacturer=Microsoft
      S:  Product=Microsoft 3-Button Mouse with IntelliEye(TM)
      C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=100mA
      I:  If#= 0 Alt= 0 #EPs= 1 Cls=03(HID  ) Sub=01 Prot=02 Driver=usbmouse
      E:  Ad=81(I) Atr=03(Int.) MxPS=   4 Ivl=10ms
      T:  Bus=01 Lev=01 Prnt=01 Port=01 Cnt=02 Dev#= 15 Spd=12  MxCh= 0
      D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
      P:  Vendor=05e3 ProdID=0701 Rev= 0.02
      S:  Product=USB TO IDE
      C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr= 96mA
      I:  If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
      E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
      E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
      2f937bad
    • Herbert Xu's avatar
      3942c9a1
    • Alan Stern's avatar
      [PATCH] USB storage: unusual_devs.h entry revision · 969cf19d
      Alan Stern authored
      Here is another update for unusual_devs.h in both 2.6 and 2.4.  No
      urgency.
      
      
      On Wed, 12 Nov 2003, Aris Basic wrote:
      
      > Device Sony Memory Stick Reader MSAC-US1
      > usb-storage: This device (054c,002d,0100 S 04 P 01) has unneeded SubClass and Protocol entries in unusual_devs.h
      >    Please send a copy of this message to <linux-usb-devel@lists.sourceforge.net>
      
      Thanks for sending this in.
      969cf19d
    • Martin Pool's avatar
      [PATCH] USB storage: add unusual storage device entry for Minolta DiMAGE · 59c0e851
      Martin Pool authored
      Yes, it seems to work OK on the 7i with this updated patch.  I don't
      have a 7 or 7Hi to try, but everything on the web seems to say the USB
      firmware works the same way.
      59c0e851
    • Stephane Galles's avatar
      [PATCH] USB storage: patch for Kyocera S5 camera · a3f206d0
      Stephane Galles authored
      I've seen some entries in 2.4.22 and 2.6.0 unusual_devs.h
      for Kyocera Finecam S3 et S4 cameras and I own a Finecam S5
      that does not work out of the box either
      (here is the beast : http://www.yashica.com/digital/finecams5/finecams5.html)
      
      so I found the unusual_devs.h entry and submitted it some month
      ago at http://www.qbik.ch/usb/devices/showdev.php?id=1626
      for the 2.4 kernels
      
      I thought It would be nice to have the whole Finecam family
      in Unusual_devs.h for 2.6.0
      
      The patch for the 2.6.0-test9 is attached with this mail
      
      It differs from the entry I submitted at www.qbik.ch
      as I used the new SC/PR_DEVICE flags and got rid of the
      IGNORE_SER flag from 2.4
      
      Do you want a patch for 2.4 too ? If so, I should test my
      old 2.4 entry with the lastest 2.4 Kernels, coz on a daily
      basis I use a 2.4.20, which is rather old. Moreover, I could
      used the SC/PR_DEVICE flags too for 2.4.22 (keeping the IGNORE_SER flag
      though)
      
      
      By the way, several entries with the running patch :
      
      /proc/bus/usb/devices :
      
      T:  Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
      D:  Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
      P:  Vendor=0482 ProdID=0103 Rev= 1.00
      C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=  2mA
      I:  If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
      E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
      E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
      I:  If#= 0 Alt= 1 #EPs= 3 Cls=ff(vend.) Sub=06 Prot=50 Driver=usb-storage
      E:  Ad=81(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
      E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
      E:  Ad=83(I) Atr=03(Int.) MxPS=   8 Ivl=32ms
      a3f206d0
    • Fabrizio Fellini's avatar
      cb2d6827
    • Per Winkvist's avatar
      [PATCH] USB storage: Make Pentax Optio S4 work · 24a5b266
      Per Winkvist authored
      The change below is needed to get the S4 camera working.
      Tested with both Optio S/S4
      24a5b266
  3. 09 Dec, 2003 14 commits
  4. 08 Dec, 2003 8 commits
    • Alan Stern's avatar
      [PATCH] USB storage: Change sddr09 to use the new s-g access routine · b3fa3588
      Alan Stern authored
      This patch updates the sddr09 driver to use the new scatter-gather access
      routine.  After installing it, the user who experienced memory access
      violations says everything is now working properly.
      b3fa3588
    • Alan Stern's avatar
      [PATCH] USB storage: Fix scatter-gather buffer access in usb-storage core · f3badfb7
      Alan Stern authored
      This patch adds a routine to protocol.c that correctly transfers data to
      or from a scatter-gather buffer.  According to Jens Axboe, we've been
      using page_address() incorrectly -- it's necessary to use kmap() instead
      -- and in fact it doesn't give the desired result when the buffers are
      located in high memory.  This could affect anyone using a system with 1 GB
      or more of RAM, and one user has already reported such a problem (as you
      know).
      
      The three fixup routines in protocol.c and usb.c have been changed to use
      the new s-g access routine.  When similar adjustments have been made to
      all the subdrivers, we will be able to eliminate the raw_bulk.c source
      file entirely.
      f3badfb7
    • Alan Stern's avatar
      [PATCH] USB storage: Remove dead code from debug.c · 7ab39894
      Alan Stern authored
      This patch removes an uncalled subroutine from debug.c.  I only noticed it
      when tracking down scatter-gather usage; there didn't seem to be any
      reason to repair it since it wasn't being used anywhere.
      7ab39894
    • Alan Stern's avatar
      [PATCH] USB storage: Enhance sddr09 to work with 64 MB SmartMedia cards · 8d93f69f
      Alan Stern authored
      This patch was written by Andries Brouwer.  It adds to sddr09 the ability
      to use 64 MB SmartMedia cards.  I have added a few minor alterations to
      make it fit in with my sequence of other patches.
      8d93f69f
    • Alan Stern's avatar
      [PATCH] USB storage: Remove unneeded scatter-gather operations in sddr09 · a01e2e63
      Alan Stern authored
      This patch removes some unnecessary scatter-gather code from the sddr09
      driver.  In its place a single smaller buffer is re-used each time through
      an I/O loop, as opposed to transferring all the data at once.
      
      Andries Brouwer kindly tested this and suggested some improvements to get
      it working right.
      a01e2e63
    • Henning Meier-Geinitz's avatar
      [PATCH] USB scanner driver: new device ids · 422cbad1
      Henning Meier-Geinitz authored
      Added vendor/product ids for Epson, Genius, Microtek, Plustek,
      Reflecta, and Visioneer scanners. Removed ids for HP PSC devices as
      these are supported by the hpoj userspace driver.
      422cbad1
    • Alan Stern's avatar
      [PATCH] USB: Fix khubd synchronization · 94ef3b63
      Alan Stern authored
      It improves synchronization with hub_irq() and guarantees that the hub
      disconnect() routine doesn't exit until the URB's completion routine has
      finished.
      94ef3b63
    • Alan Stern's avatar
      [PATCH] USB: khubd optimization · 74636bf5
      Alan Stern authored
      It changes spin_lock_save() to spin_lock() within the completion routine
      and list_del()/INIT_LIST_HEAD() to list_del_init().  It's nothing more
      than a minor optimization.
      74636bf5
  5. 05 Dec, 2003 5 commits
    • David Brownell's avatar
      [PATCH] USB: ohci, fix iso "bad entry" bug + misc · ed63f425
      David Brownell authored
      A while back there were some reports of ohci reporting a "bad entry"
      diagnostic, mostly with ISO transfers, which were mysterious until
      I recently found an easy way to reproduce it.
      
      This patch:
      
        - Fixes at least one cause of that "bad entry" diagnostic by
          waiting for INTR_WDH before completing ED unlink processing.
          (Else URB unlinking could free TDs on the donelist, so the
          WDH processing would see those entries as "bad".)
      
        - Merges the patch from Darwin Rambo <drambo@broadcom.com>,
          coping with CPUs that can't do 16 bit accesses (MIPS).
      
        - Renames a function as start_ed_unlink(), matching its role.
      
        - Fixes minor debug output issues, including a FIXME to tell
          more info about TDs on the periodic schedule.  And adding
          some missing newlines (makes this patch seem big).
      
      Nobody's complained much about that "bad entry" issue lately, but
      if necessary that part would be particularly easy to split out.
      
      Please merge to the next kernel that gets USB patches.
      ed63f425
    • Alan Stern's avatar
      [PATCH] USB storage: Fix logic error in raw_bulk.c:us_copy_to_sgbuf() · 1fca60c0
      Alan Stern authored
      This patch fixes a simple logic error in the routine that copies data from
      a driver buffer to a scatter-gather user buffer.
      1fca60c0
    • Alan Stern's avatar
      [PATCH] USB storage: Issue CBI clear_halt and fix BBB residue · af62566f
      Alan Stern authored
      This patch does 2 things (bad, I know -- but they're both pretty small
      and pretty obscure).
      
      The CBI specification states in section 2.4.3.1.3 that
      
      	... the host shall also issue Clear Feature for Endpoint Halt
      	to the Bulk In pipe if the device reports that the Data In
      	command block has Failed.
      
      along with a note in section 2.5.3 that Data Out commands should work
      analogously.  This patch does that, along with cleaning up the status
      detection logic a little.
      
      For Bulk-only transfers we currently ignore the dResidue field in the CSW,
      except for reporting it (without byte-swapping!) in a debug message.  The
      patch uses it to compute the residue value returned to the SCSI layer.
      Note that the Bulk-only spec allows devices to transfer more data than
      they actually use (i.e., they may add padding or ignore stuff) and then
      inform the host of this by means of the dResidue value.  The logic used is
      simple: our reported residue is the larger of what the device claims and
      what we didn't transfer, except that it can't be larger than the total
      transfer length.
      af62566f
    • Alan Stern's avatar
      [PATCH] USB storage: Command failure codes for sddr09 driver · 78dd3042
      Alan Stern authored
      This patch updates the sdd09 subdriver to make it return Command Failure
      with appropriate sense data (rather than Tranport Error) when:
      
      	a MODE-SENSE command requests an unsupported page;
      
      	a CDB includes an unrecognized command code.
      
      This should help prevent confusion and excessive retrying by the SCSI
      drivers.
      78dd3042
    • Ahmon Dancy's avatar
      16c7cc30
  6. 04 Dec, 2003 1 commit
    • Pete Zaitcev's avatar
      [PATCH] USB: fix comment in usblp · d0d2d872
      Pete Zaitcev authored
      I know Linus is not taking cleanups at this point, but perhaps
      you can delete it in your tree. Seems like someone (Oliver?)
      fixed all the garbage in old printer.c, so the comment is not
      needed anymore.
      
      I reviewed changes, and usblp.c looks correct. I'm doing backport
      to 2.4 for Fedora right now.
      d0d2d872