Commits · 6ac121d710697cee894d6981b804583b0a66ed38 · nexedi / linux

24 Sep, 2015 33 commits

ipvs: Pass ipvs not net to start_sync_thread · 6ac121d7

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

6ac121d7

ipvs: Pass ipvs not net to ip_vs_genl_del_daemon · df04ffb7

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

df04ffb7

ipvs: Pass ipvs not net to ip_vs_genl_new_daemon · d8443c5f

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

d8443c5f

ipvs: Pass ipvs not net to ip_vs_genl_find_service · 34c2f514

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

34c2f514

ipvs: Pass ipvs not net to ip_vs_genl_parse_service · 613fb830

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

613fb830

ipvs: Pass ipvs not net to __ip_vs_get_timeouts · af540341

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

af540341

ipvs: Pass ipvs not net to __ip_vs_get_dest_entries · 08fff4c3

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

08fff4c3

ipvs: Pass ipvs not net to __ip_vs_get_service_entries · b2876b77

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

b2876b77

ipvs: Pass ipvs not net to ip_vs_set_timeout · f1faa1e7

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

f1faa1e7

ipvs: Pass ipvs not net to ip_vs_proto_data_get · 18d6ade6

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

18d6ade6

ipvs: Cache ipvs in ip_vs_in_icmp and ip_vs_in_icmp_v6 · a47b4300

Eric W. Biederman authored Sep 21, 2015

Storte the value of net_ipvs in a variable named ipvs so that when
there are more users struct netns_ipvs in ip_vs_in_cmp and
ip_vs_in_icmp_v6 they won't need to compute the value again.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

a47b4300

ipvs: Pass ipvs not net to ip_vs_zero_all · c60856c6

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

c60856c6

ipvs: Pass ipvs not net to ip_vs_service_net_cleanup · 56d2169b

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

56d2169b

ipvs: Pass ipvs not net to ip_vs_flush · ef7c599d

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

ef7c599d

ipvs: Pass ipvs not net to ip_vs_add_service · 5060bd83

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

5060bd83

ipvs: Cache ipvs in ip_vs_genl_set_cmd · cd58278b

Eric W. Biederman authored Sep 21, 2015

Compute ipvs early in ip_vs_genl_set_cmd and use the cached value to
access ipvs->sync_state.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

cd58278b

ipvs: Pass ipvs not net to ip_vs_dest_trash_expire · 8e743f1b

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

8e743f1b

ipvs: Pass ipvs not net to __ip_vs_del_dest · 79ac82e0

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

79ac82e0

ipvs: Pass ipvs not net to ip_vs_trash_cleanup · 6c0e14f5

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

6c0e14f5

ipvs: Pass ipvs not net to ip_vs_find_dest · dc2add6f

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

dc2add6f

ipvs: Pass ipvs not net to ip_vs_has_real_service · 48aed1b0

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

48aed1b0

ipvs: Pass ipvs not net to ip_vs_service_find · 0a4fd6ce

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

0a4fd6ce

ipvs: Pass ipvs not net to __ip_vs_service_find · bb2e2a8c

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

bb2e2a8c

ipvs: Pass ipvs not net to ip_vs_svc_hashkey · ba61f390

Eric W. Biederman authored Sep 21, 2015

Use the address of ipvs not the address of net when computing the
hash value.  This removes an unncessary dependency on struct net.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

ba61f390

ipvs: Pass ipvs not net to __ip_vs_svc_fwm_find · 1ed8b947

Eric W. Biederman authored Sep 21, 2015

ipvs is what the code actually wants to use.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

1ed8b947

ipvs: Pass ipvs not net to ip_vs_svc_fwm_hashkey · f6510b24

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

f6510b24

ipvs: Store ipvs not net in struct ip_vs_service · 3109d2f2

Eric W. Biederman authored Sep 21, 2015

In practice struct netns_ipvs is as meaningful as struct net and more
useful as it holds the ipvs specific data.  So store a pointer to
struct netns_ipvs.

Update the accesses of param->net to access param->ipvs->net instead.

In functions where we are searching for an svc and filtering by net
filter by ipvs instead.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

3109d2f2

ipvs: Pass ipvs not net to ip_vs_fill_conn · 19913dec

Eric W. Biederman authored Sep 21, 2015

ipvs is what is actually desired so change the parameter and the modify
the callers to pass struct netns_ipvs.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

19913dec

ipvs: Store ipvs not net in struct ip_vs_conn_param · e64e2b46

Eric W. Biederman authored Sep 21, 2015

In practice struct netns_ipvs is as meaningful as struct net and more
useful as it holds the ipvs specific data.  So store a pointer to
struct netns_ipvs.

Update the accesses of param->net to access param->ipvs->net instead.

When lookup up struct ip_vs_conn in a hash table replace comparisons
of cp->net with comparisons of cp->ipvs which is possible
now that ipvs is present in ip_vs_conn_param.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

e64e2b46

ipvs: Store ipvs not net in struct ip_vs_conn · 58dbc6f2

Eric W. Biederman authored Sep 21, 2015

In practice struct netns_ipvs is as meaningful as struct net and more
useful as it holds the ipvs specific data.  So store a pointer to
struct netns_ipvs.

Update the accesses of conn->net to access conn->ipvs->net instead.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

58dbc6f2

ipvs: Use state->net in the ipvs forward functions · d484fc38

Eric W. Biederman authored Sep 21, 2015

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

d484fc38

ipvs: Don't use current in proc_do_defense_mode · 717e917d

Eric W. Biederman authored Sep 21, 2015

Instead store ipvs in extra2 so that proc_do_defense_mode can easily
find the ipvs that it's value is associated with.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

717e917d

ipvs: Hoist computation of ipvs earlier in sctp_conn_schedule · 1daea8ed

Eric W. Biederman authored Sep 21, 2015

The addition of sysctl_sloppy_sctp in sctp_conn_schedule resulted
in a use of ipvs before it was computed.  Hoist the computation of
ipvs earlier to avoid this problem.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>

1daea8ed

22 Sep, 2015 7 commits

usbnet: remove invalid check · 227b9e87

Andrzej Hajda authored Sep 21, 2015

skb->len is always non-negative.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

227b9e87

rndis_wlan: fix checking for default value · 7e724da6

Andrzej Hajda authored Sep 21, 2015

Thresholds uses -1 to indicate that default value should be used.
Since thresholds are unsigned sign checking makes no sense.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

7e724da6

orinoco: fix checking for default value · e79dd09b

Andrzej Hajda authored Sep 21, 2015

Thresholds uses -1 to indicate that default value should be used.
Since thresholds are unsigned sign checking makes no sense.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

e79dd09b

mwifiex: fix comparison expression · cc751498

Andrzej Hajda authored Sep 21, 2015

To avoid underflows signed variables should be used in expression.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

cc751498

net: brcm80211: fix range check · 94926121

Andrzej Hajda authored Sep 21, 2015

Unsigned minus constant is still unsigned so checking its sign makes no
sense.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

94926121

net: stmmac: fix type of entry variable · 23c2412d

Andrzej Hajda authored Sep 21, 2015

Variable can store negative values.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

23c2412d

net/ibm/emac: fix type of phy_mode · 7d2fa710

Andrzej Hajda authored Sep 21, 2015

phy_mode can be negative.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

7d2fa710