- 20 May, 2010 40 commits
-
-
Johan Hovold authored
Use bulk_out_size in usb_serial_driver to set urb buffer size. Signed-off-by:
Johan Hovold <jhovold@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Julia Lawall authored
Use kmemdup when some other buffer is immediately copied into the allocated region. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size); // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
-
Craig Shelley authored
Signed-off-by:
Craig Shelley <craig@microtron.org.uk> Cc: stable <stable@kernel.org> Signed-off-by:
-
Johan Hovold authored
Increase the bulk-out buffer size to avoid any regression in throughput after replacing the old writing scheme which used dynamic buffers (e.g. up to 2k). 256b has been determined to be a good choice for several drivers including ftdi_sio which used to have a more or less identical write implementation. Signed-off-by:
-
Johan Hovold authored
Use process_read_urb to implement line status handling. Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Use generic open to submit read urb. Signed-off-by:
-
Johan Hovold authored
Remove some whitepace and comments. Clean up close. Signed-off-by:
-
Johan Hovold authored
Signed-off-by:
-
Johan Hovold authored
Kill custom read and write implementations (dynamically allocated write urbs). Note that I chose to remove the stat module parameter which was supposed to keep count of the amount of data sent and received, but which has been broken for three years (since b308e74d "USB: visor driver adapted to new tty buffering" -- bytes_in was incorrectly updated and was thus always reported as 0). Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Fix memory leak for some devices (Sony Clie 3.5) due to port private data not being freed on release. Cc: stable <stable@kernel.org> Signed-off-by:
-
Johan Hovold authored
Kill custom fifo, read, and single-urb write implementations. Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Kill custom fifo, read and write implementations (single-urb and fifo, but still maintained list of 256*256b urb buffers per port). Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Kill custom read and write implementations (static 16*4k write-urb pool shared among all ports in system). Also remove old changelog entries in header (code is now gone, and these entries can still be retrieved through git). Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Return immediately from generic process_read_urb if urb is empty. Signed-off-by:
-
Johan Hovold authored
An urb transfer buffer is allocated at every open but was never freed. This driver is a bit of a mess... Cc: stable <stable@kernel.org> Signed-off-by:
-
Nils Radtke authored
This patch adds support for an olivetti olicard100 HЅDPA usb-stick. This device is a zeroCD one with ID 0b3c:c700 that needs switching via eject or usb-modeswitch with MessageContent="5553424312345678000000000000061b000000030000000000000000000000". After switching it has ID 0b3c:c000 and provides 5 serial ports ttyUSB[0-4]. Port 0 (modem) and 4 are interrupt ports. Signed-off-by:
Nils Radtke <lkml@Think-Future.de> Cc: stable <stable@kernel.org> Signed-off-by:
-
Greg Kroah-Hartman authored
Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com> Signed-off-by:
-
Ming Lei authored
usb_find_device was the only one user of match_device, now it is removed, so remove match_device to fix the compile warning below reported by Stephen Rothwell: drivers/usb/core/usb.c:596: warning: 'match_device' defined but not used Reported-by:
Ming Lei <tom.leiming@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Lots of minor formatting cleanups in includes/usb/ to make checkpatch happier. Signed-off-by: -
Greg Kroah-Hartman authored
Minor formatting changes to clean up the file. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Greg Kroah-Hartman authored
Minor whitespace cleanups to make checkpatch happy. Signed-off-by: -
Anton Vorontsov authored
Since commit 7acd72eb ("kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out..."), kfifo_out() is marked __must_check, and that causes gcc to produce lots of warnings like this: CC drivers/usb/host/fhci-mem.o In file included from drivers/usb/host/fhci-hcd.c:34: drivers/usb/host/fhci.h: In function 'cq_get': drivers/usb/host/fhci.h:520: warning: ignoring return value of 'kfifo_out', declared with attribute warn_unused_result ... This patch fixes the issue by properly checking the return value. Signed-off-by:
Anton Vorontsov <avorontsov@mvista.com> Cc: stable <stable@kernel.org> [.33 and .34] Signed-off-by:
-
Johan Hovold authored
Remove cp210x_disconnect which is used to kill traffic although this is already handled by the generic framework. Signed-off-by:
-
Julia Lawall authored
Use kzalloc rather than the combination of kmalloc and memset. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,size,flags; statement S; @@ -x = kmalloc(size,flags); +x = kzalloc(size,flags); if (x == NULL) S -memset(x, 0, size); // </smpl> Signed-off-by:
-
Johan Hovold authored
Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Signed-off-by:
-
Johan Hovold authored
No need to raise dtr/rts in open as this is taken care of by tty layer. Signed-off-by:
-
Johan Hovold authored
Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Use dynamically allocated urb for baudrate changes rather than unconditionally submitting the port write urb which may already be in use. Compile-only tested. Signed-off-by:
-
Johan Hovold authored
Use usb_serial_driver bulk_in_size and bulk_out_size to make sure buffers of appropriate sizes are allocated in the first place rather than reallocating them at every open. Signed-off-by:
-
Johan Hovold authored
If the user specifies a custom bulk buffer size we get a double free at port release. Cc: stable <stable@kernel.org> Signed-off-by:
-
Alan Stern authored
This patch (as1380) fixes a bug in the wakeup settings for EHCI host controllers. When the controller is suspended, if it isn't enabled for remote wakeup then we have to turn off all the port wakeup flags. Disabling PCI PME# isn't good enough, because some systems (Intel) evidently use alternate wakeup signalling paths. In addition, the patch improves the handling of the Intel Moorestown hardware by performing various power-up and power-down delays just once instead of once for each port (i.e., the delays are moved outside of the port loops). This requires extra code, but the total delay time is reduced. There are also a few additional minor cleanups. Signed-off-by:
Alan Stern <stern@rowland.harvard.edu> Reported-by:
Ondrej Zary <linux@rainbow-software.org> CC: Alek Du <alek.du@intel.com> CC: stable <stable@kernel.org> Signed-off-by:
-
