1. 19 Aug, 2004 2 commits
    • Brian King's avatar
      [PATCH] Allow TCQ depth to be lowered properly · 74a84824
      Brian King authored
      Ran into a couple small issues with the patch. First,
      blk_queue_resize_tags wasn't getting exported, so I sent Jens a patch to
      fix this, which he has now sent upstream. Second, the comment above
      blk_queue_resize_tags says the queue_lock must be held when calling this
      routine. Attached is an updated patch that grabs the lock. Other than
      that, it looks good.
      
      James Bottomley wrote:
      > On Tue, 2004-08-03 at 10:50, Brian King wrote:
      >>Currently, it is possible to call scsi_activate_tcq with a small queue depth,
      >>then later call scsi_adjust_queue_depth with a larger queue depth. This results
      >>in the scsi layer having a larger queue depth than the block layer knows about.
      >>This results in these additional commands being issued as untagged ops rather than
      >>tagged ops. This patch changes scsi_activate_tcq to call blk_queue_init_tags with
      >>the maximum supported number of tags so this cannot occur.
      >
      >
      > Sorry, been away at conferences with not enough time to remember what
      > went on here.
      >
      > The reason it looks the way it does is historical...when the blk layer
      > tcq interfaces were created, there was no way to resize the queue.  Jens
      > later added resize (for me) and I forgot to incorporate it into the
      > code.
      >
      > Another small point is that the max number of tags can be greater than
      > 256.  256 is a SPI limit only (and even the qla1280, a SPI card which
      > could use the tag as its global queue index would take > 256).  The
      > limit in scsi_adjust_queue_depth has long since been obsoleted by our
      > dynamic command allocation.
      >
      > I think the attached should work correctly (as long as it compiles...I
      > coded it up on the flight home).
      Signed-off-by: default avatarBrian King <brking@us.ibm.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      74a84824
    • James Bottomley's avatar
      get the kernel to warn about deprecated SCSI ioctls · 59fbf85b
      James Bottomley authored
      The non unique SCSI ioctls:
      
      SCSI_IOCTL_SEND_COMMAND
      SCSI_IOCTL_TEST_UNIT_READY
      SCSI_IOCTL_BENCHMARK_COMMAND
      SCSI_IOCTL_SYNC
      SCSI_IOCTL_START_UNIT
      SCSI_IOCTL_STOP_UNIT
      
      Have been deprecated for a while now.  We should make the kernel
      complain when a program actually uses one of them, so users have had
      adequate warning before they are removed.
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      59fbf85b
  2. 18 Aug, 2004 2 commits
  3. 17 Aug, 2004 1 commit
  4. 16 Aug, 2004 2 commits
    • Mike Anderson's avatar
      [PATCH] reorder call in scsi_remove_host · 44d90463
      Mike Anderson authored
      This patch against scsi-misc-2.6 reorders a call to scsi_forget_host in
      the scsi_remove_host function. This removes the error message
      "Synchronizing SCSI cache..." on rmmod of a scsi host driver module as
      shown in example output 1 and 2 below.
      
      I had previous created a much more complicated patch to work around this
      problem. In response Christoph mention a simpler solution (pointer to
      thread below) which is this patch.
      
      http://marc.theaimsgroup.com/?l=linux-scsi&m=108720042210331&w=2
      
      Example output.
      
      1.) Before patch.
      
      elm:~# scsi1 : scsi_debug, version 1.73 [20040518], dev_size_mb=8,
      opts=0x0
        Vendor: Linux     Model: scsi_debug        Rev: 0004
        Type:   Direct-Access                      ANSI SCSI revision: 03
      SCSI device sdc: 16384 512-byte hdwr sectors (8 MB)
      SCSI device sdc: drive cache: write back
       sdc: unknown partition table
      Attached scsi disk sdc at scsi1, channel 0, id 0, lun 0
      Attached scsi generic sg4 at scsi1, channel 0, id 0, lun 0,  type 0
      Synchronizing SCSI cache for disk sdc: <4>FAILED
        status = 0, message = 00, host = 1, driver = 00
      
      2.) After patch.
      
      elm:~# scsi1 : scsi_debug, version 1.73 [20040518], dev_size_mb=8, opts=0x0
        Vendor: Linux     Model: scsi_debug        Rev: 0004
        Type:   Direct-Access                      ANSI SCSI revision: 03
      SCSI device sdc: 16384 512-byte hdwr sectors (8 MB)
      SCSI device sdc: drive cache: write back
       sdc: unknown partition table
      Attached scsi disk sdc at scsi1, channel 0, id 0, lun 0
      Attached scsi generic sg4 at scsi1, channel 0, id 0, lun 0,  type 0
      Synchronizing SCSI cache for disk sdc:
      Signed-off-by: default avatarMike Anderson <andmike@us.ibm.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      44d90463
    • James Bottomley's avatar
      MPT Fusion driver 3.01.15 update · dd424b0a
      James Bottomley authored
      Highlights of this release:
      - Patch provided by Christoph Hellwig to remove the isense code.
      - Fix compile errors when CONFIG_PROC_FS=n.
      - A fix for the module parameter "mptscsih" which was not being exported.
      - The port of the 2.05.17 thru 2.05.23 of the lk 2.4 mpt driver.
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      dd424b0a
  5. 14 Aug, 2004 24 commits
  6. 13 Aug, 2004 4 commits
  7. 01 Aug, 2004 2 commits
  8. 29 Jul, 2004 3 commits