- 26 Feb, 2015 34 commits
-
-
Vaishali Thakkar authored
This patch removes struct ndis_802_11_key as it is defined in a header file but never used. Signed-off-by:
Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Aya Mahfouz authored
This patch replaces init_timer and 2 step initialization of function and data by setup_timer to make the code more concise. The issue was discovered using the following coccinelle script: @@ expression ds, e1, e2; @@ -init_timer (&ds); +setup_timer (&ds, e1, e2); ... -ds.function = e1; ... -ds.data = e2; Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by:
-
Katie Dunne authored
Fixes the checkpatch.pl Check: CHECK: Alignment should match open parenthesis Increases readability by standardizing 7 argument indentations Signed-off-by:
Katie Dunne <kdunne@mail.ccsf.edu> Signed-off-by:
-
Vaishali Thakkar authored
Here, data value 0xabadcafe in function setup_timer seems like a nonsense value and timer handler function is not using it anyway. So, change it to 0. Signed-off-by:
-
Vaishali Thakkar authored
This patch introduces the use of function setup_timer instead of structure assignments as it is the preferred way to setup and set the timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (&x); + setup_timer (&x, y, z); - x.function = y; - x.data = z; Signed-off-by:
-
Yeliz Taneroglu authored
This patch fixes the checkpatch.pl warning: WARNING: "Missing a blank line after declarations" Signed-off-by:
Yeliz Taneroglu <yeliztaneroglu@gmail.com> Signed-off-by:
-
Yeliz Taneroglu authored
The following patch fixes the checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
aybuke ozdemir authored
Brackets were removed from the expression that containing single statement. Removed following checkpatch.pl warnings: WARNING: braces {} are not necessary for single statement blocks Signed-off-by:aybuke ozdemir <aybuke.147@gmail.com> Signed-off-by:
-
aybuke ozdemir authored
This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in device.c Signed-off-by:
-
Aya Mahfouz authored
This patch fixes the following checkpatch.pl warning: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by:
-
Aya Mahfouz authored
This patch fixes the following checkpatch.pl warning: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by:
-
Vatika Harlalka authored
This patch removes the checkpatch.pl warnings "quoted string split accross lines" Signed-off-by:
Vatika Harlalka <vatikaharlalka@gmail.com> Signed-off-by:
-
Vatika Harlalka authored
This patch is to remove space after the * in pointer type function parameters in function prototype and definition to follow kernel coding conventions. Signed-off-by:
-
Vatika Harlalka authored
This patch fixes checkpatch.pl error in debug.c ERROR: do not use C99 // comments Signed-off-by:
-
Vatika Harlalka authored
This patch fixes checkpatch.pl warning "Use #include <linux/uaccess.h> instead of <asm/uaccess.h>" in i2o/config-osm.c . Signed-off-by:
-
aybuke ozdemir authored
This patch focuses on fixing the following warning generated by checkpatch.pl for the file rxtx.c Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) @@ expression e1, e2; @@ - memcpy(e1, e2, ETH_ALEN); + ether_addr_copy(e1, e2); According to ether_addr_copy() description and functionality, all Ethernet addresses should align to the u16 datatype. The changes were applied using the following coccinelle rule: Here is the output of pahole for the relevant datastructures: struct vnt_usb_send_context { void * priv; /* 0 8*/ struct sk_buff * skb; /* 8 8*/ struct urb * urb; /* 16 8*/ struct ieee80211_hdr * hdr; /* 24 8*/ unsigned int buf_len; /* 32 4*/ u32 frame_len; /* 36 4*/ u16 tx_hdr_size; /* 40 2*/ u16 tx_rate; /* 42 2*/ u8 type; /* 44 1*/ u8 pkt_no; /* 45 1*/ u8 pkt_type; /* 46 1*/ u8 need_ack; /* 47 1*/ u8 fb_option; /* 48 1*/ bool in_use; /* 49 1*/ unsigned char data[2900]; /* 50 2900*/ /* --- cacheline 46 boundary (2944 bytes) was 6 bytes ago --- */ /* size: 2952, cachelines: 47, members: 15 */ /* padding: 2 */ /* last cacheline: 8 bytes */ }; struct ieee80211_key_conf { u32 cipher; /* 0 4*/ u8 icv_len; /* 4 1*/ u8 iv_len; /* 5 1*/ u8 hw_key_idx; /* 6 1*/ u8 flags; /* 7 1*/ s8 keyidx; /* 8 1*/ u8 keylen; /* 9 1*/ u8 key[0]; /* 10 0*/ /* size: 12, cachelines: 1, members: 8 */ /* padding: 2 */ /* last cacheline: 12 bytes */ }; struct vnt_mic_hdr { u8 id; /* 0 1*/ u8 tx_priority; /* 1 1*/ u8 mic_addr2[6]; /* 2 6*/ u8 ccmp_pn[6]; /* 8 6*/ __be16 payload_len; /* 14 2*/ __be16 hlen; /* 16 2*/ __le16 frame_control; /* 18 2*/ u8 addr1[6]; /* 20 6*/ u8 addr2[6]; /* 26 6*/ u8 addr3[6]; /* 32 6*/ __le16 seq_ctrl; /* 38 2*/ u8 addr4[6]; /* 40 6*/ u16 packing; /* 46 2*/ /* size: 48, cachelines: 1, members: 13 */ /* last cacheline: 48 bytes */ }; Signed-off-by: -
Hatice ERTÜRK authored
// erased and replace it with /* */ used. Error found with checkpatch.pl Signed-off-by:
Hatice ERTURK <haticeerturk27@gmail.com> Signed-off-by:
-
Katie Dunne authored
Addresses checkpatch.pl warning: WARNING: line over 80 characters Break 2 lines over 80 characters and align with opening parenthesis Signed-off-by:
-
Katie Dunne authored
Addresses the checkpatch.pl error: ERROR: Do not use C99 // comments Remove an unneeded comment line Replace C99 comments with C89 Reduce multiple line comments to one line Shorten comments over 80 line by removing blank space Signed-off-by:
-
Melike Yurtoglu authored
WARNING: space prohibited between function name and open parenthesis '(' Remove unnecessary space between function name and opening parenthesis. That was found by running checkpatch Signed-off-by:Melike Yurtoglu <aysemelikeyurtoglu@gmail.com> Signed-off-by:
-
aybuke ozdemir authored
Fix checkpatch.pl issues with "unnecessary whitespace before a quoted newline" in llite_lib.c Signed-off-by:
-
aybuke ozdemir authored
This patch makes checkpatch.pl by fixing the following warning: WARNING: Prefer kstrto<type> to single variable sscanf. I used to kstrtoul can convert unsigned long instead of sscanf Signed-off-by:
-
aybuke ozdemir authored
This patch fixes checkpatch.pl warning in llite_lib.c WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: -
aybuke ozdemir authored
This patch fixes indent as the codingStyle of the kernel recommends in dir.c Fix checkpatch.pl error: ERROR: switch and case should be at the same indent. Signed-off-by:
-
aybuke ozdemir authored
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in dir.c Signed-off-by:
-
aybuke ozdemir authored
This patch fixes "Use #include <linux/uaccess.h> instead of <asm/uaccess.h"> checkpatch.pl warning in dir.c Signed-off-by:
-
Gulsah Kose authored
Removed return keyword from void functions. Removed following checkpatch.pl warnings: WARNING: void function return statements are not generally useful Signed-off-by:
Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by:
-
Gulsah Kose authored
Added missing blank line after declaration. Removed following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by:
-
Gulsah Kose authored
Removed unnecessary spaces between function name and open parenthesis '('. Removed following checkpatch.pl warnings: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: -
Melike Yurtoglu authored
Staging: lustre: lnet: klnds: o2iblnd: Deleted space prohibited between function name and open parenthesis WARNING: space prohibited between function name and open parenthesis '(' checkpatch.pl warning in o2iblnd_modparams.c Signed-off-by: -
Melike Yurtoglu authored
ERROR: do not initialise statics to 0 or NULL checkpatch.pl error in o2iblnd_modparams.c initial value unassigned static variables are automatically set to zero. so it is unnecessary to assign the initial value to zero Signed-off-by:
-
aybuke ozdemir authored
This fixes the checkpatch.pl error in conctl.c: ERROR: spaces required around that '||' (ctx:VxE) Signed-off-by:
-
Melike Yurtoglu authored
This patch fixes checpatch.pl warning WARNING: please, no spaces at the start of a line Signed-off-by:
-
Aya Mahfouz authored
This patch removes a commented call to LBUG since lustre should be cleaned out of debugging macros before moving out of staging. Signed-off-by:
-
- 24 Feb, 2015 6 commits
-
-
Aya Mahfouz authored
This patch fixes the following checkpatch.pl error: space prohibited before that ',' Signed-off-by:
-
Aya Mahfouz authored
This patch fixes the following checkpatch.pl errors for the file fb_bd663474.c: ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that open parenthesis '(' ERROR: space required after that ',' Signed-off-by: -
Vatika Harlalka authored
This patch addresses the checkpatch.pl warning WARNING: __aligned(size) is preferred over __attribute__((aligned(size))) aligned(x) is a macro : #define __aligned(x) __attribute__((aligned(x))) Signed-off-by:
-
Tapasweni Pathak authored
To avoid deadlock, do not call blocking functions with spinlocks held. Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile doesn't have enough free pages but will not sleep and hence deadlock can be avoided. Found by Coccinelle. Signed-off-by:
Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by:
-
Vatika Harlalka authored
This patch fixes checkpatch.pl WARNING: Line longer than 80 chars. Signed-off-by:
-
Vatika Harlalka authored
Removed trailing whitespaces to improve code readability and remove checkpatch warning. Signed-off-by:
-
