1. 05 Nov, 2013 1 commit
    • Jan Kara's avatar
      ext2: Fix fs corruption in ext2_get_xip_mem() · 7ba3ec57
      Jan Kara authored
      Commit 8e3dffc6 "Ext2: mark inode dirty after the function
      dquot_free_block_nodirty is called" unveiled a bug in __ext2_get_block()
      called from ext2_get_xip_mem(). That function called ext2_get_block()
      mistakenly asking it to map 0 blocks while 1 was intended. Before the
      above mentioned commit things worked out fine by luck but after that commit
      we started returning that we allocated 0 blocks while we in fact
      allocated 1 block and thus allocation was looping until all blocks in
      the filesystem were exhausted.
      
      Fix the problem by properly asking for one block and also add assertion
      in ext2_get_blocks() to catch similar problems.
      Reported-and-tested-by: default avatarAndiry Xu <andiry.xu@gmail.com>
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      7ba3ec57
  2. 04 Nov, 2013 1 commit
  3. 31 Oct, 2013 1 commit
  4. 18 Oct, 2013 1 commit
    • Peter A. Felvegi's avatar
      udf: fix for pathetic mount times in case of invalid file system · 44499602
      Peter A. Felvegi authored
      The UDF driver was not strict enough about checking the IDs in the
      VSDs when mounting, which resulted in reading through all the sectors
      of the block device in some unfortunate cases. Eg, trying to mount my
      uninitialized 200G SSD partition (all 0xFF bytes) took ~350 minutes to
      fail, because the code expected some of the valid IDs or a zero byte.
      During this, the mount couldn't be killed, sync from the cmdline
      blocked, and the machine froze into the shutdown. Valid filesystems
      (extX, btrfs, ntfs) were rejected by the mere accident of having a
      zero byte at just the right place in some of their sectors, close
      enough to the beginning not to generate excess I/O. The fix adds a
      hard limit on the VSD sector offset, adds the two missing VSD IDs, and
      stops scanning when encountering an invalid ID. Also replaced the
      magic number 32768 with a more meaningful #define, and supressed the
      bogus message about failing to read the first sector if no UDF fs was
      detected.
      Signed-off-by: default avatarPeter A. Felvegi <petschy@gmail.com>
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      44499602
  5. 16 Oct, 2013 1 commit
    • Eric Sandeen's avatar
      ext3: Count journal as bsddf overhead in ext3_statfs · 2046fd18
      Eric Sandeen authored
      ext4 counts journal space as bsddf overhead, but ext3 does not.
      
      For some reason when I patched ext4 I thought I should leave
      ext3 alone, but frankly it makes more sense to fix it, I think.
      
      Otherwise we get inconsistent behavior from ext3 under ext3.ko,
      and ext3 under ext4.ko, which is not at all desirable...
      
      This is testable by xfstests shared/289, though it will need
      modification because it currently special-cases ext3.
      Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      2046fd18
  6. 13 Oct, 2013 17 commits
  7. 12 Oct, 2013 10 commits
  8. 11 Oct, 2013 8 commits