- 20 Feb, 2016 40 commits
-
-
Janani Ravichandran authored
Else is unnecessary when there is a return statement in the corresponding if block. Coccinelle patch used: @rule1@ expression e1; @@ if (e1) { ... return ...; } - else{ ... - } @rule2@ expression e2; statement s1; @@ if(e2) { ... return ...; } - else s1 Signed-off-by:Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhumika Goyal authored
Assignments in function call arguments are undesirable. So pull such assignments out before function call. Made a coccinelle script to detect such cases: @@ expression fn,b,d; @@ * fn(...,d=b,...); Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Declare osc_cleanup() function and osc_obd_ops structure as static since they are defined and called only in this file. Removed osc_cleanup() function prototype since it wasn't required. This fixes the following sparse warnings: drivers/staging/lustre/lustre/osc/osc_request.c:3210:5: warning: symbol 'osc_cleanup' was not declared. Should it be static? drivers/staging/lustre/lustre/osc/osc_request.c:3259:16: warning: symbol 'osc_obd_ops' was not declared. Should it be static? Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Amitoj Kaur Chawla authored
Declare lustre_mount() function static since it is defined and called in this file only. This fixes the following sparse warning: drivers/staging/lustre/lustre/obdclass/obd_mount.c:1169:15: warning: symbol 'lustre_mount' was not declared. Should it be static? Signed-off-by:
-
Shalin Mehta authored
The parentehsis are fixed in the macro for the ldlm lock to set and clear the flags. Signed-off-by:
Shalin Mehta <shalinmehta85@gmail.com> Acked-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Oleg Drokin authored
simple_strtoul is obsolete Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Oleg Drokin authored
simple_strtoul is obsolete Signed-off-by:
-
Oleg Drokin authored
This is against kernel-code style. Signed-off-by:
-
Oleg Drokin authored
They make checkpatch unhappy, and I guess overall might confuse people too. Signed-off-by:
-
Oleg Drokin authored
Replace it with enum cfs_trace_buf_type Signed-off-by:
-
Oleg Drokin authored
We do really mean to fall through to that default case statement from all previous ones, so add a comment to unconfuse verious tools Signed-off-by:
-
Oleg Drokin authored
No need for an empty line after opening curvy brace and no need for an empty line before the closing one too. Remove them. Signed-off-by:
-
Oleg Drokin authored
Return at the end of a void function does not serve any particular purpose and makes checkpatch unhappy, so eliminate them. Signed-off-by:
-
Oleg Drokin authored
checkpatch complains that the trailing */ on the multiline comments should be on it's own line. Signed-off-by:
-
Oleg Drokin authored
the struct page_collection, struct cfs_trace_page and struct tracefiled_ctl are only used by tracefile.c, so move them there. Signed-off-by:
-
Oleg Drokin authored
Does not appear to be used anywhere. Signed-off-by:
-
Oleg Drokin authored
Lines that were too long for not good reason were shortened in this patch. Found with checkpatch. Signed-off-by:
-
Oleg Drokin authored
Problem highlighted by checkpatch. Signed-off-by:
-
Oleg Drokin authored
Avoid using leading spaces that make checkpatch unhappy. Signed-off-by:
-
Oleg Drokin authored
This fixes checkpatch messages about "spaces preferred around that '-' (ctx:VxV)" Signed-off-by:
-
Oleg Drokin authored
Found with checkpatch Signed-off-by:
-
Oleg Drokin authored
Adjust alignment of argments that were pushed to next lines to conform to kernel code style. Found with checkpatch. Signed-off-by:
-
Oleg Drokin authored
Checkpatch highlighted that some of our Lustre files carry this extra paragraph and indeed it does seem somewhat redundant, so remove it. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" The only exception is ll_update_inode where dropping != NULL in the construction below would break the logic. I guess we could change lsm != NULL to !!lsm, but that's uglier. (lsm != NULL) == ((body->valid & OBD_MD_FLEASIZE) != 0) Also removed some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also removed some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also removed some redundant assertions. Signed-off-by:
-
Oleg Drokin authored
The complicated version of osc_page_protected and osc_page_is_dlocked are unsafe and were commented out for ages, so probably no point in carrying them on. Signed-off-by:
-
Oleg Drokin authored
lock_lock_multi_match stayed commented out unused for ages now, so let's just remove it. Signed-off-by:
-
