- 15 Jul, 2019 1 commit
-
-
Nathan Chancellor authored
clang warns: drivers/watchdog/digicolor_wdt.c:121:6: warning: unused variable 'ret' [-Wunused-variable] int ret; ^ 1 warning generated. It's unused now, remove it. Fixes: cdad2697 ("watchdog: digicolor_wdt: drop warning after registering device") Link: https://github.com/ClangBuiltLinux/linux/issues/591Reported-by:kernelci.org bot <bot@kernelci.org> Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Reviewed-by:
Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20190709203409.117123-1-natechancellor@gmail.comSigned-off-by:
Wim Van Sebroeck <wim@linux-watchdog.org>
-
- 08 Jul, 2019 39 commits
-
-
Sebastian Andrzej Siewior authored
For spinlocks the type spinlock_t should be used instead of "struct spinlock". Use spinlock_t for spinlock's definition. Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Guenter Roeck <linux@roeck-us.net> Cc: linux-watchdog@vger.kernel.org Signed-off-by:
Sebastian Andrzej Siewior <bigeasy@linutronix.de> Reviewed-by:
-
Ken Sloat authored
Currently, the atmel-sama5d4-wdt continues to run after system suspend. Unless the system resumes within the watchdog timeout period so the userspace can kick it, the system will be reset. This change disables the watchdog on suspend if it is active and re-enables on resume. These actions occur during the late and early phases of suspend and resume respectively to minimize chances where a lock could occur while the watchdog is disabled. Signed-off-by:
Ken Sloat <ksloat@aampglobal.com> Acked-by:
Alexandre Belloni <alexandre.belloni@bootlin.com> Reviewed-by:
-
Guenter Roeck authored
This gets rid of the unnecessary license boilerplate, and avoids having to deal with individual patches one by one. No functional changes. Reviewed-by:
Jerry Hoemann <jerry.hoemann@hpe.com> Acked-by:
Sylvain Lemieux <slemieux.tyco@gmail.com> Reviewed-by:
Matthias Brugger <matthias.bgg@gmail.com> Acked-by:
William Breathitt Gray <vilhelm.gray@gmail.com> Signed-off-by:
-
Simon Horman authored
For consistency with the naming of (most) other documentation files for DT bindings for Renesas IP blocks rename the Renesas WDT documentation file from renesas-wdt.txt to renesas,wdt.txt. Signed-off-by:
Simon Horman <horms+renesas@verge.net.au> Reviewed-by:
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by:
-
Greg Kroah-Hartman authored
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Tomas Winkler <tomas.winkler@intel.com> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Guenter Roeck <linux@roeck-us.net> Cc: linux-watchdog@vger.kernel.org Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
-
Greg Kroah-Hartman authored
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-watchdog@vger.kernel.org Signed-off-by:
-
Jerry Hoemann authored
make htmldocs fails due to missing blank line following header. Signed-off-by:
Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Reviewed-by:
-
Mauro Carvalho Chehab authored
Convert those documents and prepare them to be part of the kernel API book, as most of the stuff there are related to the Kernel interfaces. Still, in the future, it would make sense to split the docs, as some of the stuff is clearly focused on sysadmin tasks. The conversion is actually: - add blank lines and identation in order to identify paragraphs; - fix tables markups; - add some lists markups; - mark literal blocks; - adjust title markups. At its new index.rst, let's add a :orphan: while this is not linked to the main index.rst file, in order to avoid build warnings. Signed-off-by:
-
Rasmus Villemoes authored
When the watchdog device is not open by userspace, the kernel takes care of pinging it. When the open_timeout feature is in use, we should ensure that the hardware fires close to open_timeout seconds after the kernel has assumed responsibility for the device. To do this, simply reuse the logic that is already in place for ensuring the same thing when userspace is responsible for regularly pinging the device: - When watchdog_active(wdd), this patch doesn't change anything. - When !watchdog_active(wdd), the "virtual timeout" should be taken to be ->open_deadline". When the open_timeout feature is not used or the device has been opened at least once, ->open_deadline is KTIME_MAX, and the arithmetic ends up returning keepalive_interval as we used to. This has been tested on a Wandboard with various combinations of open_timeout and timeout-sec properties for the on-board watchdog by booting with 'init=/bin/sh', timestamping the lines on the serial console, and comparing the timestamp of the 'imx2-wdt 20bc000.wdog: timeout nnn sec' line with the timestamp of the 'U-Boot SPL ...' line (which appears just after reset). Suggested-by:
Rasmus Villemoes <rasmus.villemoes@prevas.dk> Reviewed-by:
-
Rasmus Villemoes authored
This allows setting a default value for the watchdog.open_timeout commandline parameter via Kconfig. Some BSPs allow remote updating of the kernel image and root file system, but updating the bootloader requires physical access. Hence, if one has a firmware update that requires relaxing the watchdog.open_timeout a little, the value used must be baked into the kernel image itself and cannot come from the u-boot environment via the kernel command line. Being able to set the initial value in .config doesn't change the fact that the value on the command line, if present, takes precedence, and is of course immensely useful for development purposes while one has console acccess, as well as usable in the cases where one can make a permanent update of the kernel command line. Signed-off-by:
-
Rasmus Villemoes authored
The watchdog framework takes care of feeding a hardware watchdog until userspace opens /dev/watchdogN. If that never happens for some reason (buggy init script, corrupt root filesystem or whatnot) but the kernel itself is fine, the machine stays up indefinitely. This patch allows setting an upper limit for how long the kernel will take care of the watchdog, thus ensuring that the watchdog will eventually reset the machine. A value of 0 (the default) means infinite timeout, preserving the current behaviour. This is particularly useful for embedded devices where some fallback logic is implemented in the bootloader (e.g., use a different root partition, boot from network, ...). There is already handle_boot_enabled serving a similar purpose. However, such a binary choice is unsuitable if the hardware watchdog cannot be programmed by the bootloader to provide a timeout long enough for userspace to get up and running. Many of the embedded devices we see use external (gpio-triggered) watchdogs with a fixed timeout of the order of 1-2 seconds. The open timeout only applies for the first open from userspace. Should userspace need to close the watchdog device, with the intention of re-opening it shortly, the application can emulate the open timeout feature by combining the nowayout feature with an appropriate WDIOC_SETTIMEOUT immediately prior to closing the device. Signed-off-by:
-
Anson Huang authored
i.MX system controller watchdog depends on SCU driver to support interrupt function, so it needs to be subnode of SCU node in DT, binding doc should be moved to fsl,scu.txt as well. Signed-off-by:
Anson Huang <Anson.Huang@nxp.com> Reviewed-by:
Rob Herring <robh@kernel.org> Reviewed-by:
-
Anson Huang authored
i.MX system controller watchdog can support pretimeout IRQ via general SCU MU IRQ, it depends on IMX_SCU and driver MUST be probed after SCU IPC ready, then enable corresponding SCU IRQ group and register SCU IRQ notifier, when watchdog pretimeout IRQ fires, SCU MU IRQ will be handled and watchdog pretimeout notifier will be called to handle the event. Signed-off-by:
-
Yoshihiro Shimoda authored
According to the hardware manual of R-Car Gen2 and Gen3, software should wait a few RLCK cycles as following: - Delay 2 cycles before setting watchdog counter. - Delay 3 cycles before disabling module clock. So, this patch adds such delays. Signed-off-by:
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:
Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by:
-
Mans Rullgard authored
Add support for the nowayout option in the gpio watchdog driver. Signed-off-by:
Mans Rullgard <mans@mansr.com> Reviewed-by:
-
Hoan Nguyen An authored
Add helper variable dev = &pdev->dev Signed-off-by:
Hoan Nguyen An <na-hoan@jinso.co.jp> Reviewed-by:
-
Clément Péron authored
Allwinner H6 has a similar watchdog as the A64 which is already a compatible of the A31. This commit add the H6 compatible. Signed-off-by:
Clément Péron <peron.clem@gmail.com> Reviewed-by:
-
Paul Cercueil authored
Previously the jz4740_wdt_set_timeout() function was starting the timer unconditionally, even if it was stopped when that function was entered. Now, the timer will be restarted only if it was already running before this function is called. Signed-off-by:
Paul Cercueil <paul@crapouillou.net> Reviewed-by:
-
Paul Cercueil authored
Use the macros from <linux/mfd/ingenic-tcu.h> instead of declaring our own. Signed-off-by:
-
Jerry Hoemann authored
Bump driver number to reflect recent changes. Signed-off-by:
-
Jerry Hoemann authored
Update documentation to explain new module parameter kdumptimeout. Signed-off-by:
-
Jerry Hoemann authored
Instead of unconditionally stopping the watchdog timer after receipt of a pretimeout NMI, reprogram the timeout based upon module parameter kdumptimeout. The provides a more flexible override than the depricated allow_kdump. Signed-off-by:
-
Jerry Hoemann authored
Instead of stopping the hw timer during probe, have the core update the timer if the timer is already running. Signed-off-by:
-
Jerry Hoemann authored
Set max_hw_heartbeat_ms instead of max_timeout so that user client can set timeout range in excess of what the underlying hardware supports. Signed-off-by:
-
Jerry Hoemann authored
Have the WD core stop the watchdog on unregister instead of explicitly calling hpwdt_stop() in hpwdt_exit(). Signed-off-by:
-
Stefan Wahren authored
The commit 5e6acc3e ("bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD.") broke module autoloading on Raspberry Pi. So add a module alias this fix this. Signed-off-by:
Stefan Wahren <wahrenst@gmx.net> Reviewed-by:
-
Eugen Hristev authored
WDD value must be always set to max (0xFFF) otherwise the hardware block will reset the board on the first ping of the watchdog. Signed-off-by:
Eugen Hristev <eugen.hristev@microchip.com> Reviewed-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
Wolfram Sang authored
The core will print out details now. Signed-off-by:
-
