- 08 Oct, 2019 8 commits
-
-
Colin Ian King authored
There is a spelling mistake in the documentation and a module parameter description. Fix these. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20191008082205.19740-1-colin.king@canonical.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jérôme Pouiller authored
tx_policy_init() was already defined in driver cw1200. So, compilation failed when wfx and cw1200 were both built-in. In order to keep a coherent naming scheme, this patch prefixes all "tx_policy_*" functions with "wfx_". Fixes: 9bca45f3 ("staging: wfx: allow to send 802.11 frames") Reported-by:
kbuild test robot <lkp@intel.com> Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20191008094232.10014-8-Jerome.Pouiller@silabs.comSigned-off-by:
-
Jérôme Pouiller authored
Most of calls to BUG_ON() could replaced by WARN(). By the way, this patch also try to favor WARN() (that include a comment about the problem) instead of WARN_ON(). Reported-by:
Andrew Lunn <andrew@lunn.ch> Signed-off-by:
-
Jérôme Pouiller authored
On error, copy_to_user() returns number of bytes remaining. Driver should return -EFAULT. Fixes: 4f8b7fab ("staging: wfx: allow to send commands to chip") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Jérôme Pouiller authored
When built for a big-endian target, original code caused error: include/uapi/linux/swab.h:242:29: note: expected '__u32 * {aka unsigned int *}' but argument is of type 'struct hif_mib_protected_mgmt_policy *' Fixes: f95a29d4 ("staging: wfx: add HIF commands helpers") Reported-by:Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
Jérôme Pouiller authored
Original code caused an (100% reproducible) invalid memory access on big-endian targets. Fixes: b0998f0c "staging: wfx: add IRQ handling" Reported-by:
-
Jérôme Pouiller authored
Indeed, hif_msg->id is a uint8_t, so use of cpu_to_le16() is a madness. Fixes: 9bca45f3 ("staging: wfx: allow to send 802.11 frames") Reported-by:
-
Jérôme Pouiller authored
Original code did not handle case where kmalloc failed. By the way, it is more convenient to allocate and build HIF message in hif_set_beacon_filter_table() instead of to ask to caller function to build it. Fixes: 40115bbc ("staging: wfx: implement the rest of mac80211 API") Reported-by:
-
- 07 Oct, 2019 17 commits
-
-
Thomas Meyer authored
Use lib/crc32 instead of another implementation. Signed-off-by:
Thomas Meyer <thomas@m3y3r.de> Link: https://lore.kernel.org/r/20191006140745.9952-1-thomas@m3y3r.deSigned-off-by:
-
Hariprasad Kelam authored
fix below issue reported by coccicheck drivers/staging//vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:139 WARNING: Use devm_platform_ioremap_resource for g_regs Signed-off-by:
Hariprasad Kelam <hariprasad.kelam@gmail.com> Link: https://lore.kernel.org/r/1570353394-9991-1-git-send-email-hariprasad.kelam@gmail.comSigned-off-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_mlme.c: In function rtw_select_roaming_candidate: drivers/staging/rtl8723bs/core/rtw_mlme.c:2007:18: warning: variable adapter set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
zhengbin <zhengbin13@huawei.com> Link: https://lore.kernel.org/r/1570352999-45790-6-git-send-email-zhengbin13@huawei.comSigned-off-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_recv.c: In function validate_80211w_mgmt: drivers/staging/rtl8723bs/core/rtw_recv.c:1415:8: warning: variable ppp set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/core/rtw_recv.c: In function validate_80211w_mgmt: drivers/staging/rtl8723bs/core/rtw_recv.c:1403:5: warning: variable type set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/core/rtw_recv.c: In function recvframe_defrag: drivers/staging/rtl8723bs/core/rtw_recv.c:1713:6: warning: variable data set but not used [-Wunused-but-set-variable] They are not used since commit 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Reported-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_security.c: In function rtw_tkip_encrypt: drivers/staging/rtl8723bs/core/rtw_security.c:660:6: warning: variable prwskeylen set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/core/rtw_security.c: In function rtw_tkip_decrypt: drivers/staging/rtl8723bs/core/rtw_security.c:768:6: warning: variable prwskeylen set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/core/rtw_security.c: In function rtw_aes_encrypt: drivers/staging/rtl8723bs/core/rtw_security.c:1528:6: warning: variable prwskeylen set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Reported-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_sta_mgt.c: In function rtw_alloc_stainfo: drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:190:7: warning: variable tmp_aid set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Reported-by:
-
Gabriela Bittencourt authored
Cleans up checks of "Alignment should match open parenthesis" Signed-off-by:
Gabriela Bittencourt <gabrielabittencourt00@gmail.com> Link: https://lore.kernel.org/r/20191007003902.21911-1-gabrielabittencourt00@gmail.comSigned-off-by:
-
Javier F. Arias authored
Switch constant place as it should be on the right side of the test. Issue found by checkpatch. Signed-off-by:
Javier F. Arias <jarias.linux@gmail.com> Link: https://lore.kernel.org/r/20191007033202.45czxuochtylkddf@gmail.comSigned-off-by:
-
Gabriela Bittencourt authored
Cleans up warnings of "line over 80 characters" Signed-off-by:
-
Javier F. Arias authored
Remove braces that are not necessary for any arm of this statement. Issue found by checkpatch. Signed-off-by:
-
Gabriela Bittencourt authored
Cleans up checks of "don't use multiple blank line" Signed-off-by:
Quentin Deslandes <quentin.deslandes@itdev.co.uk> Link: https://lore.kernel.org/r/20191006195854.9843-1-gabrielabittencourt00@gmail.comSigned-off-by:
-
Sergio Paracuellos authored
Depending on revision of the chip, reset lines are inverted. Make code more readable making use of 'soc_device_match' in driver probe function. Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Link: https://lore.kernel.org/r/20191006181032.19112-1-sergio.paracuellos@gmail.comSigned-off-by:
-
Sumera Priyadarsini authored
Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter. Reported-by:
Sumera Priyadarsini <sylphrenadin@gmail.com> Link: https://lore.kernel.org/r/20191006105300.10181-1-sylphrenadin@gmail.comSigned-off-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/hal/sdio_ops.c: In function sdio_read_port: drivers/staging/rtl8723bs/hal/sdio_ops.c:430:6: warning: variable oldcnt set but not used [-Wunused-but-set-variable] It is not used since commit dedf215b ("staging: rtl8723bs: remove unused code") Reported-by:
-
Michael Straube authored
Variable badworden is asigned in two subsequent lines. So the first asignment is useless and not needed. Also the initialization to zero is not needed. Remove the first asignment and the initialization. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20191005141852.88712-1-straube.linux@gmail.comSigned-off-by:
-
Adham Abozaeid authored
WILC doesn't support per-vif tx power, and hence, wdev will always be null in calls to set_tx_power. Instead, wiphy should be used to execute the operation Signed-off-by:
Adham Abozaeid <adham.abozaeid@microchip.com> Link: https://lore.kernel.org/r/20191004214011.7623-1-adham.abozaeid@microchip.comSigned-off-by:
-
Javier F. Arias authored
Remove unnecessary braces for single statement block. Issue found by checkpatch. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Link: https://lore.kernel.org/r/20191006133016.GA22297@gmail.comSigned-off-by:
-
- 04 Oct, 2019 15 commits
-
-
Benjamin Poirier authored
When operating at mtu 9000, qlge does order-1 allocations for rx buffers in atomic context. This is especially unreliable when free memory is low or fragmented. Add an approach similar to commit 3161e453 ("virtio: net refill on out-of-memory") to qlge so that the device doesn't lock up if there are allocation failures. Signed-off-by:
Benjamin Poirier <bpoirier@suse.com> Link: https://lore.kernel.org/r/20190927101210.23856-18-bpoirier@suse.comSigned-off-by:
-
Benjamin Poirier authored
Reading the {s,l}bq_prod_idx registers on a running device, it appears that the adapter will only use buffers up to prod_idx & 0xfff0. The driver currently uses fixed-size guard zones (16 for sbq, 32 for lbq - don't know why this difference). After the previous patch, this approach no longer guarantees prod_idx values aligned on multiples of 16. While it appears that we can write unaligned values to prod_idx without ill effects on device operation, it makes more sense to change qlge_refill_bq() to refill up to a limit that corresponds with the device's behavior. Signed-off-by: -
Benjamin Poirier authored
Currently, if we repeatedly fail to allocate all of the buffers from the desired batching budget, we will never update the prod_idx register. Restructure code to always update prod_idx if new buffers could be allocated. This eliminates the current two stage process (clean_idx -> prod_idx) and some associated bookkeeping variables. Signed-off-by:
-
Benjamin Poirier authored
Instead of clearing the structure wholesale, it is sufficient to initialize the skb member which is used to manage sbq instances. lbq instances are managed according to curr_idx and clean_idx. Signed-off-by:
-
Benjamin Poirier authored
This just repeats what the other memset a few lines above did. Signed-off-by:
-
Benjamin Poirier authored
Given the way the driver currently works, these values are always known at compile time. Signed-off-by:
-
Benjamin Poirier authored
Given that (u16) 65536 == 0, that expression can be replaced by a simple cast. Signed-off-by:
-
Benjamin Poirier authored
This field is redundant, the type can be determined from the index, cq_id. Signed-off-by:
-
Benjamin Poirier authored
Using the unmap addr elsewhere than unmap calls is a misuse of the dma api. In prevision of this fix, qlge kept two copies of the dma address around ;) Fixes: c4e84bde ("qlge: New Qlogic 10Gb Ethernet Driver.") Fixes: 7c734359 ("qlge: Size RX buffers based on MTU.") Fixes: 2c9a266a ("qlge: Fix receive packets drop.") Signed-off-by:
-
Benjamin Poirier authored
The qlge driver (and device) uses two kinds of buffers for reception, so-called "small buffers" and "large buffers". The two are arranged in rings, the sbq and lbq. These two share similar data structures and code. Factor out data structures into a common struct qlge_bq, make required adjustments to code and dedup the most obvious cases of copy/paste. This patch should not introduce any functional change other than to some of the printk format strings. Signed-off-by:
-
Benjamin Poirier authored
This is unneeded for two reasons: 1) the cpu does not write data for the device in the mapping 2) calls like ..._sync_..._for_device(..., ..._FROMDEVICE) are nonsensical, see commit 3f0fb4e8 ("Documentation/DMA-API-HOWTO.txt: fix misleading example") Signed-off-by:
-
Benjamin Poirier authored
Tx completion rings have sbq_buf_size = 0 but there's no case where the code actually tests on that value. We can remove sbq_buf_size and use a constant instead. Signed-off-by:
Willem de Bruijn <willemb@google.com> Link: https://lore.kernel.org/r/20190927101210.23856-7-bpoirier@suse.comSigned-off-by:
-
Benjamin Poirier authored
The size of the mapping is known statically in all cases, there's no need to save it at runtime. Remove this member. Signed-off-by:
Manish Chopra <manishc@marvell.com> Link: https://lore.kernel.org/r/20190927101210.23856-6-bpoirier@suse.comSigned-off-by:
-
Benjamin Poirier authored
lbq_buf_size is duplicated to every rx_ring structure whereas lbq_buf_order is present once in the ql_adapter structure. All rings use the same buf size, keep only one copy of it. Also factor out the calculation of lbq_buf_size instead of having two copies. Signed-off-by:
-
Benjamin Poirier authored
As already done in ql_get_curr_lchunk(), this member can be replaced by a simple test. Signed-off-by:
-
