- 11 Oct, 2019 11 commits
-
-
Wambui Karuga authored
Remove variable assignment in if statements in drivers/staging/isdn/avm/b1.c. Issues reported by checkpatch.pl as: ERROR: do not use assignment in if condition Also refactor code around some if statements to remove comparisons to NULL and unnecessary braces in single statement blocks. Signed-off-by:
Wambui Karuga <wambui.karugax@gmail.com> Link: https://lore.kernel.org/r/20191011072044.7022-1-wambui.karugax@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jules Irenge authored
Fix comparison to NULL by replacing with !ptr instead. Issue detected by checkpatch. Signed-off-by:
Jules Irenge <jbi.octave@gmail.com> Link: https://lore.kernel.org/r/20191010214006.23677-4-jbi.octave@gmail.comSigned-off-by:
-
Jules Irenge authored
Add space to fix warning of preferred space near the division operator issue detected by checkpatch. Signed-off-by:
-
Jules Irenge authored
Fix multiple assignments warning " check issue detected by checkpatch tool: "CHECK: multiple assignments should be avoided". Signed-off-by:
-
Jules Irenge authored
Fix "alignment should mactch open parenthesis" checks issued by checkpatch.pl tool: "CHECK: Alignment should match open parenthesis". Signed-off-by:
-
Jules Irenge authored
Fix a misspelling of "several" detected by checkpatch Signed-off-by:
-
YueHaibing authored
Null check before kfree is redundant, so remove it. This is detected by coccinelle. Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Link: https://lore.kernel.org/r/20191010153325.16836-1-yuehaibing@huawei.comSigned-off-by:
-
Wambui Karuga authored
Remove multiple blank lines in drivers/staging/rtl8723bs/core/rtw_mlme.c. Issues reported by checkpatch.pl as: CHECK: Please don't use multiple blank lines Signed-off-by:
-
Wambui Karuga authored
Remove comparisons to true and false in multiple if statements in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by:
-
Wambui Karuga authored
Clean up multiple unnecessary braces around single statement blocks in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: WARNING: braces {} are not necessary for single statement blocks or WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: -
Wambui Karuga authored
Remove most comparisons to NULL in conditionals in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Comparison to NULL could be written Signed-off-by:
-
- 10 Oct, 2019 28 commits
-
-
Colin Ian King authored
There is a spelling mistake in a dev_warn message. Fix it. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20191010095748.17047-1-colin.king@canonical.comSigned-off-by:
-
Nachammai Karuppiah authored
Remove NULL comparison. Issue found using checkpatch.pl Signed-off-by:
Nachammai Karuppiah <nachukannan@gmail.com> Link: https://lore.kernel.org/r/1570589056-14386-1-git-send-email-nachukannan@gmail.comSigned-off-by:
-
YueHaibing authored
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by:
-
YueHaibing authored
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by:
-
Wambui Karuga authored
Fix the following warning generated by sparse in drivers/staging/octeon/ethernet-tx.c: drivers/staging/octeon/ethernet-tx.c:563:50: warning: incorrect type in assignment (different base types) drivers/staging/octeon/ethernet-tx.c:563:50: expected unsigned short [usertype] hw_chksum drivers/staging/octeon/ethernet-tx.c:563:50: got restricted __wsum [usertype] csum Warning generated by running: make C=2 CF="-D__CHECK_ENDIAN__" drivers/staging/octeon/ Signed-off-by:
-
Wambui Karuga authored
Fixes checkpatch.pl "CHECK Alignment should match open parenthesis" on drivers/staging/rtl8712/rtl8712_recv.c:122 Signed-off-by:
-
Javier F. Arias authored
Fix the style in definitions where commented code was previously removed for an improved code readability. Signed-off-by:
Javier F. Arias <jarias.linux@gmail.com> Link: https://lore.kernel.org/r/fc488562c0ddf3fa8a59e86be9b33506496ccd0c.1570672544.git.jarias.linux@gmail.comSigned-off-by:
-
Javier F. Arias authored
Remove space before tabs to fix checkpatch warning. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Remove duplicate blank lines. Signed-off-by:
-
Javier F. Arias authored
Remove commented code for a cleaner file. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix incorrect type in declaration to solve the warnings 'incorrect type in argument 2' in the rtw_get_wpa_ie and rtw_get_wpa_ie function calls, as both expect the same variable in argument 2 with the type int *. Issue found by Sparse. Signed-off-by:
-
Javier F. Arias authored
Concatenated strings should use spaces between elements. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix the wrapping style used for the function call. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Break last two function call arguments into two separate lines. Issue found by checkpatch. Signed-off-by:
-
Hans de Goede authored
rtl8723bs had 2 private file operation helpers: rtw_is_file_readable() rtw_retrive_from_file() These were only used by the removed phy_Config*WithParaFile() functions, so they can be removed now. Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20191009123223.163241-5-hdegoede@redhat.comSigned-off-by:
-
Hans de Goede authored
The phy_Config*WithParaFile() functions were the only user of this function. Signed-off-by:
-
Hans de Goede authored
Now that the phy_Config*WithParaFile() functions have been removed nothing is using these module-parameters and defines anymore. Signed-off-by:
-
Hans de Goede authored
These are no longer used, so remove them and also remove various struct definitions only used by these functions. Signed-off-by:
-
Hans de Goede authored
The rtl8723bs driver tries to load various parameters from disk, circumventing the standard firmware loader mechanism and using DIY code for this. No devices which run the mainline kernel ship with these files and even if these files were present then they still would not be loaded without additional module parameters. To be precise the following 3 conditions must all 3 be true for on disk parameters to be used: 1) The rtw_load_phy_file modparam must contain the mask for the type, this defaults to(LOAD_BB_PG_PARA_FILE | LOAD_RF_TXPWR_LMT_PARA_FILE) so with the default settings this condition is only true for: phy_ConfigBBWithPgParaFile() PHY_ConfigRFWithPowerLimitTableParaFile(); and 2) rtw_phy_file_path modparam must be set to say "/lib/firmware/"; and 3) Store a /lib/firmware/rtl8723b/XXX file in the expected format. In practice all 3 being true never happens, so the phy_Config*With*ParaFile() calls are nops, remove them. The actual code implementing them will be removed in a separate patch. Note the ODM_ConfigRFWithHeaderFile() and ODM_ConfigBBWithHeaderFile() functions always return HAL_STATUS_SUCCESS, this patch makes use of this to simplify the new code without the phy_Config*With*ParaFile() calls. Signed-off-by:
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_xmit.c: In function update_attrib: drivers/staging/rtl8723bs/core/rtw_xmit.c:680:7: warning: variable i set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
zhengbin <zhengbin13@huawei.com> Link: https://lore.kernel.org/r/1570578905-95675-1-git-send-email-zhengbin13@huawei.comSigned-off-by:
-
Javier F. Arias authored
Fix warning by removing space before tab. Signed-off-by:
-
Javier F. Arias authored
Replace the hardcoded function name with its predefined identifier. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Link: https://lore.kernel.org/r/20191008214851.p4w7cbpuldnwkne4@gmail.comSigned-off-by:
-
Nachammai Karuppiah authored
Remove typecast in the call to kfree as it is not needed. Issue found using the below coccinelle script with options -I and --recursive-includes, @@ type t1; expression *e; @@ -kfree((t1 *)e); +kfree(e); Signed-off-by:
-
zhengbin authored
Fix sparse warnings: drivers/staging/wfx/sta.c:269:6: warning: symbol 'wfx_update_filtering_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:475:6: warning: symbol 'wfx_event_handler_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:521:6: warning: symbol 'wfx_bss_loss_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:528:6: warning: symbol 'wfx_bss_params_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:539:6: warning: symbol 'wfx_set_beacon_wakeup_period_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:732:6: warning: symbol 'wfx_unjoin_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:794:6: warning: symbol 'wfx_set_cts_work' was not declared. Should it be static? drivers/staging/wfx/sta.c:1234:6: warning: symbol 'wfx_set_tim_work' was not declared. Should it be static? Reported-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/1570629030-29888-4-git-send-email-zhengbin13@huawei.comSigned-off-by:
-
zhengbin authored
Fix sparse warnings: drivers/staging/wfx/queue.c:218:16: warning: symbol 'wfx_tx_queue_get' was not declared. Should it be static? Reported-by:
-
zhengbin authored
Fix sparse warnings: drivers/staging/wfx/fwio.c:83:5: warning: symbol 'sram_write_dma_safe' was not declared. Should it be static? drivers/staging/wfx/fwio.c:229:5: warning: symbol 'load_firmware_secure' was not declared. Should it be static? Reported-by:
-
Colin Ian King authored
The memset appears to have the 2nd and 3rd arguments in the wrong order, fix this by swapping these around into the correct order. Addresses-Coverity: ("Memset fill truncated") Fixes: 4f8b7fab ("staging: wfx: allow to send commands to chip") Signed-off-by: -
Wambui Karuga authored
Remove unnecessary variable `val` in kp_spi_read_reg() that only holds the return value from readq(). Issue found by coccinelle using the script: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by:
-
- 08 Oct, 2019 1 commit
-
-
zhengbin authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/comedi/drivers/dt3000.c: In function dt3k_ai_insn_read: drivers/staging/comedi/drivers/dt3000.c:511:27: warning: variable aref set but not used [-Wunused-but-set-variable] It is not used since commit 2e310235 ("staging: comedi: dt3000: rename dt3k_ai_insn()") Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/1570520515-2186-7-git-send-email-zhengbin13@huawei.comSigned-off-by:
-
