- 27 Aug, 2018 40 commits
-
-
Leon Imhof authored
Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" detected by checkpatch.pl Signed-off-by:
Leon Imhof <leon.imhof@in.tum.de> Reviewed-by:
Gao Xiang <gaoxiang25@huawei.com> Reviewed-by:
Chao Yu <yuchao0@huawei.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Chao Yu authored
As Dan reported in LKP's mailing list: https://lists.01.org/pipermail/kbuild-all/2018-August/051419.html New smatch warnings: drivers/staging/erofs/internal.h:446 erofs_grab_bio() warn: should 'blkaddr << (12 - 9)' be a 64 bit type? drivers/staging/erofs/data.c:78 __erofs_get_meta_page() error: 'bio' dereferencing possible ERR_PTR() drivers/staging/erofs/internal.h:446 erofs_grab_bio() warn: should 'blkaddr << (12 - 9)' be a 64 bit type? Old smatch warnings: drivers/staging/erofs/unzip_vle.c:989 z_erofs_vle_unzip() error: double unlock 'mutex:&z_pagemap_global_lock' drivers/staging/erofs/unzip_vle.c:1318 z_erofs_vle_normalaccess_readpage() warn: should 'page->index << 12' be a 64 bit type? drivers/staging/erofs/unzip_vle.c:1351 __z_erofs_vle_normalaccess_readpages() warn: should '()->index << 12' be a 64 bit type? It needs to cast varable's type to sector_t before left shifting. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
-
Gao Xiang authored
Logical address of EOF LTP mapping should start at `inode->i_size' rather than `inode->i_size - 1' to `m_la(in)', fix it. Signed-off-by:
-
Gao Xiang authored
This patch fixes integer overflow on multiplication of 32-bit `lcn' in z_erofs_map_blocks_iter. Signed-off-by:
-
Gao Xiang authored
This patch adds error handing code, and fixes a missing endian conversion in vle_decompressed_index_clusterofs. Signed-off-by:
-
Gao Xiang authored
This patch moves vle clustertype definitions to erofs_fs.h since they are part of on-disk format. It also adds compile time check for Z_EROFS_VLE_DI_CLUSTER_TYPE_BITS Signed-off-by:
-
Gao Xiang authored
This patch introduces 'struct z_erofs_vle_work_finder' to clean up arguments of z_erofs_vle_work_lookup and z_erofs_vle_work_register. Signed-off-by:
-
Gao Xiang authored
This patch enhances the missing error handling code for xattr submodule, which improves the stability for the rare cases. Signed-off-by:
-
Gao Xiang authored
This patch separates 'erofs_get_meta_page' into 'erofs_get_meta_page' and 'erofs_get_meta_page_nofail'. The second one ensures that it should not fail under memory pressure and should make best efforts if IO errors occur. It also adds auxiliary variables in order to fulfill 80 character limit. Signed-off-by:
-
Gao Xiang authored
this patch renames prepare_bio to erofs_grab_bio, and adds a nofail option in order to retry in the bio allocator under memory pressure. Signed-off-by:
-
Todd Poynor authored
Interrupt types PCI_MSI and PLATFORM_WIRE are unused and unimplemented. Remove these. Signed-off-by:
Todd Poynor <toddpoynor@google.com> Signed-off-by:
-
Todd Poynor authored
Pass the gasket driver descriptor to the interrupt init function, rather than exploding out separate parameters from various fields of that structure. This allows us to make more localized changes to the types of interrupts supported (MSIX vs. wire, etc.) without affecting the calling sequence, and seems nicer for simplification purposes. Signed-off-by:
-
Todd Poynor authored
Split interrupt handler into PCI MSIX-specific and generic functions, for adding non-MSIX handlers in the future. Move MSIX init code together,, out of generic init path. Signed-off-by:
-
Todd Poynor authored
Rename lookup_internal_desc() to lookup_pci_internal_desc() to reflect use for PCI devices only, in prep for non-PCI devices in the future. Signed-off-by:
-
Todd Poynor authored
Separate code for generic parts of gasket device removal sequence from the PCI device removal code, in prep for non-PCI devices later. Signed-off-by:
-
Todd Poynor authored
Split out generic gasket device add code from the code for adding a PCI gasket device, in prep for other gasket device types in the future. Signed-off-by:
-
Todd Poynor authored
Some explicit memory barriers in the page table code are not necessary, either because: (a) The barrier follows a non-relaxed MMIO access that already performs a read or write memory barrier. (b) The barrier follows DMA API calls for which the device-visible effects of IOMMU programming are guaranteed to be flushed to the IOMMU prior to the call returning, and doesn't need to sync with normal memory access. Signed-off-by:
-
Todd Poynor authored
Use of readl() is deprecated; readl_relaxed() with appropriate memory barriers is preferred. Switch to relaxed reads and writes for better performance as well. Memory barriers required for I/O vs. normal memory access on Apex devices have already been explicitly coded in the page table routines. Signed-off-by:
-
Todd Poynor authored
gasket_perform_mapping() call dma_mapping_error() to determine if mapping failed. Signed-off-by:
-
Todd Poynor authored
Remove now-empty gasket_exit() function. Signed-off-by:
-
Todd Poynor authored
Remove debug logs that only indicate the name of the entered function, in favor of using ftrace for function tracing style logs. Signed-off-by:
-
Todd Poynor authored
gasket_alloc_dev can retrieve the device name from the parent parameter, a separate parameter isn't needed for this. Rename the variable to better reflect its meaning, as the name of the parent device for which a gasket device is being allocated. Signed-off-by:
-
Todd Poynor authored
Previous cleanups missed a case of multi-line function call with line continuation parameters not aligned per kernel style. Signed-off-by:
-
Todd Poynor authored
A debug log in gasket_alloc_dev() is issued regardless of whether the device pointer used returned success or error. The log isn't that useful anyway, remove it. Signed-off-by:
Rob Springer <rspringer@google.com> Signed-off-by:
-
Colin Ian King authored
Array cm_mappable_regions is defined but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: 'cm_mappable_regions' defined but not used [-Wunused-const-variable=] Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Sumit Kumar authored
Remove null ptr check before kfree because kfree is null ptr safe. Issue found by checkpatch. Signed-off-by:
Sumit Kumar <sumit686215@gmail.com> Signed-off-by:
-
Leonardo Brás authored
Kernel coding style recommends a space char around "/". Signed-off-by:
Leonardo Brás <leobras.c@gmail.com> Signed-off-by:
-
Nishad Kamdar authored
Removed all usages of INIT_MSG and dropped it from dbg.h. Signed-off-by:
Nishad Kamdar <nishadkamdar@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
There are some printk's which can be replaced properly using dev_* kernel functions. Use dev_info to show N_FTS status for each port using a loop instead of duplicating lines of code. Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
There are some functions in driver code that can be declared 'static'. Just do it. Signed-off-by:
-
Sumit Pundir authored
Placed a check for the return value of sscanf. -EINVAL is returned if the value is anything other than expected. Reported by checkpatch.pl Signed-off-by:
Sumit Pundir <pundirsumit11@gmail.com> Signed-off-by:
-
Bhaskar Singh authored
This patch removed unneeded variable named ret because this variable is used only to return 0. Signed-off-by:
Bhaskar Singh <bhaskar.kernel@gmail.com> Signed-off-by:
-
Bhaskar Singh authored
This patch removed function named rtw_malloc2d. I removed this function because this function is used exactly once and function call have some overhead also. Maybe this will improve code runtime slightly. Signed-off-by:
-
Bhaskar Singh authored
This patch removes support for channels > 14. That is from the TODO which says: -find and remove remaining code valid only for 5HGz. Most of obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by:
-
Bhaskar Singh authored
This patch fix spelling mistakes in TODO. Signed-off-by:
-
John Whitmore authored
Add the missing SPDX-License-Identifier tag to clear the checkpatch issue. This is a coding style change which should not impact runtime code execution. Signed-off-by:
John Whitmore <johnfwhitmore@gmail.com> Signed-off-by:
-
John Whitmore authored
Rename function PHY_SetRF8256OFDMTxPower() to phy_set_rf8256_ofdm_tx_power(), to clear the checkpatch issue with CamelCase naming. This is a coding style change which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
Rename the function PHY_SetRF8256CCKTxPower() to phy_set_rf8256_cck_tx_power(), to clear the checkpatch issue with CamelCase naming. This is a purely coding style change which should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
Rename the function phy_RF8256_Config_ParaFile() to phy_rf8256_config_para_file(). This change clears the checkpatch issue with CamelCase naming. Additionally as the function is only ever used in one file, (r8190_rtl8256.c), the function prototype has been removed from the header file, (r8190_rtl8256.h). These changes are purely coding style in nature and should have no impact on runtime code execution. Signed-off-by:
-
John Whitmore authored
Rename the function PHY_RF8256_Config() to phy_rf8256_config(). This change clears the checkpatch issue with CamelCase naming. This is a simple coding style change which should have no impact on runtime code execution. Signed-off-by:
-
