- 23 Sep, 2004 4 commits
-
-
James Bottomley authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
This was missing. It needs to be added so the module tracking actually works correctly for the driver. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: janitor@sternwelten.at Patches to remove some old ifdefs. remove most of the #include <linux/version.h> kill compat cruft like #define ahd_pci_set_dma_mask pci_set_dma_mask Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: janitor@sternwelten.at Patches to remove some old ifdefs. remove most of the #include <linux/version.h> kill compat cruft like #define ahd_pci_set_dma_mask pci_set_dma_mask Signed-off-by: Maximilian Attems <janitor@sternwelten.at> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 21 Sep, 2004 1 commit
-
-
Christoph Hellwig authored
Acked By: Moore, Eric Dean <emoore@lsil.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 20 Sep, 2004 3 commits
-
-
James Smart authored
In the cases where an LLDD knows that a lun does not exist, if it fails slave_alloc(), the midlayer reports an error message indicating slave_alloc failed. This patch allows the LLDD to reject the slave_alloc() call if it knows the lun doesn't exist, and skips the reporting of the slave_alloc failure message. This avoids jumping through hoops in the LLDD to avoid error messages from slave_alloc. Also saves cycles in that the probe is also cancelled for the non-existent device. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
looks like you applied a premature version of the last aacraid patch. This one moves the scsi_add_host back so it's not called before the driver is ready to accept queued commands. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 19 Sep, 2004 1 commit
-
-
James Bottomley authored
Currently, the only way to issue a SCSI reset of any type is to use the sg device. By adding extra ioctls to scsi_ioctl.c we enable this for all ULDs. The slight complication is that scsi_ioctl() is usually only called when the device has been checked not to be undergoing eh recovery. Resets may be issued in this scenario if the user opens the device O_NONBLOCK. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 17 Sep, 2004 5 commits
-
-
James Bottomley authored
From: Christoph Hellwig <hch@lst.de> kills lots of BSD glue and procfs mess Acked by: Matthew Wilcox <willy@debian.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
On Thu, 2004-09-16 at 14:09, Jesse Barnes wrote: > On Thursday, September 16, 2004 1:56 pm, Andrew Vasquez wrote: > > On Thu, 2004-09-16 at 13:05, Jesse Barnes wrote: > > > On Thursday, September 16, 2004 12:56 pm, Paul Jackson wrote: > > > > Andrew Vasquez has been looking at this, via private email with just > > > > me (no progress yet). Figured I update the larger list with this much > > > > ... > > > > > > It seems to be failing on one of the accesses to PCI_COMMAND in config > > > space in qla2x00_reset_chip(). I'm checking now to see if we're > > > accessing the card right after a reset but before the card has finished. > > > That would cause a master abort, the symptom I'm seeing at least. > > > > Interesting, the only changes in reset_chip() are for PCI posting > > issues. Relevant diff attached. > > Yeah, I think one of these is the culprit. Before I got your message, I fixed > some of them in my tree already (see attached) and things seem to work. > Hmm, seems we were a bit too over-aggressive in placement of the readw()s :( > WRT_REG_WORD(®->hccr, HCCR_CLR_RISC_INT); > + RD_REG_WORD(®->hccr); /* PCI Posting. */ > WRT_REG_WORD(®->hccr, HCCR_CLR_HOST_INT); > + RD_REG_WORD(®->hccr); /* PCI Posting. */ > > /* Reset ISP chip. */ > WRT_REG_WORD(®->ctrl_status, CSR_ISP_SOFT_RESET); > + RD_REG_WORD(®->ctrl_status); /* PCI Posting. */ > > In particular, are the above ok? If the chip is resetting, won't doing a read > cause a machine check (or at the very least, a device select timeout, which > will return all ones on friendlier platforms). > There are several more which deltas in qla_dbg.c which are suspect also. > WRT_REG_WORD(®->ctrl_status, CSR_ISP_SOFT_RESET); > + RD_REG_WORD(®->ctrl_status); /* PCI Posting. */ > > Same here? > Andrew, please add Jesse's patch along with the patch I'm attaching to your tree. I'll be sure to add the ia64 machine back into our test ring. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Jesse Barnes authored
On Thursday, September 16, 2004 1:56 pm, Andrew Vasquez wrote: > On Thu, 2004-09-16 at 13:05, Jesse Barnes wrote: > > On Thursday, September 16, 2004 12:56 pm, Paul Jackson wrote: > > > Andrew Vasquez has been looking at this, via private email with just > > > me (no progress yet). Figured I update the larger list with this much > > > ... > > > > It seems to be failing on one of the accesses to PCI_COMMAND in config > > space in qla2x00_reset_chip(). I'm checking now to see if we're > > accessing the card right after a reset but before the card has finished. > > That would cause a master abort, the symptom I'm seeing at least. > > Interesting, the only changes in reset_chip() are for PCI posting > issues. Relevant diff attached. Yeah, I think one of these is the culprit. Before I got your message, I fixed some of them in my tree already (see attached) and things seem to work. WRT_REG_WORD(®->hccr, HCCR_CLR_RISC_INT); + RD_REG_WORD(®->hccr); /* PCI Posting. */ WRT_REG_WORD(®->hccr, HCCR_CLR_HOST_INT); + RD_REG_WORD(®->hccr); /* PCI Posting. */ /* Reset ISP chip. */ WRT_REG_WORD(®->ctrl_status, CSR_ISP_SOFT_RESET); + RD_REG_WORD(®->ctrl_status); /* PCI Posting. */ In particular, are the above ok? If the chip is resetting, won't doing a read cause a machine check (or at the very least, a device select timeout, which will return all ones on friendlier platforms). WRT_REG_WORD(®->ctrl_status, CSR_ISP_SOFT_RESET); + RD_REG_WORD(®->ctrl_status); /* PCI Posting. */ Same here? Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Mark Haverkamp authored
Changed the managing of aac device structures to a linked list so that there is no limit to how many adapters can be configured. Also, put the call to scsi_add_host earlier in the probe function, before devices are accessed. Signed-off-by: Mark Haverkamp <markh@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Andi Kleen <ak@suse.de> Patch updated by: Christoph Hellwig <hch@infradead.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 16 Sep, 2004 6 commits
-
-
James Bottomley authored
From: Jeremy Higdon <jeremy@sgi.com> Add blacklist attribute to disable ULD attachment to a lun, and use that attribute for SGI-branded Engenio UTM luns. Minor rejection fixes and Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Kai Mäkisara authored
> Date: Tue, 14 Sep 2004 20:18:00 +0200 > From: Christoph Hellwig <hch> > Subject: [PATCH] avoid obsolete "scsi.h" APIs in st > > no actual behaviour changes, just update to the less obsfucated 2.6+ > APIs. > Looks good to me but did not link when DEBUG was set to 1: one print_req_sense() conversion was missed. This is corrected in the patch at the end of this message. Signed-off-by: Kai Makisara <kai.makisara@kolumbus.fi> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
Due to the prototype changes they'd been giving warnings since before 2.6.0 was release, it's time to finally kill them. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Christoph Hellwig authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Arjan van de Ven authored
it seems scsi_add_host() is one of those functions that a driver really has to check the return value of, but several forget to do this. Patch below marks it __must_check which will cause a warning in this case (with gcc 3.4 and later).. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 13 Sep, 2004 4 commits
-
-
Adam Radford authored
- Make tw_check_bits() static. - Add MODULE_VERSION support. - Fix ioctl path to use dma_alloc/free_coherent() instead of pci_alloc/free_consistent(). - Remove error variable from ioctl code causing confusion. retval defaults to -EFAULT, any copy_to/from_user() that returns non zero returns -EFAULT. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Mark Haverkamp authored
From: Mark Salyzyn at Adaptec In the case of this driver patch, we will report to the user via a syslogd kernel message that a foreign array has been ignored in non-intel environments; or intel environments where the BIOS fails to load to perform this set of housekeeping functions. There is a provision, via the commit variable, to change this behavior to accept the configuration instead. Signed-off-by: Mark Haverkamp <markh@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Matthew Wilcox authored
2.1.18k: - Relicence from dual BSD/GPL to pure GPL - Add my copyright to various files - Remove unnecessary MDELAY calls after printfs - Rename remaining MDELAY() to mdelay(), delete MDELAY and sym_mdelay macros - Restructure PCI initialisation to not disable chips that are part of Mylex RAID cards. - Make SYM_OPT_NVRAM_PRE_READ non-optional. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 12 Sep, 2004 2 commits
-
-
Christoph Hellwig authored
So actually I have a patch that starts to remove internal queueing from tmscsim. This gets rid of internal queueing for those cases where we can just make the midlayer do the the work by returning erros from ->queuecommand (and cleans up the tmscsim queuecommand implementation singnificantly). Next step would get rid of the more complicated internal queueing where we need to make the scsi layer requeue by returning appropinquate DID_ values from ->scsidone. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
it uses TCQ defines but doesn't include scsi/scsi_tcq.h Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 11 Sep, 2004 1 commit
-
-
Andrew Morton authored
This must have had a ton of testing. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
- 10 Sep, 2004 13 commits
-
-
James Bottomley authored
From: Hammer, Jack <Jack_Hammer@adaptec.com> - Fix path/name for scsi_hosts.h include for 2.6 kernels - Fix sort order of 7k - Remove 3 unused "inline" functions Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
sizeof() != int Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Douglas Gilbert <dougg@torque.net> The patch only touches two files: scsi.h and scsi_lib.c It adds the proposed facility and then uses it in scsi_lib in roughly 4 locations. IMO there were 3 sense processing errors: - block SG_IO did not get passed back deferred errors [SG_IO is a __pass-through__ interface!!] - MEDIUM_ERRORs _do_ get processed for deferred sense errors in scsi_io_completion() which seems unintended [I did not fix this one.] - invalid command operation code handling in __scsi_mode_sense() was just wrong If people think this is a reasonable approach, then the rest of the scsi mid-level and upper level driver could be converted. As Kai pointed we may need some general routines to pick up the sense data "extras". The benefit of doing this conversion is that it may well highlight a lot more sense data processing errors (if the above is any guide). Changes: - add structure to receive normalized sense data from either fixed or descriptor format sense data - add scsi_normalize_sense() function to populate that structure - add scsi_sense_is_deferred() function so deferred errors can be ignored in many contexts - apply new mechanism to sense data processing within the scsi_lib.c file Patch reformatted by: Christoph Hellwig <hch@lst.de> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Douglas Gilbert authored
Douglas Gilbert wrote: > It has been reported that the change to sg.c in lk 2.6.9-rc1-bk5 > to use library jiffy functions breaks sg (albeit under vmware). > Evidentally sg devices are no longer recognised after that change. > > Reverting that changeset removes the problem. Strange, it is not > obvious why. > > At some stage I must have detected negative time spans (yeh yeh it > never happens) and my versions returned 0 in this case; otherwise > the implementations look very similar. The following patch fixes the problem. It is against lk 2.6.9-rc1-bk7 (i.e. after "standard" jiffy_to_millisecs macros replaced sg versions). Change: - make sure a (large) user supplied timeout value does not result in a negative timeout passed to the midlevel Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
Olaf Hering noticed that SG_IO was no-longer working correctly on some CD-ROMS. The reason is a change in behaviour induced by switching to the new scsi_test_unit_ready() API. Apparently the CD-ROM special case needs to ignore both UNIT_ATTENTION and NOT_READY for removable media. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Adam Radford authored
- Remove deprecated SCSI_IOCTL_SEND_COMMAND interface. - Remove deprecated /proc/scsi/3w-xxxx interface. - Convert entire driver to pci_driver format. - Remove all mdelays, replace w/msleep to fix possible watchdog timer issues. - Make all register accesses macros. - Remove all prototypes from header file, reorder functions to eliminate all prototypes but one. - Add sysfs 'queue_depth' setting attribute. - Add sysfs 'stats' attribute. - Fix spinlocks everywhere, remove tw_lock spinlock. - Remove all bitfields, add bitmask access macros. - Remove un-needed scsi_eh_abort entrypoint. Controller does not support aborting invididual IO's, scsi_eh_reset sufficient. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
Update version number to 8.00.00b21-k. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Andrew Vasquez <andrew.vasquez@qlogic.com> Resync with latest released firmware -- 3.03.02 Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
Rework interrupt-handler registration in anticipation of future chip types. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
o Always set an TCQ modifier for each command submitted. o Always (re)-initialize NVRAM during execution. o Add pci_disable_device() calls to proper locations during pci-probe failure and pci-remove. o Do not begin processing until the DPC has been marked 'active'. o Fix off-by-one error while copying sense-data. o Fix bus-reset issue during back-door execution. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
James Bottomley authored
From: Andrew Vasquez <andrew.vasquez@qlogic.com> Rework driver DMA allocations to use the DMA pool APIs to minimize potential run-time allocation failures. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Fixed up rejections and replaced the schedule_timeout's in the patch with msleep Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-
Andrew Vasquez authored
Dynamically resize request-queue during initialization based on the amount of memory available to the ISP. Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-