- 23 Nov, 2015 1 commit
-
-
Sudip Mukherjee authored
kzalloc() can return NULL if it fails, and then we will be dereferencing a NULL pointer. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
Mark Brown <broonie@kernel.org>
-
- 22 Nov, 2015 2 commits
-
-
Vinod Koul authored
Since driver use infoframe symbols from video/hdmi.c we should select this symbol for this driver Reported-by:
kbuild test robot <fengguang.wu@intel.com> Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
-
Vinod Koul authored
Skylake driver uses snd_dma_buffer for data and buffer, these are variables and not pointer so do not test field addresses. Reported-by:
-
- 21 Nov, 2015 8 commits
-
-
Subhransu S. Prusty authored
Use the component framework to keep the display on till the playback in progress. Signed-off-by:
Subhransu S. Prusty <subhransu.s.prusty@intel.com> Signed-off-by:
-
Subhransu S. Prusty authored
This patch uses hdmi framework in video to fill audio infoframe. Signed-off-by:
-
Subhransu S. Prusty authored
The DAI ops are used for triggering HDMI streams and configuring the parameters Signed-off-by:
-
Subhransu S. Prusty authored
Power up/down the AFG node during runtime resume/suspend. Signed-off-by:
-
Subhransu S. Prusty authored
This adds HDA based HDMI driver to be used in platforms like SKL and onwards Register the hdmi driver with hda bus and register dais. Also parse the widget and initialize identified pin and converter widgets. For simplification, currently only one pin and one converter widget are enabled on board, as well as limit the rates supported to simples ones and not based on ELD. This things will come eventually once basic support for this is merged Signed-off-by:
-
Mark Brown authored
Merge branch 'topic/hdac' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into asoc-intel
-
Subhransu S. Prusty authored
This extends the structure definition of ext_device and adds definition for dma_params which will be used when hdmi codec. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Signed-off-by:
-
Dan Carpenter authored
"data" is always NULL in this function. I think we should be passing "&data" to sst_prepare_and_post_msg() instead of "data". Fixes: 3d9ff346 ('ASoC: Intel: sst: add stream operations') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Tested-by:
Dinesh Mirche <dinesh.mirche@intel.com> Acked-by:
-
- 20 Nov, 2015 2 commits
-
-
Vinod Koul authored
sound card rtd was an array and was updated to a list so update the driver to use a list Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
Mark Brown authored
Merge branch 'topic/pcm-list' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into asoc-intel
-
- 18 Nov, 2015 15 commits
-
-
Jeeja KP authored
The PM ops are required so that DAPM will suspend and resume the DSP pipelines properly Signed-off-by:
Jeeja KP <jeeja.kp@intel.com> Signed-off-by:
-
Vinod Koul authored
In ref configuration for Skylake, we support only 16bit, 48KHz, stereo audio, so specify these as constrains for the devices Signed-off-by:
-
Jeeja KP authored
This patch fixes the below warning form smatch and makes the skl_tplg_bind_sinks take the next sink as argument which is true when the current sink is valid sound/soc/intel/skylake/skl-topology.c:453 skl_tplg_bind_sinks() error: we previously assumed 'sink' could be null (see line 452) sound/soc/intel/skylake/skl-topology.c 451 452 if (!sink) ^^^^ New check. Reversed? 453 return skl_tplg_bind_sinks(sink, skl, src_mconfig); ^^^^ This is dereferenced inside the function. 454 455 return 0; Reported-by: -
Jeeja KP authored
When downloading the firmware/module, if the ring buffer boundary is reached, we need to wrap to the zeroth position. On next copy we need to copy till end of buffer and the remaining buffer needs to be copied from zeroth position. In this case copy was not handled correctly when wrap condition is reached which caused invalid data to be copied resulting in invalid hash failure. This patch fixes the issue by handling copy at the boundary condition correctly. Signed-off-by:
-
Jeeja KP authored
Sometimes firmware D3 IPC fails causing firmware to be in invalid state. To recover we need to reset the DSP and then shut it down, so don't return on error and continue resetting to recover. On D0, firmware will be redownloaded and DSP will be back in clean state Signed-off-by:
-
Jeeja KP authored
During firmware download, dma buffers are allocated in prepare and never freed on clean up. This patch frees the allocated dma buffer in cldma controller clean up. Signed-off-by:
-
Jeeja KP authored
Since we call _skl_resume which also initializes the chip we no need to call these explicitly, so remove the duplication Signed-off-by:
-
Jeeja KP authored
For HDA codecs WAKEENABLE bit is to programmed if codec event change has to wake the system when suspended. In skylake I2S systems which are currently supported we have only HDMI codec, which doesn't use this capability to detect a HDMI connect/ disconnect event. HDMI HDA codec uses display interface to detect connect/disconnect event. This patch removes the WAKEBIT enabling during device D0/D3 as this seems to cause spurious wakes on the system Signed-off-by:
-
Jeeja KP authored
The ASoC core already does pm_runtime_get/put in the core before opening/closing the devices. So we do not need to do this is driver, hence remove Signed-off-by:
-
Fang, Yang A authored
This patch adds skl_nau8825_ssn4567_i2s machine driver into machine table Signed-off-by:
Fang, Yang A <yang.a.fang@intel.com> Signed-off-by:
-
Harsha Priya authored
Add i2s machine driver with NAU88L25 and SSM4567 codecs Signed-off-by:
Harsha Priya <harshapriya.n@intel.com> Signed-off-by:
Conrad Cooke <conrad.cooke@intel.com> Signed-off-by:
Naveen M <naveen.m@intel.com> Signed-off-by:
Sathya Prakash M R <sathya.prakash.m.r@intel.com> Signed-off-by:
Yong Zhi <yong.zhi@intel.com> Signed-off-by:
Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Signed-off-by:
-
Jeeja KP authored
Adds new BE cpu dai to support SSP1 port. Signed-off-by:
-
Mengdong Lin authored
Currently the number of DAI links is statically defined by the machine driver at build time using an array. This makes it difficult to shrink/ grow the number of DAI links at runtime in order to reflect any changes in topology. We can change the DAI link array in the core to a list so that PCMs and FE DAI links can be added and deleted at runtime to reflect changes in use case and DSP topology. The machine driver can still register DAI links as an array. As the 1st step, this patch change the PCM runtime array to a list. A new PCM runtime is added to the list when a DAI link is bound successfully. Later patches will further implement the DAI link list. More: - define snd_soc_new/free_pcm_runtime() to create/free a runtime. - define soc_add_pcm_runtime() to add a runtime to the rtd list. - define soc_remove_pcm_runtimes() to clean up the runtime list. - traverse the rtd list to probe the link components and dais. - Add a field "num" to PCM runtime struct, used to specify the device number when creating the pcm device, and for a soc card to access its dai_props array. - The following 3rd party machine/platform drivers iterate the rtd list to check the runtimes: sound/soc/intel/atom/sst-mfld-platform-pcm.c sound/soc/intel/boards/cht_bsw_rt5645.c sound/soc/intel/boards/cht_bsw_rt5672.c sound/soc/intel/boards/cht_bsw_max98090_ti.c Signed-off-by:
Mengdong Lin <mengdong.lin@linux.intel.com> Signed-off-by:
-
Mengdong Lin authored
Vendor drivers no longer access a DAI link's runtime by the link index but by matching the link name via snd_soc_get_pcm_runtime(). We assume each DAI link has a unique name. This is preparation for changing runtimes from an array to a list later. Vendor drivers changed: sound/soc/fsl/fsl-asoc-card.c sound/soc/fsl/imx-wm8962.c sound/soc/pxa/mioa701_wm9713.c sound/soc/samsung/bells.c sound/soc/samsung/littlemill.c sound/soc/samsung/odroidx2_max98090.c sound/soc/samsung/snow.c sound/soc/samsung/speyside.c sound/soc/samsung/tobermory.c sound/soc/tegra/tegra_wm8903 Signed-off-by:
-
Vinod Koul authored
The i2c is dependency for the i2c codec drivers, so machine should depend on i2c. WIthout this we get build failures if I2C is not selected sound/soc/codecs/rl6347a.c: In function 'rl6347a_hw_write': >> sound/soc/codecs/rl6347a.c:66:8: error: implicit declaration of function >> 'i2c_master_send' [-Werror=implicit-function-declaration] ret = i2c_master_send(client, data, 4); ^ sound/soc/codecs/rl6347a.c: In function 'rl6347a_hw_read': >> sound/soc/codecs/rl6347a.c:114:8: error: implicit declaration of function >> 'i2c_transfer' [-Werror=implicit-function-declaration] ret = i2c_transfer(client->adapter, xfer, 2); Reported-by:
-
- 16 Nov, 2015 12 commits
-
-
Julia Lawall authored
The sst_block_ops structure is never modified, and is thus declared as const. Done with the help of Coccinelle. Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Acked-by:
Jie Yang <yang.jie@intel.com> Signed-off-by:
-
Vinod Koul authored
The firmware name is hard coded which doesnt allow to load different platforms for various platforms so get this name from available machine table and pass it to dsp context for loading Signed-off-by:
-
Vinod Koul authored
In order to pass the fw name to IPC driver for loading fw, we need to add a memeber to store the fw name Signed-off-by:
-
Vinod Koul authored
Now that we have common match code in place, update the SKL driver to use the common match routines for driver entry creation for UEFI BIOS systems Signed-off-by:
Omair M Abdullah <omair.m.abdullah@intel.com> Signed-off-by:
-
Vinod Koul authored
This patch moves the atom driver to use the common acpi match functions. Since atom driver has few more information in machine table, these are appended to table and set to NULL for common driver Signed-off-by:
-
Vinod Koul authored
This code to find the machine is common for all drivers so move it to a separate file and header for use in other drivers Signed-off-by:
-
Vinod Koul authored
MCPS free was being done from PGA context which will free up MCPS for only last modules in a pipe and not the rest causing MCPS leak and eventual audio loss due to no "free" MCPS. This needs to be freed for every module while cleaning up the modules, so move the check to skl_tplg_mixer_dapm_post_pmd_event() Signed-off-by:
Mohan Krishna Velaga <mohan.krishnax.velaga@intel.com> Signed-off-by:
-
Vinod Koul authored
Smatch warns that we dereferenced substream before check, so fix this by initializing ebus after the check sound/soc/intel/skylake/skl-pcm.c:802 skl_get_position() warn: variable dereferenced before check 'substream->runtime' Reported by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: -
Subhransu S. Prusty authored
This patch fixes the below warning reported by Dan by invoking skl_sst_dsp_cleanup() in cleanup path on error and not bailing out sound/soc/intel/skylake/skl-sst.c:270 skl_sst_dsp_init() info: ignoring unreachable code. Reported-by:
-
Vincent Stehlé authored
The size of the pointer to a data structure to send is erroneously passed to sst_ipc_tx_message_wait() as its tx_bytes argument. It should be given the size of the pointed skl_ipc_dxstate_info structure instead. Coincidentally, both the pointer and the structure have the same size of 8 bytes on a 64 bit machine, which "masks" the issue. Compiling for 32 bit reveals the issue more clearly. Fix the typo for correctness, and to make the code robust to future evolutions of the skl_ipc_dxstate_info structure size. This fixes the following coccicheck error: sound/soc/intel/skylake/skl-sst-ipc.c:641:8-14: ERROR: application of sizeof to pointer Signed-off-by:
Vincent Stehlé <vincent.stehle@laposte.net> Cc: Subhransu S. Prusty <subhransu.s.prusty@intel.com> Cc: Jeeja KP <jeeja.kp@intel.com> Cc: Vinod Koul <vinod.koul@intel.com> Cc: Mark Brown <broonie@kernel.org> Cc: trivial@kernel.org Signed-off-by:
-
Jeeja KP authored
SSP0 FMT uses 24 bits so fix to the value to 24 bits Signed-off-by:
-
Jeeja KP authored
The driver runtime behaviour is fine but in suspend, we missed setting the DSP to suspend and also missed resuming DSP on resume. Fix this by having common SKL suspend and resume routines which power up/down links, suspend/resume DSP and other common routines, and call these routines from both runtime as well as system PM handlers Signed-off-by:
Jayachandran B <jayachandran.b@intel.com> Signed-off-by:
-
