- 08 Feb, 2016 40 commits
-
-
Rom Lemarchand authored
Include <linux/types.h> into ashmem.h to ensure referenced types are defined Cc: Android Kernel Team <kernel-team@android.com> Cc: Greg KH <gregkh@linuxfoundation.org> Signed-off-by:
Rom Lemarchand <romlem@android.com> [jstultz: Minor commit message tweaks] Signed-off-by:
John Stultz <john.stultz@linaro.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Laura Abbott authored
Both ashmem_mmap and ashmem_shrink take the ashmem_lock. It may be possible for ashmem_mmap to invoke ashmem_shrink: -000|mutex_lock(lock = 0x0) -001|ashmem_shrink(?, sc = 0x0) <--- try to take ashmem_mutex again -002|shrink_slab(shrink = 0xDA5F1CC0, nr_pages_scanned = 0, lru_pages -002|= -002|124) -003|try_to_free_pages(zonelist = 0x0, ?, ?, ?) -004|__alloc_pages_nodemask(gfp_mask = 21200, order = 1, zonelist = -004|0xC11D0940, -005|new_slab(s = 0xE4841E80, ?, node = -1) -006|__slab_alloc.isra.43.constprop.50(s = 0xE4841E80, gfpflags = -006|2148925462, ad -007|kmem_cache_alloc(s = 0xE4841E80, gfpflags = 208) -008|shmem_alloc_inode(?) -009|alloc_inode(sb = 0xE480E800) -010|new_inode_pseudo(?) -011|new_inode(?) -012|shmem_get_inode(sb = 0xE480E800, dir = 0x0, ?, dev = 0, flags = -012|187) -013|shmem_file_setup(?, ?, flags = 187) -014|ashmem_mmap(?, vma = 0xC5D64210) <---- Acquire ashmem_mutex -015|mmap_region(file = 0xDF8E2C00, addr = 1772974080, len = 233472, -015|flags = 57, -016|sys_mmap_pgoff(addr = 0, len = 230400, prot = 3, flags = 1, fd = -016|157, pgoff -017|ret_fast_syscall(asm) -->|exception -018|NUR:0x40097508(asm) ---|end of frame Avoid this deadlock by using mutex_trylock in ashmem_shrink; if the mutex is already held, do not attempt to shrink. Cc: Greg KH <gregkh@linuxfoundation.org> Cc: Android Kernel Team <kernel-team@android.com> Reported-by:
Matt Wagantall <mattw@codeaurora.org> Reported-by:
Syed Rameez Mustafa <rameezmustafa@codeaurora.org> Reported-by:
Osvaldo Banuelos <osvaldob@codeaurora.org> Reported-by:
Subbaraman Narayanamurthy <subbaram@codeaurora.org> Signed-off-by:
Laura Abbott <lauraa@codeaurora.org> [jstultz: Minor commit message tweaks] Signed-off-by:
-
Hugo Camboulive authored
This removes a few Sparse warnings. Signed-off-by:
Hugo Camboulive <hugo.camboulive@gmail.com> Signed-off-by:
-
Hari Prasath Gujulan Elango authored
Replace multiple if..else if..statements with simple table lookup in two functions. Signed-off-by:
Hari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by:
-
Sudip Mukherjee authored
device_create() returns ERR_PTR on error, it does not return NULL. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Christian Gromm authored
This patch removes the second forwared declaration of struct most_aim. Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Signed-off-by:
-
Christian Gromm authored
This patch adds a counter for dropped packets. It needed for statistical analysis. Signed-off-by:
-
Christian Gromm authored
This patch straightens and rearranges the code of function aim_write() of module aim-cdev. Signed-off-by:
-
Christian Gromm authored
This patch makes use of kfifo_peek and kfifo_skip, which renders the variable stacked_mbo useless. It is therefore removed. Signed-off-by:
-
Christian Gromm authored
This patch changes the type of the access reference from atomit_t to int. It is needed, because the reference variable is secured by synchronization locks and does not need to be atomic anymore. Signed-off-by:
-
Christian Gromm authored
This patch fixes race conditions that might emerge from functions aim_open, aim_close, aim_read, aim_write and aim_disconnect_channel within module cdev. Signed-off-by:
-
Christian Gromm authored
This patch renames the variable 'channel' to 'c'. This is needed to have the code look more homogeneous and to prevent format violations. Signed-off-by:
-
Christian Gromm authored
This patch fixes the function channel_has_mbo that delivers the false information in case two AIMs are using the same tx channel. Signed-off-by:
-
Christian Gromm authored
This patch encapsulates shared code. It therefore creates the new functions stop_channel and destroy_cdev. Signed-off-by:
-
Christian Gromm authored
This patch prevents the cdev module from rousing the channel wait queue in case the channel is about to be closed. It is safe to do so, because the application can not be waiting within read or write and at the same time be calling close. Signed-off-by:
-
Christian Gromm authored
This patch removes the mutexes stop_task_mutex and deregister mutex, since they can safely be left out. Signed-off-by:
-
Christian Gromm authored
This patch removes unnecessary code to destroy channel objects. It is needed, because function most_stop_channel, which is indirectly triggered by function most_deregister_interface, already destroys the channels. Signed-off-by:
-
Christian Gromm authored
This patch removes the unnecessary reference conter mod_ref. Signed-off-by:
-
Christian Gromm authored
This patch removes the atomic tainted flag. It is needed to get rid of logical overhead. Signed-off-by:
-
Christian Gromm authored
This patch moves the code that disconnects linked channels. It is needed to have cleaning things up done right. Signed-off-by:
-
Christian Gromm authored
This patch removes mutex from code that doesn't need any locking. Signed-off-by:
-
Christian Gromm authored
This patch makes function store_add_link initialize the pointer to an AIM right before the channel is probed. It is needed, the AIM may already call most_start_channel while probe_channel is still running. At this point the pointer to the AIM must not be NULL. Signed-off-by:
-
Christian Gromm authored
This patch invokes AIM's disconnect_channel callback before the corresponding pointers are re-initialized to NULL. Signed-off-by:
-
Christian Gromm authored
This patch adds two missing calls to function ida_simpel_remove. Signed-off-by:
-
Christian Gromm authored
This patch removes the function destroy_most_c_obj and executes its code within function destroy_most_inst_obj. Signed-off-by:
-
Christian Gromm authored
This patch makes use of functions readl and writel instead of the __raw_* variants. Signed-off-by:
-
Christian Gromm authored
This patch increments mbo_offs by the number of bytes that have been copied and resets it in case a complete mbo has been transferred to user buffer. Signed-off-by:
-
Christian Gromm authored
This patch fixes a potential MBO leak in case function aim_read() exits right after the MBO has been fetched from kfifo and before it has been saved to the variable stacked_mbo. Signed-off-by:
-
Christian Gromm authored
This patch replaces min with min_t. Signed-off-by:
-
Christian Gromm authored
This patch unifies variable types to get less castings. Signed-off-by:
-
Christian Gromm authored
This patch replaces the ternary ?-operator with a way simpler subtraction. Signed-off-by:
-
Christian Gromm authored
This patch renames some variables for better readability. Signed-off-by:
-
Christian Gromm authored
The MBO pointer stacked_mbo and the boolean variable keep_mbo are always changed together and therefore provide the same information. This patch removes keep_mbo and uses stacked_mbo instead. Signed-off-by:
-
Hugo Camboulive authored
alloc_etherdev() calls alloc_netdev_mqs(), which already uses kzalloc/vzalloc. This clears a sparse warning : drivers/staging/unisys/visornic/visornic_main.c:1366:15: warning: memset with byte count of 1460112 Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Dan Carpenter authored
queue_delayed_work() returns bool, not negative error codes. It returns false if the work has already been queued or true otherwise. Since we don't care about that, we can just remove the test. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Don Zickus <dzickus@redhat.com> Signed-off-by:
-
Kees Cook authored
Since "name" is always used directly, force "%s" for the kthread format string to avoid any potential format string leaks. Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch fixes checkpatch.pl warning for visorchipset.c CHECK: spaces preferred around that '*' (ctx:VxV) +#define MAX_CONTROLVM_PAYLOAD_BYTES (1024*128) Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
David Kershner authored
>From napi documentation you should only process the amount your budget allows, if you go over it just wait for the next napi poll to continue. Signed-off-by:
David Kershner <david.kershner@unisys.com> Signed-off-by:
-
Benjamin Romer authored
Fix the only fixable parenthesis alignment issue in visorchipset.c. The rest are unworkable because of the length of the symbol names used. Signed-off-by:
-
Chaehyun Lim authored
It should be returned error code as -EFAULT instead of 0 when hif_drv is NULL. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
