1. 08 Sep, 2008 5 commits
    • Tejun Heo's avatar
      libata-sff: kill spurious WARN_ON() in ata_hsm_move() · 9c2676b6
      Tejun Heo authored
      On HSM_ST_ERR, ata_hsm_move() triggers WARN_ON() if AC_ERR_DEV or
      AC_ERR_HSM is not set.  PHY events may trigger HSM_ST_ERR with other
      error codes and, with or without it, there just isn't much reason to
      do WARN_ON() on it.  Even if error code is not set there, core EH
      logic won't have any problem dealing with the error condition.
      
      OSDL bz#11065 reports this problem.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      9c2676b6
    • Tejun Heo's avatar
      sata_nv: disable hardreset for generic · 2fd673ec
      Tejun Heo authored
      of them being unifying probing, hotplug and EH reset paths uniform.
      Previously, broken hardreset could go unnoticed as it wasn't used
      during probing but when something goes wrong or after hotplug the
      problem will surface and bite hard.
      
      OSDL bug 11195 reports that sata_nv generic flavor falls into this
      category.  Hardreset itself succeeds but PHY stays offline after
      hardreset.  I tried longer debounce timing but the result was the
      same.
      
        http://bugzilla.kernel.org/show_bug.cgi?id=11195
      
      So, it seems we'll have to drop hardreset from the generic flavor.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Cc: Peer Chen <pchen@nvidia.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      2fd673ec
    • Tejun Heo's avatar
      ahci: disable PMP for marvell ahcis · 17248461
      Tejun Heo authored
      Marvell ahcis don't play nicely with PMPs.  Disable it.
      
      Reported by KueiHuan Chen in the following thread.
      
        http://thread.gmane.org/gmane.linux.ide/33296Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Cc: KueiHuan Chen <kueihuan.chen@gmail.com>
      Cc: Mark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      17248461
    • Mark Lord's avatar
      sata_mv: add RocketRaid 1720 PCI ID to driver · 46c5784c
      Mark Lord authored
      Signed-off-by: default avatarPetr Jelen <petr.jelen@gmail.com>
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      46c5784c
    • Alan Cox's avatar
      ahci, pata_marvell: play nicely together · 5b66c829
      Alan Cox authored
      I've been chasing Jeff about this for months.  Jeff added the Marvell
      device identifiers to the ahci driver without making the AHCI driver
      handle the PATA port. This means a lot of users can't use current
      kernels and in most distro cases can't even install.
      
      This has been going on since March 2008 for the 6121 Marvell, and late 2007
      for the 6145!!!
      
      This was all pointed out at the time and repeatedly ignored. Bugs assigned
      to Jeff about this are ignored also.
      
      To quote Jeff in email
      
      > "Just switch the order of 'ahci' and 'pata_marvell' in
      > /etc/modprobe.conf, then use Fedora's tools regenerate the initrd.
      
      > See?  It's not rocket science, and the current configuration can be
      > easily made to work for Fedora users."
      
      (Which isn't trivial, isn't end user, shouldn't be needed, and as it usually
      breaks at install time is in fact impossible)
      
      To quote Jeff in August 2007
      
      > "   mv-ahci-pata
      > Marvell 6121/6141 PATA support.  Needs fixing in the 'PATA controller
      > command' area before it is usable, and can go upstream."
      
      Only he add the ids anyway later and caused regressions, adding a further
      id in March causing more regresions.
      
      The actual fix for the moment is very simple. If the user has included
      the pata_marvell driver let it drive the ports. If they've only selected
      for SATA support give them the AHCI driver which will run the port a fraction
      faster. Allow the user to control this decision via ahci.marvell_enable as
      a module parameter so that distributions can ship 'it works' defaults and
      smarter users (or config tools) can then flip it over it desired.
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      5b66c829
  2. 07 Sep, 2008 5 commits
  3. 06 Sep, 2008 12 commits
  4. 05 Sep, 2008 18 commits