1. 18 Nov, 2018 3 commits
  2. 17 Nov, 2018 7 commits
  3. 16 Nov, 2018 5 commits
  4. 15 Nov, 2018 12 commits
  5. 14 Nov, 2018 1 commit
  6. 13 Nov, 2018 6 commits
  7. 12 Nov, 2018 3 commits
    • Sudarsana Reddy Kalluru's avatar
      bnx2x: Assign unique DMAE channel number for FW DMAE transactions. · 77e461d1
      Sudarsana Reddy Kalluru authored
      Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW
      uses this channel for DMAE operations (e.g., TIME_SYNC implementation).
      Driver also uses the same channel 0 for DMAE operations for some of the PFs
      (e.g., PF0 on Port0). This could lead to concurrent access to the DMAE
      channel by FW and driver which is not legal. Hence need to assign unique
      DMAE id for FW.
      Currently following DMAE channels are used by the clients,
        MFW - OCBB/OCSD functionality uses DMAE channel 14/15
        Driver 0-3 and 8-11 (for PF dmae operations)
               4 and 12 (for stats requests)
      Assigning unique dmae_id '13' to the FW.
      
      Changes from previous version:
      ------------------------------
      v2: Incorporated the review comments.
      Signed-off-by: default avatarSudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
      Signed-off-by: default avatarMichal Kalderon <Michal.Kalderon@cavium.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      77e461d1
    • Sven Eckelmann's avatar
      batman-adv: Expand merged fragment buffer for full packet · d7d8bbb4
      Sven Eckelmann authored
      The complete size ("total_size") of the fragmented packet is stored in the
      fragment header and in the size of the fragment chain. When the fragments
      are ready for merge, the skbuff's tail of the first fragment is expanded to
      have enough room after the data pointer for at least total_size. This means
      that it gets expanded by total_size - first_skb->len.
      
      But this is ignoring the fact that after expanding the buffer, the fragment
      header is pulled by from this buffer. Assuming that the tailroom of the
      buffer was already 0, the buffer after the data pointer of the skbuff is
      now only total_size - len(fragment_header) large. When the merge function
      is then processing the remaining fragments, the code to copy the data over
      to the merged skbuff will cause an skb_over_panic when it tries to actually
      put enough data to fill the total_size bytes of the packet.
      
      The size of the skb_pull must therefore also be taken into account when the
      buffer's tailroom is expanded.
      
      Fixes: 610bfc6b ("batman-adv: Receive fragmented packets and merge")
      Reported-by: default avatarMartin Weinelt <martin@darmstadt.freifunk.net>
      Co-authored-by: default avatarLinus Lüssing <linus.luessing@c0d3.blue>
      Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
      Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
      d7d8bbb4
    • Sven Eckelmann's avatar
      batman-adv: Use explicit tvlv padding for ELP packets · f4156f96
      Sven Eckelmann authored
      The announcement messages of batman-adv COMPAT_VERSION 15 have the
      possibility to announce additional information via a dynamic TVLV part.
      This part is optional for the ELP packets and currently not parsed by the
      Linux implementation. Still out-of-tree versions are using it to transport
      things like neighbor hashes to optimize the rebroadcast behavior.
      
      Since the ELP broadcast packets are smaller than the minimal ethernet
      packet, it often has to be padded. This is often done (as specified in
      RFC894) with octets of zero and thus work perfectly fine with the TVLV
      part (making it a zero length and thus empty). But not all ethernet
      compatible hardware seems to follow this advice. To avoid ambiguous
      situations when parsing the TVLV header, just force the 4 bytes (TVLV
      length + padding) after the required ELP header to zero.
      
      Fixes: d6f94d91 ("batman-adv: ELP - adding basic infrastructure")
      Reported-by: default avatarLinus Lüssing <linus.luessing@c0d3.blue>
      Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
      Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
      f4156f96
  8. 11 Nov, 2018 3 commits
    • Linus Torvalds's avatar
      Linux 4.20-rc2 · ccda4af0
      Linus Torvalds authored
      ccda4af0
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net · 7a3765ed
      Linus Torvalds authored
      Pull networking fixes from David Miller:
       "One last pull request before heading to Vancouver for LPC, here we have:
      
         1) Don't forget to free VSI contexts during ice driver unload, from
            Victor Raj.
      
         2) Don't forget napi delete calls during device remove in ice driver,
            from Dave Ertman.
      
         3) Don't request VLAN tag insertion of ibmvnic device when SKB
            doesn't have VLAN tags at all.
      
         4) IPV4 frag handling code has to accomodate the situation where two
            threads try to insert the same fragment into the hash table at the
            same time. From Eric Dumazet.
      
         5) Relatedly, don't flow separate on protocol ports for fragmented
            frames, also from Eric Dumazet.
      
         6) Memory leaks in qed driver, from Denis Bolotin.
      
         7) Correct valid MTU range in smsc95xx driver, from Stefan Wahren.
      
         8) Validate cls_flower nested policies properly, from Jakub Kicinski.
      
         9) Clearing of stats counters in mc88e6xxx driver doesn't retain
            important bits in the G1_STATS_OP register causing the chip to
            hang. Fix from Andrew Lunn"
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (41 commits)
        act_mirred: clear skb->tstamp on redirect
        net: dsa: mv88e6xxx: Fix clearing of stats counters
        tipc: fix link re-establish failure
        net: sched: cls_flower: validate nested enc_opts_policy to avoid warning
        net: mvneta: correct typo
        flow_dissector: do not dissect l4 ports for fragments
        net: qualcomm: rmnet: Fix incorrect assignment of real_dev
        net: aquantia: allow rx checksum offload configuration
        net: aquantia: invalid checksumm offload implementation
        net: aquantia: fixed enable unicast on 32 macvlan
        net: aquantia: fix potential IOMMU fault after driver unbind
        net: aquantia: synchronized flow control between mac/phy
        net: smsc95xx: Fix MTU range
        net: stmmac: Fix RX packet size > 8191
        qed: Fix potential memory corruption
        qed: Fix SPQ entries not returned to pool in error flows
        qed: Fix blocking/unlimited SPQ entries leak
        qed: Fix memory/entry leak in qed_init_sp_request()
        inet: frags: better deal with smp races
        net: hns3: bugfix for not checking return value
        ...
      7a3765ed
    • Linus Torvalds's avatar
      Merge tag 'kbuild-fixes-v4.20' of... · e12e00e3
      Linus Torvalds authored
      Merge tag 'kbuild-fixes-v4.20' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
      
      Pull Kbuild fixes from Masahiro Yamada:
      
       - fix build errors in binrpm-pkg and bindeb-pkg targets
      
       - fix false positive matches in merge_config.sh
      
       - fix build version mismatch in deb-pkg target
      
       - fix dtbs_install handling in (bin)deb-pkg target
      
       - revert a commit that allows setlocalversion to write to source tree
      
      * tag 'kbuild-fixes-v4.20' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
        builddeb: Fix inclusion of dtbs in debian package
        Revert "scripts/setlocalversion: git: Make -dirty check more robust"
        kbuild: deb-pkg: fix too low build version number
        kconfig: merge_config: avoid false positive matches from comment lines
        kbuild: deb-pkg: fix bindeb-pkg breakage when O= is used
        kbuild: rpm-pkg: fix binrpm-pkg breakage when O= is used
      e12e00e3