- 07 Jan, 2016 6 commits
-
-
Manoj Kumar authored
This drop enables a future card with a device id of 0x0600 to be recognized by the cxlflash driver. As per the design, the Accelerator Function Unit (AFU) for this new IBM CXL Flash Adapter retains the same host interface as the previous generation. For the early prototypes of the new card, the driver with this change behaves exactly as the driver prior to this behaved with the earlier generation card. Therefore, no card specific programming has been added. These card specific changes can be staged in later if needed. Signed-off-by:
Manoj N. Kumar <manoj@linux.vnet.ibm.com> Acked-by:
Matthew R. Ochs <mrochs@linux.vnet.ibm.com> Reviewed-by:
Andrew Donnellan <andrew.donnellan@au1.ibm.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Manoj Kumar authored
If an async error interrupt is generated, and the error requires the FC link to be reset, it cannot be performed in the interrupt context. So a work element is scheduled to complete the link reset in a process context. If either an EEH event or an escalation occurs in between when the interrupt is generated and the scheduled work is started, the MMIO space may no longer be available. This will cause an oops in the worker thread. [ 606.806583] NIP kthread_data+0x28/0x40 [ 606.806633] LR wq_worker_sleeping+0x30/0x100 [ 606.806694] Call Trace: [ 606.806721] 0x50 (unreliable) [ 606.806796] wq_worker_sleeping+0x30/0x100 [ 606.806884] __schedule+0x69c/0x8a0 [ 606.806959] schedule+0x44/0xc0 [ 606.807034] do_exit+0x770/0xb90 [ 606.807109] die+0x300/0x460 [ 606.807185] bad_page_fault+0xd8/0x150 [ 606.807259] handle_page_fault+0x2c/0x30 [ 606.807338] wait_port_offline.constprop.12+0x60/0x130 [cxlflash] To prevent the problem space area from being unmapped, when there is pending work, a mapcount (using the kref mechanism) is held. The mapcount is released only when the work is completed. The last reference release is tied to the unmapping service. Signed-off-by:
Uma Krishnan <ukrishn@linux.vnet.ibm.com> Signed-off-by:
-
Manoj Kumar authored
After a few iterations of resetting the card, either during EEH recovery, or a host_reset the following is seen in the logs. cxlflash 0008:00: cxlflash_queuecommand: could not get a free command At every reset of the card, the commands that are outstanding are being leaked. No effort is being made to reap these commands. A few more resets later, the above error message floods the logs and the card is rendered totally unusable as no free commands are available. Iterated through the 'cmd' queue and printed out the 'free' counter and found that on each reset certain commands were in-use and stayed in-use through subsequent resets. To resolve this issue, when the card is reset, reap all the commands that are active/outstanding. Signed-off-by:
-
Uma Krishnan authored
Having a date for the driver requires it to be updated quite often. Removing the date which is not necessary. Also made use of the existing symbol to print the driver name. Signed-off-by:
-
Matthew R. Ochs authored
Applications which use virtual LUN's that are backed by a physical LUN over both adapter ports may experience an I/O failure in the event of a link loss (e.g. cable pull). Virtual LUNs may be accessed through one or both ports of the adapter. This access is encoded in the translation entries that comprise the virtual LUN and used by the AFU for load-balancing I/O and handling failover scenarios. In a link loss scenario, even though the AFU is able to maintain connectivity to the LUN, it is up to the application to retry the failed I/O. When applications are unaware of the virtual LUN's underlying topology, they are unable to make a sound decision of when to retry an I/O and therefore are forced to make their reaction to a failed I/O absolute. The result is either a failure to retry I/O or increased latency for scenarios where a retry is pointless. To remedy this scenario, provide feedback back to the application on virtual LUN creation as to which ports the LUN may be accessed. LUN's spanning both ports are candidates for a retry in a presence of an I/O failure. Signed-off-by:
-
Manoj Kumar authored
The original fix to escalate a 'login timed out' error to a LINK_RESET was only made for one of the two ports on the card. This fix resolves the same issue for the second port (port 1). Signed-off-by:
-
- 06 Jan, 2016 9 commits
-
-
K. Y. Srinivasan authored
On the interrupt path, we repeatedly establish the pointer to the storvsc_device. While the compiler does inline get_in_stor_device() (and other static functions) in the call chain in the interrupt path, the compiler is repeatedly inlining the call to get_in_stor_device() each time it is invoked. The return value of get_in_stor_device() can be cached in the interrupt path since there is higher level serialization in place to ensure correct handling when the module unload races with the processing of an incoming message from the host. Optimize this code path by caching the pointer to storvsc_device and passing it as an argument. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Reviewed-by:
Long Li <longli@microsoft.com> Reviewed-by:
Johannes Thumshirn <jthumshirn@suse.de> Reviewed-by:
Hannes Reinecke <hare@suse.com> Tested-by:
Alex Ng <alexng@microsoft.com> Signed-off-by:
-
K. Y. Srinivasan authored
The function storvsc_channel_init() repeatedly interacts with the host to extract various channel properties. Refactor this code to eliminate code repetition. Signed-off-by:
-
K. Y. Srinivasan authored
For FC devices managed by this driver, atttach the appropriate transport template. This will allow us to create the appropriate sysfs files for these devices. With this we can publish the wwn for both the port and the node. Signed-off-by:
-
K. Y. Srinivasan authored
The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux match the Windows definition. Signed-off-by:
-
Wilfried Weissmann authored
Add SGPIO support to Marvell 94xx. Signed-off-by:
Wilfried Weissmann <Wilfried.Weissmann@gmx.at> Reviewed-by:
James Bottomley <James.Bottomley@HansenPartnership.com> Signed-off-by:
-
Tomas Henzl authored
It might happen that we try to free an already freed pointer. Reported-by:
Maurizio Lombardi <mlombard@redhat.com> Signed-off-by:
Tomas Henzl <thenzl@redhat.com> Acked-by:
Chaitra P B <chaitra.basappa@avagotech.com> Signed-off-by:
-
Don Brace authored
Adding a new method to display enclosure device information. Reviewed-by:
Justin Lindley <justin.lindley@pmcs.com> Reviewed-by:
Kevin Barnett <kevin.barnett@pmcs.com> Reviewed-by:
Scott Teel <scott.teel@pmcs.com> Reviewed-by:
Don Brace <don.brace@pmcs.com> Signed-off-by:
-
Don Brace authored
SAS transport places devices on bus 0 but driver was setting the bus to 3. Reviewed-by:
-
Don Brace authored
Left off some changes from Rasmus Villemoes where he changed snprintf to scnprintf. Suggested-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Reviewed-by:
-
- 05 Jan, 2016 1 commit
-
-
Colin Ian King authored
The max outstanding commands is being printed with a 0x prefix to suggest it is a hex value, when in fact the integer decimal %d format specifier is being used and this is a bit confusing. Use %x instead to match the proceeding 0x prefix. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
- 22 Dec, 2015 17 commits
-
-
Martin K. Petersen authored
The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which translates to 32KB with the default logical block size. That's much lower than what real storage devices typically report (256KB to 1MB). Bump the optimal transfer length to 1024 blocks. Acked-by:
Douglas Gilbert <dgilbert@interlog.com> Reviewed-by:
Ewan Milne <emilne@redhat.com> Signed-off-by:
-
James Smart authored
Update version to 11.0.0.10 for upstream patch set Signed-off-by:
Dick Kennedy <dick.kennedy@avagotech.com> Signed-off-by:
James Smart <james.smart@avagotech.com> Reviewed-by:
Hannes Reinicke <hare@suse.de> Signed-off-by:
-
Punit Vara authored
This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset Signed-off-by:
Punit Vara <punitvara@gmail.com> Signed-off-by:
Sebastian Herbszt <herbszt@gmx.de> Signed-off-by:
-
Markus Elfring authored
The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
-
James Smart authored
Add logging for misconfigured optics acqe reported by fw. Signed-off-by:
-
James Smart authored
Fix external loopback failure. Rx sequence reassembly was incorrect. Signed-off-by:
-
James Smart authored
Fix mbox reuse in PLOGI completion. Moved allocations so that buffer properly init'd. Signed-off-by:
-
James Smart authored
Use new FDMI speed definitions for 10G, 25G and 40G FCoE. Signed-off-by:
-
James Smart authored
Make write check error processing more resilient. Checks to catch writes that fw reports weren't fully complete yet SCSI status indicated fine needed correction. Signed-off-by:
-
James Smart authored
Fix RDP ACC being too long. Signed-off-by:
-
James Smart authored
Fix RDP Speed reporting. Signed-off-by:
-
James Smart authored
Modularize, cleanup, add comments - for FDMI code in driver Note: I don't like the comments with leading # - but as we have a lot if present, I'm deferring to handle it in one big fix later. Signed-off-by:
-
James Smart authored
Fix crash in fcp command completion path. Missed null check. Signed-off-by:
-
James Smart authored
Fix driver crash when module parameter lpfc_fcp_io_channel set to 16 Signed-off-by:
-
James Smart authored
Fix RegLogin failed error seen on Lancer FC during port bounce Fix the statemachine and ref counting. Signed-off-by:
-
James Smart authored
Fix the FLOGI discovery logic to comply with T11 standards We weren't properly setting fabric parameters, such as R_A_TOV and E_D_TOV, when we registered the vfi object in default configs and pt2pt configs. Revise to now pass service params with the values to the firmware and ensure they are reset on link bounce. Required reworking the call sequence in the discovery threads. Signed-off-by:
-
James Smart authored
Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Signed-off-by:
-
- 17 Dec, 2015 1 commit
-
-
John Garry authored
It is preferred that drivers use platform_get_irq() instead of irq_of_parse_and_map(), so replace. Signed-off-by:
John Garry <john.garry@huawei.com> Acked-by:
Rob Herring <robh@kernel.org> Reviewed-by:
-
- 10 Dec, 2015 6 commits
-
-
Dan Carpenter authored
There were a couple cases where the error codes weren't set and also I changed the success return to "return 0;" which is the same as "return rc;" but more explicit. Fixes: 42e7a693 ('hisi_sas: Add ssp command functio') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Tested-by:
-
Rasmus Villemoes authored
If char is signed and one of these bytes happen to have a value outside the ascii range, the corresponding output will consist of "ffffff" followed by the two hex chars that were actually intended. One way to fix it would be to change the casts to (u8*) aka (unsigned char*), but it is much simpler (and generates smaller code) to use the %ph extension which was created for such short hexdumps. Signed-off-by:
Boaz Harrosh <ooo@electrozaur.com> Signed-off-by:
-
Long Li authored
Introduce a logging level for storvsc to log certain error/warning messages. Those messages are helpful in some environments, e.g. Microsoft Azure, for customer support and troubleshooting purposes. Signed-off-by:
-
Josh Boyer authored
The driver is missing calls to pci_dma_mapping_error() after performing the DMA mapping, which caused DMA-API warning to show up in dmesg's output. Though that happens only when DMA_API_DEBUG option is enabled. This change fixes the issue and makes pvscsi_map_buffers() function more robust. Signed-off-by:
Arvind Kumar <arvindkumar@vmware.com> Cc: Josh Boyer <jwboyer@fedoraproject.org> Reviewed-by:
Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by:
Josh Boyer <jwboyer@fedoraproject.org> Reviewed-by:
-
Geliang Tang authored
IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it. Signed-off-by:
Geliang Tang <geliangtang@163.com> Acked-by:
-
Dan Carpenter authored
The "> MAX_CONTEXT" should be ">= MAX_CONTEXT". Otherwise we go one step beyond the end of the cfg->ctx_tbl[] array. Signed-off-by:
-
