1. 21 Jan, 2015 7 commits
    • Jan Kara's avatar
      xfs: Remove some pointless quota checks · a3942700
      Jan Kara authored
      xfs_fs_get_xstate() and xfs_fs_get_xstatev() check whether there's quota
      running before calling xfs_qm_scall_getqstat() or
      xfs_qm_scall_getqstatv(). Thus we are certain that superblock supports
      quota and xfs_sb_version_hasquota() check is pointless. Similarly we
      know that when quota is running, mp->m_quotainfo will be allocated.
      Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      a3942700
    • Jan Kara's avatar
      xfs: Remove some useless flags tests · fbf64b3d
      Jan Kara authored
      'flags' have XFS_ALL_QUOTA_ACCT cleared immediately on function entry.
      There's no point in checking these bits later in the function. Also
      because we check something is going to change, we know some enforcement
      bits are being added and thus there's no point in testing that later.
      Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      fbf64b3d
    • Jan Kara's avatar
      xfs: Remove useless test · 8a2fdd4a
      Jan Kara authored
      Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.
      Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      8a2fdd4a
    • Jan Kara's avatar
      quota: Verify flags passed to Q_SETINFO · ca6cb091
      Jan Kara authored
      Currently flags passed via Q_SETINFO were just stored. This makes it
      hard to add new flags since in theory userspace could be just setting /
      clearing random flags. Since currently there is only one userspace
      settable flag and that is somewhat obscure flags only for ancient v1
      quota format, I'm reasonably sure noone operates these flags and
      hopefully we are fine just adding the check that passed flags are sane.
      If we indeed find some userspace program that gets broken by the strict
      check, we can always remove it again.
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      ca6cb091
    • Jan Kara's avatar
      quota: Cleanup flags definitions · 9c45101e
      Jan Kara authored
      Currently all quota flags were defined just in kernel-private headers.
      Export flags readable / writeable from userspace to userspace via
      include/uapi/linux/quota.h.
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      9c45101e
    • Jan Kara's avatar
      ocfs2: Move OLQF_CLEAN flag out of generic quota flags · 96827adc
      Jan Kara authored
      OLQF_CLEAN flag is used by OCFS2 on disk to recognize whether quota
      recovery is needed or not. We also somewhat abuse mem_dqinfo->dqi_flags
      to pass this flag around. Use private flags for this to avoid clashes
      with other quota flags / not pollute generic quota flag namespace.
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      96827adc
    • Jan Kara's avatar
      quota: Don't store flags for v2 quota format · c119c5b9
      Jan Kara authored
      Currently, v2 quota format blindly stored flags from in-memory dqinfo on
      disk, although there are no flags supported. Since it is stupid to store
      flags which have no effect, just store 0 unconditionally and don't
      bother loading it from disk.
      
      Note that userspace could have stored some flags there via Q_SETINFO
      quotactl and then later read them (although flags have no effect) but
      I'm pretty sure noone does that (most definitely quota-tools don't and
      quota interface doesn't have too much other users).
      Signed-off-by: default avatarJan Kara <jack@suse.cz>
      c119c5b9
  2. 15 Jan, 2015 1 commit
  3. 12 Jan, 2015 1 commit
  4. 07 Jan, 2015 3 commits
  5. 05 Jan, 2015 2 commits
  6. 04 Jan, 2015 4 commits
  7. 02 Jan, 2015 3 commits
  8. 31 Dec, 2014 10 commits
  9. 30 Dec, 2014 9 commits