1. 17 Mar, 2014 25 commits
    • Ana Rey's avatar
      staging: rtl8192u: make in ieee80211/ieee80211_tx.c some local functions static · a5ac48ac
      Ana Rey authored
      Make some local functions (ieee80211_qurey_ShortPreambleMode and
      ieee80211_query_HTCapShortGI) static and fix coding style in these
      function declarations when It is necessary.
      
      Fix the following sparse warnings in ieee80211/ieee80211_tx.c
      
      drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:381:6: warning: symbol 'ieee80211_qurey_ShortPreambleMode' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:395:1: warning: symbol 'ieee80211_query_HTCapShortGI' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      a5ac48ac
    • Ana Rey's avatar
      staging: rtl8192u: Added in r819xU_firmware_img.c an include to fix a sparse warning · 627877bd
      Ana Rey authored
      Fix the following warnings from sparse in r819xU_firmware_img.c
      due to the missing include of r819xU_firmware_img.h
      
        CHECK   drivers/staging/rtl8192u/r819xU_firmware_img.c
      drivers/staging/rtl8192u/r819xU_firmware_img.c:4:5: warning: symbol 'Rtl8192UsbPHY_REGArray' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:7:5: warning: symbol 'Rtl8192UsbPHY_REG_1T2RArray' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:158:5: warning: symbol 'Rtl8192UsbRadioA_Array' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:284:5: warning: symbol 'Rtl8192UsbRadioB_Array' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:326:5: warning: symbol 'Rtl8192UsbRadioC_Array' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:329:5: warning: symbol 'Rtl8192UsbRadioD_Array' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:332:5: warning: symbol 'Rtl8192UsbMACPHY_Array' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:341:5: warning: symbol 'Rtl8192UsbMACPHY_Array_PG' was not declared. Should it be static?
      drivers/staging/rtl8192u/r819xU_firmware_img.c:354:5: warning: symbol 'Rtl8192UsbAGCTAB_Array' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      627877bd
    • Ashley Smith's avatar
      staging: bcm: Replace <asm/uaccess.h> by <linux/uaccess.h> · a7e4be9d
      Ashley Smith authored
      This patch fixes the checkpatch warning to include <linux/uaccess.h> instead
      of <asm/uaccess.h>.
      Signed-off-by: default avatarAshley Smith <ashley@eclipso.ch>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      a7e4be9d
    • Andreea-Cristina Bernat's avatar
      Staging: solo6x10: Replace expressions that don't use ALIGN macro · 0cb6dfd7
      Andreea-Cristina Bernat authored
      There are some expressions that compute the roundup of a number, but don't use
      the existing macro defined in /include/kernel.h. This patch uses the following
      Coccinelle semantic patch:
      @ haskernel @
      @@
      
      @ depends on haskernel @
      expression E1, E2;
      @@
      
      - (E1 + (E2 - 1)) & ~(E2 - 1)
      + ALIGN(E1, E2)
      Signed-off-by: default avatarAndreea-Cristina Bernat <bernat.ada@gmail.com>
      Acked-by: default avatarBob Copeland <me@bobcopeland.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      0cb6dfd7
    • Tugce Sirin's avatar
      Staging: bcm: Fix sparse non-static symbol warning · 8fa7fdeb
      Tugce Sirin authored
      Fix sparse non-static symbol warning in bcm driver.
      Signed-off-by: default avatarTugce Sirin <ztugcesirin@gmail.com>
      Acked-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      8fa7fdeb
    • Tugce Sirin's avatar
      Staging: wlan-ng: Fix sparse non-static symbol warning · 36d9c250
      Tugce Sirin authored
      Fix sparse non-static symbol warning in wlan-ng driver.
      Signed-off-by: default avatarTugce Sirin <ztugcesirin@gmail.com>
      Acked-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      36d9c250
    • Andreea-Cristina Bernat's avatar
      staging: sep: Add fallthrough comment · 98e2dda3
      Andreea-Cristina Bernat authored
      This patch solves the warning "possible switch/case default not preceded by
      break or fallthrough comment".
      Signed-off-by: default avatarAndreea-Cristina Bernat <bernat.ada@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      98e2dda3
    • Himangi Saraogi's avatar
      staging:lustre: Fix sparse warning of plain integer as NULL · 87355c1b
      Himangi Saraogi authored
      This patch fixes the following sparse warning:
      drivers/staging/lustre/lustre/lov/lov_request.c:53:28: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      87355c1b
    • Ana Rey's avatar
      staging: rtl8192u: Deleted 'rtl8192_beacon_stop' function in r8192U_core.c · feb600e5
      Ana Rey authored
      This patch delete the 'rtl8192_beacon_stop' function that is not used
      in anywhere in the driver.
      
      Fix the following sparse warning in r8192U_core.c
      
      drivers/staging/rtl8192u/r8192U_core.c:1332:6: warning: symbol 'rtl8192_beacon_stop' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      feb600e5
    • Ana Rey's avatar
      staging: rtl8192u: Deleted 'rtl8192_proc_module_remove' function in r8192U_core.c · 4f59e193
      Ana Rey authored
      This patch delete the 'rtl8192_proc_module_remove' function that is not
      used in anywhere in the driver.
      
      Fix the following sparse warnings in r8192U_core.c
      
      drivers/staging/rtl8192u/r8192U_core.c:595:6: warning: symbol 'rtl8192_proc_module_remove' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      4f59e193
    • Ana Rey's avatar
      staging: rtl8192u: Deleted 'rtl8192_set_mode' function in r8192U_core.c · a5cb9b39
      Ana Rey authored
      This patch delete the 'rtl8192_set_mode' function that is not used in
      anywhere in the driver.
      
      Fix the following sparse warning in r8192U_core.c
      drivers/staging/rtl8192u/r8192U_core.c:692:6: warning: symbol 'rtl8192_set_mode' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      a5cb9b39
    • Ana Rey's avatar
      staging: rtl8192u: Deleted 'rtl819xU_cmd_isr' function in r8192U_core.c · 6a1bf3a5
      Ana Rey authored
      This patch delete the 'rtl819xU_cmd_isr' function that is not used in
      anywhere in the driver.
      
      Fix the following sparse warning in r8192U_core.c
      
      drivers/staging/rtl8192u/r8192U_core.c:1516:6: warning: symbol 'rtl819xU_cmd_isr' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      6a1bf3a5
    • Ana Rey's avatar
      staging: rtl8192u: make in ieee80211/rtl819x_BAProc.c some local functions static · 51296cdf
      Ana Rey authored
      Make some local functions (ActivateBAEntry, DeActivateBAEntry,
      TxTsDeleteBA ,RxTsDeleteBA and ieee80211_send_DELBA) static and fix
      coding style in this function declarations when It is necessary
      
      Fix the following sparse warnings in ieee80211/rtl819x_BAProc.c
      
      drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:16:6: warning: symbol 'ActivateBAEntry' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:28:6: warning: symbol 'DeActivateBAEntry' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:40:4: warning: symbol 'TxTsDeleteBA' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:70:4: warning: symbol 'RxTsDeleteBA' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:310:6: warning: symbol 'ieee80211_send_DELBA' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      51296cdf
    • Ana Rey's avatar
      staging: rtl8192u: make in ieee80211/rtl819x_HTProc.c some local functions static · 140cdd73
      Ana Rey authored
      Make some local functions static.
      
      These are the local functions that were made static:
      
      IsHTHalfNmode40Bandwidth, IsHTHalfNmodeSGI, HTIOTPeerDetermine,
      HTIOTActIsDisableMCS14, HTIOTActIsDisableMCS15,
      HTIOTActIsDisableMCSTwoSpatialStream, HTIOTActIsDisableEDCATurbo,
      HTIOTActIsMgntUseCCK6M, HTIOTActIsCCDFsync, HT_PickMCSRate,
      HTFilterMCSRate, HTUseDefaultSetting
      
      Fix the following sparse warnings in ieee80211/rtl819x_HTProc.c
      
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:222:6: warning: symbol 'IsHTHalfNmode40Bandwidth' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:241:6: warning: symbol 'IsHTHalfNmodeSGI' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:379:6: warning: symbol 'HTIOTPeerDetermine' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:416:4: warning: symbol 'HTIOTActIsDisableMCS14' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:435:6: warning: symbol 'HTIOTActIsDisableMCS15' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:472:6: warning: symbol 'HTIOTActIsDisableMCSTwoSpatialStream' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:489:4: warning: symbol 'HTIOTActIsDisableEDCATurbo' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:503:4: warning: symbol 'HTIOTActIsMgntUseCCK6M' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:518:4: warning: symbol 'HTIOTActIsCCDFsync' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:795:4: warning: symbol 'HT_PickMCSRate' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:910:4: warning: symbol 'HTFilterMCSRate' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c:1320:6: warning: symbol 'HTUseDefaultSetting' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      140cdd73
    • Ana Rey's avatar
      staging: rtl8192u: make in ieee80211/rtl819x_TSProc.c some local functions static · 1d6fa895
      Ana Rey authored
      Make some local functions static and fix coding style in this function
      declarations when It is necessary.
      
      These are the local functions that were made static:
      TsSetupTimeOut, TsInactTimeout RxPktPendingTimeout, TsAddBaProcess,
      ResetTsCommonInfo, ResetTxTsEntry, ResetRxTsEntry, AdmitTS,
      SearchAdmitTRStream, MakeTSEntry, RemoveTsEntry.
      
      Fix the following sparse warnings in ieee80211/rtl819x_TSProc.c
      
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:6:6: warning: symbol 'TsSetupTimeOut' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:12:6: warning: symbol 'TsInactTimeout' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:25:6: warning: symbol 'RxPktPendingTimeout' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:102:6: warning: symbol 'TsAddBaProcess' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:113:6: warning: symbol 'ResetTsCommonInfo' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:122:6: warning: symbol 'ResetTxTsEntry' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:133:6: warning: symbol 'ResetRxTsEntry' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:227:6: warning: symbol 'AdmitTS' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:237:17: warning: symbol 'SearchAdmitTRStream' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:312:6: warning: symbol 'MakeTSEntry' was not declared. Should it be static?
      drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:475:6: warning: symbol 'RemoveTsEntry' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      1d6fa895
    • Ana Rey's avatar
      staging: rtl8192u: Deleted 'alloc_tx_beacon_desc_ring' function in r8192U_core.c · a72eea3b
      Ana Rey authored
      This patch delete the 'alloc_tx_beacon_desc_ring' function that is not
      used in anywhere in the driver.
      
      Fix the following sparse warning in r8192U_core.c
      
      drivers/staging/rtl8192u/r8192U_core.c:883:5: warning: symbol 'alloc_tx_beacon_desc_ring' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      a72eea3b
    • Monam Agarwal's avatar
      Staging: ft1000-usb: Fix Smatch Warning in ft1000_hw.c · 1633dc5e
      Monam Agarwal authored
      This patch fixes following smatch warning:
      /drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:1148 ft1000_proc_drvmsg() warn: returning -1 instead of -ENOMEM is sloppy
      Signed-off-by: default avatarMonam Agarwal <monamagarwal123@gmail.com>
      Acked-by: default avatarNick Kossifidis <mickflemm@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      1633dc5e
    • Ana Rey's avatar
      staging: rts5139: Added in sd_cprm.c an include to fix a sparse warning · 2eeaa73c
      Ana Rey authored
      Fix the following warnings from sparse in drivers/staging/rts5139/sd_cprm.c
      due to the missing include of sd_cprm.h
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      2eeaa73c
    • Ana Rey's avatar
      staging: rts5139: make thrts5139_usb_idse local variable static in rts51x.c · d2a27670
      Ana Rey authored
      Make the local variable rts5139_usb_ids static
      
      Fix the following sparse warnings in rts51x.c
      
      CHECK   drivers/staging/rts5139/rts51x.c
      drivers/staging/rts5139/rts51x.c:835:22: warning: symbol 'rts5139_usb_ids' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      d2a27670
    • Ana Rey's avatar
      staging: rts5139: Added in ms_mg.c an include to fix a sparse warning · 884715f3
      Ana Rey authored
      Fix the following warnings from sparse in drivers/staging/rts5139/ms_mg.c
      due to the missing include of ms_mg.h
      
      drivers/staging/rts5139/ms_mg.c:81:5: warning: symbol 'mg_set_tpc_para_sub' was not declared. Should it be static?
      drivers/staging/rts5139/ms_mg.c:122:5: warning: symbol 'rts51x_mg_set_leaf_id' was not declared. Should it be static?
      drivers/staging/rts5139/ms_mg.c:173:5: warning: symbol 'rts51x_mg_get_local_EKB' was not declared. Should it be static?
      drivers/staging/rts5139/ms_mg.c:232:5: warning: symbol 'rts51x_mg_chg' was not declared. Should it be static?
      drivers/staging/rts5139/ms_mg.c:323:5: warning: symbol 'rts51x_mg_get_rsp_chg' was not declared. Should it be static?
      drivers/staging/rts5139/ms_mg.c:392:5: warning: symbol 'rts51x_mg_rsp' was not declared. Should it be static?
      drivers/staging/rts5139/ms_mg.c:450:5: warning: symbol 'rts51x_mg_get_ICV' was not declared. Should it be static?
      drivers/staging/rts5139/ms_mg.c:514:5: warning: symbol 'rts51x_mg_set_ICV' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      884715f3
    • Ana Rey's avatar
      staging: rts5139: make the local variable static · cf883f9b
      Ana Rey authored
      Make the local variable (media_not_present and invalid_cmd_field) static
      
      Fix the following sparse warnings in rts51x_transport.c
      
      drivers/staging/rts5139/rts51x_transport.c:649:4: warning: symbol 'media_not_present' was not declared. Should it be static?
      drivers/staging/rts5139/rts51x_transport.c:651:4: warning: symbol 'invalid_cmd_field' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      cf883f9b
    • Ana Rey's avatar
      staging: rtl8192u: make in r8180_93cx6.c some local functions static · f6bd19e0
      Ana Rey authored
      Make some local functions (eprom_cs, eprom_ck_cycle, eprom_w, eprom_r
      and eprom_send_bits_string) static
      
      Fix the following sparse warnings in r8180_93cx6.c
      
      drivers/staging/rtl8192u/r8180_93cx6.c:23:6: warning: symbol 'eprom_cs' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8180_93cx6.c:40:6: warning: symbol 'eprom_ck_cycle' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8180_93cx6.c:56:6: warning: symbol 'eprom_w' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8180_93cx6.c:71:7: warning: symbol 'eprom_r' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8180_93cx6.c:85:6: warning: symbol 'eprom_send_bits_string' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      f6bd19e0
    • Ana Rey's avatar
      staging: rtl8192u: make in r8192U_core.c the local functions static · f4c6074a
      Ana Rey authored
      Make some local functions static.
      
      The local functions are CamResetAllEntry, tx_timeout,
      rtl8192_data_hard_stop, rtl8192_data_hard_resume, rtl8192_hard_data_xmit,
      rtl8192_hard_start_xmit, rtl8192_config_rate, rtl8192_update_cap,
      rtl8192_net_update, MRateToHwRate8190Pci, tl8192_link_change,
      rtl8192_update_beacon, WDCAPARA_ADD, rtl8192_qos_activate,
      GetHalfNmodeSupportByAPs819xUsb, rtl8192_refresh_supportrate,
      rtl8192_getSupportedWireleeMode, rtl8192_SetWirelessMode,
      rtl8192_get_channel_map, rtl8192_init,
      rtl8192_hwconfig, rtl8192_adapter_start, TxCheckStuck,
      rtl819x_ifcheck_resetornot, CamRestoreAllEntry, rtl819x_ifsilentreset,
      rtl819x_update_rxcounts, rtl8192_open, r8192_set_mac_adr, rtl8192_ioctl,
      HwRateToMRate90, rtl819x_translate_todbm, rtl8192_process_phyinfo,
      rtl8192_record_rxdesc_forlateruse, rtl8192_rx_nomal,
      rtl819xusb_process_received_packet, rtl8192_rx_cmd.
      
      Fix the following sparse warnings in r8192U_core.c
      
      drivers/staging/rtl8192u/r8192U_core.c:241:6: warning: symbol 'CamResetAllEntry' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:676:6: warning: symbol 'tx_timeout' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1014:6: warning: symbol 'rtl8192_data_hard_stop' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1020:6: warning: symbol 'rtl8192_data_hard_resume' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1028:6: warning: symbol 'rtl8192_hard_data_xmit' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1056:5: warning: symbol 'rtl8192_hard_start_xmit' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1380:6: warning: symbol 'rtl8192_config_rate' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1427:6: warning: symbol 'rtl8192_update_cap' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1449:6: warning: symbol 'rtl8192_net_update' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:1677:4: warning: symbol 'MRateToHwRate8190Pci' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2043:6: warning: symbol 'rtl8192_link_change' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2075:6: warning: symbol 'rtl8192_update_beacon' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2090:5: warning: symbol 'WDCAPARA_ADD' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2091:6: warning: symbol 'rtl8192_qos_activate' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2319:6: warning: symbol 'GetHalfNmodeSupportByAPs819xUsb' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2333:6: warning: symbol 'rtl8192_refresh_supportrate' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2344:4: warning: symbol 'rtl8192_getSupportedWireleeMode' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2363:6: warning: symbol 'rtl8192_SetWirelessMode' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2783:7: warning: symbol 'rtl8192_get_channel_map' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2796:7: warning: symbol 'rtl8192_init' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2844:6: warning: symbol 'rtl8192_hwconfig' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:2927:6: warning: symbol 'rtl8192_adapter_start' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3183:12: warning: symbol 'TxCheckStuck' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3286:12: warning: symbol 'rtl819x_ifcheck_resetornot' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3325:6: warning: symbol 'CamRestoreAllEntry' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3401:6: warning: symbol 'rtl819x_ifsilentreset' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3521:6: warning: symbol 'rtl819x_update_rxcounts' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3638:5: warning: symbol 'rtl8192_open' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3758:5: warning: symbol 'r8192_set_mac_adr' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3774:5: warning: symbol 'rtl8192_ioctl' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3865:4: warning: symbol 'HwRateToMRate90' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3951:6: warning: symbol 'rtl819x_translate_todbm' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:3967:6: warning: symbol 'rtl8192_process_phyinfo' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:4453:6: warning: symbol 'rtl8192_record_rxdesc_forlateruse' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:4725:6: warning: symbol 'rtl8192_rx_nomal' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:4875:6: warning: symbol 'rtl819xusb_process_received_packet' was not declared. Should it be static?
      drivers/staging/rtl8192u/r8192U_core.c:4936:6: warning: symbol 'rtl8192_rx_cmd' was not declared. Should it be static?
      Signed-off-by: default avatarAna Rey <anarey@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      f4c6074a
    • Aybuke Ozdemir's avatar
      staging: solo6x10: solo6x10-v4l2-enc.c: Fix line over 80 characters. · fa91783e
      Aybuke Ozdemir authored
      Fix checkpatch.pl issues with line over 80 characters in solo6x10-v4l2-enc.c
      Signed-off-by: default avatarAybuke Ozdemir <aybuke.147@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      fa91783e
    • Iulia Manda's avatar
      staging: vt6656: Use __releases/__acquires annotations · 9009dd16
      Iulia Manda authored
      This patch fixes the following sparse warnings:
      
      drivers/staging/vt6656/usbpipe.c:147:24: warning: context imbalance in 'PIPEnsControlOut' - unexpected unlock
      drivers/staging/vt6656/usbpipe.c:209:24: warning: context imbalance in 'PIPEnsControlIn' - unexpected unlock
      Signed-off-by: default avatarIulia Manda <iulia.manda21@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      9009dd16
  2. 16 Mar, 2014 1 commit
  3. 14 Mar, 2014 10 commits
  4. 13 Mar, 2014 4 commits
    • Elena Oat's avatar
      Staging: rtl8188eu: Fix sparse warnings. · 160eaf20
      Elena Oat authored
      This patch fixes following warnings produced by sparse:
      
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31:    expected void
      const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3867:31:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38: warning:
      incorrect type in argument 1 (different address spaces)
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38:    expected void
      const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3869:38:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38: warning:
      incorrect type in argument 1 (different address spaces)
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38:    expected void
      const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3871:38:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38: warning:
      incorrect type in argument 1 (different address spaces)
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38:    expected void
      const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3873:38:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38: warning:
      incorrect type in argument 1 (different address spaces)
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38:    expected void
      const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3875:38:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38: warning:
      incorrect type in argument 1 (different address spaces)
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38:    expected void
      const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3878:38:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38: warning:
      incorrect type in argument 1 (different address spaces)
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38:    expected void
      const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3880:38:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38: warning:
      incorrect type in argument 1 (different address spaces)
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38:    expected void const *<noident>
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3883:38:    got void
      [noderef] <asn:1>*pointer
      drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3897:9: warning: cast
      removes address space of expression
      
      While at it, I have also fixed the warnings of lines over 80 characters.
      Signed-off-by: default avatarElena Oat <oat.elena@gmail.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      160eaf20
    • Gulsah Kose's avatar
      staging: rtl8712: Remove unnecessary parentheses. · 34a2c5fe
      Gulsah Kose authored
      Remove unnecessary parentheses from rtl871x_cmd.c
      Signed-off-by: default avatarGulsah Kose <gulsah.1004@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      34a2c5fe
    • Iulia Manda's avatar
      staging: unisys: visorutil: Use kzalloc instead of kmalloc with memset · 56116b2b
      Iulia Manda authored
      Fix coccinelle warnings of better allocation by using kzalloc.
      In these cases, kzalloc is preferred, as kmalloc may fail if it does not find
      contiguous memory.
      Signed-off-by: default avatarIulia Manda <iulia.manda21@gmail.com>
      Acked-by: default avatarLuis R. Rodriguez <mcgrof@do-not-panic.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      56116b2b
    • Iulia Manda's avatar
      staging: android: ion: Use ERR_CAST instead of ERR_PTR · 464a5028
      Iulia Manda authored
      Fix the following coccinelle warnings in ion.c:
      drivers/staging/android/ion/ion.c:511:9-16: WARNING: ERR_CAST can be used with buffer
      drivers/staging/android/ion/ion.c:218:9-16: WARNING: ERR_CAST can be used with table
      drivers/staging/android/ion/ion.c:1150:9-16: WARNING: ERR_CAST can be used with dmabuf
      Signed-off-by: default avatarIulia Manda <iulia.manda21@gmail.com>
      Acked-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: default avatarPeter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
      464a5028