Commits · a5b6ee06b21eaee64f100be8591fd51917bdbe36 · nexedi / linux

24 Nov, 2011 40 commits

[media] easycap: remove unused members of struct easycap · a5b6ee06

Tomas Winkler authored Nov 09, 2011

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

a5b6ee06

[media] easycap: easycap_usb_driver should be static to easycap_main.c · 4329f3c6
Tomas Winkler authored Nov 09, 2011
```
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```
4329f3c6

[media] easycap: use usb_kill_urb wrapper functions · 8b1fad2f

Tomas Winkler authored Nov 09, 2011

1. kill_video_usb can be used in all places where video urbs are killed
and reduce code repetition

2. remove unnecessary check for easycap == NULL in the function
as it is always checked by the calling function

3. rename the function to easycap_video_kill_urb to reduce
possibility of name conflict

4. implement also easycap_audio_kill_urb

5. simplify freeing urbs
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

8b1fad2f

[media] easycap: drop initializations to 0 in the probe functions · 7dfdae8e

Tomas Winkler authored Nov 09, 2011

peasycap was allocated using kzalloc so drop all
to zero initializations
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

7dfdae8e

[media] easycap: streamline the code · 101dca42

Tomas Winkler authored Nov 09, 2011

change statements of types
	if (err)
		return err
	else
		do something

and
	if (ok)
		do something
	else
		return err

into

	if (err)
		return err

	do something
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

101dca42

[media] easycap: compress initialization tables · 7dbb3920

Tomas Winkler authored Nov 09, 2011

1. saa and stk initialization tables are less then
256 entries
2. stk table can fit into u16 and saa into u8

size before
 text	   data	    bss	    dec	    hex	filename
 105687	   1072	1134800	1241559	 12f1d7	easycap.ko

size after

 text	   data	    bss	    dec	    hex	filename
 97919	   1072	1134800	1233791	 12d37f	easycap.ko
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

7dbb3920

[media] easycap: remove linux/version.h include from easycap_ioctl.c · 47cefc21
Tomas Winkler authored Nov 09, 2011
```
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
```
47cefc21

[media] easycap: cleanup function usage · 98680557

Tomas Winkler authored Nov 09, 2011

1. Remove declarations of none global functions from easycap.h
and make them static in the c-files.
2. Reorder static functions to reduce number of forward declarations.
3. Remove unused functions.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

98680557

[media] cx25821.h: Line up defines · c7855ee5

Leonid V. Fedorenchik authored Oct 22, 2011

Line up constant defines to the same column.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

c7855ee5

[media] cx25821-video.c: Change line endings · 0abfefbe

Leonid V. Fedorenchik authored Oct 22, 2011

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

0abfefbe

[media] cx25821-video.c: Fix indent · f2539814

Leonid V. Fedorenchik authored Oct 22, 2011

Fix indent of statements to improve readability.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

f2539814

[media] cx25821-video.c: Move operators · cd52b2cf

Leonid V. Fedorenchik authored Oct 22, 2011

Move operator in complex expression to the end of the line to preserve
consistency.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

cd52b2cf

[media] cx25821-video.c: Fix definitions · 4a33b6f8

Leonid V. Fedorenchik authored Oct 22, 2011

Change multiple definitions in one statement into multiple statements
with one definition per statement.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

4a33b6f8

[media] cx25821-video.c: Fix assignment · a1937e19

Leonid V. Fedorenchik authored Oct 22, 2011

Change double assignment in one statement into two assignment
statements.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

a1937e19

[media] cx25821-video.c: Change spaces · 1316b63c

Leonid V. Fedorenchik authored Oct 22, 2011

Change double spaces between lexemes into single spaces.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

1316b63c

[media] cx25821-video.c: Delete empty line · 7e7beb8c

Leonid V. Fedorenchik authored Oct 22, 2011

Delete unnecessary empty line.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

7e7beb8c

[media] cx25821-video-upstream.c: Change line endings · 8eb1fdff

Leonid V. Fedorenchik authored Oct 22, 2011

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

8eb1fdff

[media] cx25821-video-upstream.c: Fix indent · 2c68e933

Leonid V. Fedorenchik authored Oct 22, 2011

Change indent of statements to use tabs and to improve readability.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

2c68e933

[media] cx25821-video-upstream.c: Remove braces · 16f0fda7

Leonid V. Fedorenchik authored Oct 22, 2011

Delete curly braces around single if-else statements.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

16f0fda7

[media] cx25821-video-upstream-ch2.c: Change line endings · 85b7982d

Leonid V. Fedorenchik authored Oct 22, 2011

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

85b7982d

[media] cx25821-video-upstream-ch2.c: Remove braces · df253423

Leonid V. Fedorenchik authored Oct 22, 2011

Remove unnecessary curly braces around single if statement.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

df253423

[media] cx25821-video-upsstream-ch2.c: Move operators · 3a59fab4

Leonid V. Fedorenchik authored Oct 22, 2011

Move operators in complex expressions to the end of the lines to
preserve consistency.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

3a59fab4

[media] cx25821-video-upstream-ch2.c: Fix indent · 2a4492d8

Leonid V. Fedorenchik authored Oct 22, 2011

Change indent of statements with (less than 8) spaces to indent with
tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

2a4492d8

[media] cx25821-video-upstream-ch2.c: Line up comments · 3940de74

Leonid V. Fedorenchik authored Oct 22, 2011

Line up comments to match indent of surrounding statements.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

3940de74

[media] cx25821-medusa-video.c: Change line endings · 14098bc7

Leonid V. Fedorenchik authored Oct 22, 2011

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

14098bc7

[media] cx25821-medusa-video.c: Move operators · 49faae86

Leonid V. Fedorenchik authored Oct 22, 2011

Plase operators in complex expressions at the end of the lines to
preserve consistency.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

49faae86

[media] cx25821-medusa-video.c: Fix comment · 09c35440

Leonid V. Fedorenchik authored Oct 22, 2011

Delete part of the comment that is not checked in code.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

09c35440

[media] cx25821-medusa-reg.h: Line up defines · f70a6566

Leonid V. Fedorenchik authored Oct 22, 2011

Line up constant defines to the same column. (also delete unnecessary
spaces in comments)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

f70a6566

[media] cx25821-medusa-defines.h: Line up defines · 7618aa0e

Leonid V. Fedorenchik authored Oct 22, 2011

Line up constant defines to the same column.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

7618aa0e

[media] cx25821-medusa-defines.h: Fix typo · bc8b5dca

Leonid V. Fedorenchik authored Oct 22, 2011

Fix typo in comment in word 'decoder'.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

bc8b5dca

[media] cx25821-i2c.c: Change line endings · 654d075d

Leonid V. Fedorenchik authored Oct 22, 2011

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

654d075d

[media] cx25821-core.c: Change line endings · 3f0bfe5b

Leonid V. Fedorenchik authored Oct 22, 2011

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

3f0bfe5b

[media] cx25821-core.c: Fix indent · c14ea5e5

Leonid V. Fedorenchik authored Oct 22, 2011

Change indent of statements that indented with spaces to indent with
tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

c14ea5e5

[media] cx25821-core.c: Delete empty line · 43365d5d

Leonid V. Fedorenchik authored Oct 22, 2011

Delete redundant empty line.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

43365d5d

[media] cx25821-cards.c: Fix indent · 744992c0

Leonid V. Fedorenchik authored Oct 22, 2011

Fix indent of statement to use tab instead of spaces.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

744992c0

[media] cx25821-audio.h: Fix multiline defines · 6f1f0e85

Leonid V. Fedorenchik authored Oct 22, 2011

Change column of line continuation character ('\') and fix indent of
multiline defines.
Also line up remaining constant defines.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

6f1f0e85

[media] cx25821-audio.h: Line up defines · 8e249581

Leonid V. Fedorenchik authored Oct 22, 2011

Line up defines to the same column.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

8e249581

[media] cx25821-audio-upstream.c: Change line endings · 72a52fc3

Leonid V. Fedorenchik authored Oct 22, 2011

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

72a52fc3

[media] cx25821-audio-upstream.c: Move operators · 64dcb194

Leonid V. Fedorenchik authored Oct 22, 2011

Move operator of complex expression to the end of the lines to preserve
consistency.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

64dcb194

[media] cx25821-audio-upstream.c: Fix indent · 81f4c8dd

Leonid V. Fedorenchik authored Oct 22, 2011

Change wrong indent (with spaces and less than 7 columns) of statements
to tabs.
Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

81f4c8dd