- 14 Feb, 2014 40 commits
-
-
H Hartley Sweeten authored
Remove the unnecessary check of 'cmd->chanlist_len > 0'. The (*do_cmdtest) already validated this before the (*do_cmd) was called. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
It's not necessary to clear the returned data pointer when an (*insn_read) times out. For aesthetics, remove all of these in the drivers. Signed-off-by:
-
H Hartley Sweeten authored
Have the comedi core display a standard dev_dbg() message when a timeout occurs and remove all the driver specific messages. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input settle and end-of- conversion. These tests use different registers but the same bit so the register is passed as the 'context'. The same test is used in dmm32at_ai_cmd() but the 'insn' is not available. This is ok since the test function, and comedi_timeout() don't use it. Use comedi_timout() to wait for the analog output end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Combine the logic for the pcl812 and acl812 end-of-conversion in the helper function to simplify the driver. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input pipe full, scanning, amd end-of-conversion status. The status to check it passed as the 'context' to comedi_timeout(). Use comedi_timeout() to wait for the analog output end-of-conversion. This also fixes a possible bug where invalid data is returned for the analog input read if the conversion did not complete, The analog output has a similar possible bug where the cached readback value is incorrect if the conversion times out. Signed-off-by:
-
H Hartley Sweeten authored
The wait_for() macro in this driver is a bit nasty. It effects control flow which according to the CodingStyle is a _very_ bad idea. The mux_busy() and ad_done() macros are also bad since they rely on a local variable having a specific name. Remove these macros and use comedi_timeout() to wait for the analog input mux busy completion and end-of-conversion. Both of these are detected by reading the same register and testing different bits. Pass the bits to test as the 'context' to the callback function. The dt282x_ai_cmd() function also checks for the mux busy completion. The 'insn' is not available here but passing NULL is safe because nothing uses it. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. This prevents a deadlock condition that could occur by providing a timeout in case the end-of-conversion does not happen. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversion. Use break to exit the loop when a timeout occurs during the analog input read so that common code can be used to disable the device. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Also, remove some unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. This also fixes a possible bug where invalid data is returned if the conversion did not complete. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Change the errno returned when the conversion overflows from -ETIME to -EOVERFLOW. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. This prevents a deadlock condition that could occur by providing a timeout in case the end-of-conversion does not happen. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Remove the unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Change the errno returned for an overrun from -EIO to -EOVERFLOW. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog output end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
