- 20 Dec, 2013 24 commits
-
-
Wei Yongjun authored
Add the missing destroy_workqueue() before return from sep_crypto_setup() and sep_crypto_takedown(). Signed-off-by:
Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Wei Yongjun authored
In case of error, the function crypto_alloc_hash() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by:
-
Andreas Frembs authored
Checkpatch mentioned that these macros should be defined with a 'do {...} while(0)' statement. So we used grep to find all files using these macros and we found out that these macros were only used in rtl819x_Qos.h, in the defines we removed before. Since the macros are not used anywhere else we decided to remove them from the driver. Signed-off-by:Andreas Frembs <andreas.frembs@studium.uni-erlangen.de> Signed-off-by:
Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de> Signed-off-by:
-
Andreas Frembs authored
In rtl819x_Qos.h there were several macros defined but never used. So we removed this macros. Signed-off-by:
-
Andreas Frembs authored
This patch fixes the following checkpatch errors from rtllib_endianfree.h: - ERROR: Macros with complex values should be enclosed in parenthesis Signed-off-by:
-
Michael Hoefler authored
In this patch we fix some "logical" errors in bypass.c of the silicom bypass driver (in staging). Checkpatch complains about the following errors: - unnecessary forward declarations in a source file - assignment in if condition In addition to that the __init and __exit macros were missing at the init and cleanup function. There are still two warnings left for this file related to too many leadingtabs at nested blocks. I did not touch this issue becasue the code needs really some refactoring. And since i do not have the appropriate hardware to test the code, i do not change the functionality in any way. Signed-off-by:
Michael Hoefler <michael.hoefler@studium.uni-erlangen.de> Signed-off-by:
Christoph Kohl <christoph.kohl@t-online.de> Signed-off-by:
-
Michael Hoefler authored
This patch improves bypass.c (in staging) in terms of coding style. This includes different issues some of them mentioned by checkpatch: - a c++ one line comment - parenthesis at return statementes - multiple definitions in one line - missing braces according to the style guide Signed-off-by:
-
Michael Hoefler authored
This patch addresses several problems in bypass.c found by checkpatch. Furthermore it removes/adds some empty lines to make the code more readable. The following problems are fixed: - line over 80 characters - space after logical operator ! - spaces instead of tabs - missing empty line after local declarations - empty line after { The empty line issues were not discovered by checkpatch but in my opinion these changes make perfect sense in terms of readability. Signed-off-by: -
Larry Finger authored
Each instance may bre replaced by udelay Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Larry Finger authored
This wrapper does nothing on Linux. When calls to it were removed, a number of routines became empty and could also be removed. Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Larry Finger authored
Again there are two - _exit_critical() and _exit_critical_ex(). Signed-off-by:
-
Larry Finger authored
There are two such wrappers - _enter_critical() and _enter_critical_ex(). Signed-off-by:
-
Larry Finger authored
With this change, a number of variables for storing flags are no longer used. Signed-off-by:
-
Larry Finger authored
Some comment lines that mentioned spin_lock_bh() are also removed. Signed-off-by:
-
Larry Finger authored
Signed-off-by:
-
Lidza Louina authored
Originally, this driver created it's own allocating function. This patch removes that function and calls kzalloc directly. This patch affects: - driver.c - driver.h - fep5.c - tty.c Signed-off-by:
Lidza Louina <lidza.louina@gmail.com> Signed-off-by:
-
stalinsrinivasan.s authored
This is a patch to the dgnc_cls.c file that fixes up comparison with jiffies usage warning found by the checkpatch.pl tool Signed-off-by:
S. Stalin Srinivasan <stalinsrinivasan.s@gmail.com> Signed-off-by:
-
stalinsrinivasan.s authored
This is a patch to the dgnc_cls.c file that fixes up volatile usage warning found by the checkpatch.pl tool Signed-off-by:
-
stalinsrinivasan.s authored
This is a patch to the dgnc_cls.c file that fixes up 80 characters per line and code indent warnings found by the checkpatch.pl tool. Signed-off-by:
-
John Stultz authored
Prior to subitting this, Colin reworked the compat_ioctl support for the ion_test driver, moving the structure to be the same size on both 32 and 64 bit architectures. Two small things were left out. The compat_ioctl ptr assignment, and the fact that despite having uniform sized types in the structure, the structure pads out to different sizes on different arches. This patch resolves this issue by adding a padding entry after the write flag, and adding the compat_ioctl ptr. Changes in v2: - Add a padding int rather then making write a u64 Acked-by:
Colin Cross <ccross@android.com> Cc: Android Kernel Team <kernel-team@android.com> Signed-off-by:
John Stultz <john.stultz@linaro.org> Signed-off-by:
-
- 19 Dec, 2013 8 commits
-
-
Masanari Iida authored
This patch fixed trailing whitespace found by checkpatch.pl within dgap_trace.c Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Gokulnath A authored
Fixed all the line over 80 characters warning found by checkpatch.pl script. Signed-off-by:
Gokulnath A <Gokulnath.Avanashilingam@in.bosch.com> Signed-off-by:
-
Gokulnath A authored
Removed the developer debug prints BCM_DEBUG_PRINT() as per the TODO list, also removed braces for the if-statement to match coding style Signed-off-by:
-
Gary Rookard authored
I have deleated some unintelligible comments, and made a few minor white space corrections. Signed-off-by: Gary Alan Rookard Signed-off-by: -
Masanari Iida authored
This patch fixed "ERROR:trailing whitespace found by checkpatch.pl within dgap_tty.c Signed-off-by:
-
Masanari Iida authored
This patch fix "ERROR: trailing whitespace found by checkpatch.pl, whithin downld.c Signed-off-by:
-
Aaron Sierra authored
Signed-off-by:
Aaron Sierra <asierra@xes-inc.com> Signed-off-by:
-
Aaron Sierra authored
Now that the VME userspace API structures compile to a consistent size in mixed environments (32-bit userspace and 64-bit kernel), enable the .compat_ioctl to allow ioctls to execute in this environment. Signed-off-by:
-
- 18 Dec, 2013 8 commits
-
-
Gary Rookard authored
removed C99 comments to follow the linux kernel coding style thus fixing checkpatch errors respectfully. Signed-off-by:
Gary Alan Rookard <garyrookard@gmail.com> Signed-off-by:
-
John Stultz authored
RT_MUTEXES can be configured out of the kernel, causing compile problems with ION. To quote Colin: "rt_mutexes were added with the deferred freeing feature. Heaps need to return zeroed memory to userspace, but zeroing the memory on every allocation was causing performance issues. We added a SCHED_IDLE thread to zero memory in the background after freeing, but locking the heap from the SCHED_IDLE thread might block a high priority allocation thread for a long time. The lock is only used to protect the heap's free_list and free_list_size members, and is not held for any long or sleeping operations. Converting to a spinlock should prevent priority inversion without using the rt_mutex. I'd also rename it to free_lock to so it doesn't get used as a general heap lock." Thus this patch converts the rt_mutex usage to a spinlock and renames the lock free_lock to be more clear as to its use. I also had to change a bit of logic in ion_heap_freelist_drain() to safely avoid list corruption. Acked-by:
Jim Davis <jim.epost@gmail.com> Signed-off-by:
-
Matthias Wirth authored
These two macros needed reformatting but as they are not used anywhere we just removed them. Signed-off-by:
Matthias Wirth <matthias.wirth@gmail.com> Signed-off-by:
Lukas Senger <lukas@fridolin.com> Signed-off-by:
-
Matthias Wirth authored
Signed-off-by:
-
Matthias Wirth authored
Signed-off-by:
-
Eli Billauer authored
This patch replicates the correction made by Wei Yongjun on a second occurrence of the same bug. The first correction was in commit 8eec4555. Bug fixed: The error code was not set, so the error condition wasn't reflected in the return value. Reported-by:
Eli Billauer <eli.billauer@gmail.com> Signed-off-by:
-
Alan authored
Scan only to the length permitted by the buffer One of a set of sscanf problems noted by Jackie Chang Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Aaron Sierra authored
This patch updates the vme_master and vme_slave structures to use types with well defined size and to prevent the compiler from inserting padding (between enable and vme_addr for one). The original vme_master and vme_slave structs would be different sizes and have different layouts depending on whether they were built for a 32-bit or 64-bit system. On x86 it is possible to have a 32-bit userspace and a 64-bit kernel. In this type of environment, the userspace and kernel vme_user APIs would disagree and prevent ioctls from executing (based on ioctl signatures from _IOR and _IOW). Signed-off-by:
Martyn Welch <martyn.welch@ge.com> Signed-off-by:
-
