- 11 Mar, 2016 29 commits
-
-
Sandhya Bankar authored
Staging: most: Use usb_endpoint_dir_in(endpoint) instead of (endpoint->bEndpointAddress & USB_DIR_IN). Use usb_endpoint_dir_in(endpoint) instead of (endpoint->bEndpointAddress & USB_DIR_IN) to check if the endpoint has IN direction. This correction is based on following semantic patch, @@ struct usb_endpoint_descriptor *endpoint; expression E; @@ ( - endpoint->bEndpointAddress & USB_DIR_IN + usb_endpoint_dir_in(endpoint) | - endpoint->bEndpointAddress == USB_DIR_IN + usb_endpoint_dir_in(endpoint) | - (endpoint->bEndpointAddress & E) == USB_DIR_IN + usb_endpoint_dir_in(endpoint) ) Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhumika Goyal authored
This patch replaces list_entry with list_first_entry as it makes the code more clear. Done using coccinelle: @@ expression e; @@ ( - list_entry(e->next, + list_first_entry(e, ...) | - list_entry(e->prev, + list_last_entry(e, ...) ) Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Replace pr_err() calls with respective dev_err() counterpart. Semantic patch used to detect and apply the transformation: @r exists@ identifier f,s,i; position p; @@ f(...,struct s *i,...) { <+... pr_err@p(...) ...+> } @s@ identifier r.s, dev; @@ struct s { ... struct device dev; ... }; @t@ identifier r.i, s.dev; expression fmt; position r.p; @@ - pr_err@p( + dev_err(&i->dev, fmt, ...); Signed-off-by:Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
All devm functions has a device structure as the first argument which is required by dev_{err,info,dbg} printing functions. This patch converts pr_err to dev_err as dev_* is preferred after calls to devm functions. Done using coccinelle: @r1 exists@ expression e,e1; identifier f =~ "^devm_"; identifier g =~ "^pcim_"; identifier h =~ "^dmam_"; @@ e=\(f\|g\|h\)(e1,...); <+... ( - pr_info( + dev_info(e1, ...); | - pr_err( + dev_err(e1, ...); | - pr_debug( + dev_dbg(e1, ...); ) ...+> Signed-off-by: -
David Kershner authored
This patch fixes the smatch error: drivers/staging/unisys/visorbus/visorchipset.c:2217 visorchipset_ioctl() warn: user controlled 'adjustment' cast to postive rl = 's64min-s64max' This is because we read a s64 and pass it to a function as u64. Signed-off-by:
David Kershner <david.kershner@unisys.com> Signed-off-by:
-
Sandhya Bankar authored
Remove & from function name,when function name passed as an argument to another function. Function name is used as pointer without &. Signed-off-by:
-
Ben Marsh authored
This a patch to card.c to remove unnecessary blank lines in order to remove a checkpatch.pl warning. Signed-off-by:
Ben Marsh <bmarsh94@gmail.com> Signed-off-by:
-
Rehas Sachdeva authored
This patch removes the following checkpatch.pl warnings: Unnecessary parentheses around al7230_init_table_amode[0][0] Unnecessary parentheses around al7230_channel_table2[0][0] Signed-off-by:
Rehas Sachdeva <aquannie@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
Removing camel case and type prefix. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
Removing camel case and type prefix. Signed-off-by:
-
Malcolm Priestley authored
Removing camel case and type prefix. Signed-off-by:
-
Malcolm Priestley authored
Removing camel case and type prefix. Signed-off-by:
-
Malcolm Priestley authored
Removing the macro from functions. Signed-off-by:
-
Malcolm Priestley authored
Removing VNSvInPortB and nesting inside iowrite8. Signed-off-by:
-
Malcolm Priestley authored
removing byOrgValue variable. Signed-off-by:
-
Malcolm Priestley authored
removing macro from functions Signed-off-by:
-
Malcolm Priestley authored
removig macro from functions. Signed-off-by:
-
Malcolm Priestley authored
Removing the macro from functions. Signed-off-by:
-
Malcolm Priestley authored
All addressing is limited to 32 bits match this to all functions and port out functions. Signed-off-by:
-
Malcolm Priestley authored
Removing the need for variable ii. Signed-off-by:
-
Malcolm Priestley authored
Removing camel case and type prefix. Signed-off-by:
-
Malcolm Priestley authored
Use memcpy_fromio to store data removing the need for local count. Signed-off-by:
-
Malcolm Priestley authored
Removing dwData variable altogether. The reads are always 32 bit insize. Signed-off-by:
-
Malcolm Priestley authored
Removing byData variable altogether. Signed-off-by:
-
Malcolm Priestley authored
Removing camel case. Signed-off-by:
-
James Simmons authored
In the case of lustre routers you only need a functioning LNet stack. Especially since often the routers are very light weight and want to avoid any addition software that would create additional pressures on the system. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
James Simmons authored
Include a help section for Kconfig LNET. Signed-off-by:
-
James Simmons authored
A few errors exist for the Kconfig option LNET_MAX_PAYLOAD. First mistake is the default size is 1MB not 2MB as it is shown to the person configuring the kernel. Second the LNET_MAX_PAYLOAD option is more closely related to LNET than the LUSTRE_FS option. Signed-off-by:
-
James Simmons authored
The lustre file system has a layered architecture with libcfs as the lowest layer and LNet layered on top. Then on top of LNet we run the lustre client. This patch moves the libcfs module code out of lustre into the lnet tree. This fits into the long term goal of eventually merging libcfs into LNet. Signed-off-by:
-
- 08 Mar, 2016 9 commits
-
-
James Simmons authored
Sometime ago a patch was submitted to duplicate the proc_call_handler code in the LNet layer. This was due to the thinking libcfs was not used by the LNet layer. This was a wrong assumption so lets make LNet use the lprocfs_call_handler from the libcfs layer. Signed-off-by:
-
James Simmons authored
Using proc_call_handler as a function name is way too generic. Rename to lprocfs_call_handler to avoid possible collisions. Signed-off-by:
-
James Simmons authored
The ln_refcount test was changed into an assert. Signed-off-by:
-
James Nunez authored
Several error messages are missing newline characters at the end of the message. Newlines are added where necessary and other minor corrections; no punctuation at the end of an error message, add a return code to the end of error messages, device name at the beginning, etc. There are just a couple of places where newlines are removed and this is only in LDLM_DEBUG_NOLOCK. The definition of LDLM_DEBUG_NOLOCK already has a newline in it and resulted in double newlines printed. Signed-off-by:
James Nunez <james.a.nunez@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4871 Reviewed-on: http://review.whamcloud.com/10000Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
John L. Hammond <john.hammond@intel.com> Reviewed-by:
Cliff White <cliff.white@intel.com> Signed-off-by:
-
Sebastien Buisson authored
Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by:
Sebastien Buisson <sbuisson@ddn.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2744 Reviewed-on: http://review.whamcloud.com/6568Reviewed-by:
Bob Glossman <bob.glossman@intel.com> Reviewed-by:
-
Sebastien Buisson authored
Fix 'NULL pointer dereference' defects found by Coverity version 6.5.3: Dereference after null check (FORWARD_NULL) For instance, Passing null pointer to a function which dereferences it. Dereference before null check (REVERSE_INULL) Null-checking variable suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Dereference null return value (NULL_RETURNS) The following fixes for the LNet layer are broken out of patch http://review.whamcloud.com/4720. Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Sebastien Buisson authored
Fix 'data race condition' defects found by Coverity version 6.5.0: Data race condition (MISSING_LOCK) Accessing variable without holding lock. Elsewhere, this variable is accessed with lock held. Signed-off-by:
Liang Zhen <liang.zhen@intel.com> Reviewed-by:
-
Liang Zhen authored
Incoming lnet message can be delayed for seconds if it can match any of LNet Delay Rules. User can add/remove/list Delay Rule by lctl commands: - lctl net_delay_add Add a new Delay Rule to LNet, options <-s | --source SRC_NID> <-d | --dest DST_NID> <<-r | --rate RATE_NUMBER> <-i | --interlval SECONDS>> <-l | --latency DELAY_LATENCY> - lctl net_delay_del Remove matched Delay Rule from LNet, options: <[-a | --all] | <-s | --source SRC_NID> <-d | --dest DST_NID>> - lctl net_delay_list List all Delay Rules in LNet - lctl net_delay_reset Reset statistic counters for all Delay Rules Signed-off-by:
Amir Shehata <amir.shehata@intel.com> Reviewed-by:
Bobi Jam <bobijam@gmail.com> Reviewed-by:
-
Liang Zhen authored
This is implementation of LNet Drop Rule, which can randomly drop LNet messages at specified rate. LNet Drop Rule can only be applied to receive side of message. User can add drop_rule either on end point of cluster (client/server) or on LNet routers. Here are lctl command to control LNet Drop Rules: - net_drop_add -s SRC_NID -d DEST_NID --rate VALUE drop 1/@VALUE of messages from @SRC_NID to @DEST_NID - net_drop_del -s SRC_NID -d DEST_NID remove all drop rules from @SRC_NID to @DEST_NID - net_drop_list list all drop rules on current node Examples: - lctl net_drop_add -s *@o2ib0 -d 192.168.1.102@tcp 1000 add new drop rule, it will drop 1/1000 messages from network o2ib0 to 192.168.1.102@tcp - lctl net_drop_add -s 10.8.6.123@o2ib1 -d * 500 add new drop rule, it will drop 1/500 messages from 10.8.6.123@o2ib1 to all nodes Signed-off-by:
Johann Lombardi <johann.lombardi@intel.com> Reviewed-by:
-
- 05 Mar, 2016 2 commits
-
-
Arnd Bergmann authored
The icn, act2000 and pcbit drivers are all for very old hardware, and it is highly unlikely that anyone is actually still using them on modern kernels, if at all. All three drivers apparently are for hardware that predates PCI being the common connector, as they are ISA-only and active PCI ISDN cards were widely available in the 1990s. Looking through the git logs, it I cannot find any indication of a patch to any of these drivers that has been tested on real hardware, only cleanups or global API changes. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Acked-by:
Karsten Keil <isdn@linux-pingi.de> Signed-off-by:
-
Arnd Bergmann authored
The icn driver currently produces an unconditional #warning whenever we build it, introduced by Karsten Keil back in 2003: #warning TODO test headroom or use skb->nb to flag ACK Karsten's original commit (from BitKeeper) contains this description: - here are lot of bugs left, so ISDN is not stable yet but I think it's really time to fix it, even if it need some cycles to get it right (normally I'm only send patches if it works 100% for me). - I add some additional #warnings to address places which need fixing (I hope that some of the other ISDN developer jump in) Apparently this has not happened, and it is unlikely that it ever will, given that the driver doesn't seem to work. No substantial bug fixes other than janitorial cleanups have happened in the driver since then, and I see no indication that anyone who patched it had the hardware. We should probably either remove the driver, or remove all of i4l, but for now, this shuts up the distracting #warning by turning it into a comment. Signed-off-by:
-
