1. 04 Nov, 2014 2 commits
    • Peter Hurley's avatar
      drm: Remove compiler BUG_ON() test · b74c6c92
      Peter Hurley authored
      modeset->num_connectors must be 0 to reach the BUG_ON() which tests
      for non-zero modeset->num_connectors; remove BUG_ON().
      Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      b74c6c92
    • Peter Hurley's avatar
      drm: Fix DRM_FORCE_ON_DIGITAL use · 2c4cc91b
      Peter Hurley authored
      A connector may be forced on from the command line via video=
      command line setting. The digital output of dual-mode connectors
      can also be specifically selected and forced on; eg., 'video=DVI-I-2:D'.
      However, in this case, the connector->status will be mistakenly set to
      connector_status_disconnected, and the connector will not be mode set.
      
      Fix the connector->status when connector->force is DRM_FORCE_ON_DIGITAL.
      
      Note that this seems to have been broken ever since the introduction
      of the connector forcing support in
      
      commit d50ba256
      Author: Dave Airlie <airlied@linux.ie>
      Date:   Wed Sep 23 14:44:08 2009 +1000
      
          drm/kms: start adding command line interface using fb.
      Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
      [danvet: Add note about that this never worked.]
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      2c4cc91b
  2. 31 Oct, 2014 3 commits
  3. 23 Oct, 2014 2 commits
  4. 22 Oct, 2014 2 commits
  5. 21 Oct, 2014 1 commit
  6. 13 Oct, 2014 1 commit
  7. 12 Oct, 2014 1 commit
    • Joe Perches's avatar
      drm: drm_err: Remove unnecessary __func__ argument · a1f1a79c
      Joe Perches authored
      Removing the unnecessary drm_err __func__ argument by using
      the equivalent %pf and __builtin_return_address(0) makes the
      code smaller for every use of the DRM_ERROR macro.
      
      For instance: (allmodconfig)
      
      $ size drivers/gpu/drm/i915/i915.o*
         text	   data	    bss	    dec	    hex	filename
       922447	 193257	 296736	1412440	 158d58	drivers/gpu/drm/i915/i915.o.new
       928111	 193257	 296736	1418104	 15a378	drivers/gpu/drm/i915/i915.o.old
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      a1f1a79c
  8. 08 Oct, 2014 1 commit
  9. 03 Oct, 2014 1 commit
  10. 01 Oct, 2014 4 commits
  11. 30 Sep, 2014 6 commits
  12. 25 Sep, 2014 1 commit
    • Daniel Vetter's avatar
      drm: Drop grab fpriv->fbs_lock in drm_fb_release · 1b116297
      Daniel Vetter authored
      Paulo Zanoni reported a lockdep splat with a locking inversion between
      fpriv->fbs_lock and the modeset locks. This issue was introduced in
      
      commit f2b50c11
      Author: Daniel Vetter <daniel.vetter@ffwll.ch>
      Date:   Fri Sep 12 17:07:32 2014 +0200
      
          drm: Fixup locking for universal cursor planes
      
      This here is actually one of the rare cases where lockdep hits a false
      positive: The deadlock only happens in drm_fb_release, which cleans up
      the file private structure when all the references are gone. So the
      locking is the very last one and no one else can deadlock. It also
      doesn't protect anything at all, since all ioctls are guaranteed to
      have returned at this point - otherwise they'd still hold a reference
      on the file.
      
      So let's just drop it and replace it with a big comment.
      
      Cc: David Herrmann <dh.herrmann@gmail.com>
      Cc: Matt Roper <matthew.d.roper@intel.com>
      Cc: Paulo Zanoni <przanoni@gmail.com>
      Reported-and-Tested-by: default avatarPaulo Zanoni <przanoni@gmail.com>
      Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
      1b116297
  13. 24 Sep, 2014 15 commits