1. 22 Dec, 2003 1 commit
  2. 21 Dec, 2003 1 commit
  3. 19 Dec, 2003 3 commits
  4. 18 Dec, 2003 7 commits
  5. 17 Dec, 2003 3 commits
    • Linus Torvalds's avatar
      Linux 2.6.0 · 67e9bb60
      Linus Torvalds authored
      67e9bb60
    • Jes Sorensen's avatar
      [PATCH] qla1280 crash fix in error handling · 0e70f996
      Jes Sorensen authored
      This fixes a bug in the qla1280 driver where it would leave a pointer to
      an on the stack completion event in a command structure if
      qla1280_mailbox_command fails.  The result is that the interrupt handler
      later tries to complete() garbage on the stack.  The mailbox command can
      fail if a device on the bus decides to lock up etc.
      0e70f996
    • Jens Axboe's avatar
      [PATCH] CDROM_SEND_PACKET bug · f75da5af
      Jens Axboe authored
      I just found Yet Another Bug in scsi_ioctl - CDROM_SEND_PACKET puts a
      kernel pointer in hdr->cmdp, where sg_io() expects to find user address.
      This worked up until recently because of the memcpy bug, but now it
      doesn't because we do the proper copy_from_user(). 
      
      This fix undoes the user copy code from sg_io, and instead makes the
      SG_IO ioctl copy it locally.  This makes SG_IO and CDROM_SEND_PACKET
      agree on the calling convention, and everybody is happy. 
      
      I've tested that both
      
         cdrecord -dev=/dev/hdc -inq
      
      and
      
         cdrecord -dev=ATAPI:/dev/hdc -inq
      
      works now.  The former will use SG_IO, the latter CDROM_SEND_PACKET (and
      incidentally would work in both 2.4 and 2.6, if it wasn't for
      CDROM_SEND_PACKET sucking badly in 2.4).
      f75da5af
  6. 15 Dec, 2003 3 commits
    • Jens Axboe's avatar
      [PATCH] Fix IDE bus reset and DMA disable when reading blank DVD-R · 314dc154
      Jens Axboe authored
      From Jon Burgess:
      
        There is a problems with blank DVD media using the ide-cd driver.
      
        When we attempt to read the blank disk, the drive responds to the read
        request by returning a "blank media" error.  The kernel doesn't have
        any special case handling for this sense value and retries the request
        a couple of times, then gives up and does a bus reset and disables DMA
        to the device.
      
        Which obviously doesn't help the situation.
      
        The sense key value of 8 isn't listed in ide-cd.h, but it is listed in
        scsi.h as a "BLANK_CHECK" error.
      
        This trivial patch treats this error condition as a reason to abort
        the request.  This behaviour is the same as what we do with a blank CD-R.
      
        It looks like the same fix might be desired for 2.4 as well, although
        is perhaps not so important since scsi-ide is normally used instead.
      314dc154
    • Linus Torvalds's avatar
      Merge bk://linuxusb.bkbits.net/gregkh-2.6 · 3f69168f
      Linus Torvalds authored
      into home.osdl.org:/home/torvalds/v2.5/linux
      3f69168f
    • Neil Brown's avatar
      [PATCH] Fix possible bio corruption with RAID5 · e1f936a9
      Neil Brown authored
       1/ make sure raid5 doesn't try to handle multiple overlaping
          requests at the same time as this would confuse things badly.
          Currently it justs BUGs if this is attempted.
       2/ Fix a possible data-loss-on-write problem.  If two or
          more bio's that write to the same page are processed at the
          same time, only the first was actually commited to storage.
       3/ Fix a use-after-free bug.  raid5 keeps the bio's it is given
          in linked lists when more than one bio touch a single page.
          In some cases the tail of this list can be freed, and
          the current test for 'are we at the end' isn't reliable.
          This patch strengths the test to make it reliable.
      e1f936a9
  7. 14 Dec, 2003 1 commit
    • Linus Torvalds's avatar
      Fix thread group leader zombie leak · 056ffaad
      Linus Torvalds authored
      Petr Vandrovec noticed a problem where the thread group leader
      would not be properly reaped if the parent of the thread group
      was ignoring SIGCHLD, and the thread group leader had exited
      before the last sub-thread.
      
      Fixed by Ingo Molnar.
      056ffaad
  8. 13 Dec, 2003 3 commits
    • Linus Torvalds's avatar
      More subtle SMP bugs in prepare_to_wait()/finish_wait(). · e220fdf7
      Linus Torvalds authored
      This time we have a SMP memory ordering issue in prepare_to_wait(),
      where we really need to make sure that subsequent tests for the
      event we are waiting for can not migrate up to before the wait
      queue has been set up.
      e220fdf7
    • René Scharfe's avatar
      [PATCH] HPFS: missing lock_kernel() in hpfs_readdir() · 14c5d2d2
      René Scharfe authored
      In 2.5.x, the BKL was pushed from vfs_readdir() into the filesystem
      specific functions.  But only the unlock_kernel() made it into the HPFS
      code, lock_kernel() got lost on the way.  This rendered the filesystem
      unusable.
      
      This adds the missing lock_kernel().  It's been tested by Timo Maier who
      also reported the problem earlier today.
      14c5d2d2
    • Jens Axboe's avatar
      [PATCH] no bio unmap on cdb copy failure · 5965168e
      Jens Axboe authored
      The previous scsi_ioctl.c patch didn't cleanup the buffer/bio in the
      error case. 
      
      Fix it by copying the command data earlier.
      5965168e
  9. 12 Dec, 2003 1 commit
  10. 11 Dec, 2003 1 commit
  11. 10 Dec, 2003 3 commits
  12. 09 Dec, 2003 7 commits
    • Herbert Xu's avatar
      [PATCH] USB: Fix connect/disconnect race · 08bceb43
      Herbert Xu authored
      This patch was integrated by you in 2.4 six months ago.  Unfortunately
      it never got into 2.5.  Without it you can end up with crashes such
      as http://bugs.debian.org/218670
      08bceb43
    • Alan Stern's avatar
    • Oliver Neukum's avatar
      [PATCH] USB: fix race with signal delivery in usbfs · 41b98670
      Oliver Neukum authored
      apart from locking bugs, there are other races. This fixes one with
      signal delivery. The signal should be delivered _before_ the reciever
      is woken.
      41b98670
    • Oliver Neukum's avatar
      [PATCH] USB: fix sleping in interrupt bug in auerswald driver · 697a025d
      Oliver Neukum authored
      this fixes two instances of GFP_KERNEL from completion handlers.
      697a025d
    • Tom Rini's avatar
      [PATCH] USB: mark the scanner driver as obsolete · cee0c0dd
      Tom Rini authored
      On Mon, Dec 01, 2003 at 11:21:58AM -0800, Greg KH wrote:
      > Can't you use xsane without the scanner kernel driver?  I thought the
      > latest versions used libusb/usbfs to talk directly to the hardware.
      > Because of this, the USB scanner driver is marked to be removed from the
      > kernel sometime in the near future.
      
      After a bit of mucking around (and possibly finding a bug with debian's
      libusb/xsane/hotplug interaction, nothing seems to run
      /etc/hotplug/usb/libusbscanner and thus only root can scan, anyone whose
      got this working please let me know), the problem does not exist if I
      only use  libusb xsane.
      
      How about the following:
      cee0c0dd
    • Matthew Dharm's avatar
      [PATCH] USB storage: fix for jumpshot and datafab devices · bc26e4e4
      Matthew Dharm authored
      This patch fixes some obvious errors in the jumpshot and datafab drivers.
      
      This should close out Bugzilla bug #1408
      
      > Date: Mon, 1 Dec 2003 12:14:53 -0500 (EST)
      > From: Alan Stern <stern@rowland.harvard.edu>
      > Subject: Patch from Eduard Hasenleithner
      > To: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
      > cc: USB Storage List <usb-storage@one-eyed-alien.net>
      >
      > Matt:
      >
      > Did you see this patch?  It was posted to the usb-development mailing list
      > about a week ago, before I started making all my changes.  It is clearly
      > correct and necessary.
      >
      > Alan Stern
      bc26e4e4
    • Jens Axboe's avatar
      [PATCH] scsi_ioctl memcpy'ing user address · 8cc86c08
      Jens Axboe authored
      James reported a bug in scsi_ioctl.c where it mem copies a user pointer
      instead of using copy_from_user(). I inadvertently introduced this one
      when getting rid of CDROM_SEND_PACKET. Here's a trivial patch to fix it.
      8cc86c08
  13. 08 Dec, 2003 4 commits
  14. 07 Dec, 2003 2 commits
    • James McMechan's avatar
      [PATCH] tmpfs oops fix · 6f781f0c
      James McMechan authored
      The problem was that the cursor was in the list being walked, and when
      the pointer pointed to the cursor the list_del/list_add_tail pair would
      oops trying to find the entry pointed to by the prev pointer of the
      deleted cursor element.
      
      The solution I found was to move the list_del earlier, before the
      beginning of the list walk. since it is not used during the list walk and
      should not count in the list enumeration it can be deleted, then the
      list pointer cannot point to it so it can be added safely with the
      list_add_tail without oopsing, and everything works as expected.
      
      I am unable to oops this version with any of my test programs. 
      
      Patch acked by Al Viro.
      6f781f0c
    • Linus Torvalds's avatar
      Merge master.kernel.org:/home/davem/BK/net-2.5 · 0e3a42cc
      Linus Torvalds authored
      into home.osdl.org:/home/torvalds/v2.5/linux
      0e3a42cc