1. 07 Aug, 2008 4 commits
    • Andrew Morton's avatar
      PCI: make pci_register_driver() a macro · bba81165
      Andrew Morton authored
      alpha:
      
      CC [M]  drivers/usb/gadget/u_ether.o
      In file included from include/asm/dma-mapping.h:7,
                       from include/linux/dma-mapping.h:52,
                       from include/linux/dmaengine.h:29,
                       from include/linux/skbuff.h:29,
                       from include/linux/if_ether.h:114,
                       from include/linux/etherdevice.h:27,
                       from drivers/usb/gadget/u_ether.c:29:
      include/linux/pci.h: In function 'pci_register_driver':
      include/linux/pci.h:673: error: 'KBUILD_MODNAME' undeclared (first use in this function)
      include/linux/pci.h:673: error: (Each undeclared identifier is reported only once
      include/linux/pci.h:673: error: for each function it appears in.)
      
      Sam says:
      
      The problem is that u_ether.o is used by two modules so when we build it
      KBUILD_MODNAME is not defined because kbuild does not know what value to
      use.
      
      And in pci.h we have the following inline:
      
      static inline int __must_check pci_register_driver(struct pci_driver *driver)
      {
              return __pci_register_driver(driver, THIS_MODULE, KBUILD_MODNAME);
      }
      
      And alpha uses dma-mapping.h to nullify a number of functions that seem to
      require something from pci.h.
      
      Making it a macro fixes this particular problem.  However, the underlying issue
      of a file using KBUILD_MODNAME and being shared between multiple modules is
      *not* addressed.  I guess the answer there is "don't do that".
      
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Cc: Greg KH <greg@kroah.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
      bba81165
    • Eric Dumazet's avatar
      PCI: add Broadcom 5708S to VPD length quirk · 9d82d8ea
      Eric Dumazet authored
      BCM5708S wont work correctly unless VPD length truncated to 128
      Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
      9d82d8ea
    • Linus Torvalds's avatar
      Revert "pcm_native.c: remove unused label" · 685d87f7
      Linus Torvalds authored
      This reverts commit 680db013.  The label
      is actually used, but hidden behind CONFIG_SND_DEBUG and the horrible
      snd_assert() macro.
      
      That macro could probably be improved to be along the lines of
      
      	#define snd_assert(expr, args...) do { if ((void)(expr),0) { args; } } while (0)
      
      or similar to make sure that we always both evaluate 'expr' and parse
      'args', but while gcc should optimize it all away, I'm too lazy to
      really verify that.  So I'll just admit defeat and will continue to live
      with the annoying warning.
      Noted-by: default avatarRobert P. J. Day <rpjday@crashcourse.ca>
      Signed-off-by: Linus "Grr.." Torvalds
      685d87f7
    • Linus Torvalds's avatar
      iSeries: Fix up viotty_ioctl BKL locking fallout · f99e8f27
      Linus Torvalds authored
      The bogus code to call into the n_tty layer got removed in commit
      8bc5fb6a ("Remove bogons from the
      iSeries console"), but it left a now uninitialized "return ret;" around.
      
      Not that this code has ever even compiled since the BKL pushdown, since
      not only is "ret" no longer initialized, it was never actually declared
      even originally.
      
      Replace it with a "return -ENOIOCTLCMD"
      Pointed-out-by: default avatarPaul Mackerras <paulus@samba.org>
      Acked-by: default avatarAlan Cox <alan@lxorguk.ukuu.org.uk>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      f99e8f27
  2. 06 Aug, 2008 15 commits
  3. 05 Aug, 2008 21 commits