1. 26 Feb, 2015 40 commits
    • Aya Mahfouz's avatar
      staging: rtl8712: rewrite the right hand side of an assignment · bc5b749a
      Aya Mahfouz authored
      This patch rewrites the right hand side of an assignment for
      expressions of the form:
      a = (a <op> b);
      to be:
      a <op>= b;
      where <op> = << | >>.
      
      This issue was detected and resolved using the following
      coccinelle script:
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i >> e);
      +i >>= e;
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i << e);
      +i <<= e;
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      bc5b749a
    • Aya Mahfouz's avatar
      staging: rtl8712: rewrite the right hand side of an assignment · cb329d83
      Aya Mahfouz authored
      This patch rewrites the right hand side of an assignment for
      expressions of the form:
      a = (a <op> b);
      to be:
      a <op>= b;
      where <op> = << | >>.
      
      This issue was detected and resolved using the following
      coccinelle script:
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i >> e);
      +i >>= e;
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i << e);
      +i <<= e;
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      cb329d83
    • Aya Mahfouz's avatar
      staging: rtl8723au: hal: rewrite the right hand side of an assignment · 6bd70089
      Aya Mahfouz authored
      This patch rewrites the right hand side of an assignment for
      expressions of the form:
      a = (a <op> b);
      to be:
      a <op>= b;
      where <op> = << | >>.
      
      This issue was detected and resolved using the following
      coccinelle script:
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i >> e);
      +i >>= e;
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i << e);
      +i <<= e;
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      6bd70089
    • Aya Mahfouz's avatar
      staging: rtl8723au: hal: rewrite the right hand side of an assignment · 5092450c
      Aya Mahfouz authored
      This patch rewrites the right hand side of an assignment for
      expressions of the form:
      a = (a <op> b);
      to be:
      a <op>= b;
      where <op> = << | >>.
      
      This issue was detected and resolved using the following
      coccinelle script:
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i >> e);
      +i >>= e;
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i << e);
      +i <<= e;
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5092450c
    • Aya Mahfouz's avatar
      staging: rtl8723au: hal: rewrite the right hand side of an assignment · a9dbc808
      Aya Mahfouz authored
      This patch rewrites the right hand side of an assignment for
      expressions of the form:
      a = (a <op> b);
      to be:
      a <op>= b;
      where <op> = << | >>.
      
      This issue was detected and resolved using the following
      coccinelle script:
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i >> e);
      +i >>= e;
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i << e);
      +i <<= e;
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      a9dbc808
    • Aya Mahfouz's avatar
      staging: rtl8723au: rewrite the right hand side of an assignment · 26aab2b1
      Aya Mahfouz authored
      This patch rewrites the right hand side of an assignment for
      expressions of the form:
      a = (a <op> b);
      to be:
      a <op>= b;
      where <op> = << | >>.
      
      This issue was detected and resolved using the following
      coccinelle script:
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i >> e);
      +i >>= e;
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i << e);
      +i <<= e;
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      26aab2b1
    • Aya Mahfouz's avatar
      staging: xgifb: rewrite the right hand side of an assignment · 46283372
      Aya Mahfouz authored
      This patch rewrites the right hand side of an assignment for
      expressions of the form:
      a = (a <op> b);
      to be:
      a <op>= b;
      where <op> = << | >>.
      
      This issue was detected and resolved using the following
      coccinelle script:
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i >> e);
      +i >>= e;
      
      @@
      identifier i;
      expression e;
      @@
      
      -i = (i << e);
      +i <<= e;
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      46283372
    • Ksenija Stanojevic's avatar
      Staging: slicoss: Join split string. · 1cd0989e
      Ksenija Stanojevic authored
      This patch fixes warning issue by checkpatch.pl by joining the split string.
      And also creates new warning that line exceeds 80 characters. In this case
      this is more beneficial because of possibility to grep the string.
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1cd0989e
    • Yeliz Taneroglu's avatar
      Staging: ft1000: Removed unnecessary braces · a786b778
      Yeliz Taneroglu authored
      The following patch fixes the checkpatch.pl warning:
      WARNING: braces {} are not necessary for single statement blocks
      Signed-off-by: default avatarYeliz Taneroglu <yeliztaneroglu@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      a786b778
    • Gulsah Kose's avatar
      staging: ft1000: ft1000-pcmcia: Added missing blank line. · a5d5030d
      Gulsah Kose authored
      Added missing blank line after declaration. Removed following checkpatch.pl warning:
      WARNING: Missing a blank line after declarations
      Signed-off-by: default avatarGulsah Kose <gulsah.1004@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      a5d5030d
    • Gulsah Kose's avatar
      staging: ft1000: ft1000-pcmcia: Removed unnecessary parentheses. · 3a49f752
      Gulsah Kose authored
      This patch removes unnecessary parentheses from control expression.
      Removed following checkpatch.pl warning:
      WARNING: Unnecessary parentheses
      Signed-off-by: default avatarGulsah Kose <gulsah.1004@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3a49f752
    • Gulsah Kose's avatar
      staging: ft1000: ft1000-pcmcia: Deleted unnecessary braces. · 057b28f5
      Gulsah Kose authored
      Brackets were removed from the expression that containing single
      line in the phrase "if else". Removed following checkpatch.pl
      warnings:
      WARNING: braces {} are not necessary for any arm of this statement
      Signed-off-by: default avatarGulsah Kose <gulsah.1004@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      057b28f5
    • Gulsah Kose's avatar
      staging: ft1000: ft1000-pcmcia: Removed all useless "else" · eeca3458
      Gulsah Kose authored
      Removed all else keywords that used after break or return. Removed following checkpatch.pl warnings:
      WARNING: else is not generally useful after a break or return
      Signed-off-by: default avatarGulsah Kose <gulsah.1004@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      eeca3458
    • Dilek Uzulmez's avatar
      Staging: drivers: dma: Add space before ( · fe146473
      Dilek Uzulmez authored
      This patch fixes checkpatch.pl error in file ste_dma40.c
      ERROR: space required before the open parenthesis '('
      Signed-off-by: default avatarDilek Uzulmez <dilekuzulmez@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      fe146473
    • Ksenija Stanojevic's avatar
      Staging: rtl8192: Simplifying if-else statement · d0049dfc
      Ksenija Stanojevic authored
      This patch simplifies the code by not having two identical paths and
      fixes the warning given by checkpatch.pl: "else is not useful after
      a break or return".
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d0049dfc
    • Melike Yurtoglu's avatar
      Staging: rtl8192e: replace memcpy() by ether_addr_copy() using coccinelle and pack variable · 1f3aefb5
      Melike Yurtoglu authored
      This patch focuses on fixing the following warning generated
      by checkpatch.pl for the file rxtx.c
      
      Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
      are __aligned(2)
      
      @@ expression e1, e2; @@
      
      - memcpy(e1, e2, ETH_ALEN);
      + ether_addr_copy(e1, e2);
      
      struct net_device {
              char                       name[16];             /*     0    16*/
              struct hlist_node          name_hlist;           /*    16    16*/
              char *                     ifalias;              /*    32     8*/
              long unsigned int          mem_end;              /*    40     8*/
              long unsigned int          mem_start;            /*    48     8*/
              long unsigned int          base_addr;            /*    56     8*/
              /* --- cacheline 1 boundary (64 bytes) --- */
              int                        irq;                  /*    64     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              long unsigned int          state;                /*    72     8*/
              struct list_head           dev_list;             /*    80    16*/
              struct list_head           napi_list;            /*    96    16*/
              struct list_head           unreg_list;           /*   112    16*/
              /* --- cacheline 2 boundary (128 bytes) --- */
              struct list_head           close_list;           /*   128    16*/
              struct {
                      struct list_head   upper;                /*   144    16*/
                      struct list_head   lower;                /*   160    16*/
              } adj_list;                                      /*   144    32*/
              struct {
                      struct list_head   upper;                /*   176    16*/
                      struct list_head   lower;                /*   192    16*/
              } all_adj_list;                                  /*   176    32*/
              /* --- cacheline 3 boundary (192 bytes) was 16 bytes ago --- */
              netdev_features_t          features;             /*   208     8*/
              netdev_features_t          hw_features;          /*   216     8*/
              netdev_features_t          wanted_features;      /*   224     8*/
              netdev_features_t          vlan_features;        /*   232     8*/
              netdev_features_t          hw_enc_features;      /*   240     8*/
              netdev_features_t          mpls_features;        /*   248     8*/
              /* --- cacheline 4 boundary (256 bytes) --- */
      	int                        ifindex;              /*   256     4*/
              int                        iflink;               /*   260     4*/
              struct net_device_stats    stats;                /*   264   184*/
              /* --- cacheline 7 boundary (448 bytes) --- */
              atomic_long_t              rx_dropped;           /*   448     8*/
              atomic_long_t              tx_dropped;           /*   456     8*/
              atomic_t                   carrier_changes;      /*   464     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              const struct iw_handler_def  * wireless_handlers; /*   472     8*/
              struct iw_public_data *    wireless_data;        /*   480     8*/
              const struct net_device_ops  * netdev_ops;       /*   488     8*/
              const struct ethtool_ops  * ethtool_ops;         /*   496     8*/
              const struct forwarding_accel_ops  * fwd_ops;    /*   504     8*/
              /* --- cacheline 8 boundary (512 bytes) --- */
              const struct header_ops  * header_ops;           /*   512     8*/
              unsigned int               flags;                /*   520     4*/
              unsigned int               priv_flags;           /*   524     4*/
              short unsigned int         gflags;               /*   528     2*/
              short unsigned int         padded;               /*   530     2*/
              unsigned char              operstate;            /*   532     1*/
              unsigned char              link_mode;            /*   533     1*/
              unsigned char              if_port;              /*   534     1*/
              unsigned char              dma;                  /*   535     1*/
              unsigned int               mtu;                  /*   536     4*/
              short unsigned int         type;                 /*   540     2*/
              short unsigned int         hard_header_len;      /*   542     2*/
              short unsigned int         needed_headroom;      /*   544     2*/
              short unsigned int         needed_tailroom;      /*   546     2*/
              unsigned char              perm_addr[32];        /*   548    32*/
              /* --- cacheline 9 boundary (576 bytes) was 4 bytes ago --- */
              unsigned char              addr_assign_type;     /*   580     1*/
              unsigned char              addr_len;             /*   581     1*/
              short unsigned int         neigh_priv_len;       /*   582     2*/
              short unsigned int         dev_id;               /*   584     2*/
              short unsigned int         dev_port;             /*   586     2*/
              spinlock_t                 addr_list_lock;       /*   588     4*/
      	struct netdev_hw_addr_list uc;                   /*   592    24*/
              struct netdev_hw_addr_list mc;                   /*   616    24*/
              /* --- cacheline 10 boundary (640 bytes) --- */
              struct netdev_hw_addr_list dev_addrs;            /*   640    24*/
              struct kset *              queues_kset;          /*   664     8*/
              unsigned char              name_assign_type;     /*   672     1*/
              bool                       uc_promisc;           /*   673     1*/
      
              /* XXX 2 bytes hole, try to pack */
      
              unsigned int               promiscuity;          /*   676     4*/
              unsigned int               allmulti;             /*   680     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct vlan_info *         vlan_info;            /*   688     8*/
              struct dsa_switch_tree *   dsa_ptr;              /*   696     8*/
              /* --- cacheline 11 boundary (704 bytes) --- */
              struct tipc_bearer *       tipc_ptr;             /*   704     8*/
              void *                     atalk_ptr;            /*   712     8*/
              struct in_device *         ip_ptr;               /*   720     8*/
              struct dn_dev *            dn_ptr;               /*   728     8*/
              struct inet6_dev *         ip6_ptr;              /*   736     8*/
              void *                     ax25_ptr;             /*   744     8*/
              struct wireless_dev *      ieee80211_ptr;        /*   752     8*/
              struct wpan_dev *          ieee802154_ptr;       /*   760     8*/
              /* --- cacheline 12 boundary (768 bytes) --- */
              long unsigned int          last_rx;              /*   768     8*/
              unsigned char *            dev_addr;             /*   776     8*/
              struct netdev_rx_queue *   _rx;                  /*   784     8*/
              unsigned int               num_rx_queues;        /*   792     4*/
              unsigned int               real_num_rx_queues;   /*   796     4*/
              long unsigned int          gro_flush_timeout;    /*   800     8*/
              rx_handler_func_t *        rx_handler;           /*   808     8*/
              void *                     rx_handler_data;      /*   816     8*/
              struct netdev_queue *      ingress_queue;        /*   824     8*/
              /* --- cacheline 13 boundary (832 bytes) --- */
      	unsigned char              broadcast[32];        /*   832    32*/
      
              /* XXX 32 bytes hole, try to pack */
      
              /* --- cacheline 14 boundary (896 bytes) --- */
              struct netdev_queue *      _tx;                  /*   896     8*/
              unsigned int               num_tx_queues;        /*   904     4*/
              unsigned int               real_num_tx_queues;   /*   908     4*/
              struct Qdisc *             qdisc;                /*   912     8*/
              long unsigned int          tx_queue_len;         /*   920     8*/
              spinlock_t                 tx_global_lock;       /*   928     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct xps_dev_maps *      xps_maps;             /*   936     8*/
              struct cpu_rmap *          rx_cpu_rmap;          /*   944     8*/
              long unsigned int          trans_start;          /*   952     8*/
              /* --- cacheline 15 boundary (960 bytes) --- */
              int                        watchdog_timeo;       /*   960     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct timer_list          watchdog_timer;       /*   968    80*/
              /* --- cacheline 16 boundary (1024 bytes) was 24 bytes ago ---* */
              int *                      pcpu_refcnt;          /*  1048     8*/
              struct list_head           todo_list;            /*  1056    16*/
              struct hlist_node          index_hlist;          /*  1072    16*/
              /* --- cacheline 17 boundary (1088 bytes) --- */
              struct list_head           link_watch_list;      /*  1088    16*/
              enum {
                      NETREG_UNINITIALIZED = 0,
                      NETREG_REGISTERED = 1,
                      NETREG_UNREGISTERING = 2,
                      NETREG_UNREGISTERED = 3,
                      NETREG_RELEASED = 4,
                      NETREG_DUMMY = 5,
              } reg_state:8;                                     /*  1104 4 */
      	/* Bitfield combined with next fields */
      
              bool                       dismantle;            /*  1105     1*/
      
              /* Bitfield combined with previous fields */
      
              enum {
                      RTNL_LINK_INITIALIZED = 0,
                      RTNL_LINK_INITIALIZING = 1,
              } rtnl_link_state:16;                               /*  1104 4 */
      
              /* XXX 4 bytes hole, try to pack */
      
              void                       (*destructor)(struct net_device *);/*  1112     8 */
              struct netpoll_info *      npinfo;               /*  1120     8*/
              struct net *               nd_net;               /*  1128     8*/
              union {
                      void *             ml_priv;              /*           8*/
                      struct pcpu_lstats * lstats;             /*           8*/
                      struct pcpu_sw_netstats * tstats;        /*           8*/
                      struct pcpu_dstats * dstats;             /*           8*/
                      struct pcpu_vstats * vstats;             /*           8*/
              };                                               /*  1136     8*/
              struct garp_port *         garp_port;            /*  1144     8*/
              /* --- cacheline 18 boundary (1152 bytes) was 4 bytes ago --- */
              struct mrp_port *          mrp_port;             /*  1152     8*/
              struct device              dev;                  /*  1160   696*/
      
              /* XXX last struct has 7 bytes of padding */
      
              /* --- cacheline 29 boundary (1856 bytes) was 4 bytes ago --- */
              const struct attribute_group  * sysfs_groups[4]; /*  1856    32*/
              const struct attribute_group  * sysfs_rx_queue_group; /*  18888 */
              const struct rtnl_link_ops  * rtnl_link_ops;     /*  1896     8*/
              unsigned int               gso_max_size;         /*  1904     4*/
              u16                        gso_max_segs;         /*  1908     2*/
              u16                        gso_min_segs;         /*  1910     2*/
      	const struct dcbnl_rtnl_ops  * dcbnl_ops;        /*  1912     8*/
              /* --- cacheline 30 boundary (1920 bytes) was 4 bytes ago --- */
              u8                         num_tc;               /*  1920     1*/
      
              /* XXX 1 byte hole, try to pack */
      
              struct netdev_tc_txq       tc_to_txq[16];        /*  1922    64*/
              /* --- cacheline 31 boundary (1984 bytes) was 6 bytes ago --- */
              u8                         prio_tc_map[16];      /*  1986    16*/
      
              /* XXX 2 bytes hole, try to pack */
      
              unsigned int               fcoe_ddp_xid;         /*  2004     4*/
              struct phy_device *        phydev;               /*  2008     8*/
              struct lock_class_key *    qdisc_tx_busylock;    /*  2016     8*/
              int                        group;                /*  2024     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct pm_qos_request      pm_qos_req;           /*  2032   176*/
              /* --- cacheline 34 boundary (2176 bytes) was 36 bytes ago --- * */
      
              /* size: 2240, cachelines: 35, members: 120 */
              /* sum members: 2147, holes: 11, sum holes: 65 */
              /* padding: 32 */
              /* paddings: 1, sum paddings: 7 */
      
              /* BRAIN FART ALERT! 2240 != 2147 + 65(holes), diff = 28 */
      
      };
      Signed-off-by: default avatarMelike Yurtoglu <aysemelikeyurtoglu@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      1f3aefb5
    • Vaishali Thakkar's avatar
      Staging: rtl8712: Use mod_timer · 875b7dec
      Vaishali Thakkar authored
      This patch introduces the use of API function mod_timer
      instead of driver specific function as it is a more
      efficient and standard way to update the expire field of
      an active timer.
      Signed-off-by: default avatarVaishali Thakkar <vthakkar1994@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      875b7dec
    • Katie Dunne's avatar
      Staging: rtl8712: Remove unused macros · a6c6e298
      Katie Dunne authored
      Removes several macro definitions that are unused
      Patch 2 will remove the same definitions in rtl8188eu/include/wifi.h
      Signed-off-by: default avatarKatie Dunne <kdunne@mail.ccsf.edu>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      a6c6e298
    • Melike Yurtoglu's avatar
      Staging: rtl8712: replace memcpy() by ether_addr_copy() using coccinelle and pack variable · d55519ab
      Melike Yurtoglu authored
      This patch focuses on fixing the following warning generated
      by checkpatch.pl for the file rtl871x_cmd.c
      
      Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
      are __aligned(2)
      
      @@ expression e1, e2; @@
      
      - memcpy(e1, e2, ETH_ALEN);
      + ether_addr_copy(e1, e2);
      
      struct _adapter {
              struct dvobj_priv          dvobjpriv;            /*     0    40*/
              struct mlme_priv           mlmepriv;             /*    40  1560*/
              /* --- cacheline 25 boundary (1600 bytes) --- */
              struct cmd_priv            cmdpriv;              /*  1600   136*/
              /* --- cacheline 27 boundary (1728 bytes) was 8 bytes ago --- */
              struct evt_priv            evtpriv;              /*  1736    96*/
              /* --- cacheline 28 boundary (1792 bytes) was 40 bytes ago --- * */
              struct io_queue *          pio_queue;            /*  1832     8*/
              struct xmit_priv           xmitpriv;             /*  1840   912*/
              /* --- cacheline 43 boundary (2752 bytes) --- */
              struct recv_priv           recvpriv;             /*  2752  1088*/
              /* --- cacheline 60 boundary (3840 bytes) --- */
              struct sta_priv            stapriv;              /*  3840   672*/
              /* --- cacheline 70 boundary (4480 bytes) was 32 bytes ago --- * */
              struct security_priv       securitypriv;         /*  4512  4816*/
              /* --- cacheline 145 boundary (9280 bytes) was 48 bytes ago --- * */
              struct registry_priv       registrypriv;         /*  9328   968*/
              /* --- cacheline 160 boundary (10240 bytes) was 56 bytes ago --- * */
              struct wlan_acl_pool       acl_list;             /* 10296  1536*/
              /* --- cacheline 184 boundary (11776 bytes) was 56 bytes ago --- * */
              struct pwrctrl_priv        pwrctrlpriv;          /* 11832   224*/
              /* --- cacheline 188 boundary (12032 bytes) was 24 bytes ago --- * */
              struct eeprom_priv         eeprompriv;           /* 12056   508*/
      
              /* XXX 4 bytes hole, try to pack */
      
              /* --- cacheline 196 boundary (12544 bytes) was 24 bytes ago --- * */
              struct hal_priv            halpriv;              /* 12568    88*/
              /* --- cacheline 197 boundary (12608 bytes) was 48 bytes ago --- * */
              struct led_priv            ledpriv;              /* 12656   304*/
              /* --- cacheline 202 boundary (12928 bytes) was 32 bytes ago --- * */
              struct mp_priv             mppriv;               /* 12960  1080*/
      	 /* --- cacheline 219 boundary (14016 bytes) was 24 bytes ago * --- */
              s32                        bDriverStopped;       /* 14040     4*/
              s32                        bSurpriseRemoved;     /* 14044     4*/
              u32                        IsrContent;           /* 14048     4*/
              u32                        ImrContent;           /* 14052     4*/
              u8                         EepromAddressSize;    /* 14056     1*/
              u8                         hw_init_completed;    /* 14057     1*/
      
              /* XXX 6 bytes hole, try to pack */
      
              struct task_struct *       cmdThread;            /* 14064     8*/
              pid_t                      evtThread;            /* 14072     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              /* --- cacheline 220 boundary (14080 bytes) --- */
              struct task_struct *       xmitThread;           /* 14080     8*/
              pid_t                      recvThread;           /* 14088     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              uint                       (*dvobj_init)(struct _adapter *); /*14096     8 */
              void                       (*dvobj_deinit)(struct _adapter *);/* 14104     8 */
              struct net_device *        pnetdev;              /* 14112     8*/
              int                        bup;                  /* 14120     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct net_device_stats    stats;                /* 14128   184*/
              /* --- cacheline 223 boundary (14272 bytes) was 40 bytes ago --- * */
      	 struct iw_statistics       iwstats;              /* 14312    32*/
              /* --- cacheline 224 boundary (14336 bytes) was 8 bytes ago --- * */
              int                        pid;                  /* 14344     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct work_struct         wkFilterRxFF0;        /* 14352    32*/
              u8                         blnEnableRxFF0Filter; /* 14384     1*/
      
              /* XXX 3 bytes hole, try to pack */
      
              spinlock_t                 lockRxFF0Filter;      /* 14388     4*/
              const struct firmware  *   fw;                   /* 14392     8*/
              /* --- cacheline 225 boundary (14400 bytes) --- */
              struct usb_interface *     pusb_intf;            /* 14400     8*/
              struct mutex               mutex_start;          /* 14408    40*/
      
              /* XXX last struct has 4 bytes of padding */
      
              struct completion          rtl8712_fw_ready;     /* 14448    32*/
              /* --- cacheline 226 boundary (14464 bytes) was 16 bytes ago --- * */
      
              /* size: 14480, cachelines: 227, members: 40 */
              /* sum members: 14451, holes: 7, sum holes: 29 */
              /* paddings: 1, sum paddings: 4 */
              /* last cacheline: 16 bytes */
      };
      Signed-off-by: default avatarMelike Yurtoglu <aysemelikeyurtoglu@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d55519ab
    • Melike Yurtoglu's avatar
      Staging: rtl8712: replace memcpy() by ether_addr_copy() using coccinelle and pack variable · c7c42826
      Melike Yurtoglu authored
      This patch focuses on fixing the following warning generated
      by checkpatch.pl for the file rxtx.c
      
      Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
      are __aligned(2)
      
      @@ expression e1, e2; @@
      
      - memcpy(e1, e2, ETH_ALEN);
      + ether_addr_copy(e1, e2);
      
      struct _adapter {
              struct dvobj_priv          dvobjpriv;            /*     0    40*/
              struct mlme_priv           mlmepriv;             /*    40  1560*/
              /* --- cacheline 25 boundary (1600 bytes) --- */
              struct cmd_priv            cmdpriv;              /*  1600   136*/
              /* --- cacheline 27 boundary (1728 bytes) was 8 bytes ago --- */
              struct evt_priv            evtpriv;              /*  1736    96*/
              /* --- cacheline 28 boundary (1792 bytes) was 40 bytes ago --- * */
              struct io_queue *          pio_queue;            /*  1832     8*/
              struct xmit_priv           xmitpriv;             /*  1840   912*/
              /* --- cacheline 43 boundary (2752 bytes) --- */
              struct recv_priv           recvpriv;             /*  2752  1088*/
              /* --- cacheline 60 boundary (3840 bytes) --- */
              struct sta_priv            stapriv;              /*  3840   672*/
              /* --- cacheline 70 boundary (4480 bytes) was 32 bytes ago --- * */
              struct security_priv       securitypriv;         /*  4512  4816*/
              /* --- cacheline 145 boundary (9280 bytes) was 48 bytes ago --- * */
              struct registry_priv       registrypriv;         /*  9328   968*/
              /* --- cacheline 160 boundary (10240 bytes) was 56 bytes ago --- * */
              struct wlan_acl_pool       acl_list;             /* 10296  1536*/
              /* --- cacheline 184 boundary (11776 bytes) was 56 bytes ago --- * */
              struct pwrctrl_priv        pwrctrlpriv;          /* 11832   224*/
              /* --- cacheline 188 boundary (12032 bytes) was 24 bytes ago --- * */
              struct eeprom_priv         eeprompriv;           /* 12056   508*/
      
              /* XXX 4 bytes hole, try to pack */
      
              /* --- cacheline 196 boundary (12544 bytes) was 24 bytes ago --- * */
              struct hal_priv            halpriv;              /* 12568    88*/
              /* --- cacheline 197 boundary (12608 bytes) was 48 bytes ago --- * */
              struct led_priv            ledpriv;              /* 12656   304*/
              /* --- cacheline 202 boundary (12928 bytes) was 32 bytes ago --- * */
              struct mp_priv             mppriv;               /* 12960  1080*/
              /* --- cacheline 219 boundary (14016 bytes) was 24 bytes ago --- * */
              s32                        bDriverStopped;       /* 14040     4*/
              s32                        bSurpriseRemoved;     /* 14044     4*/
              u32                        IsrContent;           /* 14048     4*/
              u32                        ImrContent;           /* 14052     4*/
      	 u8                         EepromAddressSize;    /* 14056     1*/
              u8                         hw_init_completed;    /* 14057     1*/
      
              /* XXX 6 bytes hole, try to pack */
      
              struct task_struct *       cmdThread;            /* 14064     8*/
              pid_t                      evtThread;            /* 14072     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              /* --- cacheline 220 boundary (14080 bytes) --- */
              struct task_struct *       xmitThread;           /* 14080     8*/
              pid_t                      recvThread;           /* 14088     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              uint                       (*dvobj_init)(struct _adapter *); /*14096     8 */
              void                       (*dvobj_deinit)(struct _adapter *);/* 14104     8 */
              struct net_device *        pnetdev;              /* 14112     8*/
              int                        bup;                  /* 14120     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct net_device_stats    stats;                /* 14128   184*/
              /* --- cacheline 223 boundary (14272 bytes) was 40 bytes ago --- * */
              struct iw_statistics       iwstats;              /* 14312    32*/
              /* --- cacheline 224 boundary (14336 bytes) was 8 bytes ago --- * */
              int                        pid;                  /* 14344     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct work_struct         wkFilterRxFF0;        /* 14352    32*/
              u8                         blnEnableRxFF0Filter; /* 14384     1*/
      
              /* XXX 3 bytes hole, try to pack */
      
              spinlock_t                 lockRxFF0Filter;      /* 14388     4*/
              const struct firmware  *   fw;                   /* 14392     8*/
      	 u8                         EepromAddressSize;    /* 14056     1*/
              u8                         hw_init_completed;    /* 14057     1*/
      
              /* XXX 6 bytes hole, try to pack */
      
              struct task_struct *       cmdThread;            /* 14064     8*/
              pid_t                      evtThread;            /* 14072     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              /* --- cacheline 220 boundary (14080 bytes) --- */
              struct task_struct *       xmitThread;           /* 14080     8*/
              pid_t                      recvThread;           /* 14088     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              uint                       (*dvobj_init)(struct _adapter *); /*14096     8 */
              void                       (*dvobj_deinit)(struct _adapter *);/* 14104     8 */
              struct net_device *        pnetdev;              /* 14112     8*/
              int                        bup;                  /* 14120     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct net_device_stats    stats;                /* 14128   184*/
              /* --- cacheline 223 boundary (14272 bytes) was 40 bytes ago --- * */
              struct iw_statistics       iwstats;              /* 14312    32*/
              /* --- cacheline 224 boundary (14336 bytes) was 8 bytes ago --- * */
              int                        pid;                  /* 14344     4*/
      
              /* XXX 4 bytes hole, try to pack */
      
              struct work_struct         wkFilterRxFF0;        /* 14352    32*/
              u8                         blnEnableRxFF0Filter; /* 14384     1*/
      
              /* XXX 3 bytes hole, try to pack */
      
              spinlock_t                 lockRxFF0Filter;      /* 14388     4*/
              const struct firmware  *   fw;                   /* 14392     8*/
      	/* --- cacheline 225 boundary (14400 bytes) --- */
              struct usb_interface *     pusb_intf;            /* 14400     8*/
              struct mutex               mutex_start;          /* 14408    40*/
      
              /* XXX last struct has 4 bytes of padding */
      
              struct completion          rtl8712_fw_ready;     /* 14448    32*/
              /* --- cacheline 226 boundary (14464 bytes) was 16 bytes ago --- * */
      
              /* size: 14480, cachelines: 227, members: 40 */
              /* sum members: 14451, holes: 7, sum holes: 29 */
              /* paddings: 1, sum paddings: 4 */
              /* last cacheline: 16 bytes */
      };
      Signed-off-by: default avatarMelike Yurtoglu <aysemelikeyurtoglu@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c7c42826
    • Gamze POLAT's avatar
      staing: rtl8712: else after return or break warning · da077689
      Gamze POLAT authored
      This patch fixes checkpatch.pl warning.
      WARNING: else is not generally useful after a break or return
      Signed-off-by: default avatarGamze POLAT <gamzepolat94@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      da077689
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Simplify if condition · 352e579d
      Ksenija Stanojevic authored
      Remove unnecessary TRUE statement. Field bMediaConnect is of bool
      type, so such change is correct.
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      352e579d
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Simplify if condition. · 72b16fe3
      Ksenija Stanojevic authored
      Remove unnecessary TRUE statement. Fields bDynamicTxLowPower and
      bDynamicTxHighPower are of bool type so such change is correct.
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      72b16fe3
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Convert comments from C99 to C89 style · ff757c8a
      Ksenija Stanojevic authored
      Kernel style for comments is C89 style. Issue found by checkpatch.pl.
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      ff757c8a
    • Navya Sri Nizamkari's avatar
      staging: rtl8192u: Remove unnecessary comment · a064d27a
      Navya Sri Nizamkari authored
      The <linux/config.h> header file is not used anymore,
      so it is commented out in this file.This patch deletes
      that unnecessary comment.
      Signed-off-by: default avatarNavya Sri Nizamkari <navyasri.tech@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      a064d27a
    • Navya Sri Nizamkari's avatar
      staging: rtl8192u: Remove commented header. · f79483ea
      Navya Sri Nizamkari authored
      This patch removes the commented header <linux/config.h>
      as it is not used in modern linux systems.
      Signed-off-by: default avatarNavya Sri Nizamkari <navyasri.tech@gmail.com>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f79483ea
    • Navya Sri Nizamkari's avatar
      staging: rtl8192u: Remove commented header. · 45466a5c
      Navya Sri Nizamkari authored
      This patch removes the commented header <linux/config.h>
      as it is not used in modern linux systems.
      Signed-off-by: default avatarNavya Sri Nizamkari <navyasri.tech@gmail.com>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      45466a5c
    • Navya Sri Nizamkari's avatar
      staging: rtl8192u: Remove commented header. · 7ea8b64d
      Navya Sri Nizamkari authored
      This patch removes the commented header <linux/config.h>
      as it is not used in modern linux systems.
      Signed-off-by: default avatarNavya Sri Nizamkari <navyasri.tech@gmail.com>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7ea8b64d
    • Navya Sri Nizamkari's avatar
      staging: rtl8192u: Remove commented header. · 609de3ae
      Navya Sri Nizamkari authored
      This patch removes the commented header <linux/config.h>
      as it is not used in modern linux systems.
      Signed-off-by: default avatarNavya Sri Nizamkari <navyasri.tech@gmail.com>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      609de3ae
    • Navya Sri Nizamkari's avatar
      staging: rtl8192u: Remove commented header. · e5e33965
      Navya Sri Nizamkari authored
      This patch removes the commented header <linux/config.h>
      as it is not used in modern linux systems.
      Signed-off-by: default avatarNavya Sri Nizamkari <navyasri.tech@gmail.com>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      e5e33965
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Remove trailing whitespace. · 97567a90
      Ksenija Stanojevic authored
      This patch removes whitespace at the end of the line.
      Issue found by checkpatch.pl.
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      97567a90
    • Dilek Uzulmez's avatar
      Staging: rtl8192u: Fix do not use // c99 comments. · 62058952
      Dilek Uzulmez authored
      This patch fixes "do not use // C99 comments" errors in ieee80211_module.c
      Signed-off-by: default avatarDilek Uzulmez <dilekuzulmez@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      62058952
    • Dilek Uzulmez's avatar
      Staging: rtl8192u: Remove space before ',' · d6413982
      Dilek Uzulmez authored
      This patch fixes checkpatch.pl error in file r8190_rtl8256.h
      ERROR: space prohibited before that ',' (ctx:WxW)
      Signed-off-by: default avatarDilek Uzulmez <dilekuzulmez@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d6413982
    • Dilek Uzulmez's avatar
      Staging: rtl8192u: Fix do not use // c99 comments. · 36f7c381
      Dilek Uzulmez authored
      This patch fixes "do not use // C99 comments" errors in
      r8190_rtl8256.h
      Signed-off-by: default avatarDilek Uzulmez <dilekuzulmez@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      36f7c381
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Replace printk() with pr_debug() and netdev_dbg(). · fb99f874
      Ksenija Stanojevic authored
      For dynamic debugging pr_debug() or netdev_dbg (if there is a ponter
      to a device net structure) is preferred over printk(), which is the
      raw way to print something. Issue found by checkpatch.pl.
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      fb99f874
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Remove else after return · bf1c66e8
      Ksenija Stanojevic authored
      This patch simplifies the code by removing else and fixes
      the following checkpatch.pl warning: "else is not useful after
      break or return".
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      bf1c66e8
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Replace header files · 3033669e
      Ksenija Stanojevic authored
      Files <asm/string.h> and <asm/errno.h> should not be included directly.
      This patch fixes the following checkpatch.pl warnings:
      Use #include <linux/errno.h> instead of <asm/errno.h>
      Use #include <linux/string.h> instead of <asm/string.h>
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      3033669e
    • Ksenija Stanojevic's avatar
      Staging: rtl8192u: Remove space before tab · 98bedd77
      Ksenija Stanojevic authored
      This patch fixes the checkpatch.pl warning:
      WARNING: "please, no space before tabs"
      Signed-off-by: default avatarKsenija Stanojevic <ksenija.stanojevic@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      98bedd77
    • Gamze POLAT's avatar
      Staging: dgnc: Removed trailing whitespace · b0487a7c
      Gamze POLAT authored
      Removed trailing whitespaces to improve code readability and remove
      checkpatch warning.
      Signed-off-by: default avatarGamze POLAT <gamzepolat94@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b0487a7c
    • Aya Mahfouz's avatar
      staging: slicloss: replace init_timer by setup_timer · 7d2b3cf7
      Aya Mahfouz authored
      This patch replaces init_timer and the 2 step initialization of function
      and data by setup_timer to make the code more concise.
      
      The issue was discovered using the following coccinelle script:
      
      @@
      expression ds, e1, e2;
      @@
      
      -init_timer (&ds);
      +setup_timer (&ds, e1, e2);
      ...
      (
      -ds.function = e1;
      ...
      -ds.data = e2;
      |
      -ds.data = e2;
      ...
      -ds.function = e1;
      )
      Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7d2b3cf7