- 02 Mar, 2010 40 commits
-
-
Alessio Igor Bogani authored
As Alan Cox have pinpointed the driver still required protection against parallels calls to the config ioctl(). If lock is still necessary the use of BKL is abused here. So replace BKL with a more convenient mutex. Signed-off-by:
Alessio Igor Bogani <abogani@texware.it> Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: Johan Hovold <jhovold@gmail.com> Cc: Alan Cox <alan@linux.intel.com> Cc: Daniel Mack <daniel@caiaq.de> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Thomas Gleixner authored
The semaphore data->lock is semantically a mutex. Convert it to a real mutex. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Cc: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by:
-
Michal Nazarewicz authored
The mass storage function responded needlessly to a set configuration packet. This was a leftover from converting gadget (file storage gadget) into a composite function. Moreover, it has failed to respond to get max LUN request. Adding request queueing made the function work better. Signed-off-by:
Michal Nazarewicz <m.nazarewicz@samsung.com> Signed-off-by:
Marek Szyprowski <m.szyprowski@samsung.com> Cc: Alan Stern <stern@rowland.harvard.edu> Cc: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by:
-
Michal Nazarewicz authored
Adds a fallback which forces all LUNs ejection (including non-removable and with prevent_medium_removal flag) when mass storage function (MSF) worker thread exits and gadget fails to handle the situation. Previously, if thread_exits was not specified mass storage function (MSF) did nothing when exiting thread as it's unclear for *function* what to do when it's thread terminates so responsibility of handling this situation was left to the *gadget* using the function. The g_mass_storage handled the situation by unregistering itself (the same thing that file storage gadget does). However, g_multi did nothing and so MSF did not eject LUNs which prevented file system unmounting. Signed-off-by:
Kyungmin Park <kyungmin.park@samsung.com> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Alan Stern <stern@rowland.harvard.edu> Signed-off-by:
-
Cliff Cai authored
Trying to use double buffer modes in RTL versions <2.0 may result in infinite hangs or data corruption. So avoid them with older versions. Signed-off-by:
Cliff Cai <cliff.cai@analog.com> Signed-off-by:
Mike Frysinger <vapier@gentoo.org> Signed-off-by:
Felipe Balbi <felipe.balbi@nokia.com> Signed-off-by:
-
Cliff Cai authored
All current Blackfin parts are using RTL v1.9, but they don't expose the hardware registers to probe this dynamically. So hardcode the version to v1.9 for now. Need to move the local hwvers related defines higher up in the header so that sub-musb headers may utilize them. Signed-off-by:
-
Robert Jarzmik authored
As reported by Antonio, there are cases where the ep->lock can be taken twice, triggering a deadlock. The typical sequence is : irq_handler \ -> gadget.complete() \ -> pxa27x_udc.pxa_ep_queue() : ep->lock is taken \ -> gadget.complete() \ -> pxa27x_udc.pxa_ep_queue() : ep->lock is taken ==> *deadlock* The patch fixes this by : - releasing the lock each time gadget.complete() is called - adding a check in handle_ep() to detect a recursive call, in which case the function becomes on no-op. The patch is still not good enough for ep0. For this unique endpoint, another well thought over patch will be needed. Reported-by:Antonio Ospite <ospite@studenti.unina.it> Tested-by:
Robert Jarzmik <robert.jarzmik@free.fr> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Eric Miao <eric.y.miao@gmail.com> Signed-off-by:
-
Mike Dunn authored
Add support for the serial port on devices based on the MosChip 7715, which provides a serial and parallel port on a single usb interface. This is added to the existing driver for the Moschip 7720 dual serial port device. The 7715 is very similiar to the 7720, requiring only the addition of a calc_num_ports() function, a separate interrupt-in endpoint callback, and some manipulation of the port pointers added to the attach() function to correct the fact that the usbserial core erroneously assigns the first bulk in/out endpoint pair to the serial port (the 7715 uses these for its parallel port). There is no support for the 7715's parallel port yet. Signed-off-by:
Mike Dunn <mikedunn@newsguy.com> Signed-off-by:
-
Dan Carpenter authored
Johan Hovold points out that get_string() is basically just a re-implimentation of usb_string(). It is also buggy. It does DMA on the stack and it doesn't handle negative returns from usb_get_descriptor(). Plus unicode_to_ascii() is a rubbish function and moving to usb_string() avoids using it. Let's eliminate get_string() entirely. Reported-by:
Johan Hovold <jhovold@gmail.com> Signed-off-by:
Dan Carpenter <error27@gmail.com> Acked-by:
-
FUJITA Tomonori authored
This replaces deprecated dma_sync_single() with dma_sync_single_for_cpu(). There is no functional change because dma_sync_single() simply calls dma_sync_single_for_cpu(): static inline void __deprecated dma_sync_single(struct device *dev, dma_addr_t addr, size_t size, enum dma_data_direction dir) { dma_sync_single_for_cpu(dev, addr, size, dir); } This fixes the following compile warnings: drivers/usb/gadget/s3c-hsotg.c: In function 's3c_hsotg_unmap_dma': drivers/usb/gadget/s3c-hsotg.c:376: warning: 'dma_sync_single' is deprecated (declared at /home/fujita/git/linux-2.6/include/linux/dma-mapping.h:109) drivers/usb/gadget/s3c-hsotg.c: In function 's3c_hsotg_map_dma': drivers/usb/gadget/s3c-hsotg.c:758: warning: 'dma_sync_single' is deprecated (declared at /home/fujita/git/linux-2.6/include/linux/dma-mapping.h:109) Signed-off-by:FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Acked-by:
Ben Dooks <ben@simtec.co.uk> Signed-off-by:
-
Felipe Balbi authored
we were printing the info about musb probe too early where it was still possible for things to go wrong. Move the down right before the return 0 statement. While at that also convert pr_info to dev_info. Signed-off-by:
-
Felipe Balbi authored
when probe() fails, we should iounmap() the mapped address. Signed-off-by:
-
Felipe Balbi authored
Trivial patch, no functional changes. Signed-off-by:
-
Felipe Balbi authored
after 2.6.34, those fields will be removed from struct musb_hdrc_platform_data, it's expected that other architectures are fixed by then. Signed-off-by:
-
Felipe Balbi authored
... and even added a flag to struct musb, so let's use that. Signed-off-by:
-
Felipe Balbi authored
we have those addresses already ioremaped, so let's use our __raw_readl/writel wrappers. Signed-off-by:
-
Ajay Kumar Gupta authored
Adding support for MUSB register save and restore during system suspend and resume. Changes: - Added musb_save/restore_context() functions - Added platform specific musb_platform_save/restore_context() to handle platform specific jobs. - Maintaining BlackFin compatibility by adding read/write functions for registers which are not available in BlackFin Tested system suspend and resume on OMAP3EVM board. Signed-off-by:Anand Gadiyar <gadiyar@ti.com> Signed-off-by:
Ajay Kumar Gupta <ajay.gupta@ti.com> Signed-off-by:
-
Christoph Egger authored
The configuration Option USB_HCD_DMA is not reachable in KConfig so this piece of Code is effectively dead and useless. Remove it to avoid confusion. Signed-off-by:
Christoph Egger <siccegge@stud.informatik.uni-erlangen.de> Signed-off-by:
-
Chris Frey authored
Uses the new snoop function from commit 4c6e8971, but includes the buffer data where appropriate, as before. Signed-off-by:
Chris Frey <cdfrey@foursquare.net> Signed-off-by:
-
Mark Brown authored
Keeps sparse happy if nothing else. Signed-off-by:
Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:
-
Thadeu Lima de Souza Cascardo authored
Signed-off-by:
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com> Signed-off-by:
-
Andreas Mohr authored
- correct spelling - correct non-tabbed .tiocmget/.tiocmset entries Signed-off-by:
Andreas Mohr <andi@lisas.de> Signed-off-by:
-
Andreas Mohr authored
- correct spelling/whitespace in ftdi_sio.h and ftdi_sio_ids.h Signed-off-by:
-
Julia Lawall authored
The variables priv and portdata are initialized twice to the same (side effect-free) expressions. Drop one initialization in each case. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // <smpl> @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(...) ... when != x ( x = f(...,<+...x...+>,...) | * x = f(...) ) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
-
Marcel Holtmann authored
The problem with Ethernet based networking devices is to clearly identify what's their usage. Special interfaces like bridges, WiFi, Bluetooth, WiMAX or WWAN are already using DEVTYPE identification. This patch marks the Ethernet functions of gadgets from the device type "gadget". Automatic setup of these interfaces can now happen from userspace without the need of hardcoding the network interface name. Signed-off-by:
Marcel Holtmann <marcel@holtmann.org> Signed-off-by:
-
Greg Kroah-Hartman authored
The Barry project's userspace program, bcharge, can better handle this device and functionality, and it also works with the latest phones, which this driver does not support. So remove it, as the userspace code should be used instead. Cc: Chris Frey <cdfrey@foursquare.net> Signed-off-by: -
Oliver Neukum authored
Total removal from the ioctl code path except for the outcall to external modules. Locking is ensured by the normal locks of usbfs. Signed-off-by:
Oliver Neukum <oliver@neukum.org> Cc: Alan Stern <stern@rowland.harvard.edu> Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
This driver had used BKL to guard against disconnect but was incorrectly converted leaving an SMP race. BKL was added to disconnect() to fix this race BKL was removed from ioctl() as the mutex is sufficient on its own. Signed-off-by:
-
Oliver Neukum authored
BKL not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL not needed at all. Removed without replacement. Signed-off-by:
-
Oliver Neukum authored
BKL was not needed at all. Removed without replacement. Signed-off-by:
Pete Zaitcev <zaitcev@redhat.com> Signed-off-by:
-
