Remove some useless NULL checks in cpqphp_core.c

Convert ctrl_slot_setup to use goto for error handling and fix some minor
coding style things.

This puts the LED shifting used as "hardware test" in a function to make
cpqhp_hardware_test much smaller and easier to read. Also changes some
comments from C++ to C style.

Fix a lot of coding style issues in Compaq PCI hotplug:
-spaces before opening brace of functions
-much too much C++ style comments
-wrap long lines
-remove some comments where the code does not really need to be explained

Eike

Convert Compaq PCI Hotplug driver to use the new style of module parameters.

set_controller_speed is implemented in cpqphp.h but only used in cpqphp_ctrl.c
and it's much too big to be defined in a header file. This patch moves it to
cpqphp_ctrl.c. Also the inline attribute is removed, this function is called
from 2 places and to big to be an inline.

Remove some useless NULL and magic checks from Compaq PCI Hotplug driver.
If one of this pointers is invalid we are in bad trouble anyway.

The usual coding style fixes, this time for cpqphp_ctrl.c and cpqphp.c.

configure_new_function is way too big (>600 lines). Split it in 2 functions,
one for the new functions and one for bridges. And split out a small piece
from the bridge function which is used twice to it's own function.

Patch is huge because of the identation changes but does nothing than the
split and some minor coding style changes.

The result of kmalloc does not need to be casted, it is a void * which can be
assigned to any pointer variable. Also avoid code duplication in one if
statement.

Some final fixes for the skeleton driver:
-spaces before opening brace
-add a better example for hardware_test function
-remove a "int retval" in a void function
-some more coding style changes
-changed enough stuff: increase version number
-fix a typo in a comment

Convert PCI hotplug skeleton driver to use goto for error handling in
init_slots to avoid code duplication.

Add __init and __exit to some functions only called from __init/__exit context.

Coding style fixes for pcihp_skeleton.c: remove spaces before opening braces
and change a comment in function hardware_test to make clearer that the
functions purpose is not to tell the user there are no tests.

This one removes all the useless NULL checks including slot_paranoia_check,
get_slot and the magic number from the PCI hotplug skeleton driver. Also some
lines containing only a single tab are fixed.

Convert the PCI hotplug skeleton driver to use new style of module parameter
handling.

If there is a condition with the comment "should never happen" it is a good
place for a BUG() if it is ever reached.

Some minor coding style fixes:
-space before opening brace of function
-wrap some long lines
-change some identations from spaces to tabs

This one fixes another space before an opening brace I missed before and
optimizes the error paths in init_slots a bit more.

The magic slot number was only another type of checking the validity of a
pointer. These checks are all gone so magic can follow them.

This one converts acpiphp_core.c to use the new interface for module
parameters.

Convert the driver to use new interface for module parameters, Also fix the
driver name used in debug messages.

Eike

slot->magic is not used anymore since slot_paranoia_check is dead, so just kill
it.

A special function for handling the parameters in non-module case is not
needed, the MODULE_* makros handle this also for compiled in situations.

If we remove this 3 get_* functions the pci hotplug core will do the same
thing for us.

Fix 2 very ugly return constructs.

This one converts the error handling in init_slots to use gotos to avoid code
duplication.

The function hardware_test only tells that there are no tests. If we just
kill it the file "test" in the slot's directory will not show up which
means pretty much the same.

This patch kills the space before the opening brace in function
declarations. It also beautifies some ugly return statements.

Matthew Wilcox wrote:
> On Thu, Apr 22, 2004 at 01:18:23PM +0200, Rolf Eike Beer wrote:
> > slot_paranoia_check is only another kind of checking everything for NULL.
> > Removing this leads to function get_slot is reduced to a simple cast, so
> > this function can be killed also.
>
> Since private is void *, you don't even need the casts.
>
> >  static int enable_slot (struct hotplug_slot *hotplug_slot)
> >  {
> > -	struct slot *slot = get_slot(hotplug_slot, __FUNCTION__);
> > +	struct slot *slot = (struct slot *)hotplug_slot->private;
>
> 	struct slot *slot = hotplug_slot->private;
>
> is enough.

Fixed.

If the "struct hotplug_struct *" parameter to any function in
hotplug_slots_ops is ever NULL something bogus is going on. In this case we
should just oops and not hide the bug. This also fixes the driver name used in
debug messages.

Attached patch fix the problem I have found during DLPAR I/O slots
testing on our new hardware.  rpaphp needs to set eeh-option(eanbled)
for newly added IOA prior to performing PCI config(pci_setup_device),
otherwise the pci_dev of the IOA will have invalid base address
information.

Linas Vepstas impleted eeh changes.

The messages read:

PCI: Address space collision on region 8 of bridge 0000:00:1f.0 [1180:11bf]
PCI: Ignoring BAR0-3 of IDE controller 0000:00:1f.1
Transparent bridge - 0000:00:1e.0
PCI: Using IRQ router PIIX/ICH [8086/24cc] at 0000:00:1f.0
PCI: Found IRQ 11 for device 0000:00:1f.1

The following patch adds "PCI: " in front of the message and KERN_INFO as well.
Compile&boot tested.

Jochen

Can you please feed the following patch to Andrew?

into ppc970.osdl.org:/home/torvalds/v2.6/linux

a ppc64 tree.