1. 28 Jul, 2020 1 commit
    • Takashi Iwai's avatar
      ALSA: hda/hdmi: Fix keep_power assignment for non-component devices · c2c3657f
      Takashi Iwai authored
      It's been reported that, when neither nouveau nor Nvidia graphics
      driver is used, the screen starts flickering.  And, after comparing
      between the working case (stable 4.4.x) and the broken case, it turned
      out that the problem comes from the audio component binding.  The
      Nvidia and AMD audio binding code clears the bus->keep_power flag
      whenever snd_hdac_acomp_init() succeeds.  But this doesn't mean that
      the component is actually bound, but it merely indicates that it's
      ready for binding.  So, when both nouveau and Nvidia are blacklisted
      or not ready, the driver keeps running without the audio component but
      also with bus->keep_power = false.  This made the driver runtime PM
      kicked in and powering down when unused, which results in flickering
      in the graphics side, as it seems.
      
      For fixing the bug, this patch moves the bus->keep_power flag change
      into generic_acomp_notifier_set() that is the function called from the
      master_bind callback of component ops; i.e. it's guaranteed that the
      binding succeeded.
      
      BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208609
      Fixes: 5a858e79 ("ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs")
      Cc: <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20200728082033.23933-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      c2c3657f
  2. 27 Jul, 2020 2 commits
  3. 24 Jul, 2020 2 commits
  4. 22 Jul, 2020 1 commit
  5. 18 Jul, 2020 1 commit
  6. 17 Jul, 2020 2 commits
    • Takashi Iwai's avatar
      Merge tag 'asoc-fix-v5.8-rc5' of... · d3bbc28b
      Takashi Iwai authored
      Merge tag 'asoc-fix-v5.8-rc5' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus
      
      ASoC: Fixes for v5.8
      
      An awful lot of mostly small fixes here, mainly for x86 based platforms
      and the CODEC drivers mainly used on them.  For the most part this is
      either minor device specific stuff which seems to come from detailed
      testing or robustness against errors which comes from people having done
      some fuzzing runs aginst the topology code.
      d3bbc28b
    • Takashi Iwai's avatar
      ALSA: info: Drop WARN_ON() from buffer NULL sanity check · 60379ba0
      Takashi Iwai authored
      snd_info_get_line() has a sanity check of NULL buffer -- both buffer
      itself being NULL and buffer->buffer being NULL.  Basically both
      checks are valid and necessary, but the problem is that it's with
      snd_BUG_ON() macro that triggers WARN_ON().  The latter condition
      (NULL buffer->buffer) can be met arbitrarily by user since the buffer
      is allocated at the first write, so it means that user can trigger
      WARN_ON() at will.
      
      This patch addresses it by simply moving buffer->buffer NULL check out
      of snd_BUG_ON() so that spurious WARNING is no longer triggered.
      
      Reported-by: syzbot+e42d0746c3c3699b6061@syzkaller.appspotmail.com
      Cc: <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20200717084023.5928-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      60379ba0
  7. 16 Jul, 2020 5 commits
  8. 14 Jul, 2020 1 commit
  9. 13 Jul, 2020 1 commit
  10. 11 Jul, 2020 2 commits
  11. 10 Jul, 2020 3 commits
  12. 09 Jul, 2020 3 commits
  13. 08 Jul, 2020 11 commits
  14. 07 Jul, 2020 5 commits