- 10 Nov, 2013 40 commits
-
-
Rashika Kheria authored
This patch fixes the following Sparse warnings in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:3636:12: warning: symbol 'rtllib_MgntDisconnectIBSS' was not declared. Should it be static? drivers/staging/rtl8192e/rtllib_softmac.c:3661:13: warning: symbol 'rtllib_MlmeDisassociateRequest' was not declared. Should it be static? drivers/staging/rtl8192e/rtllib_softmac.c:3687:13: warning: symbol 'rtllib_MgntDisconnectAP' was not declared. Should it be static? Signed-off-by:
Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Rashika Kheria authored
This patch fixes the following Sparse warning in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:298:12: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:298:12: expected unsigned short [unsigned] [usertype] fc drivers/staging/rtl8192e/rtllib_softmac.c:298:12: got restricted __le16 [usertype] frame_ctl drivers/staging/rtl8192e/rtllib_softmac.c:810:32: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:810:32: expected restricted __le16 [usertype] frame_ctl drivers/staging/rtl8192e/rtllib_softmac.c:810:32: got int drivers/staging/rtl8192e/rtllib_softmac.c:814:34: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:814:34: expected restricted __le16 [usertype] duration_id drivers/staging/rtl8192e/rtllib_softmac.c:814:34: got int drivers/staging/rtl8192e/rtllib_softmac.c:821:33: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:821:33: expected restricted __le16 [usertype] algorithm drivers/staging/rtl8192e/rtllib_softmac.c:821:33: got int drivers/staging/rtl8192e/rtllib_softmac.c:955:24: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:955:24: expected unsigned short [unsigned] [usertype] val16 drivers/staging/rtl8192e/rtllib_softmac.c:955:24: got restricted __le16 [usertype] <noident> drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: expected restricted __le16 [usertype] duration_id drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: got int drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: expected restricted __le16 [usertype] listen_interval drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: got unsigned short [unsigned] [usertype] listen_interval Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following Sparse warning in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:812:40: warning: invalid assignment: |= drivers/staging/rtl8192e/rtllib_softmac.c:812:40: left side has type restricted __le16 drivers/staging/rtl8192e/rtllib_softmac.c:812:40: right side has type int drivers/staging/rtl8192e/rtllib_softmac.c:924:17: warning: invalid assignment: |= drivers/staging/rtl8192e/rtllib_softmac.c:924:17: left side has type restricted __le16 drivers/staging/rtl8192e/rtllib_softmac.c:924:17: right side has type int drivers/staging/rtl8192e/rtllib_softmac.c:924:17: error: cast from unknown type Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following Sparse warning in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:230:19: warning: restricted __le16 degrades to integer Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following sparse warning in rtllib_tx.c- warning: restricted __le16 degrades to integer Signed-off-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following sparse warning in rtllib_tx.c- drivers/staging/rtl8192e/rtllib_tx.c:234:24: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_tx.c:234:24: expected restricted __le16 [usertype] frag_size drivers/staging/rtl8192e/rtllib_tx.c:234:24: got int [signed] txb_size drivers/staging/rtl8192e/rtllib_tx.c:613:43: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_tx.c:613:43: expected restricted __le16 [usertype] payload_size drivers/staging/rtl8192e/rtllib_tx.c:613:43: got unsigned int [unsigned] len drivers/staging/rtl8192e/rtllib_tx.c:767:35: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_tx.c:767:35: expected restricted __le16 [usertype] payload_size drivers/staging/rtl8192e/rtllib_tx.c:767:35: got int [signed] [assigned] bytes drivers/staging/rtl8192e/rtllib_tx.c:814:51: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_tx.c:814:51: expected restricted __le16 [usertype] seq_ctl drivers/staging/rtl8192e/rtllib_tx.c:814:51: got unsigned short drivers/staging/rtl8192e/rtllib_tx.c:174:36: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_tx.c:174:36: expected unsigned short [unsigned] [short] [usertype] <noident> drivers/staging/rtl8192e/rtllib_tx.c:174:36: got restricted __be16 [usertype] <noident> drivers/staging/rtl8192e/rtllib_tx.c:873:35: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_tx.c:873:35: expected restricted __le16 [usertype] payload_size drivers/staging/rtl8192e/rtllib_tx.c:873:35: got unsigned int [unsigned] len Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following sparse warning in rtllib_module.c- drivers/staging/rtl8192e/rtllib_module.c:240:12: warning: symbol 'rtllib_init' was not declared. Should it be static? drivers/staging/rtl8192e/rtllib_module.c:260:13: warning: symbol 'rtllib_exit' was not declared. Should it be static? Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following sparse warning in rtllib_rx.c- drivers/staging/rtl8192e/rtllib_rx.c:2267:34: warning: cast to restricted __le32 drivers/staging/rtl8192e/rtllib_rx.c:2268:34: warning: cast to restricted __le32 drivers/staging/rtl8192e/rtllib_rx.c:2269:36: warning: cast to restricted __le32 drivers/staging/rtl8192e/rtllib_rx.c:2269:36: warning: cast from restricted __le16 Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following sparse warning in rtllib_rx.c- warning: restricted __le16 degrades to integer Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following Sparse warning in rtllib_rx.c- drivers/staging/rtl8192e/rtllib_rx.c:493:37: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_rx.c:493:37: expected unsigned short [unsigned] [usertype] len drivers/staging/rtl8192e/rtllib_rx.c:493:37: got restricted __be16 [usertype] <noident> drivers/staging/rtl8192e/rtllib_rx.c:1227:37: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_rx.c:1227:37: expected unsigned short [unsigned] [usertype] len drivers/staging/rtl8192e/rtllib_rx.c:1227:37: got restricted __be16 [usertype] <noident> drivers/staging/rtl8192e/rtllib_rx.c:1635:40: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_rx.c:1635:40: expected restricted __le16 <noident> drivers/staging/rtl8192e/rtllib_rx.c:1635:40: got int drivers/staging/rtl8192e/rtllib_rx.c:1637:40: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_rx.c:1637:40: expected restricted __le16 <noident> drivers/staging/rtl8192e/rtllib_rx.c:1637:40: got int drivers/staging/rtl8192e/rtllib_rx.c:1641:45: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_rx.c:1641:45: expected restricted __le16 <noident> drivers/staging/rtl8192e/rtllib_rx.c:1641:45: got unsigned short [unsigned] [usertype] <noident> Signed-off-by:
-
Teodora Baluta authored
The wHubCharacteristics field in usb_hub_descriptor structure is __le16 so there is no need for cast. The cpu_to_le16 returns a __le16 type for a u16 type. Used cpu_to_le16 to silence last sparse error. drivers/staging/usbip/vhci_hcd.c:223:35: warning: incorrect type in assignment (different base types) drivers/staging/usbip/vhci_hcd.c:223:35: expected restricted __le16 [usertype] wHubCharacteristics drivers/staging/usbip/vhci_hcd.c:223:35: got unsigned short [unsigned] [usertype] <noident> drivers/staging/usbip/vhci_hcd.c:351:34: warning: incorrect type in assignment (different base types) drivers/staging/usbip/vhci_hcd.c:351:34: expected unsigned short [unsigned] [short] [usertype] <noident> drivers/staging/usbip/vhci_hcd.c:351:34: got restricted __le16 [usertype] <noident> drivers/staging/usbip/vhci_hcd.c:352:34: warning: incorrect type in assignment (different base types) drivers/staging/usbip/vhci_hcd.c:352:34: expected unsigned short [unsigned] [short] [usertype] <noident> drivers/staging/usbip/vhci_hcd.c:352:34: got restricted __le16 [usertype] <noident> drivers/staging/usbip/vhci_hcd.c:540:36: warning: restricted __le16 degrades to integer Signed-off-by:
Teodora Baluta <teobaluta@gmail.com> Signed-off-by:
-
Himangi Saraogi authored
This patch removes the checkpatch.pl warnings "quoted string split accross lines" in usbip_common.c. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Reviewed-by:
-
Himangi Saraogi authored
This patch removes the checkpatch.pl warnings "quoted string split across lines" in stub_rx.c by merging the quoted strings and the ensuring that the lines are not more than 80 characters long. Signed-off-by:
-
Himangi Saraogi authored
This patch removes the checkpatch.pl warning "do not add new typedefs" and changes all source files that use that typedef. Also lines were shortened to 80 characters to do away with the checkpatch.pl warning "line over 80 characters" generated due to replacement of the hfa384x_bytestr_t by struct hfa384x_bytestr in prism2mgmt.c, prism2mgmt.h, prism2mib.c, prism2sta.c. Signed-off-by:
-
Himangi Saraogi authored
This patch removes checkpatch.pl warnings "line over 80 characters" in cfg80211.c. Signed-off-by:
-
Archana kumari authored
This patch fixes "space prohibted before semicolon" warning in dm365_ipipe_hw.cdetected via checkpatch.pl Signed-off-by:
Archana kumari <archanakumari959@gmail.com> Reviewed-by:
-
Himangi Saraogi authored
This patch removes the checkpatch.pl warning "please, no space before tabs" in saa7134-go7007.c by converting space followed by tab to tab followed by tab. Signed-off-by:
-
Himangi Saraogi authored
This patch removes the checkpatch.pl error "trailing statements should be on next line" in go7007-fw.c. Signed-off-by:
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with space prohibited before semicolon in dm365_ipipe.c Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Reviewed-by:
-
Ingrid Cheung authored
Fixes multiple checkpatch warnings for long lines in Bcmchar.c. Signed-off-by:
Ingrid Cheung <hi@ingridcheung.com> Signed-off-by:
-
Ingrid Cheung authored
Fixed a line that was over 80 characters in Bcmchar.c. Signed-off-by:
-
Nandini Hanumanthagowda authored
removed any prohibited spaces and added required spaces around operators to follow linux coding style and hence fixed the checkpatch errors Signed-off-by:
Nandini Hanumanthagowda <nandu.hgowda@gmail.com> Reviewed-by:
-
Nandini Hanumanthagowda authored
removed prohibited space before semicolon(;) to fix checkpatch warning Signed-off-by:
Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following checkpatch.pl warning in smscsi.c- WARNING: externs should be avoided in .c files Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following checkpatch.pl warning in smilsub.c- WARNING: externs should be avoided in .c files Signed-off-by:
-
Rashika Kheria authored
This patch fixes the following checkpatch.pl warning in smilmain.c- WARNING: externs should be avoided in .c files Signed-off-by:
-
Valentina Manea authored
This fixes coccinelle error regarding functions that return bool and return 1 and 0 instead of true and false. Signed-off-by:
Valentina Manea <valentina.manea.m@gmail.com> Reviewed-by:
-
Archana kumari authored
This patch fixes sparse warning by adding __user annotations in lirc_serial.c Signed-off-by:
-
Teodora Baluta authored
This patch deletes any unneeded semicolons in driver vt6655 as detected by coccinelle. Signed-off-by:
-
Teodora Baluta authored
This patch corrects comparison of bool to 0/1 for file drivers/staging/vt6655/rxtx.c. The following type of coccinelle detected warnings are silenced: WARNING: Comparison of bool to 0/1 Signed-off-by:
-
Teodora Baluta authored
This patch fixes the following warnings detected using coccinelle for drivers/staging/wmgr.c file: drivers/staging/vt6655/wmgr.c:2335:1-22: WARNING: Assignment of bool to 0/1 drivers/staging/vt6655/wmgr.c:2338:1-27: WARNING: Assignment of bool to 0/1 Signed-off-by:
-
Teodora Baluta authored
This patch fixes the following type of coccinelle detected warnings for driver vt6655: WARNING: Comparison to bool Signed-off-by:
-
Teodora Baluta authored
Place braces on same line for code statements. Fix the following checkpatch.pl type of error for drivers/staging/vt6655/bssdb.c file: ERROR: that open brace { should be on the previous line Signed-off-by: -
Teodora Baluta authored
This patch fixes the following type of checkpatch.pl errors in drivers/staging/vt6655/bssdb.c file: ERROR: trailing statements should be on next line Signed-off-by:
-
Teodora Baluta authored
This patch removes braces for single statement blocks, clearing these types of checkpatch.pl warnings: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: -
Teodora Baluta authored
This patch replaces C99 comments with /* .. */ comments. Any commented code is deleted. Signed-off-by:
-
Nandini Hanumanthagowda authored
removed prohibited spaces around operators and added required spaces around operators wherever necessary to fix checkpatch errors Signed-off-by:
-
Valentina Manea authored
This fixes sparse warnings for functions and variables, e.g.: * drivers/staging/vt6656/card.c:69:11: warning: symbol 'cwRXBCNTSFOff' was not declared. Should it be static? Some warnings were false positives, such as: * drivers/staging/vt6656/dpc.c:249:5: warning: symbol 'RXbBulkInProcessData' was not declared. Should it be static? Signed-off-by:
-
Archana kumari authored
This patch fixes sparse warning for static declaration in wpa2.c Signed-off-by:
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with printk() should include kern_ facility level in r8185b_init.c Signed-off-by:
-
