- 26 Jul, 2017 12 commits
-
-
Tushar Dave authored
i40e hardware descriptor fields are in little-endian format. Driver must use le32_to_cpu while evaluating these fields otherwise on big-endian arch we end up evaluating incorrect values, cause errors like: i40evf 0000:03:0a.0: Expected response 24 from PF, received 402653184 i40evf 0000:03:0a.1: Expected response 7 from PF, received 117440512 Signed-off-by:
Tushar Dave <tushar.n.dave@oracle.com> Reviewed-by:
Shannon Nelson <shannon.nelson@oracle.com> Tested-by:
Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-
Daniel Borkmann authored
Fill the XDP prog_id with the id just like we do in other XDP enabled drivers such as ixgbe. This is needed so that on dump we can retrieve the attached program based on the id, and dump BPF insns, opcodes, etc back to user space. Only XDP driver missing this is currently i40e. Signed-off-by:
Daniel Borkmann <daniel@iogearbox.net> Acked-by:
John Fastabend <john.fastabend@gmail.com> Acked-by:
Alexander Duyck <alexander.h.duyck@intel.com> Tested-by:
-
Jesse Brandeburg authored
These includes were all being used in the driver, but weren't being directly included. Since the current advised method is to directly include anything that you need, this implements that. Signed-off-by:
Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by:
-
Jacob Keller authored
The i40e driver attempts to display the UDP tunnel name by doing a check against the type, where for non-zero types we use "vxlan" and for zero type we use "geneve". This is not future proof, because if new tunnel types get added, we'll incorrectly label them. It also depends on the value of UDP_TUNNEL_TYPE_GENEVE == 0, which is brittle. Instead, replace this with a function that can return a constant string depending on the type. For now we'll use "unknown" for types we don't know about, and we can expand this in the future if new types get added. Signed-off-by:
Jacob Keller <jacob.e.keller@intel.com> Tested-by:
-
Jesse Brandeburg authored
Compiler reported several places where driver compared signed and unsigned types. Cast or change the types to remove the warnings. Signed-off-by:
-
Jesse Brandeburg authored
This just reorders some local vars and makes the code flow clearer. Signed-off-by:
-
Jesse Brandeburg authored
The compiler warned on an oddly indented bit of code, and when investigating that, noted that the functions themselves had an odd flow. The if condition was checked, and would exclude a call to AQ, but then the aq_ret would be checked unconditionally which just looks really weird, and is likely to cause objections. Signed-off-by:
-
Jesse Brandeburg authored
As it turns out there was only a small set of errors on 32 bit, and we just needed to be using the right calls for dealing with timespec64 variables. Signed-off-by:
-
Paul M Stillwell Jr authored
There are some rare cases where the release resource call will return an admin Q timeout. In these cases the code needs to try to release the resource again until it succeeds or it times out. Signed-off-by:
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> Tested-by:
-
Jacob Keller authored
During certain events such as a CORER, multiple devices will run a work task to handle some cleanup. This can cause issues due to a single-threaded workqueue which can mean that a device doesn't cleanup in time. Prevent this by removing the single-threaded restriction on the module workqueue. This avoids the need to add more complex yielding logic in our service task routine. This is also similar to what other drivers such as fm10k do. Signed-off-by:
-
Carolyn Wyborny authored
This patch fixes a problem found in systems when entering S4 state. This patch fixes the problem by ensuring that the misc vector's IRQ is disabled as well. Without this patch a stack trace can be seen upon entering S4 state. Signed-off-by:
Carolyn Wyborny <carolyn.wyborny@intel.com> Tested-by:
-
Gustavo A R Silva authored
Fix incorrect variable assignment. Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be used in this instance is aq_ret instead of ret. Also, variable ret is updated at line 1602 just before return, so assigning a value to this variable in this code block is useless. Addresses-Coverity-ID: 1397693 Signed-off-by:
Gustavo A R Silva <garsilva@embeddedor.com> Acked-by:
-
- 25 Jul, 2017 28 commits
-
-
David S. Miller authored
Michael Chan says: ==================== bnxt_en: Fix kbuild errors and rename phys_port_name. Fix 2 more kbuild errors (the first one already fixed by DaveM), and rename the physical port name. ==================== Signed-off-by:David S. Miller <davem@davemloft.net>
-
Sathya Perla authored
Fix the phys_port_name for the external physical port to be in "pA" format and that of VF-rep to be in "pCvfD" format as suggested by Jakub Kicinski. Fixes: c124a62f ("bnxt_en: add support for port_attr_get and get_phys_port_name") Signed-off-by:
Sathya Perla <sathya.perla@broadcom.com> Signed-off-by:
Michael Chan <michael.chan@broadcom.com> Signed-off-by:
-
Sathya Perla authored
This fixes the build error: ‘struct net_device’ has no member named ‘switchdev_ops’ Reported-by:
kbuild test robot <lkp@intel.com> Fixes: c124a62f ("bnxt_en: add support for port_attr_get and and get_phys_port_name") Signed-off-by:
-
Sathya Perla authored
And define empty functions in bnxt_vfr.h when CONFIG_BNXT_SRIOV is not defined. This fixes build error when CONFIG_BNXT_SRIOV is switched off: >> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:165:16: error: 'struct >> bnxt' has no member named 'sriov_lock' Reported-by:
-
David S. Miller authored
Stephen Hemminger says: ==================== network related warning fixes Various fixes for warnings in network code and drivers. ==================== Signed-off-by: -
stephen hemminger authored
Signed-off-by:
Stephen Hemminger <sthemmin@microsoft.com> Acked-by:
Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by:
-
stephen hemminger authored
The variable owned_by_user is always set, but only used when kernel is configured with LOCKDEP enabled. Get rid of the warning by moving the code to put the call to owned_by_user into the the rcu_protected call. Signed-off-by:
-
stephen hemminger authored
warning: ‘recent_old_fops’ defined but not used Signed-off-by:
-
stephen hemminger authored
warning: variable ‘netdev’ set but not used Signed-off-by:
-
stephen hemminger authored
Fix a couple of warnings where variable ‘txq’ set but not used Signed-off-by:
-
stephen hemminger authored
Fixes warning because location is u32 and can never be netative warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Signed-off-by:
-
Dirk van der Merwe authored
When a netdev (PF netdev or representor) is opened or closed, set the physical port config bit appropriately - which powers UP/DOWN the PHY module for the physical interface. The PHY is powered first in the HW/FW configuration step when opening the netdev and again last in the HW/FW configuration step when closing the netdev. This is only applicable when there is a physical port associated with the netdev and if the NSP support this. Otherwise we silently ignore this step. The 'nfp_eth_set_configured' can actually return positive values - updated the function documentation appropriately. Signed-off-by:
Dirk van der Merwe <dirk.vandermerwe@netronome.com> Reviewed-by:
Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by:
-
Tonghao Zhang authored
we can use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR 1. drivers/net/appletalk/ipddp.c 2. drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by:
Tonghao Zhang <xiangxia.m.yue@gmail.com> Signed-off-by:
-
David S. Miller authored
Suggested by Jakub Kicinski. Fixes: c124a62f ("bnxt_en: add support for port_attr_get and and get_phys_port_name") Reported-by:
-
John Allen authored
On resume, the ibmvnic driver will fail to resume normal operation. The main crq gets closed on suspend by the vnic server and doesn't get reopened again as the interrupt for the transport event that would reset the main crq comes in after the driver has been suspended. This patch resolves the issue by removing the calls to kick the receive interrupts handlers and instead directly invoking the main crq interrupt handler. This will ensure that we see the transport event necessary to properly resume the driver. Signed-off-by:
John Allen <jallen@linux.vnet.ibm.com> Signed-off-by:
-
David S. Miller authored
Stephen Hemminger says: ==================== netvsc: minor fixes This fixes fallout from previous patch related to RTNL and RCU annotaiton. Also one patch sent to wrong list. ==================== Signed-off-by: -
stephen hemminger authored
This value has been calculated in rndis_device_attach since 4.11. Signed-off-by:
-
stephen hemminger authored
Since these files use rtnl_derefernce make sure and include rtnetlink.h Signed-off-by:
-
stephen hemminger authored
The number of channels returned by rndis_filter_device_add maybe less than the number requested. Therefore set correct real number of queues. Signed-off-by:
-
stephen hemminger authored
In interrupt handler, prefetch the first incoming ring element so that it is in cache by the time NAPI poll gets to it. Signed-off-by:
-
Mohammed Gamal authored
This condition already uses an object of type ipv6hdr in the line above. Use the object directly instead of calling ipv6_hdr Signed-off-by:
Mohammed Gamal <mgamal@redhat.com> Signed-off-by:
-
stephen hemminger authored
Remove accidental rtnl_unlock from earlier testing. Fixes: 3962981f ("netvsc: add rtnl annotations in rndis") Signed-off-by:
-
David S. Miller authored
Michael Chan says: ==================== bnxt_en: Updates for net-next. This series includes updating the firmware interface, adding methods to get and set VEPA/VEB bridge modes, some minor DCBX and ETS refinements, and 3 patches from Sathya Perla to implement initial VF representors for SRIOV switching. ==================== Signed-off-by: -
Sathya Perla authored
This patch adds support for the switchdev_port_attr_get() and ndo_get_phys_port_name() methods for the PF and the VF-reps. Using this support a user application can deduce that the PF (when in the ESWITCH_SWDEV mode) and it's VF-reps form a switch. Signed-off-by:
-
Sathya Perla authored
This patch introduces the RX/TX and a simple netdev implementation for VF-reps. The VF-reps use the RX/TX rings of the PF. For each VF-rep the PF driver issues a VFR_ALLOC FW cmd that returns "cfa_code" and "cfa_action" values. The FW sets up the filter tables in such a way that VF traffic by default (in absence of other rules) gets punted to the parent PF. The cfa_code value in the RX-compl informs the driver of the source VF. For traffic being transmitted from the VF-rep, the TX BD is tagged with a cfa_action value that informs the HW to punt it to the corresponding VF. Signed-off-by:
-
Sathya Perla authored
This patch is a part of a patch-set that introduces support for VF-reps in the bnxt_en driver. The driver registers eswitch mode get/set methods with the devlink interface that allow a user to enable SRIOV switchdev mode. When enabled, the driver registers a VF-rep netdev object for each VF with the stack. This can essentially bring the VFs unders the management perview of the hypervisor and applications such as OVS. The next patch in the series, adds the RX/TX routines and a slim netdev implementation for the VF-reps. Signed-off-by:
-
Michael Chan authored
In addition to the ETS weight, older firmware also requires the min_bw parameter to be set for it to work properly. Signed-off-by:
-
Michael Chan authored
Report DCB_CAP_DCBX_LLD_MANAGED only if the firmware DCBX agent is enabled and running for PF or VF. Otherwise, if both LLDP and DCBX agents are disabled in firmware, we report DCB_CAP_DCBX_LLD_HOST and allow host IEEE DCB settings. This patch refines the current logic in the driver. Signed-off-by:
-
