1. 17 Feb, 2003 8 commits
    • David Brownell's avatar
      [PATCH] USB: sg_complete() warning downgrade · d3704370
      David Brownell authored
      An error check would wrongly fire after usb_sg_cancel().
      This patch prevents the misfire, and also makes the
      diagnostic (a) more useful, (b) less scarey.
      d3704370
    • Steven Cole's avatar
      [PATCH] USB: trivial help texts for drivers/usb/serial/Kconfig · 398e1039
      Steven Cole authored
      Here are some trivial help texts for drivers/usb/serial/Kconfig.
      398e1039
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: minor speedtouch changes · c0e59929
      Duncan Sands authored
      Add some comments and debug info.
      c0e59929
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: speedtouch 330 support · a792bb5c
      Duncan Sands authored
      Differences: speedtouch 330 vs the older speedtouch USB:
      Vendor and ProdID: no difference (!)
      Rev: 2.00 vs 0.00
      SerialNumber: 0090D0xxxxxx, xxxxxx larger for 330
      Interface 1, Alt 2:
      	E: Ad=06(O) Atr=02(Bulk) MxPS=64 Ivl=0ms
      	E: Ad=07(O) Atr=02(Bulk) MxPS=64 Ivl=0ms
      	E: Ad=87(I) Atr=01(Isoc) MxPS=640 Ivl=1ms
      vs
      	E: Ad=06(O) Atr=02(Bulk) MxPS=32 Ivl=0ms
      	E: Ad=07(O) Atr=02(Bulk) MxPS=32 Ivl=0ms
      	E: Ad=87(I) Atr=02(Bulk) MxPS=64 Ivl=0ms
      Interface 1, Alt 3:
      	E: Ad=06(O) Atr=02(Bulk) MxPS=64 Ivl=0ms
      	E: Ad=07(O) Atr=02(Bulk) MxPS=64 Ivl=0ms
      	E: Ad=87(I) Atr=01(Isoc) MxPS=960 Ivl=1ms
      vs
      	E: Ad=06(O) Atr=02(Bulk) MxPS=16 Ivl=0ms
      	E: Ad=07(O) Atr=02(Bulk) MxPS=16 Ivl=0ms
      	E: Ad=87(I) Atr=02(Bulk) MxPS=64 Ivl=0ms
      The current driver works with the speedtouch 330 as long as we use alternate setting
      1 on interface 1 rather than alternate 2 as we do now.  In fact it makes sense to use
      alternate 1 for the speedtouch USB as well: the difference is in the max packet size
      for the out bulk endpoint (0x07): 64 for Alt 1, 32 for Alt 2.  Since we send only
      multiples of 53 bytes (ATM cell size), the potential lower latency for Alt 2 is not
      really exploitable (think about it!).  My tests indicate no harm and perhaps a slight
      gain by using Alt 1.  The manufacturer seems to think so too, since they chose to
      keep the Alt 1 setting and threw out Alt 2 when designing the 330.  So just use Alt 1
      for both modems.
      a792bb5c
    • Duncan Sands's avatar
      dff40c3a
    • Duncan Sands's avatar
      9882da45
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: Fix speedtouch maxi race · a552909f
      Duncan Sands authored
      Instead of trying to close all ATM connections in the USB disconnect routine,
      just notify the ATM layer that the ATM device should go down when the last
      connection is closed.  This should be the last big speedtouch stability fix.
      a552909f
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: fix speedtouch micro race · 8c6c4484
      Duncan Sands authored
      The disconnect routine counts the completed_receivers/spare_senders list
      to see if the completion handler has finished.  It then kills the tasklet.
      However the tasklet was being scheduled after adding to the lists, creating
      a micro race.  So schedule the tasklet before adding to the list.
      8c6c4484
  2. 16 Feb, 2003 9 commits
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: Missing speedtouch bits · 860ed2a6
      Duncan Sands authored
      Let's not forget to update the ATM transmission statistics!  And
      let's not pretend to support AAL0 when we don't.
      860ed2a6
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: speedtouch dead code elimination · 4ae6059e
      Duncan Sands authored
      Eliminate a pile of code that isn't used anymore now the new send code
      is in place, and make some cosmetic changes.
      4ae6059e
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: new speedtouch send path · 452a2de3
      Duncan Sands authored
      Finally, here is the new code for sending packets.  The ATM layer passes us a skb
      containing the packet to be sent.  We need to encode that as AAL5, and then encapsulate
      the result in a series of ATM cells.  Finally, the result has to be sent to the modem.
      When we have finished with the skb, we need to pass it back to the ATM layer.
      
      The old code did this as follows: (1) Try to do the AAL5 encoding in place in the skb.
      This fattens the packet, so there is not always enough room.  Thus sometimes a new skb
      is allocated.  (2) Try to form the frame of ATM cells in place.  This also fattens the
      packet, so sometimes another skb is allocated here too.  (3) send the urb, using the
      skb as buffer.
      
      The main problems with this are: (1) in the urb completion handler, we need to pass
      the skb back to the ATM layer, or free it ourselves if we allocated a new one.  The
      driver was pretty confused about which to do.  Also, error conditions were not
      always handled right.  (2) if the ATM layer wants to close the VCC (connection),
      any urbs in flight using skbs from that VCC need to be shot down, otherwise the
      skb may be returned to a VCC that no longer exists when the urb completes.  You
      have to be careful to shoot down the right urb (beware of resubmission), and deal
      with failures of usb_unlink_urb.  (3) There may need to be several memory allocations.
      
      The new code sidesteps all this by (1) not sending the skb off with the urb, and
      (2) not reallocating the skb at all.  It simply has a couple of buffers of fixed
      size: the encoded and encapsulated content of the skb is placed in a buffer.  The
      skb is sent back down to the ATM layer and the buffer is sent off with the urb.
      Et voila, as they say around here.
      
      Now for the complicating factors: (1) if there are no spare buffers, the incoming
      skb needs to be queued (this was already the case if there were no free urbs).  If
      the VCC is closed, the skbs from that VCC need to be removed from the queue.  This
      is trivial and is done in udsl_usb_cancelsends.  (2) The skbs can be quite big.  In
      practice, with the default configuration for pppd, they contain at most 1502 bytes.
      However pppd can be configured to send up to 16k packets, and who says everyone
      is using pppd? - the ATM layer allows up to 64k packets.  So how big should the
      buffers be?  Not 64k, that's for sure - I've set them to about 6k (128 ATM cells).
      So there needs to be a way to encode/encapsulate and transfer only part of the skb's
      payload into a buffer.  This is done by udsl_write_cell, which extracts one ATM
      cell from the skb.  The data needed is precalculated by udsl_groom_skb and stored
      in the skb's cb field.  This also means that if there is only a little room left
      in a buffer, it can still be filled by extracting part of a skb.  A nice consequence
      is that under heavy load (many packets being sent), the driver starts streaming the
      data to the USB subsystem: every time a send urb completes, there is a completely
      filled buffer waiting to be sent, so not only is the time between urb completion and
      resubmission essentially zero, but the amount of data sent in each USB transaction is
      as big as possible, each buffer containing the contents of several skbs (typically 4).
      
      And the best thing is: it actually works!
      452a2de3
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: on-the-fly AAL5/ATM encoding for speedtouch · 210e817e
      Duncan Sands authored
      Add a new encoding routine, udsl_write_cell, which extracts one ATM cell from a skb
      and writes it, doing the AAL5/ATM encoding on the fly.  To make this possible, various
      bits of info about the AAL5/ATM structure need to be stored beforehand in the skb.
      This is done by udsl_groom_skb using the udsl_control structure introduced in the
      previous patch.
      210e817e
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: More infrastructure for new speedtouch send path · 3a16d1e5
      Duncan Sands authored
      Add a new structure, udsl_control.  It will live in the sk_buff cb field,
      so check there is room for it and bail out during module init if not.
      3a16d1e5
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: expose crc defs to speedtouch · df56a4e3
      Duncan Sands authored
      Expose some CRC definitions in atmsar.h (for use by speedtouch.c).
      df56a4e3
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: infrastructure for new speedtouch send path · d71ce8f0
      Duncan Sands authored
      Put in infrastructure for the new send code.  The only code changes are in the
      udsl_usb_probe and udsl_usb_disconnect functions, changed to initialize/finalize the
      new fields (plus cleaned up a bit).  I couldn't resist a real code change while I was
      there: freeing the memory used by the ATM after shutting it down, rather than before!
      This doesn't make any difference since the shutdown routine doesn't work - so it still
      oopses.  I will fix the shutdown routine later.
      d71ce8f0
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: yet another trivial speedtouch change · e6577d83
      Duncan Sands authored
      Measure the receive buffer size in ATM cells (53 bytes).
      e6577d83
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: Even more trivial speedtouch change · 5d894895
      Duncan Sands authored
      Rename UDSL_RECEIVE_BUFFER_SIZE to UDSL_RCV_BUFFER_SIZE.
      5d894895
  3. 15 Feb, 2003 23 commits