- 25 Oct, 2007 40 commits
-
-
Oliver Neukum authored
this driver has a possible use after free due to a race when disconnect and open handle intfdata without a lock. Signed-off-by:
Oliver Neukum <oneukum@suse.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Oliver Neukum authored
again, possible use after free due to touching intfdata without lock. Signed-off-by:
-
Oliver Neukum authored
the driver sets intfdata to NULL without lock. Data structures can be freed and accessed. Signed-off-by:
-
Oliver Neukum authored
the emi62 also lacks an error check. Signed-off-by:
-
Oliver Neukum authored
this drivers lacks an error check. Signed-off-by:
-
Sarah Sharp authored
Avoid potential null pointer dereference. Signed-off-by:
Sarah Sharp <sarah.a.sharp@intel.com> Signed-off-by:
-
David Brownell authored
Remove various newly-introduced compiler warnings for OHCI. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net> Signed-off-by:
-
David Brownell authored
Get rid of pointless pci_set_mwi() compiler warning. Signed-off-by:
-
Jiri Kosina authored
USB: usbserial - fix potential deadlock between write() and IRQ usb_serial_generic_write() doesn't disable interrupts when taking port->lock, and could therefore deadlock with usb_serial_generic_read_bulk_callback() being called from interrupt, taking the same lock. Fix it. Signed-off-by:
Jiri Kosina <jkosina@suse.cz> Acked-by:
Larry Finger <larry.finger@lwfinger.net> Signed-off-by:
-
Masakazu Mokuno authored
This patch adds support for the IO Data Device USB-RSAQ5, PL2303 based USB-serial converter, to pl2303 driver Signed-off-by:
Masakazu Mokuno <mokuno@sm.sony.co.jp> Signed-off-by:
-
Oliver Neukum authored
the disconnect method of this driver set intfdata to NULL before removing attribute files. The attributes' read methods will happily follow the NULL pointer. Here's the correct ordering. Signed-off-by : Oliver Neukum <oneukum@suse.de> Signed-off-by: -
Oliver Neukum authored
Pete caused me to lock at buggy drivers in this respect. The idmouse has a race between open and disconnect. This patch - solves the open/disconnect race - switches locking to mutexes Signed-off-by:
-
Alan Stern authored
This patch (as1005) fixes a rather subtle problem. When usb_set_configuration() registers the interfaces and their files in sysfs, it doesn't expect those files to exist already. But when an interface is registered, its driver may call usb_set_interface() and thereby cause the sysfs files to be created. The result is an error when usb_set_configuration() goes on to create those same files again. The (not-so-great) solution is to have usb_set_configuration() remove any existing files before creating them. Signed-off-by:
Alan Stern <stern@rowland.harvard.edu> Signed-off-by:
-
Ingo Molnar authored
fix ssb_ohci_probe() build bug: drivers/built-in.o: In function `ssb_ohci_probe': ohci-hcd.c:(.text+0xbff39): undefined reference to `ssb_device_enable' ohci-hcd.c:(.text+0xbff6f): undefined reference to `ssb_admatch_base' ohci-hcd.c:(.text+0xbff8b): undefined reference to `ssb_admatch_size' ohci-hcd.c:(.text+0xbffe5): undefined reference to `ssb_device_disable' [...] the reason was that this Kconfig combination was allowed: CONFIG_SSB=m CONFIG_USB_OHCI_HCD=y CONFIG_USB_OHCI_HCD_SSB=y the fix is to require a modular USB_OHCI_HCD build when SSB is modular. Signed-off-by:
Ingo Molnar <mingo@elte.hu> Acked-by:
Michael Buesch <mb@bu3sch.de> Signed-off-by:
-
Alan Cox authored
Signed-off-by:
Alan Cox <alan@redhat.com> Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Adrian Bunk authored
The Coverity checker spotted that we have already oops'ed if "dev" was NULL in these places. Since "dev" being NULL isn't possible at these places this patch removes the NULL checks. Additionally, I've fixed the formatting of the if's. Signed-off-by:
Adrian Bunk <bunk@kernel.org> Acked-by:
Oliver Neukum <oliver@neukum.org> Signed-off-by:
-
Adrian Bunk authored
The Coverity checker spotted that we have already oops'ed if "dev" was NULL. Since "dev" being NULL doesn't seem to be possible here this patch removes the NULL check. Signed-off-by:
Adrian Bunk <bunk@stusta.de> Acked-by:
-
Oliver Neukum authored
URB_FREE_BUFFER needs to be allowed in the sanity checks to use drivers that use that flag. Signed-off-by:
Marcel Holtmann <marcel@holtmann.org> Cc: stable <stable@kernel.org> Signed-off-by:
-
Alan Cox authored
The ISD200 driver imports a single trivial routine from the IDE layer and in doing so creates a mess of dependancies that drag in the entire old IDE layer. Even more sad - it does this for a routine which is usually (little endian) a null function! - Copy the function into ISD200 - Rename it so it doesn't clash with the ide header prototype - Remove all the depend constraints Signed-off-by:
-
Matthias Kaehlcke authored
FTDI Elan driver: Convert the semaphore ftdi->u132_lock to the mutex API Signed-off-by:
Matthias Kaehlcke <matthias.kaehlcke@gmail.com> Signed-off-by:
-
Alan Stern authored
This patch (as1003) changes uhci-hcd to treat the URB_ISO_ASAP flag the same as other host controller drivers, namely, to schedule an Iso URB for the first available time slot that hasn't already expired. URBs in which the flag isn't set will be scheduled for the first slot following the last URB, even if it has expired. This fixes a problem reported by Martin Bachem. Signed-off-by:
-
Alan Cox authored
Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
Andrew Morton authored
WARNING: line over 80 characters #23: FILE: drivers/usb/serial/ftdi_sio.c:297: + speed_t force_baud; /* if non-zero, force the baud rate to this value */ ERROR: use tabs not spaces #31: FILE: drivers/usb/serial/ftdi_sio.c:881: +^I$ ERROR: use tabs not spaces #39: FILE: drivers/usb/serial/ftdi_sio.c:890: +^I$ WARNING: line over 80 characters #111: FILE: drivers/usb/serial/ftdi_sio.c:1956: + tty_encode_baud_rate(port->tty, priv->force_baud, priv->force_baud); Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Signed-off-by:
-
Alan Cox authored
- Remove can't happen tests - Rework speed validation in terms of baud rates not CBAUD bits - Report speed set (or chosen) - Minor termios correctness Signed-off-by:
-
Alan Cox authored
- Convert to new baud rate functions - Add baud rate reporting Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
No hardware termios setting in this case so keep the old settings Signed-off-by:
-
Alan Cox authored
For the devices that have no hardware settings set up the termios return properly. Signed-off-by:
-
Alan Cox authored
- Clear unsupported CMSPAR - Encode resulting speeds Signed-off-by:
-
Alan Cox authored
- Clear unsupported CMSPAR bit - Clean up long chains of a->b-> a bit - Encode baud rate back into tty structure properly Signed-off-by:
-
Alan Cox authored
- Clean up paranoia checks - Propogate back a correct fixed termios Signed-off-by:
-
Alan Cox authored
The empeg is pretty fixed. Tidy up the long foo->bar->baz stuff and encode the fixed speed properly. Signed-off-by:
-
Alan Cox authored
- Expand some x&y to x & y so I could read it when checking - Clear CMSPAR bit in the termios (as the driver does not support it) - Encode the speed using the new tty_encode_baud_rate facility Signed-off-by:
-
Alan Cox authored
The ch341 currently doesn't support most of the hardware setting. So to keep the termios data right we propogate the old termios hardware values back then encode the speed. Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
- Set the i/ospeed in the initial termios properly - Use the tty_encode_baud_rate functions to report resulting rates properly Signed-off-by:
-
Alan Cox authored
Earlier patches have removed the checking for old v new differences from the USB drivers so we can now pass in a valid blank old termios so that we don't to fill the drivers with magic hacks for console support Signed-off-by:
-
Greg Kroah-Hartman authored
This adds support for the U727 and MC950 devices. Cc: Rony Sarkis <rsarkis@nvtl.com> Signed-off-by:
-
